)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"32cdc5aa7f4d0b30958a38847a88c6d815f7f4fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2c6b974c_8afb79f6","updated":"2022-05-24 14:02:01.000000000","message":"Not sure about neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py (at least missing conflict line, but more why it looks so different to yoga)","commit_id":"9e2425111b6f7413098bbb38f6013d18b3804303"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"6f7fffe2e434573b40182299853bacbc44aa8cfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45188732_184f6c8a","updated":"2022-05-30 09:12:27.000000000","message":"Thanks for details, this looks good to go with that different test in xena (and older, similar comments)","commit_id":"9e2425111b6f7413098bbb38f6013d18b3804303"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"68e7f73ffb8d930eb6f7b7c87f7bb43bc2628d45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4c721f57_832c1942","updated":"2022-05-30 10:58:40.000000000","message":"recheck","commit_id":"9e2425111b6f7413098bbb38f6013d18b3804303"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"32cdc5aa7f4d0b30958a38847a88c6d815f7f4fa","unresolved":true,"context_lines":[{"line_number":3930,"context_line":"            \u002710.0.0.1\u0027, \u002710.0.0.0/24\u0027)[\u0027subnet\u0027]"},{"line_number":3931,"context_line":""},{"line_number":3932,"context_line":"    @mock.patch.object(ovn_client.OVNClient, \u0027get_virtual_port_parents\u0027)"},{"line_number":3933,"context_line":"    def test_create_port_with_virtual_type_and_options(self, mock_get_parents):"},{"line_number":3934,"context_line":"        fake_parents \u003d [\u0027parent-0\u0027, \u0027parent-1\u0027]"},{"line_number":3935,"context_line":"        mock_get_parents.return_value \u003d fake_parents"},{"line_number":3936,"context_line":"        port \u003d {\u0027id\u0027: \u0027virt-port\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"805269a9_4b4ff2da","side":"PARENT","line":3933,"range":{"start_line":3933,"start_character":8,"end_line":3933,"end_character":78},"updated":"2022-05-24 14:02:01.000000000","message":"I am a bit lost on how backport looks here compared to yoga https://review.opendev.org/c/openstack/neutron/+/842293/1/neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py#2743\nyoga/master intention seemed to keep get_virtual_port_parents mock and use it, while this one removes mock and its use at L3935","commit_id":"e59cf95dc017a45bda9da01e5feb401fd3b3fbde"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"32b0ade4f3eb27c2510780cce66f757d40741770","unresolved":true,"context_lines":[{"line_number":3930,"context_line":"            \u002710.0.0.1\u0027, \u002710.0.0.0/24\u0027)[\u0027subnet\u0027]"},{"line_number":3931,"context_line":""},{"line_number":3932,"context_line":"    @mock.patch.object(ovn_client.OVNClient, \u0027get_virtual_port_parents\u0027)"},{"line_number":3933,"context_line":"    def test_create_port_with_virtual_type_and_options(self, mock_get_parents):"},{"line_number":3934,"context_line":"        fake_parents \u003d [\u0027parent-0\u0027, \u0027parent-1\u0027]"},{"line_number":3935,"context_line":"        mock_get_parents.return_value \u003d fake_parents"},{"line_number":3936,"context_line":"        port \u003d {\u0027id\u0027: \u0027virt-port\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af6a9ce_e0bff7d2","side":"PARENT","line":3933,"range":{"start_line":3933,"start_character":8,"end_line":3933,"end_character":78},"in_reply_to":"805269a9_4b4ff2da","updated":"2022-05-27 08:49:37.000000000","message":"Same reason as before. https://review.opendev.org/c/openstack/neutron/+/816383 mocked the method \"virtual_port_parents\" in each individual class. Here I\u0027m creating this mock only in the parent class, that is enough. I would prefer to have this in master.","commit_id":"e59cf95dc017a45bda9da01e5feb401fd3b3fbde"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"32cdc5aa7f4d0b30958a38847a88c6d815f7f4fa","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        self.mech_driver.sb_ovn \u003d fakes.FakeOvsdbSbOvnIdl()"},{"line_number":84,"context_line":"        self.mech_driver._post_fork_event.set()"},{"line_number":85,"context_line":"        self.mech_driver._ovn_client._qos_driver \u003d mock.Mock()"},{"line_number":86,"context_line":"        self._virtual_port_parents \u003d mock.patch.object("},{"line_number":87,"context_line":"            ovn_client.OVNClient, \u0027get_virtual_port_parents\u0027, return_value\u003d[])"},{"line_number":88,"context_line":"        self.virtual_port_parents \u003d self._virtual_port_parents.start()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class TestOVNMechanismDriverBase(MechDriverSetupBase,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7c9dd595_519461ff","line":88,"range":{"start_line":86,"start_character":0,"end_line":88,"end_character":70},"updated":"2022-05-24 14:02:01.000000000","message":"This comes from I3d01f58dca570537b5e754b331ca4809a7161ae2 not the parent of this backport, is it needed here? As it was not needed in yoga - maybe related to how different test looks below","commit_id":"9e2425111b6f7413098bbb38f6013d18b3804303"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"32b0ade4f3eb27c2510780cce66f757d40741770","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        self.mech_driver.sb_ovn \u003d fakes.FakeOvsdbSbOvnIdl()"},{"line_number":84,"context_line":"        self.mech_driver._post_fork_event.set()"},{"line_number":85,"context_line":"        self.mech_driver._ovn_client._qos_driver \u003d mock.Mock()"},{"line_number":86,"context_line":"        self._virtual_port_parents \u003d mock.patch.object("},{"line_number":87,"context_line":"            ovn_client.OVNClient, \u0027get_virtual_port_parents\u0027, return_value\u003d[])"},{"line_number":88,"context_line":"        self.virtual_port_parents \u003d self._virtual_port_parents.start()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class TestOVNMechanismDriverBase(MechDriverSetupBase,"}],"source_content_type":"text/x-python","patch_set":2,"id":"70bb8f09_1238c887","line":88,"range":{"start_line":86,"start_character":0,"end_line":88,"end_character":70},"in_reply_to":"7c9dd595_519461ff","updated":"2022-05-27 08:49:37.000000000","message":"I found the reason: https://review.opendev.org/c/openstack/neutron/+/816383\n\nIn this patch I\u0027m patching, for other reason, the method \"get_virtual_port_parents\". This is not in Xena.","commit_id":"9e2425111b6f7413098bbb38f6013d18b3804303"}]}