)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9a419ce58cdcce84cd532c0708f29f0a5f5afe49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1696252b_053bf6a5","updated":"2022-05-19 04:17:56.000000000","message":"@Brian we attempted https://review.opendev.org/c/openstack/neutron/+/829475 in past and to clear the unit tests issue u seeing here we had to update tests, we haven\u0027t got the root cause though.","commit_id":"f50ed0b458c0a148e78e75d4c8eb175066158d95"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f00aeafc831e98c7787ae81533558ef3e1099de0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d19d8824_679a0691","updated":"2022-05-19 02:28:59.000000000","message":"Clearly I broke something","commit_id":"f50ed0b458c0a148e78e75d4c8eb175066158d95"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a996c72b61f50d9801bf526b15ac7fc39098496e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0a4e7fd_6b2182cd","updated":"2022-05-19 17:36:55.000000000","message":"Thanks for the info Yatin, I wonder if it\u0027s related to this SG extension, as even trying to use the one from neutron-lib results in a failure:\n\nhttps://review.opendev.org/c/openstack/neutron/+/842581\n\nDebugging in that might help.","commit_id":"f50ed0b458c0a148e78e75d4c8eb175066158d95"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ebed809f343e1aade032e645c009be697bb2044","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ef838d4_7c89aa47","updated":"2022-05-19 01:39:07.000000000","message":"This looks correct, but let\u0027s see what zuul thinks...","commit_id":"f50ed0b458c0a148e78e75d4c8eb175066158d95"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"146262307ad510df770e1e7ba3eb57ae50419e49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9cb39de4_d47e2c25","updated":"2022-05-19 23:09:46.000000000","message":"Sigh, the rebase didn\u0027t help, clearly there\u0027s something broken with OVN here as only these two tests are affected.","commit_id":"131f7f3e86f4020101dd1c0294456a8abc4998b6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7312952fe03d7af2cf115104b08ad33031e4972f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"354ec667_cb9242a1","updated":"2022-07-08 12:48:40.000000000","message":"Hi Brian, can you remove the WIP flag?","commit_id":"17dd556a7e5a95a491e1dd2ffb8b627a2344123a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0fe3b4710208c6156e937a2812c3ba9bf0aff848","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"898c320c_61935b7e","updated":"2022-07-11 10:09:51.000000000","message":"Looks ok, thanks for taking care","commit_id":"17dd556a7e5a95a491e1dd2ffb8b627a2344123a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"18091c0f246f490d06327c019fa81ce79f4d4b40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b78b67ea_fbc5b1ff","updated":"2022-07-11 18:22:15.000000000","message":"Just updated commit message with bug ID and comment in test file.","commit_id":"357ee21d12d0af6c64ba60f541ab61d44cd6d00f"}],"neutron/tests/unit/db/test_ovn_revision_numbers_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eac70b1f4392a828730e926ff2b84696b9870ead","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Hack to extend resources for revision number tests, there has to be"},{"line_number":138,"context_line":"# a better way"},{"line_number":139,"context_line":"class TestExtensionManager(extensions.PluginAwareExtensionManager):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_resources(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9e9df560_6dbddf50","line":138,"updated":"2022-07-08 13:23:16.000000000","message":"Rodolfo - do you see a better way to fix this issue? I couldn\u0027t figure out any better, the class inheritance is a little confusing if you look at the patch Yatin mentioned.","commit_id":"17dd556a7e5a95a491e1dd2ffb8b627a2344123a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8b1d5e593602ca5d67c2fe9ebe53893a1ac74720","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Hack to extend resources for revision number tests, there has to be"},{"line_number":138,"context_line":"# a better way"},{"line_number":139,"context_line":"class TestExtensionManager(extensions.PluginAwareExtensionManager):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_resources(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"e63c2792_3011893a","line":138,"in_reply_to":"3f1df0be_4061fb0d","updated":"2022-07-11 14:51:25.000000000","message":"Ok, I can live with it since it\u0027s on the test too. Do you want me to update this comment and/or add the closes-bug tag now that there\u0027s a bug?","commit_id":"17dd556a7e5a95a491e1dd2ffb8b627a2344123a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"714f8c6c694e00cd84825fc48287412b2a4b5199","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Hack to extend resources for revision number tests, there has to be"},{"line_number":138,"context_line":"# a better way"},{"line_number":139,"context_line":"class TestExtensionManager(extensions.PluginAwareExtensionManager):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_resources(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"310b14c0_4ededabe","line":138,"in_reply_to":"5b990ca3_ac37f4cc","updated":"2022-07-11 18:22:28.000000000","message":"Done","commit_id":"17dd556a7e5a95a491e1dd2ffb8b627a2344123a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0905208a528d5bcb27317d4c229eee3e6fb55e6a","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Hack to extend resources for revision number tests, there has to be"},{"line_number":138,"context_line":"# a better way"},{"line_number":139,"context_line":"class TestExtensionManager(extensions.PluginAwareExtensionManager):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_resources(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1df0be_4061fb0d","line":138,"in_reply_to":"9e9df560_6dbddf50","updated":"2022-07-11 11:03:47.000000000","message":"I\u0027ve tested making SecurityGroupTestExtensionManager inherit from PluginAwareExtensionManager, but we need to do something similar to what you have done here; if not, we\u0027ll have the SG router twice and with different definition.\n\nI\u0027ve tried also changing SecurityGroupTestPlugin to load the SG definition, but this is not the place to do this.\n\nThe problem of SG is that we don\u0027t load it in the same way as other APIs. This is why in first term SecurityGroupTestExtensionManager was implemented for testing and the method SecurityGroupTestExtensionManager.get_resources.\n\nIMO, what you have implemented here is the least invasive method and works for this particular TestRevisionNumberMaintenance class, that inherits from SecurityGroupsTestCase but doesn\u0027t load the API resources.","commit_id":"17dd556a7e5a95a491e1dd2ffb8b627a2344123a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"358ee45e5611f52a4991f97f005b6db111baca73","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Hack to extend resources for revision number tests, there has to be"},{"line_number":138,"context_line":"# a better way"},{"line_number":139,"context_line":"class TestExtensionManager(extensions.PluginAwareExtensionManager):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_resources(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5b990ca3_ac37f4cc","line":138,"in_reply_to":"e63c2792_3011893a","updated":"2022-07-11 15:30:44.000000000","message":"The reference to the launchpad bug will be perfect. The comment is enough, I don\u0027t think we need more.","commit_id":"17dd556a7e5a95a491e1dd2ffb8b627a2344123a"}]}