)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"77d20e38b89affc6b0e15d6175e2b78a4bccda5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"41d8cfd4_82257889","updated":"2022-05-27 11:47:21.000000000","message":"Looks ok","commit_id":"7cf7ae05659b363e54fbb04d2c02f91b17763921"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"08b66fb39bcf5accc9d4963a12f1a600e2a441a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7bd04a1d_4dbe046f","updated":"2023-01-18 10:05:13.000000000","message":"sorry for forgetting this review, thanks Brian","commit_id":"7cf7ae05659b363e54fbb04d2c02f91b17763921"}],"neutron/agent/linux/interface.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"165cc0c1042659fb198f14989c8872618d00873f","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    @abc.abstractmethod"},{"line_number":260,"context_line":"    def plug_new(self, network_id, port_id, device_name, mac_address,"},{"line_number":261,"context_line":"                 bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone):"},{"line_number":262,"context_line":"        \"\"\"Plug in the interface only for new devices that don\u0027t exist yet.\"\"\""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def plug(self, network_id, port_id, device_name, mac_address,"},{"line_number":265,"context_line":"             bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"78547b58_131f0c29","line":262,"updated":"2022-05-30 09:32:15.000000000","message":"this wasn\u0027t removed by the patch which You are reverting. Should we add it back here?","commit_id":"7cf7ae05659b363e54fbb04d2c02f91b17763921"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ac41422451f4e0f3ea8e5900b96df0e1582572dc","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    @abc.abstractmethod"},{"line_number":260,"context_line":"    def plug_new(self, network_id, port_id, device_name, mac_address,"},{"line_number":261,"context_line":"                 bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone):"},{"line_number":262,"context_line":"        \"\"\"Plug in the interface only for new devices that don\u0027t exist yet.\"\"\""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def plug(self, network_id, port_id, device_name, mac_address,"},{"line_number":265,"context_line":"             bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"de9a2714_7f882ea6","line":262,"in_reply_to":"4f4122eb_3e380d0d","updated":"2022-11-30 18:55:10.000000000","message":"So the original revert did add this back and I think I know why after looking at it.\n\nThis was originally removed since it\u0027s already defined in the neutron lib LinuxInterfaceDriver() class. That class has link_up\u003dTrue, which I believe will break Midonet. So I\u0027m guessing putting this here fixes that?\n\nFor that reason I think this backport is fine since it does match the code in the master branch.","commit_id":"7cf7ae05659b363e54fbb04d2c02f91b17763921"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0e484bd29d128ee686ce3fc4f5f64a96c0320a8a","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    @abc.abstractmethod"},{"line_number":260,"context_line":"    def plug_new(self, network_id, port_id, device_name, mac_address,"},{"line_number":261,"context_line":"                 bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone):"},{"line_number":262,"context_line":"        \"\"\"Plug in the interface only for new devices that don\u0027t exist yet.\"\"\""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def plug(self, network_id, port_id, device_name, mac_address,"},{"line_number":265,"context_line":"             bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a19ae19f_74919093","line":262,"in_reply_to":"78547b58_131f0c29","updated":"2022-05-31 08:05:01.000000000","message":"good catch\nAs I see only link_up\u003dTrue parameter was added, see [1]\n\n[1]: https://review.opendev.org/c/openstack/neutron/+/707406/13/neutron/agent/linux/interface.py#258","commit_id":"7cf7ae05659b363e54fbb04d2c02f91b17763921"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"b119f32c673f6f7e9545671e4e422005502c0d89","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    @abc.abstractmethod"},{"line_number":260,"context_line":"    def plug_new(self, network_id, port_id, device_name, mac_address,"},{"line_number":261,"context_line":"                 bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone):"},{"line_number":262,"context_line":"        \"\"\"Plug in the interface only for new devices that don\u0027t exist yet.\"\"\""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def plug(self, network_id, port_id, device_name, mac_address,"},{"line_number":265,"context_line":"             bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f4122eb_3e380d0d","line":262,"in_reply_to":"a19ae19f_74919093","updated":"2022-06-25 09:58:53.000000000","message":"I didn\u0027t add the abc method manually, it came as part of the revert and cherry-pick. I have also tested all this and it works fine.","commit_id":"7cf7ae05659b363e54fbb04d2c02f91b17763921"}]}