)]}'
{"tools/ovn_migration/tripleo_environment/playbooks/roles/migration/templates/activate-ovn.sh.j2":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f97033f4a4282b0efea3d48cb5bf2b374d2245b8","unresolved":true,"context_lines":[{"line_number":40,"context_line":"# Delete ovs bridges - br-tun and br-migration"},{"line_number":41,"context_line":"ovs-vsctl --if-exists del-br {{ tunnel_bridge }}"},{"line_number":42,"context_line":"ovs-vsctl --if-exists del-br br-migration"},{"line_number":43,"context_line":"ovs-vsctl --if-exists del-port br-int patch-tun"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"for br in $(ovs-vsctl list-br | egrep \u0027br-mig-[0-9]+\u0027); do"},{"line_number":46,"context_line":"   ovs-vsctl --if-exists del-br $br"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"586cfd4c_7f7c4213","line":43,"range":{"start_line":43,"start_character":38,"end_line":43,"end_character":47},"updated":"2022-06-02 06:21:15.000000000","message":"This should be the config variable \"int_peer_patch_port\" (that by default is \"patch-tun\").","commit_id":"1f0708b352fc846ab5d8d0bc55b812bb8fbcf303"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9fc26a6c1f79b16c38d260919c0d7061984f3f12","unresolved":true,"context_lines":[{"line_number":40,"context_line":"# Delete ovs bridges - br-tun and br-migration"},{"line_number":41,"context_line":"ovs-vsctl --if-exists del-br {{ tunnel_bridge }}"},{"line_number":42,"context_line":"ovs-vsctl --if-exists del-br br-migration"},{"line_number":43,"context_line":"ovs-vsctl --if-exists del-port br-int patch-tun"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"for br in $(ovs-vsctl list-br | egrep \u0027br-mig-[0-9]+\u0027); do"},{"line_number":46,"context_line":"   ovs-vsctl --if-exists del-br $br"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"cc06fb2a_dd3d6276","line":43,"range":{"start_line":43,"start_character":38,"end_line":43,"end_character":47},"in_reply_to":"586cfd4c_7f7c4213","updated":"2022-06-13 20:21:07.000000000","message":"Thanks, that\u0027s a good point and I forgot about this option.\n\nHowever, on the other hand, this code is supported only when migration a tripleo environment and I didn\u0027t find any place where tripleo could configure this option. I can come up with a code that reads it from the config file or dynamically from the OVS but I\u0027m thinking if it won\u0027t be counter productive as it brings more complexity just to support a Neutron config option that\u0027s not configurable from Tripleo.\n\nPlease share your thoughts on this, if it\u0027s worth implementing the mechanism.","commit_id":"1f0708b352fc846ab5d8d0bc55b812bb8fbcf303"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e25c47cdc133de242fe741200f009d60e01f77ab","unresolved":true,"context_lines":[{"line_number":40,"context_line":"# Delete ovs bridges - br-tun and br-migration"},{"line_number":41,"context_line":"ovs-vsctl --if-exists del-br {{ tunnel_bridge }}"},{"line_number":42,"context_line":"ovs-vsctl --if-exists del-br br-migration"},{"line_number":43,"context_line":"ovs-vsctl --if-exists del-port br-int patch-tun"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"for br in $(ovs-vsctl list-br | egrep \u0027br-mig-[0-9]+\u0027); do"},{"line_number":46,"context_line":"   ovs-vsctl --if-exists del-br $br"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d8edb39f_2a686f75","line":43,"range":{"start_line":43,"start_character":38,"end_line":43,"end_character":47},"in_reply_to":"cc06fb2a_dd3d6276","updated":"2022-06-21 14:09:03.000000000","message":"I\u0027ve checked the OOO code and I didn\u0027t see it. That could be safe having this consideration.","commit_id":"1f0708b352fc846ab5d8d0bc55b812bb8fbcf303"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"69aaaee4be79904ef20d26d5093d08a651618b71","unresolved":true,"context_lines":[{"line_number":40,"context_line":"# Delete ovs bridges - br-tun and br-migration"},{"line_number":41,"context_line":"ovs-vsctl --if-exists del-br {{ tunnel_bridge }}"},{"line_number":42,"context_line":"ovs-vsctl --if-exists del-br br-migration"},{"line_number":43,"context_line":"ovs-vsctl --if-exists del-port br-int patch-tun"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"for br in $(ovs-vsctl list-br | egrep \u0027br-mig-[0-9]+\u0027); do"},{"line_number":46,"context_line":"   ovs-vsctl --if-exists del-br $br"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7fcef952_35aae37e","line":43,"range":{"start_line":43,"start_character":38,"end_line":43,"end_character":47},"in_reply_to":"d8edb39f_2a686f75","updated":"2022-06-22 05:04:11.000000000","message":"i see puppet-neutron allows to configure it https://opendev.org/openstack/puppet-neutron/src/branch/master/manifests/agents/ml2/ovs.pp#L490, so the option can be set with TripleO too. but unsure if that\u0027s something generally configured as the original bug didn\u0027t describe the use case https://bugs.launchpad.net/puppet-neutron/+bug/1531039, so i am +2 on this as if it\u0027s needed in future dynamic option can be implemented.","commit_id":"1f0708b352fc846ab5d8d0bc55b812bb8fbcf303"}]}