)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"41f48f3e3109f027718680866debc3359e2b846f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40ca1ae4_f051725d","updated":"2022-06-16 11:30:45.000000000","message":"Good catch","commit_id":"60dd62187bae6fa85a65109e1082f3dc2caa2e95"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"ad41e2d9795ed12c11db386460b39d17a563f0e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3cba5816_aaf22696","updated":"2022-06-13 08:51:18.000000000","message":"Thanks, Rodolfo! Would this case be worth covering in the tests (at least the unit tests)?","commit_id":"60dd62187bae6fa85a65109e1082f3dc2caa2e95"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"13485730d50a3336baa5840037e5be470c05d01e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0fbddf1_458c9c77","in_reply_to":"3cba5816_aaf22696","updated":"2022-06-16 15:32:20.000000000","message":"Done","commit_id":"60dd62187bae6fa85a65109e1082f3dc2caa2e95"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b2897f784c792bbd3d5537b587a2dbd622de9707","unresolved":true,"context_lines":[{"line_number":1060,"context_line":"                # unset it."},{"line_number":1061,"context_line":"                for port in self.ovsdb.db_list("},{"line_number":1062,"context_line":"                        \u0027Port\u0027, columns\u003d[\u0027_uuid\u0027, \u0027qos\u0027]).execute("},{"line_number":1063,"context_line":"                        check_error\u003dTrue):"},{"line_number":1064,"context_line":"                    if port[\u0027qos\u0027] \u003d\u003d qos_id:"},{"line_number":1065,"context_line":"                        self.ovsdb.db_clear(\u0027Port\u0027, port[\u0027_uuid\u0027],"},{"line_number":1066,"context_line":"                                            \u0027qos\u0027).execute(check_error\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5dd27726_d9412f3c","line":1063,"updated":"2022-06-07 14:19:27.000000000","message":"I\u0027m just wondering if using db_find() with the qos_id like L1085 below will make this faster by returning less ports?","commit_id":"cd43579c237a0c4a6315d7c1aecc4d5afe582b8a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3a26d1b291f0d00fbdd90403d11bdb0729a37680","unresolved":true,"context_lines":[{"line_number":1060,"context_line":"                # unset it."},{"line_number":1061,"context_line":"                for port in self.ovsdb.db_list("},{"line_number":1062,"context_line":"                        \u0027Port\u0027, columns\u003d[\u0027_uuid\u0027, \u0027qos\u0027]).execute("},{"line_number":1063,"context_line":"                        check_error\u003dTrue):"},{"line_number":1064,"context_line":"                    if port[\u0027qos\u0027] \u003d\u003d qos_id:"},{"line_number":1065,"context_line":"                        self.ovsdb.db_clear(\u0027Port\u0027, port[\u0027_uuid\u0027],"},{"line_number":1066,"context_line":"                                            \u0027qos\u0027).execute(check_error\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2b1240e_605e3bb9","line":1063,"in_reply_to":"5dd27726_d9412f3c","updated":"2022-06-07 15:32:46.000000000","message":"If I\u0027m not wrong, \"qos\" is not an index in \"Port\" table so ovsdbapp will iterate over the table. In any case, it is more elegant using \"db_find()\". I\u0027ll push a new PS.","commit_id":"cd43579c237a0c4a6315d7c1aecc4d5afe582b8a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ed9bb78d834a301ff4a2408e3707b83187f307f","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"                # unset it."},{"line_number":1061,"context_line":"                for port in self.ovsdb.db_list("},{"line_number":1062,"context_line":"                        \u0027Port\u0027, columns\u003d[\u0027_uuid\u0027, \u0027qos\u0027]).execute("},{"line_number":1063,"context_line":"                        check_error\u003dTrue):"},{"line_number":1064,"context_line":"                    if port[\u0027qos\u0027] \u003d\u003d qos_id:"},{"line_number":1065,"context_line":"                        self.ovsdb.db_clear(\u0027Port\u0027, port[\u0027_uuid\u0027],"},{"line_number":1066,"context_line":"                                            \u0027qos\u0027).execute(check_error\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0ea30117_69b3a57d","line":1063,"in_reply_to":"a2b1240e_605e3bb9","updated":"2022-06-08 08:22:03.000000000","message":"Done","commit_id":"cd43579c237a0c4a6315d7c1aecc4d5afe582b8a"}]}
