)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"505f163b35ae130bd69c1d265e60bcd56abc297c","unresolved":true,"context_lines":[{"line_number":19,"context_line":"This commit implements this agreement, initially with Linuxbridge"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/845646"},{"line_number":22,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/847989"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[1] https://lists.openstack.org/pipermail/openstack-discuss/2022-April/028164.html"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7bc38be8_2ab23ca2","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":67},"updated":"2022-06-28 21:34:26.000000000","message":"Within the same repository, what is used is the commit dependency. Instead of creating this dependency, you should rebase this patch on top of 847989","commit_id":"d8e501ee003cc96112ee6bd472df0619dcb01199"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9e53a7e302088dd6700ee5aec9dc4ed4b93a31f1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"This commit implements this agreement, initially with Linuxbridge"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/845646"},{"line_number":22,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/847989"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[1] https://lists.openstack.org/pipermail/openstack-discuss/2022-April/028164.html"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"6481f493_bc693bb5","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":67},"in_reply_to":"7bc38be8_2ab23ca2","updated":"2022-06-28 22:41:08.000000000","message":"Done","commit_id":"d8e501ee003cc96112ee6bd472df0619dcb01199"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0af75cba84e190e4d012ff919e83618f20c811c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48023ffa_5cb7f200","updated":"2022-06-09 03:06:17.000000000","message":"One interesting thing is that OpenStack Installation Guides are still using linux bridge as default, there are many pictures and config options [1][2]. All these docs should be updated, or maybe move [3] to the install-guide is enough.\n[1] https://docs.openstack.org/install-guide/overview.html#networking-option-1-provider-networks\n[2] https://docs.openstack.org/install-guide/overview.html#networking-option-2-self-service-networks\n[3] https://docs.openstack.org/neutron/latest/admin/deploy-ovs\n\nJust some thoughts from this change, not so much really related to this patch. 😊","commit_id":"86e82c56c10f18ec04cff9f072e7a2e8efecd6f1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8e23e142b79a85212411b9a47cdd1fe390b9ecf3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0bbaf8e_61b5c0a8","in_reply_to":"48023ffa_5cb7f200","updated":"2022-06-14 07:19:56.000000000","message":"good catch, perhaps updating the figures is better, as with that we remove misleading messages to operators","commit_id":"86e82c56c10f18ec04cff9f072e7a2e8efecd6f1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"48cc987f63e0005b52be46e8ef0377459486e228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"402d2969_383386f8","updated":"2022-06-16 13:27:36.000000000","message":"This change will break any environment running on linux bridge once migrated to Zed. Is that what we want?","commit_id":"a6a969295a0e88c931a361dde30c539a3829f6a0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"46bae41be72fb40986522992d7a27cf6c26dd023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"668b92a9_66176d69","in_reply_to":"402d2969_383386f8","updated":"2022-06-16 23:25:45.000000000","message":"In the PTG we agreed the following:\n\n\"...To make it clear for operators we add warning logs highlighting that the\ngiven feature/driver is experimental, and introduce cfg option to enable\nsuch features explicitly.\"\n\nSaid in another way, if a feature that has been classified as experimental is not enabled explicitly by the user, it shouldn\u0027t work. Otherwise, the community will continue expecting the Neutron team to continue maintaining the feature. It\u0027s a question of sending clear signals","commit_id":"a6a969295a0e88c931a361dde30c539a3829f6a0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6effbc81dd0993001180d3999ef7b01c296028b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7afae8d6_7847c9d3","in_reply_to":"668b92a9_66176d69","updated":"2022-06-16 23:27:36.000000000","message":"I also added a release note to give deployers a heads up","commit_id":"a6a969295a0e88c931a361dde30c539a3829f6a0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cef5da2db73495b68f31706bc7f14cba5bf666b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"28a5c058_bff1093d","updated":"2022-06-17 17:34:33.000000000","message":"recheck","commit_id":"15c6d3a2cd2159c1759dc4d6abd541065fb9e4b9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"82cdb92a44b636a3212dd96fb7e202576f25e0c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ab357eb6_8da7afac","updated":"2022-06-20 12:50:04.000000000","message":"Code is ok. Minor error in doc (check doc CI job).\n\n+2 once the error is fixed.","commit_id":"520b7532d0570cd2f6ef7e4931e0d88af5faf9ff"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f94f3c61ea41f2d94b349ec438dcb13ae51c730b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d0d83fc3_0f8f904c","updated":"2022-06-29 14:32:11.000000000","message":"Only some small nits. Great job IMO. Thx a lot 😊","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9e53a7e302088dd6700ee5aec9dc4ed4b93a31f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"16f31d28_40437a93","updated":"2022-06-28 22:41:08.000000000","message":"duh, I knew that :-)","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"80f2264fa0e8d0127cc7305acc8c432131252149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f2ba3a90_7563a7be","updated":"2022-06-30 06:22:55.000000000","message":"Hey Miguel, looks good, just had a few general comments in addition to my specific ones.\n\nI ran \u0027tox -e docs\u0027 but didn\u0027t see the new group or options in any of the generated files, or in the samples with \u0027tox -e genconfig\u0027. Maybe I missed them? If not I think you need changes in:\n\nneutron/opts.py: list_experimental_opts() method\nsetup.cfg: entry for above method near related ones\netc/oslo-config-generator/neutron.conf: add neutron.common namespace?\n\nOf course when I did that locally it still didn\u0027t work.\n\nHopefully my rambling makes sense 😊","commit_id":"010d6cee5631f9e0b812e93e23da995e32c681e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ce445e5d0b2a764a4380b559e5e7ab53eedc087f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c98309df_c80b2bc3","in_reply_to":"f2ba3a90_7563a7be","updated":"2022-06-30 23:00:26.000000000","message":"All done. Thanks for the review!","commit_id":"010d6cee5631f9e0b812e93e23da995e32c681e5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7d5d87662eb7908397a61938a9df0449de68e025","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9ddf6496_e0be4339","updated":"2022-07-01 03:06:39.000000000","message":"LGTM, tried this locally and see and the docs and samples are correct now, I had a small typo in setup.cfg which is why I didn\u0027t get it to work, you didn\u0027t make the same mistake 😊","commit_id":"7f0413c84c4515cd2fae31d823613c4d7ea43110"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c0cfb12c6bc460906ad9fbbcbb6f4f1427692d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a64e92ff_8f5a2fa8","updated":"2022-07-01 07:31:29.000000000","message":"Nice, thanks","commit_id":"7f0413c84c4515cd2fae31d823613c4d7ea43110"}],"doc/source/admin/config-experimental-framework.rst":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"82cdb92a44b636a3212dd96fb7e202576f25e0c2","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":"     Feature                    Option in neutron.conf to enable"},{"line_number":20,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":"     ML2 Linuxbridge driver        linuxbridge"},{"line_number":22,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This is an example of how to enable the use of an experimental feature:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"8c193293_c884f322","line":21,"range":{"start_line":21,"start_character":33,"end_line":21,"end_character":35},"updated":"2022-06-20 12:50:04.000000000","message":"nit: extra spaces (but RST should format this table correctly)","commit_id":"520b7532d0570cd2f6ef7e4931e0d88af5faf9ff"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7251ddafff07369fb040599cc32842a077c21d7f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":"     Feature                    Option in neutron.conf to enable"},{"line_number":20,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":"     ML2 Linuxbridge driver        linuxbridge"},{"line_number":22,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This is an example of how to enable the use of an experimental feature:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"442b5cf2_91d40da6","line":21,"range":{"start_line":21,"start_character":33,"end_line":21,"end_character":35},"in_reply_to":"8c193293_c884f322","updated":"2022-06-28 15:02:47.000000000","message":"Done","commit_id":"520b7532d0570cd2f6ef7e4931e0d88af5faf9ff"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"80f2264fa0e8d0127cc7305acc8c432131252149","unresolved":true,"context_lines":[{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Some Neutron features are not supported because the community doesn\u0027t have"},{"line_number":8,"context_line":"anymore the resources and technical expertise to maintain them. As they arise,"},{"line_number":9,"context_line":"the Neutron team designates these features as experimental. Deployers can"},{"line_number":10,"context_line":"continue using these features at their own risk, by explicitly enabling them in"},{"line_number":11,"context_line":"the ``EXPERIMENTAL`` section of ``neutron.conf``."}],"source_content_type":"text/x-rst","patch_set":9,"id":"13123906_2abb8e95","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":62},"updated":"2022-06-30 06:22:55.000000000","message":"nit: this sounds better with anymore at the end:\n\nthe resources and/or technical expertise to maintain them anymore.","commit_id":"d8e501ee003cc96112ee6bd472df0619dcb01199"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ce445e5d0b2a764a4380b559e5e7ab53eedc087f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Some Neutron features are not supported because the community doesn\u0027t have"},{"line_number":8,"context_line":"anymore the resources and technical expertise to maintain them. As they arise,"},{"line_number":9,"context_line":"the Neutron team designates these features as experimental. Deployers can"},{"line_number":10,"context_line":"continue using these features at their own risk, by explicitly enabling them in"},{"line_number":11,"context_line":"the ``EXPERIMENTAL`` section of ``neutron.conf``."}],"source_content_type":"text/x-rst","patch_set":9,"id":"c8edd2d5_7faaafed","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":62},"in_reply_to":"13123906_2abb8e95","updated":"2022-06-30 23:00:26.000000000","message":"Done","commit_id":"d8e501ee003cc96112ee6bd472df0619dcb01199"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f94f3c61ea41f2d94b349ec438dcb13ae51c730b","unresolved":true,"context_lines":[{"line_number":9,"context_line":"the Neutron team designates these features as experimental. Deployers can"},{"line_number":10,"context_line":"continue using these features at their own risk, by explicitly enabling them in"},{"line_number":11,"context_line":"the ``EXPERIMENTAL`` section of ``neutron.conf``."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The following table shows the Neutron features currently designated as"},{"line_number":14,"context_line":"experimetal:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"0e93c047_e2152170","line":12,"updated":"2022-06-29 14:32:11.000000000","message":"Can be in follow up patch but maybe we could add some info about that if someone is interested in maintaining such feature, should contact with neutron team about that, and give some contact details there too. Wdyt?","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2f6dee74bec817704925760f437c88329f6cf9d0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"the Neutron team designates these features as experimental. Deployers can"},{"line_number":10,"context_line":"continue using these features at their own risk, by explicitly enabling them in"},{"line_number":11,"context_line":"the ``EXPERIMENTAL`` section of ``neutron.conf``."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The following table shows the Neutron features currently designated as"},{"line_number":14,"context_line":"experimetal:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"44536936_3e1a9969","line":12,"in_reply_to":"0e93c047_e2152170","updated":"2022-06-29 22:15:19.000000000","message":"Excellent idea. Done!","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"}],"neutron/common/experimental.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"48cc987f63e0005b52be46e8ef0377459486e228","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        LOG.warning(\"Feature \u0027%s\u0027 is unsupported and is treated as \""},{"line_number":35,"context_line":"                    \"experimental. Use at your own risk.\", feature)"},{"line_number":36,"context_line":"    else:"},{"line_number":37,"context_line":"        LOG.error(\"Feature \u0027%s\u0027 is experimental and has to be explicitely \""},{"line_number":38,"context_line":"                  \"enabled in \u0027cfg.CONF.EXPERIMENTAL\u0027\", feature)"},{"line_number":39,"context_line":"        raise SystemExit(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0660efb3_509bbfed","line":37,"range":{"start_line":37,"start_character":62,"end_line":37,"end_character":73},"updated":"2022-06-16 13:27:36.000000000","message":"explicitly","commit_id":"a6a969295a0e88c931a361dde30c539a3829f6a0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"46bae41be72fb40986522992d7a27cf6c26dd023","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        LOG.warning(\"Feature \u0027%s\u0027 is unsupported and is treated as \""},{"line_number":35,"context_line":"                    \"experimental. Use at your own risk.\", feature)"},{"line_number":36,"context_line":"    else:"},{"line_number":37,"context_line":"        LOG.error(\"Feature \u0027%s\u0027 is experimental and has to be explicitely \""},{"line_number":38,"context_line":"                  \"enabled in \u0027cfg.CONF.EXPERIMENTAL\u0027\", feature)"},{"line_number":39,"context_line":"        raise SystemExit(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"09496c3a_68187e65","line":37,"range":{"start_line":37,"start_character":62,"end_line":37,"end_character":73},"in_reply_to":"0660efb3_509bbfed","updated":"2022-06-16 23:25:45.000000000","message":"Done","commit_id":"a6a969295a0e88c931a361dde30c539a3829f6a0"}],"neutron/conf/experimental.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"48cc987f63e0005b52be46e8ef0377459486e228","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from neutron._i18n import _"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"EXPERIMENTAL_CFG_GROUP \u003d \u0027EXPERIMENTAL\u0027"},{"line_number":19,"context_line":"EXPERIMENTAL_LINUXBRIDGE \u003d \u0027experimental_linuxbridge\u0027"},{"line_number":20,"context_line":"EXPERIMENTAL_OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.BoolOpt(EXPERIMENTAL_LINUXBRIDGE,"},{"line_number":22,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ac795317_62a0c122","line":19,"range":{"start_line":19,"start_character":28,"end_line":19,"end_character":41},"updated":"2022-06-16 13:27:36.000000000","message":"I would avoid repeating \"experimental\" for each new config option, once we have then inside \"EXPERIMENTAL\".","commit_id":"a6a969295a0e88c931a361dde30c539a3829f6a0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"46bae41be72fb40986522992d7a27cf6c26dd023","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron._i18n import _"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"EXPERIMENTAL_CFG_GROUP \u003d \u0027EXPERIMENTAL\u0027"},{"line_number":19,"context_line":"EXPERIMENTAL_LINUXBRIDGE \u003d \u0027experimental_linuxbridge\u0027"},{"line_number":20,"context_line":"EXPERIMENTAL_OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.BoolOpt(EXPERIMENTAL_LINUXBRIDGE,"},{"line_number":22,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d478022d_1d12bbe1","line":19,"range":{"start_line":19,"start_character":28,"end_line":19,"end_character":41},"in_reply_to":"ac795317_62a0c122","updated":"2022-06-16 23:25:45.000000000","message":"Done","commit_id":"a6a969295a0e88c931a361dde30c539a3829f6a0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"80f2264fa0e8d0127cc7305acc8c432131252149","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron._i18n import _"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"EXPERIMENTAL_CFG_GROUP \u003d \u0027EXPERIMENTAL\u0027"},{"line_number":19,"context_line":"EXPERIMENTAL_LINUXBRIDGE \u003d \u0027linuxbridge\u0027"},{"line_number":20,"context_line":"EXPERIMENTAL_OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.BoolOpt(EXPERIMENTAL_LINUXBRIDGE,"}],"source_content_type":"text/x-python","patch_set":9,"id":"333e0cd8_e5161af6","line":18,"updated":"2022-06-30 06:22:55.000000000","message":"I didn\u0027t think you could use all-caps for a config group name, at least oslo.config should show a warning although I don\u0027t see it?\n\nSee https://review.opendev.org/c/openstack/neutron/+/839818","commit_id":"d8e501ee003cc96112ee6bd472df0619dcb01199"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ce445e5d0b2a764a4380b559e5e7ab53eedc087f","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron._i18n import _"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"EXPERIMENTAL_CFG_GROUP \u003d \u0027EXPERIMENTAL\u0027"},{"line_number":19,"context_line":"EXPERIMENTAL_LINUXBRIDGE \u003d \u0027linuxbridge\u0027"},{"line_number":20,"context_line":"EXPERIMENTAL_OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.BoolOpt(EXPERIMENTAL_LINUXBRIDGE,"}],"source_content_type":"text/x-python","patch_set":9,"id":"eaaf8d29_0774760a","line":18,"in_reply_to":"333e0cd8_e5161af6","updated":"2022-06-30 23:00:26.000000000","message":"Done","commit_id":"d8e501ee003cc96112ee6bd472df0619dcb01199"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f94f3c61ea41f2d94b349ec438dcb13ae51c730b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    cfg.BoolOpt(EXPERIMENTAL_LINUXBRIDGE,"},{"line_number":22,"context_line":"                default\u003dFalse,"},{"line_number":23,"context_line":"                help\u003d_(\u0027Enable execution of the experimental Linuxbridge \u0027"},{"line_number":24,"context_line":"                       \u0027driver.\u0027)),"},{"line_number":25,"context_line":"]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"4003c53d_838b6100","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":30},"updated":"2022-06-29 14:32:11.000000000","message":"nit: should be \"agent\" probably","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2f6dee74bec817704925760f437c88329f6cf9d0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    cfg.BoolOpt(EXPERIMENTAL_LINUXBRIDGE,"},{"line_number":22,"context_line":"                default\u003dFalse,"},{"line_number":23,"context_line":"                help\u003d_(\u0027Enable execution of the experimental Linuxbridge \u0027"},{"line_number":24,"context_line":"                       \u0027driver.\u0027)),"},{"line_number":25,"context_line":"]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"a1d602f1_2bad35b9","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":30},"in_reply_to":"4003c53d_838b6100","updated":"2022-06-29 22:15:19.000000000","message":"Done","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"}],"neutron/opts.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7d5d87662eb7908397a61938a9df0449de68e025","unresolved":true,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":"def list_experimental_opts():"},{"line_number":368,"context_line":"    return ["},{"line_number":369,"context_line":"        (neutron.conf.experimental.EXPERIMENTAL_CFG_GROUP,"},{"line_number":370,"context_line":"         itertools.chain(neutron.conf.experimental.experimental_opts)"},{"line_number":371,"context_line":"         ),"},{"line_number":372,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":13,"id":"4298cce9_de0c8203","line":369,"range":{"start_line":369,"start_character":9,"end_line":369,"end_character":57},"updated":"2022-07-01 03:06:39.000000000","message":"super nit: s/\u0027experimental\u0027 just because none of the others use constants","commit_id":"7f0413c84c4515cd2fae31d823613c4d7ea43110"}],"neutron/plugins/ml2/drivers/linuxbridge/mech_driver/mech_linuxbridge.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f94f3c61ea41f2d94b349ec438dcb13ae51c730b","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self):"},{"line_number":37,"context_line":"        experimental.validate_experimental_enabled("},{"line_number":38,"context_line":"            c_experimental.EXPERIMENTAL_LINUXBRIDGE)"},{"line_number":39,"context_line":"        sg_enabled \u003d securitygroups_rpc.is_firewall_enabled()"},{"line_number":40,"context_line":"        vif_details \u003d {portbindings.CAP_PORT_FILTER: sg_enabled,"},{"line_number":41,"context_line":"                       portbindings.VIF_DETAILS_CONNECTIVITY:"}],"source_content_type":"text/x-python","patch_set":10,"id":"77be7453_fa657b22","line":38,"updated":"2022-06-29 14:32:11.000000000","message":"should we add the same for the agent\u0027s code or it\u0027s enough to have it here only?","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2f6dee74bec817704925760f437c88329f6cf9d0","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self):"},{"line_number":37,"context_line":"        experimental.validate_experimental_enabled("},{"line_number":38,"context_line":"            c_experimental.EXPERIMENTAL_LINUXBRIDGE)"},{"line_number":39,"context_line":"        sg_enabled \u003d securitygroups_rpc.is_firewall_enabled()"},{"line_number":40,"context_line":"        vif_details \u003d {portbindings.CAP_PORT_FILTER: sg_enabled,"},{"line_number":41,"context_line":"                       portbindings.VIF_DETAILS_CONNECTIVITY:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5b0f56b9_71d40f33","line":38,"in_reply_to":"77be7453_fa657b22","updated":"2022-06-29 22:15:19.000000000","message":"With this, the Neutron server will not start if linuxbridge is not configured as experimental. I think that is enough","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"}],"neutron/tests/fullstack/resources/environment.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f94f3c61ea41f2d94b349ec438dcb13ae51c730b","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        if self.local_ip_ext:"},{"line_number":74,"context_line":"            self.service_plugins +\u003d \u0027,local_ip\u0027"},{"line_number":75,"context_line":"        self.quota_driver \u003d quota_driver"},{"line_number":76,"context_line":"        self.linuxbridge \u003d linuxbridge"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def tunneling_enabled(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7e517094_14aa585e","line":76,"updated":"2022-06-29 14:32:11.000000000","message":"that variable names can be a bit confusing IMO. Maybe better would be to name them as \"allow_experimental_linuxbridge\" or something like that","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2f6dee74bec817704925760f437c88329f6cf9d0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        if self.local_ip_ext:"},{"line_number":74,"context_line":"            self.service_plugins +\u003d \u0027,local_ip\u0027"},{"line_number":75,"context_line":"        self.quota_driver \u003d quota_driver"},{"line_number":76,"context_line":"        self.linuxbridge \u003d linuxbridge"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def tunneling_enabled(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3d7da906_b125949e","line":76,"in_reply_to":"7e517094_14aa585e","updated":"2022-06-29 22:15:19.000000000","message":"Done","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"}],"releasenotes/notes/Experimental-features-framework-8c34291b5b0be367.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"82cdb92a44b636a3212dd96fb7e202576f25e0c2","unresolved":true,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Introduce the experimental features framework."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"    - Some Neutron features are not supported due to lack of resources or"},{"line_number":6,"context_line":"      technical expertise to maintain them. As they arise, those features will"},{"line_number":7,"context_line":"      be marked as experimental by the Neutron core team"},{"line_number":8,"context_line":"    - Deployers will be able to continue using experimental features by"},{"line_number":9,"context_line":"      explicitly enabling them in the \u0027EXPERIMENTAL\u0027 section of neutron.conf"},{"line_number":10,"context_line":"    - The ML2 linuxbridge driver is the first feature to be marked as"},{"line_number":11,"context_line":"      experimental. To continue using it, deployers have to set to True the"},{"line_number":12,"context_line":"      \u0027linuxbridge\u0027 option in the \u0027EXPERIMENTAL\u0027 section of neutron.conf"},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    The ML2 linuxbridge driver has been marked as experimental due to lack"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f05cd610_92b3dc45","line":12,"range":{"start_line":5,"start_character":4,"end_line":12,"end_character":72},"updated":"2022-06-20 12:50:04.000000000","message":"nit: I think all of this should be in the same point.\n\nfeatures:\n    - |\n      paragraph 1\n      paragraph 2\n      paragraph 3","commit_id":"520b7532d0570cd2f6ef7e4931e0d88af5faf9ff"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7251ddafff07369fb040599cc32842a077c21d7f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Introduce the experimental features framework."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"    - Some Neutron features are not supported due to lack of resources or"},{"line_number":6,"context_line":"      technical expertise to maintain them. As they arise, those features will"},{"line_number":7,"context_line":"      be marked as experimental by the Neutron core team"},{"line_number":8,"context_line":"    - Deployers will be able to continue using experimental features by"},{"line_number":9,"context_line":"      explicitly enabling them in the \u0027EXPERIMENTAL\u0027 section of neutron.conf"},{"line_number":10,"context_line":"    - The ML2 linuxbridge driver is the first feature to be marked as"},{"line_number":11,"context_line":"      experimental. To continue using it, deployers have to set to True the"},{"line_number":12,"context_line":"      \u0027linuxbridge\u0027 option in the \u0027EXPERIMENTAL\u0027 section of neutron.conf"},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    The ML2 linuxbridge driver has been marked as experimental due to lack"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0b473251_e62184a3","line":12,"range":{"start_line":5,"start_character":4,"end_line":12,"end_character":72},"in_reply_to":"f05cd610_92b3dc45","updated":"2022-06-28 15:02:47.000000000","message":"Done","commit_id":"520b7532d0570cd2f6ef7e4931e0d88af5faf9ff"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f94f3c61ea41f2d94b349ec438dcb13ae51c730b","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    \u0027linuxbridge\u0027 option in the \u0027EXPERIMENTAL\u0027 section of neutron.conf."},{"line_number":14,"context_line":"deprecations:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    The ML2 linuxbridge driver has been marked as experimental due to lack"},{"line_number":17,"context_line":"    of resources to maintain it. To continue using it, deployers have to set"},{"line_number":18,"context_line":"    to True the \u0027linuxbridge\u0027 option in the \u0027EXPERIMENTAL\u0027 section of"},{"line_number":19,"context_line":"    neutron.conf"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f3984df1_c659a90b","line":16,"range":{"start_line":16,"start_character":24,"end_line":16,"end_character":30},"updated":"2022-06-29 14:32:11.000000000","message":"and agent 😊","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2f6dee74bec817704925760f437c88329f6cf9d0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \u0027linuxbridge\u0027 option in the \u0027EXPERIMENTAL\u0027 section of neutron.conf."},{"line_number":14,"context_line":"deprecations:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    The ML2 linuxbridge driver has been marked as experimental due to lack"},{"line_number":17,"context_line":"    of resources to maintain it. To continue using it, deployers have to set"},{"line_number":18,"context_line":"    to True the \u0027linuxbridge\u0027 option in the \u0027EXPERIMENTAL\u0027 section of"},{"line_number":19,"context_line":"    neutron.conf"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"486456d2_301687e4","line":16,"range":{"start_line":16,"start_character":24,"end_line":16,"end_character":30},"in_reply_to":"f3984df1_c659a90b","updated":"2022-06-29 22:15:19.000000000","message":"Done","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"}],"zuul.d/rally.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f94f3c61ea41f2d94b349ec438dcb13ae51c730b","unresolved":true,"context_lines":[{"line_number":50,"context_line":"            DEFAULT:"},{"line_number":51,"context_line":"              enable_code_profiling: True"},{"line_number":52,"context_line":"            EXPERIMENTAL:"},{"line_number":53,"context_line":"              linuxbridge: true"},{"line_number":54,"context_line":"    required-projects:"},{"line_number":55,"context_line":"      - openstack/rally"},{"line_number":56,"context_line":"      - openstack/rally-openstack"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"465006f4_29ece6b7","line":53,"updated":"2022-06-29 14:32:11.000000000","message":"do we need it here? Maybe instead we should remove linuxbridge from the mech drivers list in that job. It\u0027s \"ovs\" job really.","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2f6dee74bec817704925760f437c88329f6cf9d0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            DEFAULT:"},{"line_number":51,"context_line":"              enable_code_profiling: True"},{"line_number":52,"context_line":"            EXPERIMENTAL:"},{"line_number":53,"context_line":"              linuxbridge: true"},{"line_number":54,"context_line":"    required-projects:"},{"line_number":55,"context_line":"      - openstack/rally"},{"line_number":56,"context_line":"      - openstack/rally-openstack"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e32d87c8_d54bd1de","line":53,"in_reply_to":"465006f4_29ece6b7","updated":"2022-06-29 22:15:19.000000000","message":"Done","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"}],"zuul.d/tempest-multinode.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f94f3c61ea41f2d94b349ec438dcb13ae51c730b","unresolved":true,"context_lines":[{"line_number":215,"context_line":"        post-config:"},{"line_number":216,"context_line":"          $NEUTRON_CONF:"},{"line_number":217,"context_line":"            EXPERIMENTAL:"},{"line_number":218,"context_line":"              linuxbridge: true"},{"line_number":219,"context_line":"          $NEUTRON_L3_CONF:"},{"line_number":220,"context_line":"            agent:"},{"line_number":221,"context_line":"              debug_iptables_rules: True"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"59a1b07b_2140bf95","line":218,"updated":"2022-06-29 14:32:11.000000000","message":"do we need it here? Maybe instead we should remove linuxbridge from the mech drivers list in that job. It\u0027s \"ovs\" job really.","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2f6dee74bec817704925760f437c88329f6cf9d0","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        post-config:"},{"line_number":216,"context_line":"          $NEUTRON_CONF:"},{"line_number":217,"context_line":"            EXPERIMENTAL:"},{"line_number":218,"context_line":"              linuxbridge: true"},{"line_number":219,"context_line":"          $NEUTRON_L3_CONF:"},{"line_number":220,"context_line":"            agent:"},{"line_number":221,"context_line":"              debug_iptables_rules: True"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"16158109_e4b3409f","line":218,"in_reply_to":"59a1b07b_2140bf95","updated":"2022-06-29 22:15:19.000000000","message":"Done","commit_id":"e83b1d0ac0eaaba4fb883045e1e4122c9a53e1bb"}]}
