)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8ecca2298913f2530f4f74b317aa69985c44b439","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb4af6b8_f3820f76","updated":"2022-06-13 19:49:03.000000000","message":"-1 just to get clarification of my question there.","commit_id":"347f17a0d23f3aa0cd006e91d3d88bb3f4cad382"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74208eb3b2de47194c8470ae2725710b76aefda3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bbd5a4a8_4b8a512d","updated":"2022-06-13 16:28:31.000000000","message":"recheck","commit_id":"347f17a0d23f3aa0cd006e91d3d88bb3f4cad382"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"89c978b545cbfcdb9493e6d051e613e66257d985","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f5113625_3608ae06","updated":"2022-06-16 12:23:11.000000000","message":"LGTM","commit_id":"f3b84ed099dee38b75192cd0aadab325f089c1f5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9bec20b6af6aa3ed198d0513a616f9fa71fa4604","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bbb0a99e_5277a7de","updated":"2022-06-17 05:57:17.000000000","message":"fullstack/functional seems broken with pyroute2-0.6.12 release https://review.opendev.org/c/openstack/requirements/+/845871, reporting bug.","commit_id":"f3b84ed099dee38b75192cd0aadab325f089c1f5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"450baa729f06915f299b71d1dc5734b498ea0636","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"179fc584_04445cc9","updated":"2022-06-17 13:38:01.000000000","message":"recheck","commit_id":"f3b84ed099dee38b75192cd0aadab325f089c1f5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1fd8c8378a84ad5b466c04c67ebc6fa9b3f923ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8e291f7e_449e4f51","updated":"2022-06-14 12:58:50.000000000","message":"recheck","commit_id":"f3b84ed099dee38b75192cd0aadab325f089c1f5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b65dacafbde5b9edf743819fe3974df0c28da630","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"35d88eaa_7fba5957","in_reply_to":"bbb0a99e_5277a7de","updated":"2022-06-17 07:21:18.000000000","message":"reported https://bugs.launchpad.net/neutron/+bug/1979031","commit_id":"f3b84ed099dee38b75192cd0aadab325f089c1f5"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8ecca2298913f2530f4f74b317aa69985c44b439","unresolved":true,"context_lines":[{"line_number":1015,"context_line":"            return True"},{"line_number":1016,"context_line":"        return False"},{"line_number":1017,"context_line":""},{"line_number":1018,"context_line":"    def _update_security_group_on_port(self, context, id, port,"},{"line_number":1019,"context_line":"                                       original_port, updated_port):"},{"line_number":1020,"context_line":"        \"\"\"Update security groups on port."},{"line_number":1021,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffc38331_73a094a6","line":1018,"updated":"2022-06-13 19:49:03.000000000","message":"how this change is related to the change described in the commit message?","commit_id":"347f17a0d23f3aa0cd006e91d3d88bb3f4cad382"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a57bb024c238ed3311b2cd8ad99ceedf8d52fd7d","unresolved":false,"context_lines":[{"line_number":1015,"context_line":"            return True"},{"line_number":1016,"context_line":"        return False"},{"line_number":1017,"context_line":""},{"line_number":1018,"context_line":"    def _update_security_group_on_port(self, context, id, port,"},{"line_number":1019,"context_line":"                                       original_port, updated_port):"},{"line_number":1020,"context_line":"        \"\"\"Update security groups on port."},{"line_number":1021,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dc47a892_51e8b219","line":1018,"in_reply_to":"f4b3001e_438335e1","updated":"2022-06-14 15:10:06.000000000","message":"Done","commit_id":"347f17a0d23f3aa0cd006e91d3d88bb3f4cad382"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"24386e09d48ae78b904fa9416fde56b905bf6a9a","unresolved":true,"context_lines":[{"line_number":1015,"context_line":"            return True"},{"line_number":1016,"context_line":"        return False"},{"line_number":1017,"context_line":""},{"line_number":1018,"context_line":"    def _update_security_group_on_port(self, context, id, port,"},{"line_number":1019,"context_line":"                                       original_port, updated_port):"},{"line_number":1020,"context_line":"        \"\"\"Update security groups on port."},{"line_number":1021,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f4b3001e_438335e1","line":1018,"in_reply_to":"ffc38331_73a094a6","updated":"2022-06-14 06:40:51.000000000","message":"Good question. This method is called only from inside this class. And this method is calling \"_process_port_create_security_group\" and this method is calling \"_create_port_security_group_binding\". All those methods are private now. Despite we don\u0027t have any rule, commandment or imposition, we **usually** decorate the public methods with the DB context and then we call private methods that handle BD objects expecting an active transaction.\n\nIn any case, I\u0027ll update this method description (and \"_process_port_create_security_group\") saying that this must be called inside an active writer transaction.","commit_id":"347f17a0d23f3aa0cd006e91d3d88bb3f4cad382"}]}