)]}'
{"neutron/agent/l3_agent.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e648a2ec1448ec3e7a5d849bb534ee6a47eac95a","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                routers \u003d self.plugin_rpc.get_routers("},{"line_number":815,"context_line":"                    self.context, router_ids)"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"                fetched \u003d set([r[\u0027id\u0027] for r in routers])"},{"line_number":818,"context_line":"                self.removed_routers.update(self.updated_routers - fetched)"},{"line_number":819,"context_line":"                self.updated_routers.clear()"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9he4%3D","line":817,"updated":"2014-04-03 22:49:56.000000000","message":"You should be able to avoid re-executing this list comprehension for each router in the routers list by placing this line right above line 777.","commit_id":"9da60d0a417dd70c16ae34f5877c564e425e4cf8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f7fd6d23cf9bbc8cff1a693cc2ae77ad33fa76f5","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                routers \u003d self.plugin_rpc.get_routers("},{"line_number":815,"context_line":"                    self.context, router_ids)"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"                fetched \u003d set([r[\u0027id\u0027] for r in routers])"},{"line_number":818,"context_line":"                self.removed_routers.update(self.updated_routers - fetched)"},{"line_number":819,"context_line":"                self.updated_routers.clear()"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9bn4%3D","line":817,"in_reply_to":"AAAAWH%2F9f%2Bs%3D","updated":"2014-04-04 15:10:03.000000000","message":"No worries. I\u0027ve had a few review fails myself recently.  It happens.","commit_id":"9da60d0a417dd70c16ae34f5877c564e425e4cf8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"382db80102ddfecb8e3c8814a8d6ecda8d5631a2","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                routers \u003d self.plugin_rpc.get_routers("},{"line_number":815,"context_line":"                    self.context, router_ids)"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"                fetched \u003d set([r[\u0027id\u0027] for r in routers])"},{"line_number":818,"context_line":"                self.removed_routers.update(self.updated_routers - fetched)"},{"line_number":819,"context_line":"                self.updated_routers.clear()"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9f%2Bs%3D","line":817,"in_reply_to":"AAAAWH%2F9gKY%3D","updated":"2014-04-04 04:41:50.000000000","message":"Doh. Review fail. Sorry about that Carl.","commit_id":"9da60d0a417dd70c16ae34f5877c564e425e4cf8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2ab6db9d20c60b96e28540dc941f65a61fd52280","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                routers \u003d self.plugin_rpc.get_routers("},{"line_number":815,"context_line":"                    self.context, router_ids)"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"                fetched \u003d set([r[\u0027id\u0027] for r in routers])"},{"line_number":818,"context_line":"                self.removed_routers.update(self.updated_routers - fetched)"},{"line_number":819,"context_line":"                self.updated_routers.clear()"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9gKY%3D","line":817,"in_reply_to":"AAAAWH%2F9he4%3D","updated":"2014-04-04 04:06:29.000000000","message":"Line 777 is in the _process_routers method which is called from this method on line 821.  So, this call is already outside of the for r in routers loop.","commit_id":"9da60d0a417dd70c16ae34f5877c564e425e4cf8"}]}