)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9b7b9b6f97da1efc495181a359a48f527002affa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0cf45c48_aef6437c","updated":"2022-07-18 11:53:22.000000000","message":"recheck","commit_id":"77d27e51b104797e29d10efa4a736c82d468833b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3ed7044beedafefff283733405686c9bcc2ea139","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c35e341d_0e220df1","updated":"2022-07-19 08:09:54.000000000","message":"Looks ok. Functional job fails due to https://bugs.launchpad.net/neutron/+bug/1981963","commit_id":"aa3bbddb018613a0affc1048641c906582c61784"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":29759,"name":"zhangmeng","email":"zhangmeng9502@gmail.com","username":"zhangmeng9502"},"change_message_id":"be54f65195df7a9623552778749512f7f051d355","unresolved":true,"context_lines":[{"line_number":1848,"context_line":"        # for being treated. If that does not happen, it is a potential"},{"line_number":1849,"context_line":"        # error condition of which operators should be aware"},{"line_number":1850,"context_line":"        port_needs_binding \u003d True"},{"line_number":1851,"context_line":"        if not vif_port.ofport or vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1852,"context_line":"            LOG.error(\"VIF port: %s has no ofport configured or is invalid, \""},{"line_number":1853,"context_line":"                      \"and might not be able to transmit. (ofport\u003d%s)\","},{"line_number":1854,"context_line":"                      vif_port.vif_id, vif_port.ofport)"}],"source_content_type":"text/x-python","patch_set":3,"id":"16d85c4c_5c526e2a","line":1851,"range":{"start_line":1851,"start_character":15,"end_line":1851,"end_character":30},"updated":"2022-07-20 08:16:12.000000000","message":"Ensure vif_port is not None before use its attribuie ofport, if vif_port is None will raise exception, will not logging at line 1872","commit_id":"689db7122ada23ffa1be2ac76598a611c5bcd9b3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bb053d8e1a4859df24b06ac1ecf98e4b9e3d5b65","unresolved":true,"context_lines":[{"line_number":1848,"context_line":"        # for being treated. If that does not happen, it is a potential"},{"line_number":1849,"context_line":"        # error condition of which operators should be aware"},{"line_number":1850,"context_line":"        port_needs_binding \u003d True"},{"line_number":1851,"context_line":"        if not vif_port.ofport or vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1852,"context_line":"            LOG.error(\"VIF port: %s has no ofport configured or is invalid, \""},{"line_number":1853,"context_line":"                      \"and might not be able to transmit. (ofport\u003d%s)\","},{"line_number":1854,"context_line":"                      vif_port.vif_id, vif_port.ofport)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a933d52c_cd0a2133","line":1851,"range":{"start_line":1851,"start_character":15,"end_line":1851,"end_character":30},"in_reply_to":"0f65b51a_ec6cd464","updated":"2022-07-21 06:04:04.000000000","message":"Ah yes, interesting point. let me provide a patch to fix that. Thank you.","commit_id":"689db7122ada23ffa1be2ac76598a611c5bcd9b3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"dba1fbcac5b652f50ed9af39e6c8931712babdf0","unresolved":true,"context_lines":[{"line_number":1848,"context_line":"        # for being treated. If that does not happen, it is a potential"},{"line_number":1849,"context_line":"        # error condition of which operators should be aware"},{"line_number":1850,"context_line":"        port_needs_binding \u003d True"},{"line_number":1851,"context_line":"        if not vif_port.ofport or vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1852,"context_line":"            LOG.error(\"VIF port: %s has no ofport configured or is invalid, \""},{"line_number":1853,"context_line":"                      \"and might not be able to transmit. (ofport\u003d%s)\","},{"line_number":1854,"context_line":"                      vif_port.vif_id, vif_port.ofport)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df2ca707_581e304b","line":1851,"range":{"start_line":1851,"start_character":15,"end_line":1851,"end_character":30},"in_reply_to":"16d85c4c_5c526e2a","updated":"2022-07-20 11:06:15.000000000","message":"Hey! thanks for thid check. There are no reasons to have vif_port None at that point but reason to have ofport as an empty dict of -1.","commit_id":"689db7122ada23ffa1be2ac76598a611c5bcd9b3"},{"author":{"_account_id":29759,"name":"zhangmeng","email":"zhangmeng9502@gmail.com","username":"zhangmeng9502"},"change_message_id":"2cc158f7bb973e881c7d862832a92a3f418a01e1","unresolved":true,"context_lines":[{"line_number":1848,"context_line":"        # for being treated. If that does not happen, it is a potential"},{"line_number":1849,"context_line":"        # error condition of which operators should be aware"},{"line_number":1850,"context_line":"        port_needs_binding \u003d True"},{"line_number":1851,"context_line":"        if not vif_port.ofport or vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1852,"context_line":"            LOG.error(\"VIF port: %s has no ofport configured or is invalid, \""},{"line_number":1853,"context_line":"                      \"and might not be able to transmit. (ofport\u003d%s)\","},{"line_number":1854,"context_line":"                      vif_port.vif_id, vif_port.ofport)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0f65b51a_ec6cd464","line":1851,"range":{"start_line":1851,"start_character":15,"end_line":1851,"end_character":30},"in_reply_to":"5a3b3dce_f79841ce","updated":"2022-07-20 14:34:50.000000000","message":"As you said, there are no reasons to have vif_port None or empty,  so line 1871-1872 won\u0027t run forerver?\n\nI think it should be:\n\n```\nif vif_port:\n    if not vif_port.ofport or vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT:\n        LOG.error(\"VIF port: %s has no ofport configured or is invalid, \"\n                  \"and might not be able to transmit. (ofport\u003d%s)\",\n                  vif_port.vif_id, vif_port.ofport)\n    do other things\nelse:\n     LOG.debug(\"No VIF port for port %s defined on agent.\", port_id)\n```\n\notherwise，line 1871-1872 loses its usefulness。","commit_id":"689db7122ada23ffa1be2ac76598a611c5bcd9b3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8cc38395ccbfa7c990b8fed98a99283a85bc6124","unresolved":false,"context_lines":[{"line_number":1848,"context_line":"        # for being treated. If that does not happen, it is a potential"},{"line_number":1849,"context_line":"        # error condition of which operators should be aware"},{"line_number":1850,"context_line":"        port_needs_binding \u003d True"},{"line_number":1851,"context_line":"        if not vif_port.ofport or vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1852,"context_line":"            LOG.error(\"VIF port: %s has no ofport configured or is invalid, \""},{"line_number":1853,"context_line":"                      \"and might not be able to transmit. (ofport\u003d%s)\","},{"line_number":1854,"context_line":"                      vif_port.vif_id, vif_port.ofport)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d57ac295_da981e5b","line":1851,"range":{"start_line":1851,"start_character":15,"end_line":1851,"end_character":30},"in_reply_to":"a933d52c_cd0a2133","updated":"2022-07-21 06:25:16.000000000","message":"Fixed here: https://review.opendev.org/c/openstack/neutron/+/850609/1\n\nBTW I\u0027m struggling fixing job failing with regards of this patch https://review.opendev.org/c/openstack/neutron/+/839479/21, if you could have a look I would appreciate your help.","commit_id":"689db7122ada23ffa1be2ac76598a611c5bcd9b3"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c4fa680497ace89edf48a671d90317cfaf3f7070","unresolved":false,"context_lines":[{"line_number":1848,"context_line":"        # for being treated. If that does not happen, it is a potential"},{"line_number":1849,"context_line":"        # error condition of which operators should be aware"},{"line_number":1850,"context_line":"        port_needs_binding \u003d True"},{"line_number":1851,"context_line":"        if not vif_port.ofport or vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1852,"context_line":"            LOG.error(\"VIF port: %s has no ofport configured or is invalid, \""},{"line_number":1853,"context_line":"                      \"and might not be able to transmit. (ofport\u003d%s)\","},{"line_number":1854,"context_line":"                      vif_port.vif_id, vif_port.ofport)"}],"source_content_type":"text/x-python","patch_set":3,"id":"740a3f06_ee4b4e36","line":1851,"range":{"start_line":1851,"start_character":15,"end_line":1851,"end_character":30},"in_reply_to":"d57ac295_da981e5b","updated":"2022-07-21 06:54:34.000000000","message":"Could be fixed in scope of this patch IMO","commit_id":"689db7122ada23ffa1be2ac76598a611c5bcd9b3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"62579b575c6449956c76f814cb7e417941f4cb14","unresolved":true,"context_lines":[{"line_number":1848,"context_line":"        # for being treated. If that does not happen, it is a potential"},{"line_number":1849,"context_line":"        # error condition of which operators should be aware"},{"line_number":1850,"context_line":"        port_needs_binding \u003d True"},{"line_number":1851,"context_line":"        if not vif_port.ofport or vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1852,"context_line":"            LOG.error(\"VIF port: %s has no ofport configured or is invalid, \""},{"line_number":1853,"context_line":"                      \"and might not be able to transmit. (ofport\u003d%s)\","},{"line_number":1854,"context_line":"                      vif_port.vif_id, vif_port.ofport)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3b3dce_f79841ce","line":1851,"range":{"start_line":1851,"start_character":15,"end_line":1851,"end_character":30},"in_reply_to":"df2ca707_581e304b","updated":"2022-07-20 11:07:10.000000000","message":"s/empty dict/empty list","commit_id":"689db7122ada23ffa1be2ac76598a611c5bcd9b3"}]}