)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"932d3911fbc33e34330283ec1f1af93a95789815","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8da914be_0ec9f364","updated":"2022-07-22 08:08:06.000000000","message":"This patch answers the comment on the previous patch (https://review.opendev.org/c/openstack/neutron/+/850147/3/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#1851 )","commit_id":"0b961a826638785aa02408ab2c1f3f6b061af621"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5ba39f8054d1a494e9fd240669e37c2bb59a968c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7822bfc9_836bdcf1","updated":"2022-07-21 15:23:06.000000000","message":"recheck","commit_id":"0b961a826638785aa02408ab2c1f3f6b061af621"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"711195ae2d0cc68256fbc2c23e7ee780ae54d9a6","unresolved":true,"context_lines":[{"line_number":1845,"context_line":"                       fixed_ips, device_owner, provisioning_needed):"},{"line_number":1846,"context_line":"        port_needs_binding \u003d True"},{"line_number":1847,"context_line":"        if vif_port:"},{"line_number":1848,"context_line":"            if not vif_port.ofport or \\"},{"line_number":1849,"context_line":"              vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1850,"context_line":"                # When this function is called for a port, the port should have"},{"line_number":1851,"context_line":"                # an OVS ofport configured, as only these ports were considered"},{"line_number":1852,"context_line":"                # for being treated. If that does not happen, it is a potential"}],"source_content_type":"text/x-python","patch_set":1,"id":"d261d31b_8b18e5ee","line":1849,"range":{"start_line":1848,"start_character":12,"end_line":1849,"end_character":56},"updated":"2022-07-21 06:56:19.000000000","message":"According to HACKING rules please:\n if (not vif_port.ofport or\n              vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT):","commit_id":"8e5cbc9fd0f45560dc1f8e4ebc15b3753f352b4c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"dca24de62f170c04617be84b08356304cf3b4713","unresolved":false,"context_lines":[{"line_number":1845,"context_line":"                       fixed_ips, device_owner, provisioning_needed):"},{"line_number":1846,"context_line":"        port_needs_binding \u003d True"},{"line_number":1847,"context_line":"        if vif_port:"},{"line_number":1848,"context_line":"            if not vif_port.ofport or \\"},{"line_number":1849,"context_line":"              vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1850,"context_line":"                # When this function is called for a port, the port should have"},{"line_number":1851,"context_line":"                # an OVS ofport configured, as only these ports were considered"},{"line_number":1852,"context_line":"                # for being treated. If that does not happen, it is a potential"}],"source_content_type":"text/x-python","patch_set":1,"id":"97e69da8_0ffe95ad","line":1849,"range":{"start_line":1848,"start_character":12,"end_line":1849,"end_character":56},"in_reply_to":"d261d31b_8b18e5ee","updated":"2022-07-21 10:34:35.000000000","message":"Done","commit_id":"8e5cbc9fd0f45560dc1f8e4ebc15b3753f352b4c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"df8eb925af42d8907b7b84c40d714804894fa8c1","unresolved":true,"context_lines":[{"line_number":1844,"context_line":"                       physical_network, segmentation_id, admin_state_up,"},{"line_number":1845,"context_line":"                       fixed_ips, device_owner, provisioning_needed):"},{"line_number":1846,"context_line":"        port_needs_binding \u003d True"},{"line_number":1847,"context_line":"        if vif_port:"},{"line_number":1848,"context_line":"            if (not vif_port.ofport or"},{"line_number":1849,"context_line":"                    vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT):"},{"line_number":1850,"context_line":"                # When this function is called for a port, the port should have"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c10cdcb_bd44721b","line":1847,"updated":"2022-07-25 08:37:27.000000000","message":"I don\u0027t understand how it can be None. It seems that treat_vif_port() is called only in L1993 but in the same loop in L1970 it is checked if \"port\" is not None. If it\u0027s None (or False) loop will be continued so treat_vif_port will never be called in such case.\nAm I missing something there?","commit_id":"0b961a826638785aa02408ab2c1f3f6b061af621"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6e8c51e61450a76842935ac98f93b9331b5987d5","unresolved":true,"context_lines":[{"line_number":1844,"context_line":"                       physical_network, segmentation_id, admin_state_up,"},{"line_number":1845,"context_line":"                       fixed_ips, device_owner, provisioning_needed):"},{"line_number":1846,"context_line":"        port_needs_binding \u003d True"},{"line_number":1847,"context_line":"        if vif_port:"},{"line_number":1848,"context_line":"            if (not vif_port.ofport or"},{"line_number":1849,"context_line":"                    vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT):"},{"line_number":1850,"context_line":"                # When this function is called for a port, the port should have"}],"source_content_type":"text/x-python","patch_set":2,"id":"a4bfebf6_4d527a64","line":1847,"in_reply_to":"1c10cdcb_bd44721b","updated":"2022-07-25 09:35:59.000000000","message":"Yes, I think it\u0027s a good point, we could in that case just remove that whole condition.","commit_id":"0b961a826638785aa02408ab2c1f3f6b061af621"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bedabb621f9a374c91f628302abfeaac97b341a0","unresolved":false,"context_lines":[{"line_number":1844,"context_line":"                       physical_network, segmentation_id, admin_state_up,"},{"line_number":1845,"context_line":"                       fixed_ips, device_owner, provisioning_needed):"},{"line_number":1846,"context_line":"        port_needs_binding \u003d True"},{"line_number":1847,"context_line":"        if vif_port:"},{"line_number":1848,"context_line":"            if (not vif_port.ofport or"},{"line_number":1849,"context_line":"                    vif_port.ofport \u003d\u003d ovs_lib.INVALID_OFPORT):"},{"line_number":1850,"context_line":"                # When this function is called for a port, the port should have"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f9497a8_127bae96","line":1847,"in_reply_to":"a4bfebf6_4d527a64","updated":"2022-09-05 12:29:11.000000000","message":"Done","commit_id":"0b961a826638785aa02408ab2c1f3f6b061af621"}]}