)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"2561e810b765810d2ea02a35990ff25e9aab9be8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"agent would not deploy an instance or kill existing instance."},{"line_number":12,"context_line":"The patch also fix haproxy still working after setting admin state"},{"line_number":13,"context_line":"up status to False by killing the existing haproxy process."},{"line_number":14,"context_line":"Close-Bug: #1302283"},{"line_number":15,"context_line":"Close-Bug: #1302333"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2883eb69b3262ac1fa3ffb46b52e0e27beb9d20d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F9fV0%3D","line":14,"updated":"2014-04-04 07:16:56.000000000","message":"Closes-Bug:","commit_id":"c9164c08268bd31716ee309c28b11389fa6411ac"}],"neutron/services/loadbalancer/drivers/haproxy/namespace_driver.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"30c2c174d9c5523f2c9b58088b3163fc290d9527","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                constants.ACTIVE_PENDING_STATUSES):"},{"line_number":281,"context_line":"            return False"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        #Add a special condition check when vip.session_persistence.type is"},{"line_number":284,"context_line":"        #HTTP_COOKIE and members list is empty"},{"line_number":285,"context_line":"        if (not logical_config[\u0027members\u0027] and"},{"line_number":286,"context_line":"            (logical_config[\u0027vip\u0027][\u0027session_persistence\u0027][\u0027type\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9bSI%3D","line":283,"updated":"2014-04-04 15:49:19.000000000","message":"nit: add a space after \u0027#\u0027","commit_id":"8d794b1943926de2fe9a10d968bfab77811c59e6"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"0c0fa99da2db7f486ccf20e7aa8f0f024ea2ee58","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                constants.ACTIVE_PENDING_STATUSES):"},{"line_number":281,"context_line":"            return False"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        #Add a special condition check when vip.session_persistence.type is"},{"line_number":284,"context_line":"        #HTTP_COOKIE and members list is empty"},{"line_number":285,"context_line":"        if (not logical_config[\u0027members\u0027] and"},{"line_number":286,"context_line":"            (logical_config[\u0027vip\u0027][\u0027session_persistence\u0027][\u0027type\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F%2F5s%3D","line":283,"in_reply_to":"AAAAWH%2F9UrI%3D","updated":"2014-04-08 01:01:59.000000000","message":"Done","commit_id":"8d794b1943926de2fe9a10d968bfab77811c59e6"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"188d5a2a9d7c8af3b89817f9882112e85257170d","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                constants.ACTIVE_PENDING_STATUSES):"},{"line_number":281,"context_line":"            return False"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        #Add a special condition check when vip.session_persistence.type is"},{"line_number":284,"context_line":"        #HTTP_COOKIE and members list is empty"},{"line_number":285,"context_line":"        if (not logical_config[\u0027members\u0027] and"},{"line_number":286,"context_line":"            (logical_config[\u0027vip\u0027][\u0027session_persistence\u0027][\u0027type\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9UrI%3D","line":283,"in_reply_to":"AAAAWH%2F9bSI%3D","updated":"2014-04-07 04:05:09.000000000","message":"+1","commit_id":"8d794b1943926de2fe9a10d968bfab77811c59e6"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"0c0fa99da2db7f486ccf20e7aa8f0f024ea2ee58","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                constants.ACTIVE_PENDING_STATUSES):"},{"line_number":281,"context_line":"            return False"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        #Add a special condition check when vip.session_persistence.type is"},{"line_number":284,"context_line":"        #HTTP_COOKIE and members list is empty"},{"line_number":285,"context_line":"        if (not logical_config[\u0027members\u0027] and"},{"line_number":286,"context_line":"            (logical_config[\u0027vip\u0027][\u0027session_persistence\u0027][\u0027type\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F%2F5w%3D","line":283,"in_reply_to":"AAAAWH%2F9bSI%3D","updated":"2014-04-08 01:01:59.000000000","message":"Done","commit_id":"8d794b1943926de2fe9a10d968bfab77811c59e6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6b3463446f4cb78409f364f36ee47dbe7bf4b0b0","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            return False"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        # add a special condition check when vip.session_persistence.type is"},{"line_number":284,"context_line":"        # HTTP_COOKIE and members list is empty"},{"line_number":285,"context_line":"        if (not logical_config[\u0027members\u0027] and"},{"line_number":286,"context_line":"            (logical_config[\u0027vip\u0027][\u0027session_persistence\u0027][\u0027type\u0027] \u003d\u003d"},{"line_number":287,"context_line":"             \u0027HTTP_COOKIE\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F7tY%3D","line":284,"updated":"2014-04-09 12:03:08.000000000","message":"we need to be consistent in case there are no members in the loadbalancer config and do not depend on session persistence existence. IMO for this case the correct fix is to not add cookie persistence option to the backend if there are no members: https://github.com/openstack/neutron/blob/master/neutron/services/loadbalancer/drivers/haproxy/cfg.py#L203","commit_id":"a4e1b2c11db4dda8b517cf53b9a0c7c71cf45ae5"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"3d37838dab440a42e86bc24b22b854b5dc99f044","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            return False"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        # add a special condition check when vip.session_persistence.type is"},{"line_number":284,"context_line":"        # HTTP_COOKIE and members list is empty"},{"line_number":285,"context_line":"        if (not logical_config[\u0027members\u0027] and"},{"line_number":286,"context_line":"            (logical_config[\u0027vip\u0027][\u0027session_persistence\u0027][\u0027type\u0027] \u003d\u003d"},{"line_number":287,"context_line":"             \u0027HTTP_COOKIE\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F1dA%3D","line":284,"in_reply_to":"AAAAW3%2F%2F7tY%3D","updated":"2014-04-10 03:35:12.000000000","message":"Yeah, you are right. Thanks for your point and i would revise it.","commit_id":"a4e1b2c11db4dda8b517cf53b9a0c7c71cf45ae5"}]}