)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"25524e4a6b355bc97ebba1293a9f42f65c9eadaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa42dd4a_f031b169","updated":"2022-08-10 14:38:23.000000000","message":"It is also called from OVNL3RouterPlugin.disassociate_floatingips. This is why I recommend to keep it.","commit_id":"516a641ab42c86198757401dd691123074f68d10"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e845226b32e620b654d63083852ac08ea96e23b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bbf1a01a_94e56d45","updated":"2022-08-10 10:55:38.000000000","message":"Seen issue in https://zuul.opendev.org/t/openstack/build/eaf39616e30d41a79af41ec4dd8ebfb5/log/controller/logs/screen-q-svc.txt#105345\n\n@radolfo can you check if this is enough","commit_id":"516a641ab42c86198757401dd691123074f68d10"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"decc8727d297c1697fb4302f062dc3d0db547d81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e34f9b8c_6cabae06","in_reply_to":"aa42dd4a_f031b169","updated":"2022-08-18 12:31:49.000000000","message":"Thanks @Rodolfo got your point, i believe can remove retry decorator and handle ovnl3 case the same way as done for update_floatingip_status case https://review.opendev.org/c/openstack/neutron/+/848701/5/neutron/services/ovn_l3/plugin.py, can you please confirm or you think there is some other way to handle it?","commit_id":"516a641ab42c86198757401dd691123074f68d10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d0e7a5c238eaa1e9e771258dca2d5bd778ba2406","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f97079d2_d731d305","in_reply_to":"e34f9b8c_6cabae06","updated":"2022-08-22 12:58:58.000000000","message":"This is not the same case. The disassociate method has its own writer context inside, something the \"update_floatingip_status\" didn\u0027t. Only when this method is called outside a transaction, the decorator applies and the write context is created inside the retry process.","commit_id":"516a641ab42c86198757401dd691123074f68d10"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"49fdcf976d76c2db09a4c9c9d05ed2ff8ff96b42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eecd9d5c_591646da","in_reply_to":"f97079d2_d731d305","updated":"2022-08-25 07:31:13.000000000","message":"Ohkk updated by moving writer context and retry decorator to the methods from where it\u0027s called. Not sure if there is some other better way for doing same.","commit_id":"516a641ab42c86198757401dd691123074f68d10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4f387ff56715d6df87cbe5750d01cf404dc7600f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b554418f_b067d030","updated":"2022-08-25 07:42:02.000000000","message":"There is no need for this change.","commit_id":"ccf2b341df3f92c4a8605cb2939886cee0caa1a7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b789b9576ca4d573e7bc31a7e25f394784417f2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe3acdad_1c864b37","in_reply_to":"210120cc_a61a0134","updated":"2022-09-12 06:33:14.000000000","message":"@rodolfo i see it\u0027s called https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L1698-L1707 and that part exists since xena https://github.com/openstack/neutron/commit/fd8b88ef542197f85e42cfe721d3d5217905acc8","commit_id":"ccf2b341df3f92c4a8605cb2939886cee0caa1a7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ffafb1210d17377e5854839d54c8a71b799565e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"210120cc_a61a0134","in_reply_to":"7232718f_e993187c","updated":"2022-08-26 07:42:32.000000000","message":"I don\u0027t know to what patch this log belongs. The code path does not exist in master. For example, \"if not l3_obj.FloatingIP.objects_exist(\" is not executed from inside the method \"disassociate_floatingips\".","commit_id":"ccf2b341df3f92c4a8605cb2939886cee0caa1a7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"fb4fd3ed69208e8759b0e7e07459d4dca64ac5ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7232718f_e993187c","in_reply_to":"b554418f_b067d030","updated":"2022-08-25 08:00:23.000000000","message":"ahh you mean all is good without this patch or need to fix in some other way?\nhad pushed this change after i saw https://paste.opendev.org/show/bSkoATDyPeRKLATUObFx/","commit_id":"ccf2b341df3f92c4a8605cb2939886cee0caa1a7"}]}