)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3264a4ffbc4547db50507ea28da2885e6109866e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow operator to disable usage of random-fully"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some specific use case, the cloud operator expects the source port"},{"line_number":10,"context_line":"of a packet to stay the same across all masquerading layer up to the"},{"line_number":11,"context_line":"destination host.   With the implementation of the random-fully code,"},{"line_number":12,"context_line":"this behavior was changed as source_port is always rewritten no matter"},{"line_number":13,"context_line":"which type of architecture / network CIDRs is being used in the backend."},{"line_number":14,"context_line":"This setting allows a user to fallback to the original behavior of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"90a1f850_195a84ae","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":16},"updated":"2022-08-23 05:56:49.000000000","message":"Please file a bug and describe this use case. I also think it should be an RFE [1]: new config options better be discussed by the neutron drivers team.\n\n[1] https://docs.openstack.org/neutron/latest/contributor/policies/blueprints.html#neutron-request-for-feature-enhancements","commit_id":"22900163b35112ceeb475e3e1a97c929dba3a6ec"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"97c8e88071d84fec34bb69798357486162220a0b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow operator to disable usage of random-fully"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some specific use case, the cloud operator expects the source port"},{"line_number":10,"context_line":"of a packet to stay the same across all masquerading layer up to the"},{"line_number":11,"context_line":"destination host.   With the implementation of the random-fully code,"},{"line_number":12,"context_line":"this behavior was changed as source_port is always rewritten no matter"},{"line_number":13,"context_line":"which type of architecture / network CIDRs is being used in the backend."},{"line_number":14,"context_line":"This setting allows a user to fallback to the original behavior of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fe72177c_6362217a","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":16},"in_reply_to":"6cfbb7fb_7940c7fd","updated":"2022-08-23 13:06:49.000000000","message":"I opened a bug and attached in to this patch.  I do think we should disable it by default to keep the same behavior as before but that\u0027s just me.   I\u0027m fine with being able to change that behavior if it\u0027s problematic but maybe I should add more information in the configuration option to let people know what to expect .","commit_id":"22900163b35112ceeb475e3e1a97c929dba3a6ec"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"20103b8b961d33ad079403c730b641fc5c84a970","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow operator to disable usage of random-fully"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some specific use case, the cloud operator expects the source port"},{"line_number":10,"context_line":"of a packet to stay the same across all masquerading layer up to the"},{"line_number":11,"context_line":"destination host.   With the implementation of the random-fully code,"},{"line_number":12,"context_line":"this behavior was changed as source_port is always rewritten no matter"},{"line_number":13,"context_line":"which type of architecture / network CIDRs is being used in the backend."},{"line_number":14,"context_line":"This setting allows a user to fallback to the original behavior of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a4503f80_b25b0059","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":16},"in_reply_to":"90a1f850_195a84ae","updated":"2022-08-23 08:53:53.000000000","message":"+1","commit_id":"22900163b35112ceeb475e3e1a97c929dba3a6ec"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"5c879b8be807fc0c71a0c612168d737e40f02f89","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow operator to disable usage of random-fully"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some specific use case, the cloud operator expects the source port"},{"line_number":10,"context_line":"of a packet to stay the same across all masquerading layer up to the"},{"line_number":11,"context_line":"destination host.   With the implementation of the random-fully code,"},{"line_number":12,"context_line":"this behavior was changed as source_port is always rewritten no matter"},{"line_number":13,"context_line":"which type of architecture / network CIDRs is being used in the backend."},{"line_number":14,"context_line":"This setting allows a user to fallback to the original behavior of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6cfbb7fb_7940c7fd","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":16},"in_reply_to":"a4503f80_b25b0059","updated":"2022-08-23 12:50:07.000000000","message":"So far, I only know it\u0027s blocking a telco migration from queens to train due to this change in behavior but I\u0027ll try to get more information and create a bug because this is clearly a regression for some users when it\u0027s a solution to a bug from some other users.","commit_id":"22900163b35112ceeb475e3e1a97c929dba3a6ec"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3264a4ffbc4547db50507ea28da2885e6109866e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In some specific use case, the cloud operator expects the source port"},{"line_number":10,"context_line":"of a packet to stay the same across all masquerading layer up to the"},{"line_number":11,"context_line":"destination host.   With the implementation of the random-fully code,"},{"line_number":12,"context_line":"this behavior was changed as source_port is always rewritten no matter"},{"line_number":13,"context_line":"which type of architecture / network CIDRs is being used in the backend."},{"line_number":14,"context_line":"This setting allows a user to fallback to the original behavior of the"},{"line_number":15,"context_line":"masquerading process which is to keep the source_port consistent across"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e0b65db3_a5476cb6","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":26},"updated":"2022-08-23 05:56:49.000000000","message":"when/where it was changed?","commit_id":"22900163b35112ceeb475e3e1a97c929dba3a6ec"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"5c879b8be807fc0c71a0c612168d737e40f02f89","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In some specific use case, the cloud operator expects the source port"},{"line_number":10,"context_line":"of a packet to stay the same across all masquerading layer up to the"},{"line_number":11,"context_line":"destination host.   With the implementation of the random-fully code,"},{"line_number":12,"context_line":"this behavior was changed as source_port is always rewritten no matter"},{"line_number":13,"context_line":"which type of architecture / network CIDRs is being used in the backend."},{"line_number":14,"context_line":"This setting allows a user to fallback to the original behavior of the"},{"line_number":15,"context_line":"masquerading process which is to keep the source_port consistent across"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa8e7b0_1c1d64de","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":26},"in_reply_to":"2b71b553_c7c7b43c","updated":"2022-08-23 12:50:07.000000000","message":"Exact, it\u0027s still a behavior change.   I don\u0027t see any release notes saying this will happen ... nor that random-fully was implemented.   It\u0027s a behavior changed and should\u0027ve been documented somewhere.","commit_id":"22900163b35112ceeb475e3e1a97c929dba3a6ec"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"97c8e88071d84fec34bb69798357486162220a0b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In some specific use case, the cloud operator expects the source port"},{"line_number":10,"context_line":"of a packet to stay the same across all masquerading layer up to the"},{"line_number":11,"context_line":"destination host.   With the implementation of the random-fully code,"},{"line_number":12,"context_line":"this behavior was changed as source_port is always rewritten no matter"},{"line_number":13,"context_line":"which type of architecture / network CIDRs is being used in the backend."},{"line_number":14,"context_line":"This setting allows a user to fallback to the original behavior of the"},{"line_number":15,"context_line":"masquerading process which is to keep the source_port consistent across"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a6f0d8d5_d2e42e56","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":26},"in_reply_to":"3fa8e7b0_1c1d64de","updated":"2022-08-23 13:06:49.000000000","message":"Ack","commit_id":"22900163b35112ceeb475e3e1a97c929dba3a6ec"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"20103b8b961d33ad079403c730b641fc5c84a970","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In some specific use case, the cloud operator expects the source port"},{"line_number":10,"context_line":"of a packet to stay the same across all masquerading layer up to the"},{"line_number":11,"context_line":"destination host.   With the implementation of the random-fully code,"},{"line_number":12,"context_line":"this behavior was changed as source_port is always rewritten no matter"},{"line_number":13,"context_line":"which type of architecture / network CIDRs is being used in the backend."},{"line_number":14,"context_line":"This setting allows a user to fallback to the original behavior of the"},{"line_number":15,"context_line":"masquerading process which is to keep the source_port consistent across"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"2b71b553_c7c7b43c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":26},"in_reply_to":"e0b65db3_a5476cb6","updated":"2022-08-23 08:53:53.000000000","message":"This was the patch that intorduced random-fully:\nhttps://review.opendev.org/c/openstack/neutron/+/636473 and the bug: https://bugs.launchpad.net/neutron/+bug/1814002\n\nrandom-fully is available from iptables 1.6.0 (see: https://opendev.org/openstack/neutron/src/branch/master/neutron/common/_constants.py#L66 ) so perhaps this sentence more refers to the change in iptables?","commit_id":"22900163b35112ceeb475e3e1a97c929dba3a6ec"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"988721370a9e2462bba8f01ce3035f8b20c85e5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d90e21df_ca5a7eec","updated":"2022-08-23 13:16:30.000000000","message":"Please, add a release note (1) describing this change and (2) saying that you are adding a new config knob.","commit_id":"948b241f0cacce1460848748c1fef83b91b169ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7de5a4380ce96422117d21da568110e18886f712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b941da15_09501187","updated":"2022-08-25 14:54:13.000000000","message":"Thanks for the efforts, let\u0027s wait for the CI results and perhaps slaweq\u0027s vote","commit_id":"23df1a334914279cc1a4dee71d00fae941a20913"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"e644743aa6f2534a1aa42b48467897b96845ce89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8b7e40dd_c4983278","updated":"2022-08-26 02:55:36.000000000","message":"recheck","commit_id":"bbefe5285e7ab799422fab81488f57c9c22769b6"}],"neutron/agent/linux/iptables_manager.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"988721370a9e2462bba8f01ce3035f8b20c85e5c","unresolved":true,"context_lines":[{"line_number":493,"context_line":"    @property"},{"line_number":494,"context_line":"    def random_fully(self):"},{"line_number":495,"context_line":"        if self._random_fully is not None:"},{"line_number":496,"context_line":"            return self._random_fully and \\"},{"line_number":497,"context_line":"                   not cfg.CONF.AGENT.disable_random_fully"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        version \u003d self._get_version()"},{"line_number":500,"context_line":"        self.__class__._random_fully \u003d utils.is_version_greater_equal("}],"source_content_type":"text/x-python","patch_set":6,"id":"84d85a5a_72d38875","line":497,"range":{"start_line":496,"start_character":12,"end_line":497,"end_character":58},"updated":"2022-08-23 13:16:30.000000000","message":"This is not the right approach. We have the property \"random_fully\" to in the first iteration, set a value. What you should do is to set it in L500-L503\n\n  if self._random_fully is not None:\n      return self._random_fully\n\n  version \u003d self._get_version()\n  _random_fully \u003d utils.is_version_greater_equal(\n      version, n_const.IPTABLES_RANDOM_FULLY_VERSION)\n  self._random_fully \u003d _random_fully and not cfg.CONF.AGENT.disable_random_fully\n  return self_random_fully","commit_id":"948b241f0cacce1460848748c1fef83b91b169ef"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"3f3a47241d9751c3cc9105c6073116d659ba732e","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    @property"},{"line_number":494,"context_line":"    def random_fully(self):"},{"line_number":495,"context_line":"        if self._random_fully is not None:"},{"line_number":496,"context_line":"            return self._random_fully and \\"},{"line_number":497,"context_line":"                   not cfg.CONF.AGENT.disable_random_fully"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        version \u003d self._get_version()"},{"line_number":500,"context_line":"        self.__class__._random_fully \u003d utils.is_version_greater_equal("}],"source_content_type":"text/x-python","patch_set":6,"id":"dee01b1e_ae2db977","line":497,"range":{"start_line":496,"start_character":12,"end_line":497,"end_character":58},"in_reply_to":"73937190_51535d78","updated":"2022-08-25 12:43:25.000000000","message":"Ack","commit_id":"948b241f0cacce1460848748c1fef83b91b169ef"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f5c4dbd0faa9fa8a15c0304d0d5d461a668a241b","unresolved":true,"context_lines":[{"line_number":493,"context_line":"    @property"},{"line_number":494,"context_line":"    def random_fully(self):"},{"line_number":495,"context_line":"        if self._random_fully is not None:"},{"line_number":496,"context_line":"            return self._random_fully and \\"},{"line_number":497,"context_line":"                   not cfg.CONF.AGENT.disable_random_fully"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        version \u003d self._get_version()"},{"line_number":500,"context_line":"        self.__class__._random_fully \u003d utils.is_version_greater_equal("}],"source_content_type":"text/x-python","patch_set":6,"id":"73937190_51535d78","line":497,"range":{"start_line":496,"start_character":12,"end_line":497,"end_character":58},"in_reply_to":"84d85a5a_72d38875","updated":"2022-08-24 14:56:42.000000000","message":"+1 for Rodolfo\u0027s comment","commit_id":"948b241f0cacce1460848748c1fef83b91b169ef"}],"neutron/conf/agent/common.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f5c4dbd0faa9fa8a15c0304d0d5d461a668a241b","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"SNAT_OPTS \u003d ["},{"line_number":51,"context_line":"    cfg.BoolOpt(\u0027disable_random_fully\u0027,"},{"line_number":52,"context_line":"                default\u003dFalse,"},{"line_number":53,"context_line":"                help\u003d_(\"Disable random-fully in SNAT masquerade rules.\")),"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"8744cf85_021cff4c","line":52,"updated":"2022-08-24 14:56:42.000000000","message":"maybe it\u0027s just me but it seems like \"too complicated\" for me. Maybe simply config option should be named \"random_fully\" or \"use_random_fully\" and then default to True. IMHO it would be more natural.","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"3f3a47241d9751c3cc9105c6073116d659ba732e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"SNAT_OPTS \u003d ["},{"line_number":51,"context_line":"    cfg.BoolOpt(\u0027disable_random_fully\u0027,"},{"line_number":52,"context_line":"                default\u003dFalse,"},{"line_number":53,"context_line":"                help\u003d_(\"Disable random-fully in SNAT masquerade rules.\")),"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"d9911055_d497ab6b","line":52,"in_reply_to":"8744cf85_021cff4c","updated":"2022-08-25 12:43:25.000000000","message":"Ack","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f5c4dbd0faa9fa8a15c0304d0d5d461a668a241b","unresolved":true,"context_lines":[{"line_number":140,"context_line":"                       \"ensure the format being generated matches the format \""},{"line_number":141,"context_line":"                       \"of iptables-save. This option should not be turned \""},{"line_number":142,"context_line":"                       \"on for production systems because it imposes a \""},{"line_number":143,"context_line":"                       \"performance penalty.\")),"},{"line_number":144,"context_line":"]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"PROCESS_MONITOR_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"c26c21b7_91abfa08","line":143,"updated":"2022-08-24 14:56:42.000000000","message":"why You didn\u0027t add this new option here?","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"3f3a47241d9751c3cc9105c6073116d659ba732e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                       \"ensure the format being generated matches the format \""},{"line_number":141,"context_line":"                       \"of iptables-save. This option should not be turned \""},{"line_number":142,"context_line":"                       \"on for production systems because it imposes a \""},{"line_number":143,"context_line":"                       \"performance penalty.\")),"},{"line_number":144,"context_line":"]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"PROCESS_MONITOR_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"8400f081_5bb599e8","line":143,"in_reply_to":"44cfd7bb_c3b84baa","updated":"2022-08-25 12:43:25.000000000","message":"Ah yeah well... I didn\u0027t see it but it makes sense to move it there as well.","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"54ceb1d15fc725e23f90f7ddd2098b6d73984b89","unresolved":true,"context_lines":[{"line_number":140,"context_line":"                       \"ensure the format being generated matches the format \""},{"line_number":141,"context_line":"                       \"of iptables-save. This option should not be turned \""},{"line_number":142,"context_line":"                       \"on for production systems because it imposes a \""},{"line_number":143,"context_line":"                       \"performance penalty.\")),"},{"line_number":144,"context_line":"]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"PROCESS_MONITOR_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"44cfd7bb_c3b84baa","line":143,"in_reply_to":"c26c21b7_91abfa08","updated":"2022-08-25 12:15:36.000000000","message":"good catch, +1","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"}],"releasenotes/notes/disable_random_fully-527b20bc524c308a.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8e09792b497f54d181b0d9dfcbf6495677443a92","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    repeating in any of their networks and this setting have the effect of"},{"line_number":8,"context_line":"    randomizing the source_port for the masquerading which avoid a race"},{"line_number":9,"context_line":"    condition when generating the tuple of for that connection and allows"},{"line_number":10,"context_line":"    every connection to never be dropped due to this workaround."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    [1] https://bugs.launchpad.net/neutron/+bug/1814002"},{"line_number":13,"context_line":"features:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b3ccb32f_1993528e","line":10,"updated":"2022-08-24 15:00:02.000000000","message":"Prelude section isn\u0027t needed really.","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"3f3a47241d9751c3cc9105c6073116d659ba732e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    repeating in any of their networks and this setting have the effect of"},{"line_number":8,"context_line":"    randomizing the source_port for the masquerading which avoid a race"},{"line_number":9,"context_line":"    condition when generating the tuple of for that connection and allows"},{"line_number":10,"context_line":"    every connection to never be dropped due to this workaround."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    [1] https://bugs.launchpad.net/neutron/+bug/1814002"},{"line_number":13,"context_line":"features:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f9ad70e4_0ea4210d","line":10,"in_reply_to":"b3ccb32f_1993528e","updated":"2022-08-25 12:43:25.000000000","message":"Ack","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8e09792b497f54d181b0d9dfcbf6495677443a92","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    [1] https://bugs.launchpad.net/neutron/+bug/1814002"},{"line_number":13,"context_line":"features:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Add disable_random_fully setting to allow an operator to disable "},{"line_number":16,"context_line":"    the iptables random-fully property on an iptable rules."},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e6cb422f_83872d06","line":15,"updated":"2022-08-24 15:00:02.000000000","message":"please remove trailing space","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8e09792b497f54d181b0d9dfcbf6495677443a92","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    [1] https://bugs.launchpad.net/neutron/+bug/1814002"},{"line_number":13,"context_line":"features:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Add disable_random_fully setting to allow an operator to disable "},{"line_number":16,"context_line":"    the iptables random-fully property on an iptable rules."},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fec6bc8_722e6262","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":28},"updated":"2022-08-24 15:00:02.000000000","message":"this can be inside `` `` - it will render better in HTML file","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"3f3a47241d9751c3cc9105c6073116d659ba732e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    [1] https://bugs.launchpad.net/neutron/+bug/1814002"},{"line_number":13,"context_line":"features:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Add disable_random_fully setting to allow an operator to disable "},{"line_number":16,"context_line":"    the iptables random-fully property on an iptable rules."},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"cb2564e0_630e3b05","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":28},"in_reply_to":"9fec6bc8_722e6262","updated":"2022-08-25 12:43:25.000000000","message":"Ack","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"3f3a47241d9751c3cc9105c6073116d659ba732e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    [1] https://bugs.launchpad.net/neutron/+bug/1814002"},{"line_number":13,"context_line":"features:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Add disable_random_fully setting to allow an operator to disable "},{"line_number":16,"context_line":"    the iptables random-fully property on an iptable rules."},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b8a93d25_0125640c","line":15,"in_reply_to":"e6cb422f_83872d06","updated":"2022-08-25 12:43:25.000000000","message":"Ack","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8e09792b497f54d181b0d9dfcbf6495677443a92","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    the iptables random-fully property on an iptable rules."},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    If this setting is enabled, it will prevent random fully from being"},{"line_number":20,"context_line":"    used and if there\u0027re 2 guests in different networks using the same"},{"line_number":21,"context_line":"    source_ip and source_port and they try to reach the same dest_ip and"},{"line_number":22,"context_line":"    dest_port, packets might be dropped in the kernel do to the racy"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d5cbe897_38983d59","line":19,"updated":"2022-08-24 15:00:02.000000000","message":"Please keep in mind that notes from different sections are rendered in different places in HTML file and aren\u0027t connected together based on the source file. So writing something like \"this setting\" here will make it very unclear in the release notes page. Please see https://662cba25091b41168cd8-c6d0ba205acfdaf07abcc75d255ce0b7.ssl.cf5.rackcdn.com/854041/7/check/build-openstack-releasenotes/6c3cf1a/docs/unreleased.html for rendered version of that note","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"3f3a47241d9751c3cc9105c6073116d659ba732e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    the iptables random-fully property on an iptable rules."},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    If this setting is enabled, it will prevent random fully from being"},{"line_number":20,"context_line":"    used and if there\u0027re 2 guests in different networks using the same"},{"line_number":21,"context_line":"    source_ip and source_port and they try to reach the same dest_ip and"},{"line_number":22,"context_line":"    dest_port, packets might be dropped in the kernel do to the racy"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f1963803_ed7b7989","line":19,"in_reply_to":"d5cbe897_38983d59","updated":"2022-08-25 12:43:25.000000000","message":"Ack","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8e09792b497f54d181b0d9dfcbf6495677443a92","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    source_ip and source_port and they try to reach the same dest_ip and"},{"line_number":22,"context_line":"    dest_port, packets might be dropped in the kernel do to the racy"},{"line_number":23,"context_line":"    tuple generation .   Enabling this setting should only be done if"},{"line_number":24,"context_line":"    source_port is really important such as in network firewall ACLs "},{"line_number":25,"context_line":"    and that the source_ip are never repeating withing the platform."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ae394ed_a8a24817","line":24,"updated":"2022-08-24 15:00:02.000000000","message":"trailing space to remove","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"3f3a47241d9751c3cc9105c6073116d659ba732e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    source_ip and source_port and they try to reach the same dest_ip and"},{"line_number":22,"context_line":"    dest_port, packets might be dropped in the kernel do to the racy"},{"line_number":23,"context_line":"    tuple generation .   Enabling this setting should only be done if"},{"line_number":24,"context_line":"    source_port is really important such as in network firewall ACLs "},{"line_number":25,"context_line":"    and that the source_ip are never repeating withing the platform."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"43daeb20_02c576b4","line":24,"in_reply_to":"3ae394ed_a8a24817","updated":"2022-08-25 12:43:25.000000000","message":"Ack","commit_id":"f39df22210e4c3c30a8e13d1f68b364c99c5dd0f"}],"releasenotes/notes/use_random_fully-527b20bc524c308a.yaml":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7de5a4380ce96422117d21da568110e18886f712","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    the kernel do to the racy tuple generation .   Disabling this"},{"line_number":13,"context_line":"    setting should only be done if source_port is really important such"},{"line_number":14,"context_line":"    as in network firewall ACLs and that the source_ip are never repeating"},{"line_number":15,"context_line":"    withing the platform."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"89a75dcd_10a9a3f4","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":11},"updated":"2022-08-25 14:54:13.000000000","message":"nit: within?","commit_id":"23df1a334914279cc1a4dee71d00fae941a20913"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"d2c5a9be50573ee7e9388ffea053841ed86d0d22","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    the kernel do to the racy tuple generation .   Disabling this"},{"line_number":13,"context_line":"    setting should only be done if source_port is really important such"},{"line_number":14,"context_line":"    as in network firewall ACLs and that the source_ip are never repeating"},{"line_number":15,"context_line":"    withing the platform."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e209ac50_91cb35dd","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":11},"in_reply_to":"89a75dcd_10a9a3f4","updated":"2022-08-26 03:00:34.000000000","message":"Ack","commit_id":"23df1a334914279cc1a4dee71d00fae941a20913"}]}
