)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"55b9368f0f2d5d65ef7252bb18e2a5b5c8e40491","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Do not allow a tenant to create a default SG for another one"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The attempt to list security groups for a non-existent"},{"line_number":10,"context_line":"project can create a default SG for it. Only allow if"},{"line_number":11,"context_line":"privileges allow."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ieef7011f48cd2188d4254ff16d90a6465bbabfe3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8ae518c5_65554819","line":10,"updated":"2022-09-02 08:40:51.000000000","message":"Note that this works also for existing valid project_ids.","commit_id":"2d4b229105d757b98878bf3c92805518b53838be"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1ad5a185a3393be0b70f728dade30e33289808ac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Do not allow a tenant to create a default SG for another one"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The attempt to list security groups for a non-existent"},{"line_number":10,"context_line":"project can create a default SG for it. Only allow if"},{"line_number":11,"context_line":"privileges allow."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ieef7011f48cd2188d4254ff16d90a6465bbabfe3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a6426161_e398954f","line":10,"in_reply_to":"8ae518c5_65554819","updated":"2022-09-02 14:57:23.000000000","message":"True, it will work for any string at all including an existing project ID that doesn\u0027t have a default SG. Will tweak wording.","commit_id":"2d4b229105d757b98878bf3c92805518b53838be"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"55b9368f0f2d5d65ef7252bb18e2a5b5c8e40491","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73f3c98b_133e4edd","updated":"2022-09-02 08:40:51.000000000","message":"Adding a test scenario to this patch would seem useful. (I know that this is still WIP, just kind of countering the +2 ;).","commit_id":"2d4b229105d757b98878bf3c92805518b53838be"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1ad5a185a3393be0b70f728dade30e33289808ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c354970e_b041c6f1","updated":"2022-09-02 14:57:23.000000000","message":"I will update and add a unit test. Thanks for reviews.","commit_id":"2d4b229105d757b98878bf3c92805518b53838be"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"62a6007c5765d3ad01650e41cc6c4ad2fad30898","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c912cfab_474a89af","updated":"2022-09-02 01:20:10.000000000","message":"This is only a test to see if it doesn\u0027t break the API. It probably needs a tweak (and test) since it doesn\u0027t trigger an API failure code. Anyone can feel free to take over and make better.","commit_id":"2d4b229105d757b98878bf3c92805518b53838be"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d9b29890681d9d10a5e7f8ed1b26611bc788211e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4846626f_6b05b24a","in_reply_to":"73f3c98b_133e4edd","updated":"2022-09-02 15:00:06.000000000","message":"Done","commit_id":"2d4b229105d757b98878bf3c92805518b53838be"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"176abbdf0ba561a1877d4d28c25f3297b7a527ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9b26f2f_d54140af","updated":"2022-09-02 15:48:34.000000000","message":"Solves the issue in my local test, thx.","commit_id":"01fc2b9195f999df4d810df4ee63f77ecbc81f7e"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"64f25fc81a7e2f20a97721ff3e0960f492df3346","unresolved":true,"context_lines":[{"line_number":930,"context_line":"        \"\"\"Create a default security group if one doesn\u0027t exist."},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"        :returns: the default security group id for given tenant."},{"line_number":933,"context_line":"        \"\"\""},{"line_number":934,"context_line":"        if not extensions.is_extension_supported(self, \u0027security-group\u0027):"},{"line_number":935,"context_line":"            return"},{"line_number":936,"context_line":"        default_group_id \u003d self._get_default_sg_id(context, tenant_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"31b2c68c_c414f8a4","line":933,"updated":"2022-09-02 07:31:39.000000000","message":"The idea looks ok, but perhaps the logic fits more to _ensure_def_sec_group as we have all info from context here","commit_id":"2d4b229105d757b98878bf3c92805518b53838be"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1ad5a185a3393be0b70f728dade30e33289808ac","unresolved":false,"context_lines":[{"line_number":930,"context_line":"        \"\"\"Create a default security group if one doesn\u0027t exist."},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"        :returns: the default security group id for given tenant."},{"line_number":933,"context_line":"        \"\"\""},{"line_number":934,"context_line":"        if not extensions.is_extension_supported(self, \u0027security-group\u0027):"},{"line_number":935,"context_line":"            return"},{"line_number":936,"context_line":"        default_group_id \u003d self._get_default_sg_id(context, tenant_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"aa195b5e_35d0cffc","line":933,"in_reply_to":"31b2c68c_c414f8a4","updated":"2022-09-02 14:57:23.000000000","message":"Yes, seems reasonable, I was a little worried because of all the other call paths into here but will try.","commit_id":"2d4b229105d757b98878bf3c92805518b53838be"}]}