)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a2fff80721f0fbb09c83e38ab97f26c6cbd666b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"For DvrEdgeRouter, snat namespace should not be created in initialize."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For DvrEdgeRouter, snat-netns are not necessarily created and should not be"},{"line_number":10,"context_line":"created in initialize, but rather when the node is _is_this_snat_host."},{"line_number":11,"context_line":"When snat-netns is created at initialize, if the node is not the snat host for"},{"line_number":12,"context_line":"that router it will cause the port associated with fip to be removed when"},{"line_number":13,"context_line":"processing DvrEdgeRouter.external_gateway_added, resulting in fip being"},{"line_number":14,"context_line":"unavailable. And although this node is not the snat host, it has the VM of"},{"line_number":15,"context_line":"this node bound to fip and fip still needs to be implemented in this node."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"fixed: openstack dvr_snat node and compute node are the same node, the VM on"},{"line_number":18,"context_line":"this node is bound to fip, but the snat_port of the router of this VM is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3e1890_068c7a78","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":74},"updated":"2022-09-13 11:11:09.000000000","message":"I don\u0027t see this in the patch, I only see that _create_snat_namespace() was moved from DvrEdgeRouter to DvrEdgeHaRouter - can you please clarify why?","commit_id":"38f4afa73a938041b40af54bcc8c073dbb7a2779"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"838c893dd3db62383eac55d9dc6c10a4926ef3e8","unresolved":true,"context_lines":[{"line_number":14,"context_line":"unavailable. And although this node is not the snat host, it has the VM of"},{"line_number":15,"context_line":"this node bound to fip and fip still needs to be implemented in this node."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"fixed: openstack dvr_snat node and compute node are the same node, the VM on"},{"line_number":18,"context_line":"this node is bound to fip, but the snat_port of the router of this VM is"},{"line_number":19,"context_line":"located in another network node,VM can access north-south traffic via fip."},{"line_number":20,"context_line":"But if you restart the l3-agent,The external_gateway_removed is called during"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"21bf432b_6e507ee9","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":65},"updated":"2022-09-14 06:33:17.000000000","message":"After reading this message, IMO, this is another bug of running mixed dvr_snat and compute nodes. We have marked such configuration as not supported:\nhttps://review.opendev.org/c/openstack/neutron/+/801503\n\nBecause there are many other problems.\nhttps://bugs.launchpad.net/neutron/+bug/1934666\nhttps://bugs.launchpad.net/neutron/+bug/1945306","commit_id":"38f4afa73a938041b40af54bcc8c073dbb7a2779"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e55197253c283ce2bf9ba38e96940f3c9bcbcf17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f0e500a_8148018a","updated":"2022-09-06 09:14:12.000000000","message":"it seems like functional tests failure is related to that patch https://c82535b5ddc53821c6ca-c5bb35ae23b4f1517e6ef394b01c7761.ssl.cf5.rackcdn.com/855995/1/check/neutron-functional-with-uwsgi/c5500d5/testr_results.html\nPlease check it before rechecking.","commit_id":"d7002f39b5cae28506f4363a7afc9286e478962c"}],"neutron/tests/functional/agent/l3/test_dvr_router.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a2fff80721f0fbb09c83e38ab97f26c6cbd666b","unresolved":true,"context_lines":[{"line_number":2199,"context_line":"        net_helpers.assert_ping(src_machine.namespace, fip_same_scope)"},{"line_number":2200,"context_line":"        net_helpers.assert_ping(src_machine.namespace, fip_diff_scope)"},{"line_number":2201,"context_line":""},{"line_number":2202,"context_line":"    def test_direct_route_for_address_scope(self):"},{"line_number":2203,"context_line":"        self.agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"},{"line_number":2204,"context_line":"        (machine_same_scope, machine_diff_scope,"},{"line_number":2205,"context_line":"            router) \u003d self._setup_address_scope(\u0027scope1\u0027, \u0027scope2\u0027, \u0027scope1\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"22ddfea1_924a46ed","side":"PARENT","line":2202,"range":{"start_line":2202,"start_character":8,"end_line":2202,"end_character":43},"updated":"2022-09-13 11:11:09.000000000","message":"why is this test removed?","commit_id":"12b21e235e6f3b235f576bdc4986e0e4626277ea"}]}