)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ff05c8c7f63e50b68cf4751283035a6e9d24a894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"77af5b52_0b515b5e","updated":"2022-09-08 19:12:41.000000000","message":"Thanks","commit_id":"9db653a9743c8675b834dae40e3c6b27deefdb95"}],"neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"41ed7c420ce657fe992499a988c076d4ce6c370f","unresolved":true,"context_lines":[{"line_number":1735,"context_line":"                      self.l3_plugin._get_dvr_subnet_ids_on_host_query("},{"line_number":1736,"context_line":"                          self.context, host)]"},{"line_number":1737,"context_line":"        self.assertEqual(expected, set(subnet_ids))"},{"line_number":1738,"context_line":"        self.context.session.commit()"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"    def test__get_dvr_subnet_ids_on_host_query(self):"},{"line_number":1741,"context_line":"        with self.subnet(cidr\u003d\u002720.0.0.0/24\u0027) as subnet1,\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"faaa7db6_121b6169","line":1738,"range":{"start_line":1738,"start_character":8,"end_line":1738,"end_character":37},"updated":"2022-09-08 11:15:08.000000000","message":"what if: \n  with with db_api.CONTEXT_READER.using(self.context):\n    subnet_ids \u003d [item[0] for item in\n                  self.l3_plugin._get_dvr_subnet_ids_on_host_query(\n                    self.context, host)]\n    self.assertEqual(expected, set(subnet_ids))\n\nwill this work?","commit_id":"80bc925e77aa1e7706650d648bacfee453789e13"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9a10c9573fe1ecf4f1c9d43a05bb3e5c9d3c149a","unresolved":true,"context_lines":[{"line_number":1735,"context_line":"                      self.l3_plugin._get_dvr_subnet_ids_on_host_query("},{"line_number":1736,"context_line":"                          self.context, host)]"},{"line_number":1737,"context_line":"        self.assertEqual(expected, set(subnet_ids))"},{"line_number":1738,"context_line":"        self.context.session.commit()"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"    def test__get_dvr_subnet_ids_on_host_query(self):"},{"line_number":1741,"context_line":"        with self.subnet(cidr\u003d\u002720.0.0.0/24\u0027) as subnet1,\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"0388d2d1_1ac660fc","line":1738,"range":{"start_line":1738,"start_character":8,"end_line":1738,"end_character":37},"in_reply_to":"2545ab3f_4f6086b3","updated":"2022-09-08 16:14:10.000000000","message":"yes with this looks better, also need to fix some other tests as mentioned in https://review.opendev.org/c/openstack/neutron/+/856444","commit_id":"80bc925e77aa1e7706650d648bacfee453789e13"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"46419b565b53d4bedbc9636078fc128cf81f6e39","unresolved":true,"context_lines":[{"line_number":1735,"context_line":"                      self.l3_plugin._get_dvr_subnet_ids_on_host_query("},{"line_number":1736,"context_line":"                          self.context, host)]"},{"line_number":1737,"context_line":"        self.assertEqual(expected, set(subnet_ids))"},{"line_number":1738,"context_line":"        self.context.session.commit()"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"    def test__get_dvr_subnet_ids_on_host_query(self):"},{"line_number":1741,"context_line":"        with self.subnet(cidr\u003d\u002720.0.0.0/24\u0027) as subnet1,\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"2545ab3f_4f6086b3","line":1738,"range":{"start_line":1738,"start_character":8,"end_line":1738,"end_character":37},"in_reply_to":"faaa7db6_121b6169","updated":"2022-09-08 11:15:54.000000000","message":"Sorry,\n  with with db_api.CONTEXT_READER.using(self.context):\n    subnet_ids \u003d [item[0] for item in\n                  self.l3_plugin._get_dvr_subnet_ids_on_host_query(\n                    self.context, host)]\n  self.assertEqual(expected, set(subnet_ids))","commit_id":"80bc925e77aa1e7706650d648bacfee453789e13"}]}
