)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"a629b347eada9061038babab18fc26fba7491d2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1654618d_e4246af6","updated":"2022-09-20 06:59:15.000000000","message":"LGTM","commit_id":"6d7f9e07658700470046acfa3e1217c63dca2585"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"d83cba8f7eeb10df6574def1515b835a9bc8aa23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"274cbdde_48dc1e3b","updated":"2023-12-18 15:39:23.000000000","message":"I\u0027m having trouble understanding how this would help for the type of Exception mentioned in the bug (a connection issue). If there is a problem connecting to the ovn database, then that will happen in python-ovs\u0027s `Idl.run()` code before we get parse notifications, which come in a `reply` message for the initial dump on connection. Without a connection, we can\u0027t get a reply.\n\nAdditionally, _Server.Database generally only has a row for each DB on the connection (so I think _Server and either OVN_Northbound/OVN_Southbound). So at most there would be two rows that were processed and notifications sent. So it seems weird that we\u0027d save much time exiting early, and even stranger would be if we were actually getting some kind of exception during processing of those rows.\n\nWe\u0027ve had issues in the past where sql database disconnection cause issues when hitting the hash node code, but I think we\u0027ve at least mitigated those. Exiting early during DB schema processing might give us a few more milliseconds of waiting before trying to write to the SQL db and avoid some exceptions there?\n\nI don\u0027t think this patch will hurt anything, as the only thing we do with _Server.Database events is handle schema changes, and the patch handles that before exiting early in `notify()` (BTW the schema change we are handling happened in v20.09, so is \u003e3 years old and likely not an issue any more). I just don\u0027t understand by what mechanism it would help in the case mentioned by the launchpad bug.","commit_id":"edc1025a83913fcc4929f036f645826b942bdff7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"06094ffea34f22828b1b91c78fa105bf7d487905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7ac8dc28_156bd046","updated":"2023-12-01 18:25:02.000000000","message":"Since the fix mentions an ovsdbapp bug I\u0027m adding Terry to reviewers","commit_id":"edc1025a83913fcc4929f036f645826b942bdff7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"964b22e9cc714f6ae85b399e494d21479cbd4bab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2e66c9b3_ba233bbe","updated":"2023-04-14 10:31:28.000000000","message":"recheck neutron-ovn-tempest-ovs-release-ubuntu-old","commit_id":"edc1025a83913fcc4929f036f645826b942bdff7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f6a93433759652381dd4bc378ec6a65c65fc744f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a2cc921e_802c8ad8","updated":"2023-04-14 16:25:09.000000000","message":"recheck rally","commit_id":"edc1025a83913fcc4929f036f645826b942bdff7"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"096e055baeac5f9b567660ad1fc9eb2cd785e948","unresolved":true,"context_lines":[{"line_number":717,"context_line":"        # Finish processing the database table as soon as possible"},{"line_number":718,"context_line":"        # see more: https://bugs.launchpad.net/ovsdbapp/+bug/1988039"},{"line_number":719,"context_line":"        if row._table.name \u003d\u003d \u0027Database\u0027:"},{"line_number":720,"context_line":"            return"},{"line_number":721,"context_line":"        self.notify_handler.notify(event, row, updates, global_\u003dTrue)"},{"line_number":722,"context_line":"        try:"},{"line_number":723,"context_line":"            target_node \u003d self._hash_ring.get_node(str(row.uuid))"}],"source_content_type":"text/x-python","patch_set":3,"id":"c0a61fb1_7108ba28","line":720,"updated":"2022-09-13 14:56:00.000000000","message":"maybe simple UT to cover that case could be added?","commit_id":"2a5c186139bcd7030d6c83bc26a010d4e621cfe0"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"9880d5f295a1556f3dfb3f141a1791c8f9bc4647","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        # Finish processing the database table as soon as possible"},{"line_number":718,"context_line":"        # see more: https://bugs.launchpad.net/ovsdbapp/+bug/1988039"},{"line_number":719,"context_line":"        if row._table.name \u003d\u003d \u0027Database\u0027:"},{"line_number":720,"context_line":"            return"},{"line_number":721,"context_line":"        self.notify_handler.notify(event, row, updates, global_\u003dTrue)"},{"line_number":722,"context_line":"        try:"},{"line_number":723,"context_line":"            target_node \u003d self._hash_ring.get_node(str(row.uuid))"}],"source_content_type":"text/x-python","patch_set":3,"id":"88230ef3_8eb11dc6","line":720,"in_reply_to":"c0a61fb1_7108ba28","updated":"2022-09-15 00:46:13.000000000","message":"hi slawek, Added a unit test.","commit_id":"2a5c186139bcd7030d6c83bc26a010d4e621cfe0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9ca35916cec5b1a285fb1d53a8ee66d252a2e10a","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    def notify(self, event, row, updates\u003dNone):"},{"line_number":724,"context_line":"        try:"},{"line_number":725,"context_line":"            self.handle_db_schema_changes(event, row)"},{"line_number":726,"context_line":"            # Finish processing the database table as soon as possible."},{"line_number":727,"context_line":"            # More info in https://bugs.launchpad.net/ovsdbapp/+bug/1988039."},{"line_number":728,"context_line":"            if row._table.name \u003d\u003d \u0027Database\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"c4c25d33_c01da72a","line":725,"updated":"2024-01-02 21:03:24.000000000","message":"Note that I proposed removal of this method: https://review.opendev.org/c/openstack/neutron/+/904238/2/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py#713\n\nWithout it we don\u0027t even need to monitor the Database table unless it\u0027s used elsewhere but I can\u0027t find where.","commit_id":"edc1025a83913fcc4929f036f645826b942bdff7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"72a12c34179d48e7937469303e1ee8392cba9531","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    def notify(self, event, row, updates\u003dNone):"},{"line_number":724,"context_line":"        try:"},{"line_number":725,"context_line":"            self.handle_db_schema_changes(event, row)"},{"line_number":726,"context_line":"            # Finish processing the database table as soon as possible."},{"line_number":727,"context_line":"            # More info in https://bugs.launchpad.net/ovsdbapp/+bug/1988039."},{"line_number":728,"context_line":"            if row._table.name \u003d\u003d \u0027Database\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"50ee0c43_9a3b7354","line":725,"in_reply_to":"c4c25d33_c01da72a","updated":"2024-01-10 17:38:09.000000000","message":"So since that other change merged can this one be abandoned?","commit_id":"edc1025a83913fcc4929f036f645826b942bdff7"}]}