)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0f39d9aa2273646448cee4474a77b1d946f83575","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f653e299_d465046f","updated":"2022-09-22 14:58:57.000000000","message":"Q: do we need a similar change in the OVN placement code? neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/placement.py","commit_id":"48a9bf551bd902a46c89d92e69f00d606a9ec0ac"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bc7eb7f7abf11cf7ef4ef7bd8897668c1486c792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a0d1670_48480bc6","in_reply_to":"f653e299_d465046f","updated":"2022-09-28 16:10:05.000000000","message":"Right! Good catch.","commit_id":"48a9bf551bd902a46c89d92e69f00d606a9ec0ac"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"11535810af9e5c1718bf032cb55129b72bd2721c","unresolved":true,"context_lines":[{"line_number":1203,"context_line":"            return False"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"        br_map \u003d agent.get(\u0027configurations\u0027, {}).get(\u0027bridge-mappings\u0027, \u0027\u0027)"},{"line_number":1206,"context_line":"        mapping_dict \u003d helpers.parse_mappings(br_map.split(\u0027,\u0027))"},{"line_number":1207,"context_line":"        return segment[\u0027physical_network\u0027] in mapping_dict"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"    def patch_plugin_merge(self, method_name, new_fn, op\u003doperator.add):"}],"source_content_type":"text/x-python","patch_set":3,"id":"6f0edd58_8ddad566","line":1206,"updated":"2022-10-17 16:19:36.000000000","message":"Do you think we need to add a few lines to test_check_segment_for_agent()? Something like:\n\n+        agent[\u0027configurations\u0027] \u003d {\u0027bridge-mappings\u0027:\n+                                   \u0027physnet1:br-ex1,physnet1:br-ex2\u0027}\n+        self.assertRaises(ValueError,\n+                          self.mech_driver.check_segment_for_agent,\n+                          segment, agent)\n+\n\nI know parse_mappings is already tested for this duplicate case so might be overkill.","commit_id":"39b2a03db73c26ecf7e26962a7b47d2ca1bb5ad4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2ab0e08bc32f8c2d3096e74c095068f9d504c5e8","unresolved":false,"context_lines":[{"line_number":1203,"context_line":"            return False"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"        br_map \u003d agent.get(\u0027configurations\u0027, {}).get(\u0027bridge-mappings\u0027, \u0027\u0027)"},{"line_number":1206,"context_line":"        mapping_dict \u003d helpers.parse_mappings(br_map.split(\u0027,\u0027))"},{"line_number":1207,"context_line":"        return segment[\u0027physical_network\u0027] in mapping_dict"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"    def patch_plugin_merge(self, method_name, new_fn, op\u003doperator.add):"}],"source_content_type":"text/x-python","patch_set":3,"id":"4ab86c23_c9e54a76","line":1206,"in_reply_to":"6f0edd58_8ddad566","updated":"2022-10-17 16:51:28.000000000","message":"Done","commit_id":"39b2a03db73c26ecf7e26962a7b47d2ca1bb5ad4"}]}