)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27a05001f40b8aa16be88b8d8ef426201327eee9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-28 20:30:41 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Since OVN 22.09, config is stored in \"Chassis.other_config\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"Chassis\" configuration is stored in \"Chassis.other_config\" and"},{"line_number":10,"context_line":"not replicated to \"Chassis.external_ids\". This patch handles both"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b0d8a030_5ebe3918","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":15},"updated":"2022-09-29 12:30:24.000000000","message":"I think it\u0027s much older than that, I introduced this other_config column in the OVN chassis back in 2020 but left the external_ids as a backward compatible layer.\n\nSo perhaps they just got rid of that backward compatible layer recently ?\n\nThis was the commit: https://github.com/ovn-org/ovn/commit/74d90c2223d0a8c123823fb849b4c2de58c296e4","commit_id":"95f3af1d61966522cbf0f9755d1fe5780c2bfd81"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"09d9c6305d92d427e66bbda0fa3cadf0a1929377","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-28 20:30:41 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Since OVN 22.09, config is stored in \"Chassis.other_config\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"Chassis\" configuration is stored in \"Chassis.other_config\" and"},{"line_number":10,"context_line":"not replicated to \"Chassis.external_ids\". This patch handles both"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0bcc58b3_e6ca128b","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":15},"in_reply_to":"b0d8a030_5ebe3918","updated":"2022-09-29 13:00:00.000000000","message":"Right, I\u0027ll update the commit message.","commit_id":"95f3af1d61966522cbf0f9755d1fe5780c2bfd81"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"72e9593a416fb8eff9112bf8eba82799ecd7e741","unresolved":true,"context_lines":[{"line_number":11,"context_line":"cases, considering that the same Neutron code can be executed with"},{"line_number":12,"context_line":"newer and older versions of OVN."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Once considered that the minimum required version of OVN is 22.09,"},{"line_number":15,"context_line":"the references to \"external_ids\" will be removed."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1990229"},{"line_number":18,"context_line":"Change-Id: If379cefb66a262318858e1cea6503aa3a56ba956"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a630d88b_72a044cb","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":49},"updated":"2022-09-29 12:36:22.000000000","message":"Not needed as the other_config exists for a while.\n\nI was checking, it has been removed recently at https://github.com/ovn-org/ovn/commit/51309429cc3032a0cb422603e7bbda4905ca01ae\n\nBut it\u0027s been there since 2020 (see comment above L7)","commit_id":"95f3af1d61966522cbf0f9755d1fe5780c2bfd81"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"09d9c6305d92d427e66bbda0fa3cadf0a1929377","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cases, considering that the same Neutron code can be executed with"},{"line_number":12,"context_line":"newer and older versions of OVN."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Once considered that the minimum required version of OVN is 22.09,"},{"line_number":15,"context_line":"the references to \"external_ids\" will be removed."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1990229"},{"line_number":18,"context_line":"Change-Id: If379cefb66a262318858e1cea6503aa3a56ba956"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"67e7bcc3_023b2294","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":49},"in_reply_to":"a630d88b_72a044cb","updated":"2022-09-29 13:00:00.000000000","message":"Yeah but, for example, with ovn-nbctl 20.03.0 the \"other_config\" value is not there. I think we can keep this compatibility check for a couple of releases.","commit_id":"95f3af1d61966522cbf0f9755d1fe5780c2bfd81"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a42199ff1b0510407e93061c10f10aeff824bded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2256d644_a0ae53ef","updated":"2022-09-29 12:33:05.000000000","message":"Code-wise it looks good, I think the commit message is a bit misleading as core OVN just now got rid of the backward compatible layer we had between other_config and external_ids for storing configuration in the Chassis","commit_id":"95f3af1d61966522cbf0f9755d1fe5780c2bfd81"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eec3f4c136ad36f0ec823e3077fedc463ad4a680","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a4500fab_7aee7ba2","updated":"2022-10-03 13:16:25.000000000","message":"recheck unrelated FT error","commit_id":"f8fa909444cf87d55819fa9dbc45ed77cff7b845"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"c93dee25ece780fccc28a6c7aad245770dfce1e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2778e410_75aaa2dc","updated":"2022-10-06 14:38:51.000000000","message":"this patch does not imply need to alter table to other_config on each gateway node? It is just for ovn dbs?\nSo this doc is still valid then? For example for ovn-bridge-mappings (and other):\nhttps://docs.openstack.org/neutron/latest/admin/ovn/external_ports.html#ovn-database-information","commit_id":"f8fa909444cf87d55819fa9dbc45ed77cff7b845"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"41d7cf8526e08f77f2055e90afc39c913fbb068d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8aa1f216_4d648d0d","in_reply_to":"174cafb7_e58f0b21","updated":"2022-10-06 15:52:30.000000000","message":"hmm, ovn still creates bridge mappings in local ovsdb to external-ids in their tests - https://github.com/ovn-org/ovn/blob/main/tests/ovn-controller.at#L70\n(unless I\u0027m reading it wrong)","commit_id":"f8fa909444cf87d55819fa9dbc45ed77cff7b845"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"52a0b28ca463f4507c8f16149359029f473d04d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"174cafb7_e58f0b21","in_reply_to":"2778e410_75aaa2dc","updated":"2022-10-06 14:44:39.000000000","message":"Not anymore, I need to update this doc. Since OVN 20.06, this configuration should be retrieved from \"other_config\"","commit_id":"f8fa909444cf87d55819fa9dbc45ed77cff7b845"}],"neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py":[{"author":{"_account_id":31823,"name":"Benjamin Reichel","email":"b.reichel@syseleven.de","username":"benj200"},"change_message_id":"8c9004e984daedb8b96aef490ae69aa1edf0f40f","unresolved":true,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @staticmethod  # it is by default, but this makes pep8 happy"},{"line_number":143,"context_line":"    def __new__(cls, chassis_private, driver):"},{"line_number":144,"context_line":"        other_config \u003d cls.chassis_from_private(chassis_private).other_config"},{"line_number":145,"context_line":"        if \u0027enable-chassis-as-gw\u0027 in other_config.get(\u0027ovn-cms-options\u0027, []):"},{"line_number":146,"context_line":"            cls \u003d ControllerGatewayAgent"},{"line_number":147,"context_line":"        return super().__new__(cls)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b5669983_5cfce7fd","line":144,"updated":"2022-10-04 07:36:12.000000000","message":"The liveness check for agents are stored in chassis_private table. I\u0027m not certain if this needs to be changed as well since chassis table is only affected.","commit_id":"f8fa909444cf87d55819fa9dbc45ed77cff7b845"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4788f8cb188166aec629e8680714b68ee6001b4c","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @staticmethod  # it is by default, but this makes pep8 happy"},{"line_number":143,"context_line":"    def __new__(cls, chassis_private, driver):"},{"line_number":144,"context_line":"        other_config \u003d cls.chassis_from_private(chassis_private).other_config"},{"line_number":145,"context_line":"        if \u0027enable-chassis-as-gw\u0027 in other_config.get(\u0027ovn-cms-options\u0027, []):"},{"line_number":146,"context_line":"            cls \u003d ControllerGatewayAgent"},{"line_number":147,"context_line":"        return super().__new__(cls)"}],"source_content_type":"text/x-python","patch_set":5,"id":"49ffaf4b_bb4b4f50","line":144,"in_reply_to":"b5669983_5cfce7fd","updated":"2022-10-04 08:32:24.000000000","message":"Right, we use Chassis_Private (if existing is the deployment, depending on the version) to control the status of the agents. But the configuration options (\"ovn-cms-options\") are only in the Chassis register [1][2]. We use the method \"chassis_from_private\" to retrieve the Chassis register to read the \"other_config\" field.\n\n[1]https://github.com/ovn-org/ovn/blob/ea2e5b3303c3a89189055f723777f7fff3ad9f1f/ovn-sb.ovsschema#L41-L43\n[2]https://github.com/ovn-org/ovn/blob/ea2e5b3303c3a89189055f723777f7fff3ad9f1f/ovn-sb.xml#L306-L312","commit_id":"f8fa909444cf87d55819fa9dbc45ed77cff7b845"}],"releasenotes/notes/ovn-chassis-other-config-7db15b9d10bf7f04.yaml":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d641811feba354e3f9fcf05c4c54259145dcc595","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Since OVN 20.06, the \"Chassis\" register configuration is stored in the"},{"line_number":10,"context_line":"    \"other_config\" field and replicated into \"external_ids\". This replication"},{"line_number":11,"context_line":"    is stopped in OVN 22.09. The ML2/OVN plugin retrieves the \"Chassi\""},{"line_number":12,"context_line":"    configuration from the \"other_config\" field only. That makes Neutron"},{"line_number":13,"context_line":"    not compatible with OVN versions below 20.06."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bddd2cd1_b08499b0","line":11,"range":{"start_line":11,"start_character":63,"end_line":11,"end_character":69},"updated":"2022-10-06 09:44:05.000000000","message":"nit: Chassis?","commit_id":"f8fa909444cf87d55819fa9dbc45ed77cff7b845"}]}