)]}'
{"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cebaaa8c9b8316d7efa08b589a1e16e20dfe107d","unresolved":true,"context_lines":[{"line_number":362,"context_line":"                if (count \u003d\u003d MAX_PROVISIONING_TRIES or"},{"line_number":363,"context_line":"                        owner.startswith(const.DEVICE_OWNER_NETWORK_PREFIX) or"},{"line_number":364,"context_line":"                        owner.startswith(const.DEVICE_OWNER_NEUTRON_PREFIX) or"},{"line_number":365,"context_line":"                        owner.startswith(const.DEVICE_OWNER_BAREMETAL_PREFIX)):"},{"line_number":366,"context_line":"                    return"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"                # Wait 0.5 seconds before checking again if the port is bound."}],"source_content_type":"text/x-python","patch_set":1,"id":"1b03b7b3_3a7ac98b","line":365,"updated":"2022-09-28 17:55:53.000000000","message":"Should this be flipped and instead check against not being DEVICE_OWNER_COMPUTE_PREFIX ?","commit_id":"0796d421ce66d1f7ea9127d0091727dc317477a2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6f3558293a36376d1430fcdc32e9b654f20eae4b","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                if (count \u003d\u003d MAX_PROVISIONING_TRIES or"},{"line_number":363,"context_line":"                        owner.startswith(const.DEVICE_OWNER_NETWORK_PREFIX) or"},{"line_number":364,"context_line":"                        owner.startswith(const.DEVICE_OWNER_NEUTRON_PREFIX) or"},{"line_number":365,"context_line":"                        owner.startswith(const.DEVICE_OWNER_BAREMETAL_PREFIX)):"},{"line_number":366,"context_line":"                    return"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"                # Wait 0.5 seconds before checking again if the port is bound."}],"source_content_type":"text/x-python","patch_set":1,"id":"27728040_300c8121","line":365,"in_reply_to":"1b03b7b3_3a7ac98b","updated":"2022-09-29 10:52:38.000000000","message":"Actually I realized that when I pushed this patch. Only \"compute:xxx\" ports should be here. I\u0027ll push an update","commit_id":"0796d421ce66d1f7ea9127d0091727dc317477a2"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7b0ddd17a3e75945b04ed9fc0e83f463a734353e","unresolved":true,"context_lines":[{"line_number":1129,"context_line":"        port_id \u003d \u0027fake_port_id\u0027"},{"line_number":1130,"context_line":"        device_owner \u003d constants.DEVICE_OWNER_COMPUTE_PREFIX + \u0027nova\u0027"},{"line_number":1131,"context_line":"        port \u003d mock.Mock(id\u003dport_id, admin_state_up\u003dTrue,"},{"line_number":1132,"context_line":"                         device_owner\u003ddevice_owner)"},{"line_number":1133,"context_line":"        mock_get_port.return_value \u003d port"},{"line_number":1134,"context_line":"        with mock.patch.object(plugin, \u0027update_port_status\u0027) as mock_pstatus:"},{"line_number":1135,"context_line":"            pb1 \u003d mock.MagicMock(vif_type\u003dportbindings.VIF_TYPE_UNBOUND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"00c3996a_0b617278","line":1132,"updated":"2022-09-29 15:04:49.000000000","message":"Since it\u0027s probably easy enough to do, should add a test with a non-compute prefix and make sure update_port_status() is not called.","commit_id":"53b8dbde54200d78791dd96eda8372f1ff5b7d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a03ae1deb31a7c3a75585152b4516023984ccbfc","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        port_id \u003d \u0027fake_port_id\u0027"},{"line_number":1130,"context_line":"        device_owner \u003d constants.DEVICE_OWNER_COMPUTE_PREFIX + \u0027nova\u0027"},{"line_number":1131,"context_line":"        port \u003d mock.Mock(id\u003dport_id, admin_state_up\u003dTrue,"},{"line_number":1132,"context_line":"                         device_owner\u003ddevice_owner)"},{"line_number":1133,"context_line":"        mock_get_port.return_value \u003d port"},{"line_number":1134,"context_line":"        with mock.patch.object(plugin, \u0027update_port_status\u0027) as mock_pstatus:"},{"line_number":1135,"context_line":"            pb1 \u003d mock.MagicMock(vif_type\u003dportbindings.VIF_TYPE_UNBOUND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"40ca39b3_18c98f22","line":1132,"in_reply_to":"00c3996a_0b617278","updated":"2022-09-29 15:15:21.000000000","message":"Done","commit_id":"53b8dbde54200d78791dd96eda8372f1ff5b7d4c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"01a39aad3944285d334983b442f3546e042077bd","unresolved":true,"context_lines":[{"line_number":1142,"context_line":"            mock_pstatus.assert_called_once_with(self.context, port_id,"},{"line_number":1143,"context_line":"                                                 constants.PORT_STATUS_ACTIVE)"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    @mock.patch(\u0027neutron.plugins.ml2.plugin.db.get_port\u0027)"},{"line_number":1146,"context_line":"    @mock.patch.object(p_utils, \u0027get_port_binding_by_status_and_host\u0027)"},{"line_number":1147,"context_line":"    def test__port_provisioned_port_retry_port_binding_unbound_no_vm_port("},{"line_number":1148,"context_line":"            self, mock_get_pb, mock_get_port):"},{"line_number":1149,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":1150,"context_line":"        port_id \u003d \u0027fake_port_id\u0027"},{"line_number":1151,"context_line":"        port \u003d mock.Mock(id\u003dport_id, admin_state_up\u003dTrue,"},{"line_number":1152,"context_line":"                         device_owner\u003d\u0027other_value\u0027)"},{"line_number":1153,"context_line":"        mock_get_port.return_value \u003d port"},{"line_number":1154,"context_line":"        with mock.patch.object(plugin, \u0027update_port_status\u0027) as mock_pstatus:"},{"line_number":1155,"context_line":"            pb1 \u003d mock.MagicMock(vif_type\u003dportbindings.VIF_TYPE_UNBOUND)"},{"line_number":1156,"context_line":"            mock_get_pb.return_value \u003d pb1"},{"line_number":1157,"context_line":"            plugin._port_provisioned(\u0027port\u0027, \u0027evt\u0027, \u0027trigger\u0027,"},{"line_number":1158,"context_line":"                                     payload\u003devents.DBEventPayload("},{"line_number":1159,"context_line":"                                         self.context, resource_id\u003dport_id))"},{"line_number":1160,"context_line":"            mock_pstatus.assert_not_called()"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"    def test_port_after_create_outside_transaction(self):"},{"line_number":1163,"context_line":"        self.tx_open \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"73caef04_8c2a21af","line":1160,"range":{"start_line":1145,"start_character":0,"end_line":1160,"end_character":44},"updated":"2022-09-30 09:56:46.000000000","message":"+1","commit_id":"21491efd9f8ce6df98cb58c26da7896d75cb4a8b"}]}