)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"52bf82dfd05f6d41df432e55ad111594f2e34965","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"25eb1610_f4ca361e","updated":"2022-10-04 15:53:06.000000000","message":"This is still a WIP","commit_id":"bb688ff12ebbd90a19dd7bdf14a8b7c1fadd6256"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a0462435eb5efb2a238c85153ffe595e42d2629d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ae02d63_d96cbec8","updated":"2022-10-05 18:43:42.000000000","message":"Nice! I could go either way on the refactoring split, leaving W+1 off just in case you were working on it. Otherwise, I\u0027d say ship it.","commit_id":"50eee19723b2d762c2b5653e7a2c75e470f44cdf"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d66734ec6d074fe3161be1f3e15af4646736a1bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e39b835f_aff87706","updated":"2022-10-05 10:23:27.000000000","message":"Thanks for the patch guys, it looks good! A question and two notes in-line.","commit_id":"50eee19723b2d762c2b5653e7a2c75e470f44cdf"}],"neutron/common/ovn/utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d66734ec6d074fe3161be1f3e15af4646736a1bf","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    \u0027PortExtraDHCPValidation\u0027, [\u0027failed\u0027, \u0027invalid_ipv4\u0027, \u0027invalid_ipv6\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class OvsdbClientCommand(object):"},{"line_number":61,"context_line":"    _CONNECTION \u003d 0"},{"line_number":62,"context_line":"    _PRIVATE_KEY \u003d 1"},{"line_number":63,"context_line":"    _CERTIFICATE \u003d 2"}],"source_content_type":"text/x-python","patch_set":5,"id":"5523b2f4_2cc72bd4","line":60,"updated":"2022-10-05 10:23:27.000000000","message":"Do we plan to move this to ovsdbapp eventually ? It sounds like something that could be used by other projects too.\n\nIf so, perhaps we should add a TODO to replace it once the ovsdbapp version is available and requirements are updated ?","commit_id":"50eee19723b2d762c2b5653e7a2c75e470f44cdf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"918e1807a5497a6af32deecfb5ae472ff64dcb9d","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    \u0027PortExtraDHCPValidation\u0027, [\u0027failed\u0027, \u0027invalid_ipv4\u0027, \u0027invalid_ipv6\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class OvsdbClientCommand(object):"},{"line_number":61,"context_line":"    _CONNECTION \u003d 0"},{"line_number":62,"context_line":"    _PRIVATE_KEY \u003d 1"},{"line_number":63,"context_line":"    _CERTIFICATE \u003d 2"}],"source_content_type":"text/x-python","patch_set":5,"id":"e1b84460_b46be086","line":60,"in_reply_to":"5523b2f4_2cc72bd4","updated":"2022-10-05 13:21:53.000000000","message":"I haven\u0027t thought about it but I would say we don\u0027t plan to. ovsdbapp is intended to be a wrapper around python-ovs while this is hard-core ovsdb protocol utility. I would move it in case there is a demand for it.","commit_id":"50eee19723b2d762c2b5653e7a2c75e470f44cdf"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"757c9c63f25d2a3f8f72674a7263d9122f6d1563","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    \u0027PortExtraDHCPValidation\u0027, [\u0027failed\u0027, \u0027invalid_ipv4\u0027, \u0027invalid_ipv6\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class OvsdbClientCommand(object):"},{"line_number":61,"context_line":"    _CONNECTION \u003d 0"},{"line_number":62,"context_line":"    _PRIVATE_KEY \u003d 1"},{"line_number":63,"context_line":"    _CERTIFICATE \u003d 2"}],"source_content_type":"text/x-python","patch_set":5,"id":"780e2c1e_5d4ac27f","line":60,"in_reply_to":"e1b84460_b46be086","updated":"2022-10-05 13:27:55.000000000","message":"Fair, we can keep here for now","commit_id":"50eee19723b2d762c2b5653e7a2c75e470f44cdf"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d66734ec6d074fe3161be1f3e15af4646736a1bf","unresolved":true,"context_lines":[{"line_number":1146,"context_line":"            }"},{"line_number":1147,"context_line":"        ]"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"        return ovn_utils.OvsdbClientTransactCommand.run(cmd)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def update_segment_host_mapping(self, host, phy_nets):"},{"line_number":1152,"context_line":"        \"\"\"Update SegmentHostMapping in DB\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"4273614a_b96afad6","line":1149,"updated":"2022-10-05 10:23:27.000000000","message":"Refactoring this method seems outside of the scope of this patch and the bug it\u0027s trying to address. I am not necessarily against it but perhaps a mention in the commit message would be good.","commit_id":"50eee19723b2d762c2b5653e7a2c75e470f44cdf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"918e1807a5497a6af32deecfb5ae472ff64dcb9d","unresolved":true,"context_lines":[{"line_number":1146,"context_line":"            }"},{"line_number":1147,"context_line":"        ]"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"        return ovn_utils.OvsdbClientTransactCommand.run(cmd)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def update_segment_host_mapping(self, host, phy_nets):"},{"line_number":1152,"context_line":"        \"\"\"Update SegmentHostMapping in DB\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"cad5189a_6c19cbe0","line":1149,"in_reply_to":"4273614a_b96afad6","updated":"2022-10-05 13:21:53.000000000","message":"I also thought about splitting this into two patches, one that would refactor and introduce OvsdbClientTransactCommand and the other that replaces neutron_pg_drop handling. I can try to split it, I think it would make sense.","commit_id":"50eee19723b2d762c2b5653e7a2c75e470f44cdf"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"757c9c63f25d2a3f8f72674a7263d9122f6d1563","unresolved":true,"context_lines":[{"line_number":1146,"context_line":"            }"},{"line_number":1147,"context_line":"        ]"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"        return ovn_utils.OvsdbClientTransactCommand.run(cmd)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def update_segment_host_mapping(self, host, phy_nets):"},{"line_number":1152,"context_line":"        \"\"\"Update SegmentHostMapping in DB\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"b1f1dcd2_66ed24ae","line":1149,"in_reply_to":"cad5189a_6c19cbe0","updated":"2022-10-05 13:27:55.000000000","message":"I don\u0027t know if that\u0027s necessary to be honest, I commented because there\u0027s no mention of refactoring these two mac_bindings methods in the commit message.","commit_id":"50eee19723b2d762c2b5653e7a2c75e470f44cdf"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d66734ec6d074fe3161be1f3e15af4646736a1bf","unresolved":true,"context_lines":[{"line_number":1695,"context_line":"                ]"},{"line_number":1696,"context_line":"            }"},{"line_number":1697,"context_line":"        ]"},{"line_number":1698,"context_line":"        return utils.OvsdbClientTransactCommand.run(cmd)"},{"line_number":1699,"context_line":""},{"line_number":1700,"context_line":"    def _delete_lrouter_port(self, context, port_id, router_id\u003dNone, txn\u003dNone):"},{"line_number":1701,"context_line":"        \"\"\"Delete a logical router port.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"8406c7e7_93afe7de","line":1698,"updated":"2022-10-05 10:23:27.000000000","message":"Refactoring this method seems outside of the scope of this patch and the bug it\u0027s trying to address. I am not necessarily against it but perhaps a mention in the commit message would be good.","commit_id":"50eee19723b2d762c2b5653e7a2c75e470f44cdf"}]}