)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6fec6c04e04a5904ae97771c9c7ecceab0831616","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"caeaf11d_8adeb71b","updated":"2022-10-06 10:19:20.000000000","message":"Can you add the LP bug ID?\n\nWhat OVN version do you have? Do you have the \"chassis_private\" table? If not, try to update your env. That should reduce the impact of the metadata agent heartbeat.","commit_id":"f199e4b424dafc6166e03a31188fb7d47e98dc36"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"e0331491a069053dd53680d27c01f994857fae00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"95dbacdc_be88bf03","in_reply_to":"caeaf11d_8adeb71b","updated":"2022-10-06 13:02:40.000000000","message":"Sure, LP bug done.","commit_id":"f199e4b424dafc6166e03a31188fb7d47e98dc36"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d1f2537eb663ab603f463914f442de23d1aad717","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"268a7899_919f45d5","updated":"2022-11-02 11:40:58.000000000","message":"Hi @Terry, can you review this patch?","commit_id":"628442aed7400251f12809a45605bd717f494c4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ff7952ff5a18ce0affb714087d3bf14bfd1622e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f3903b7b_325181bc","updated":"2022-11-30 09:15:07.000000000","message":"I\u0027m not sure about this patch and I would Terry to check it","commit_id":"628442aed7400251f12809a45605bd717f494c4e"}],"neutron/agent/ovn/metadata/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"74cd2f6debc1a99b102cf5b2604df62b2d534099","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            self.first_run \u003d False"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            try:"},{"line_number":206,"context_line":"                interval \u003d randrange(0, max(cfg.CONF.agent_down_time // 2, 1))"},{"line_number":207,"context_line":"            except cfg.NoSuchOptError:"},{"line_number":208,"context_line":"                interval \u003d 0"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"559f7f88_3d4aebe0","line":206,"updated":"2022-10-05 15:44:53.000000000","message":"So if agent_down_time\u003d0, this will be randrange(0, 1), which will always return 0 since it won\u0027t include the upper endpoint. In that case you\u0027d want to use randint().","commit_id":"4c8d845c2debe71d400edd08d40294902ed3d845"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"d71c146904eaa6be7a9c8b4f7dbb9112c0c1de36","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            self.first_run \u003d False"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            try:"},{"line_number":206,"context_line":"                interval \u003d randrange(0, max(cfg.CONF.agent_down_time // 2, 1))"},{"line_number":207,"context_line":"            except cfg.NoSuchOptError:"},{"line_number":208,"context_line":"                interval \u003d 0"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6ab0a060_facf5263","line":206,"in_reply_to":"559f7f88_3d4aebe0","updated":"2022-10-06 10:01:01.000000000","message":"Ack","commit_id":"4c8d845c2debe71d400edd08d40294902ed3d845"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"74cd2f6debc1a99b102cf5b2604df62b2d534099","unresolved":true,"context_lines":[{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            try:"},{"line_number":206,"context_line":"                interval \u003d randrange(0, max(cfg.CONF.agent_down_time // 2, 1))"},{"line_number":207,"context_line":"            except cfg.NoSuchOptError:"},{"line_number":208,"context_line":"                interval \u003d 0"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        LOG.debug(\"Delaying updating chassis table for %s seconds\", interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d501a262_069b0152","line":207,"updated":"2022-10-05 15:44:53.000000000","message":"This should never happen, right? If it does then something isn\u0027t importing and registering the options. For example see what neutron/agent/common/utils.py does.","commit_id":"4c8d845c2debe71d400edd08d40294902ed3d845"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"d71c146904eaa6be7a9c8b4f7dbb9112c0c1de36","unresolved":true,"context_lines":[{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            try:"},{"line_number":206,"context_line":"                interval \u003d randrange(0, max(cfg.CONF.agent_down_time // 2, 1))"},{"line_number":207,"context_line":"            except cfg.NoSuchOptError:"},{"line_number":208,"context_line":"                interval \u003d 0"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        LOG.debug(\"Delaying updating chassis table for %s seconds\", interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c84c83af_f952a612","line":207,"in_reply_to":"d501a262_069b0152","updated":"2022-10-06 10:01:01.000000000","message":"you are right\nJust notice: registering of AGENTS_OPTS in agents_db are imported in some dizzy way agent-\u003elinux.external_process-\u003elinux.ip_lib-\u003ecommon.utils.\nConsidering to register AGENTS_OPTS more explicit here.","commit_id":"4c8d845c2debe71d400edd08d40294902ed3d845"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"32cd5130f4f94456c6e6919bd1eb21cf7c7a9d35","unresolved":true,"context_lines":[{"line_number":204,"context_line":"            interval \u003d 0"},{"line_number":205,"context_line":"            self.first_run \u003d False"},{"line_number":206,"context_line":"        else:"},{"line_number":207,"context_line":"            interval \u003d randint(0, cfg.CONF.agent_down_time // 2)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        LOG.debug(\"Delaying updating chassis table for %s seconds\", interval)"},{"line_number":210,"context_line":"        timer \u003d threading.Timer(interval, _update_chassis, [self, row])"}],"source_content_type":"text/x-python","patch_set":4,"id":"a59c2058_c63d0166","line":207,"range":{"start_line":207,"start_character":34,"end_line":207,"end_character":58},"updated":"2022-10-10 14:56:30.000000000","message":"default value for this is 75 seconds so it can be delayed for about 37 seconds even. Wouldn\u0027t that be too much?","commit_id":"628442aed7400251f12809a45605bd717f494c4e"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"3e0b1b2356478b2b471fb4b5a3fc5b4cdd91c887","unresolved":true,"context_lines":[{"line_number":204,"context_line":"            interval \u003d 0"},{"line_number":205,"context_line":"            self.first_run \u003d False"},{"line_number":206,"context_line":"        else:"},{"line_number":207,"context_line":"            interval \u003d randint(0, cfg.CONF.agent_down_time // 2)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        LOG.debug(\"Delaying updating chassis table for %s seconds\", interval)"},{"line_number":210,"context_line":"        timer \u003d threading.Timer(interval, _update_chassis, [self, row])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9023ff5c_fe30f3ab","line":207,"range":{"start_line":207,"start_character":34,"end_line":207,"end_character":58},"in_reply_to":"a59c2058_c63d0166","updated":"2022-10-12 09:44:01.000000000","message":"well, anyway neutron waits agent_down_time seconds until marks specific agent as down. At least two heartbeats should be in place in that time.\nWhen agent is initialized there is no delay to make agent sign-in immediately.","commit_id":"628442aed7400251f12809a45605bd717f494c4e"}]}