)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Support for minimum bandwidth rules in tunnelled networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for QoS minimum bandwidth rules in tunnelled"},{"line_number":10,"context_line":"networks. Now the ML2/OVS and ML2/OVS mechanism drivers can represent"},{"line_number":11,"context_line":"in the Placement API the available bandwidth of the tunnelled networks"},{"line_number":12,"context_line":"in each compute host."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"dcc543d8_627c2e48","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":37},"updated":"2022-12-07 11:53:47.000000000","message":"OVN I guess","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c706944526437ff651a04c42150e8e9e30d48a4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support for minimum bandwidth rules in tunnelled networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for QoS minimum bandwidth rules in tunnelled"},{"line_number":10,"context_line":"networks. Now the ML2/OVS and ML2/OVS mechanism drivers can represent"},{"line_number":11,"context_line":"in the Placement API the available bandwidth of the tunnelled networks"},{"line_number":12,"context_line":"in each compute host."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"e4c5cc33_293138ab","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":37},"in_reply_to":"dcc543d8_627c2e48","updated":"2022-12-12 08:42:27.000000000","message":"Right!","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":true,"context_lines":[{"line_number":22,"context_line":"bandwidth rules."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"NOTE: spec still under review:"},{"line_number":25,"context_line":"  https://review.opendev.org/c/openstack/neutron-specs/+/860859"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"What is missing and will be added in next patches:"},{"line_number":28,"context_line":"* Fullstack tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"0344ad97_481b2e7b","line":25,"updated":"2022-12-07 11:53:47.000000000","message":"spec is merged now","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c706944526437ff651a04c42150e8e9e30d48a4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"bandwidth rules."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"NOTE: spec still under review:"},{"line_number":25,"context_line":"  https://review.opendev.org/c/openstack/neutron-specs/+/860859"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"What is missing and will be added in next patches:"},{"line_number":28,"context_line":"* Fullstack tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"0157efae_7b3da1b5","line":25,"in_reply_to":"0344ad97_481b2e7b","updated":"2022-12-12 08:42:27.000000000","message":"Thanks, I\u0027ll keep the spec reference but removing the \"under review\" comment.","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"d09135e1a9e8207b074463de80110731ca75adc4","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"RFE spec: https://review.opendev.org/c/openstack/neutron-specs/+/860859"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"What is missing and will be added in next patches:"},{"line_number":27,"context_line":"* Fullstack tests."},{"line_number":28,"context_line":"* Tempest tests, that will be pushed to the corresponding repository."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/863880"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"6d09a14f_fe573cca","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":69},"updated":"2022-12-23 17:23:18.000000000","message":"nit: remove since it was added already","commit_id":"9232617f763148f389206740928b3ec7750c4a01"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fee35274345dfaa15139e5dda4fdb4f980f3f1b8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"RFE spec: https://review.opendev.org/c/openstack/neutron-specs/+/860859"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"What is missing and will be added in next patches:"},{"line_number":27,"context_line":"* Fullstack tests."},{"line_number":28,"context_line":"* Tempest tests, that will be pushed to the corresponding repository."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/863880"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"50e9515e_fc4fc560","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":69},"in_reply_to":"6d09a14f_fe573cca","updated":"2023-01-02 11:34:18.000000000","message":"I\u0027ll keep the tempest line.","commit_id":"9232617f763148f389206740928b3ec7750c4a01"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"99bbb192264df71720e3f4fa818a666d765e4484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"73863906_35ccae03","updated":"2022-11-03 08:18:06.000000000","message":"I tested with single host ovs devstack, and it works by my basic checks (tested with both port on VXLAN and parallelly on VLAN network to see if no issue with old scenario), thanks","commit_id":"b10520e5218c1cfb63a40fb7a55621340feb30f7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9125659b79b26066e2b44822a9f7d3389769d317","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1372f952_48f3fe84","updated":"2022-11-15 16:58:31.000000000","message":"TODO:\n* Change the ostrait name","commit_id":"04047ef121eb8dcb9c6f397057f276330db474e4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"916969b4_df288e58","updated":"2022-12-07 11:53:47.000000000","message":"Generally looks good. Only some nits and release note update is needed 😊","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb5a318a185e25dcefa0bce4524342cf02270c9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c56c8d0d_fb4ec50d","updated":"2022-12-02 17:16:07.000000000","message":"recheck live migration error","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c794eee05adf69225ed2bb52c7f245fa288f458d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"eadeeb8b_c0ea873f","updated":"2022-12-23 10:03:40.000000000","message":"Hello fellow reviewers, if you have some time, please check this patch.\n\nThanks in advance!","commit_id":"9232617f763148f389206740928b3ec7750c4a01"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d1e12374d879593a080ce2f195026a788ffa5c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3fe1c719_f4ee9737","updated":"2022-12-19 10:55:42.000000000","message":"Hi folks, if you have some mins, please review this patch. Thanks in advance.","commit_id":"9232617f763148f389206740928b3ec7750c4a01"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"519258d09767cbd8c148417a27c75e171de788a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"78ad826e_81725d7b","updated":"2022-12-19 13:01:12.000000000","message":"LGTM, thanks!","commit_id":"9232617f763148f389206740928b3ec7750c4a01"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c8f5331f44c5b75afa5b443cb7081787af5a66c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e5cc1c87_6ea91c8c","updated":"2023-01-04 17:43:15.000000000","message":"Hi folks, if you have some minutes, please review this patch. Thanks in advance!","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"c163305c879eb4f39e16d85e03e2f9f78db49e21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"abbee00b_ac6a326d","updated":"2023-01-05 14:05:08.000000000","message":"Looks good from what I saw","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d80f3578e0444da8438316bf7d4788d0f73b8ff7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"8f507766_13cd7c64","updated":"2023-01-13 19:42:54.000000000","message":"recheck FT","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a12274f307de9235caaefe1ecd37f23277a4cda4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"5b86b89c_55c7e3e4","updated":"2023-01-02 16:47:04.000000000","message":"recheck fullstack","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c1d3916ee261cbe472f7d48bbac40f25383b29fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b9288416_4e8cf36d","updated":"2023-01-12 16:55:01.000000000","message":"recheck fullstack timeout","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4791f090121e11ce55ac7d7112731ca1ab22a757","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"ed9ffaa9_bd845ca6","updated":"2023-01-13 12:09:47.000000000","message":"recheck fullstack timeout","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44dfc5e9c811e933a296469094fb192946ed3c75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"2ea40890_95267284","updated":"2023-01-16 09:17:27.000000000","message":"recheck lb and cover (??)","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb212343a163ec5785b8979c94ea89c4979290aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"cf4647cc_d4fc15a1","updated":"2023-01-13 15:24:51.000000000","message":"recheck tempest","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"625c6f972704cad38aaaf3dbdc7417f7f6192ed3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9ced8768_2fee6bc2","updated":"2023-01-12 10:23:54.000000000","message":"recheck unrelated (to me) errors","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ae255384180fc1c1cc4165ffd577900c2956cfc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"87fef560_87583751","updated":"2023-01-16 15:02:54.000000000","message":"recheck unrelated FT error","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"93f4fe44d9ae9b6c64382e97c81b8a903290ce8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"48ed1b08_251c7c55","updated":"2023-01-12 14:12:01.000000000","message":"recheck unrelated fullstack test","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2801a0e2719d5d8311409a4fd9888383f36b878b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1a9996e7_a12a43bc","updated":"2023-01-13 09:12:03.000000000","message":"recheck unrelates tempest","commit_id":"3ebdfe612a931a044877b2041a4ab68489bde5b7"}],"doc/source/admin/config-qos-min-bw.rst":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"99bbb192264df71720e3f4fa818a666d765e4484","unresolved":true,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":".. note::"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    \"rp_tunnelled\" is not a bridge nor an interface present in the host."},{"line_number":275,"context_line":"    It is mandatory to specify where this resource is located. Multiple hosts"},{"line_number":276,"context_line":"    can have the same resource provider \"rp_tunnelled\"."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"neutron-sriov-agent config"}],"source_content_type":"text/x-rst","patch_set":6,"id":"cc9d7954_b65b40cf","line":276,"range":{"start_line":274,"start_character":4,"end_line":276,"end_character":55},"updated":"2022-11-03 08:18:06.000000000","message":"resource_provider_hypervisors is an agent side cfg option, as I know, so this was set only if the hypervisor name was different from the default hypervisor_name, the point is that rp_tunneled be \"wired\" under the good host\u0027s resource_provider, am I wrong?","commit_id":"59d4066213fdc6dee0f18953785b389fab225c78"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dd0858b7a938c98200b92bc2635009c66aba5cc6","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":".. note::"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    \"rp_tunnelled\" is not a bridge nor an interface present in the host."},{"line_number":275,"context_line":"    It is mandatory to specify where this resource is located. Multiple hosts"},{"line_number":276,"context_line":"    can have the same resource provider \"rp_tunnelled\"."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"neutron-sriov-agent config"}],"source_content_type":"text/x-rst","patch_set":6,"id":"46e1a51f_1e83cabc","line":276,"range":{"start_line":274,"start_character":4,"end_line":276,"end_character":55},"in_reply_to":"cc9d7954_b65b40cf","updated":"2022-11-03 09:34:18.000000000","message":"Right, in OVS there is not need to explicitly define the \"resource_provider_hypervisors\" mappings. I\u0027ll remove it.\n\nHowever, in OVN it is needed.","commit_id":"59d4066213fdc6dee0f18953785b389fab225c78"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":true,"context_lines":[{"line_number":182,"context_line":"  by a ``direct-physical`` port."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Since Antelope, Open vSwitch and OVN mechanism drivers can specify the"},{"line_number":186,"context_line":"available bandwidth for tunnelled networks (SR-IOV does not support these"},{"line_number":187,"context_line":"network types yet). The key \"rp_tunnelled\" is used to model those networks"},{"line_number":188,"context_line":"that are not backed by a physical network. This bandwidth models the limits"}],"source_content_type":"text/x-rst","patch_set":19,"id":"75f8b7cd_f1882370","line":185,"range":{"start_line":185,"start_character":6,"end_line":185,"end_character":14},"updated":"2022-12-07 11:53:47.000000000","message":"nit: please add also 2023.1 name as we want to use more those version numbers starting with next release 😊","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c706944526437ff651a04c42150e8e9e30d48a4","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  by a ``direct-physical`` port."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Since Antelope, Open vSwitch and OVN mechanism drivers can specify the"},{"line_number":186,"context_line":"available bandwidth for tunnelled networks (SR-IOV does not support these"},{"line_number":187,"context_line":"network types yet). The key \"rp_tunnelled\" is used to model those networks"},{"line_number":188,"context_line":"that are not backed by a physical network. This bandwidth models the limits"}],"source_content_type":"text/x-rst","patch_set":19,"id":"947ec58d_e0c119af","line":185,"range":{"start_line":185,"start_character":6,"end_line":185,"end_character":14},"in_reply_to":"75f8b7cd_f1882370","updated":"2022-12-12 08:42:27.000000000","message":"Done","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"d09135e1a9e8207b074463de80110731ca75adc4","unresolved":true,"context_lines":[{"line_number":603,"context_line":".. code-block:: console"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    # as admin"},{"line_number":606,"context_line":"    $ openstack --os-placement-api-version 1.17 trait list | awk \u0027/CUSTOM_/ { print $2 }\u0027 | sort"},{"line_number":607,"context_line":"    CUSTOM_PHYSNET_PHYSNET0"},{"line_number":608,"context_line":"    CUSTOM_TUNNELLED_NETWORKS"},{"line_number":609,"context_line":"    CUSTOM_VNIC_TYPE_DIRECT"}],"source_content_type":"text/x-rst","patch_set":21,"id":"a0e85f17_7f6a8521","line":606,"range":{"start_line":606,"start_character":58,"end_line":606,"end_character":96},"updated":"2022-12-23 17:23:18.000000000","message":"nit: I know this is not your change . But the cli provides way to filter and sort natively\nwith --name\u003dstartswith:CUSTOM_ --sort-ascending\n\nhttps://docs.openstack.org/osc-placement/latest/cli/index.html#trait-list","commit_id":"9232617f763148f389206740928b3ec7750c4a01"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fee35274345dfaa15139e5dda4fdb4f980f3f1b8","unresolved":false,"context_lines":[{"line_number":603,"context_line":".. code-block:: console"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    # as admin"},{"line_number":606,"context_line":"    $ openstack --os-placement-api-version 1.17 trait list | awk \u0027/CUSTOM_/ { print $2 }\u0027 | sort"},{"line_number":607,"context_line":"    CUSTOM_PHYSNET_PHYSNET0"},{"line_number":608,"context_line":"    CUSTOM_TUNNELLED_NETWORKS"},{"line_number":609,"context_line":"    CUSTOM_VNIC_TYPE_DIRECT"}],"source_content_type":"text/x-rst","patch_set":21,"id":"66a82f08_10c28242","line":606,"range":{"start_line":606,"start_character":58,"end_line":606,"end_character":96},"in_reply_to":"a0e85f17_7f6a8521","updated":"2023-01-02 11:34:18.000000000","message":"I\u0027ll check it in follow-up patches.","commit_id":"9232617f763148f389206740928b3ec7750c4a01"}],"neutron/agent/common/placement_report.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8fdf240472118f866d5ac07604163257da0e1328","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        # TODO(ralonsoh): create a n-lib method to return the custom trait for"},{"line_number":208,"context_line":"        # rp_tunnelled."},{"line_number":209,"context_line":"        tunnelled_trait_mappings \u003d {RP_TUNNELLED: CUSTOM_TUNNELLED_NETWORKS}"},{"line_number":210,"context_line":"        physnet_trait_mappings \u003d {}"},{"line_number":211,"context_line":"        for physnet, devices in self._device_mappings.items():"},{"line_number":212,"context_line":"            for device in devices:"}],"source_content_type":"text/x-python","patch_set":1,"id":"550c1cd3_bd59dede","line":209,"range":{"start_line":209,"start_character":35,"end_line":209,"end_character":76},"updated":"2022-10-11 15:20:16.000000000","message":"for this os_traits has method (https://opendev.org/openstack/os-traits/src/branch/master/os_traits/__init__.py#L140 )","commit_id":"2ae940c10cce7304a1a58bf7aeb24f86b2599b7d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7ef7c46e46eed722bb6ee802bcc3a1d9c3af8784","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        # TODO(ralonsoh): create a n-lib method to return the custom trait for"},{"line_number":208,"context_line":"        # rp_tunnelled."},{"line_number":209,"context_line":"        tunnelled_trait_mappings \u003d {RP_TUNNELLED: CUSTOM_TUNNELLED_NETWORKS}"},{"line_number":210,"context_line":"        physnet_trait_mappings \u003d {}"},{"line_number":211,"context_line":"        for physnet, devices in self._device_mappings.items():"},{"line_number":212,"context_line":"            for device in devices:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b6afd554_65a51339","line":209,"range":{"start_line":209,"start_character":35,"end_line":209,"end_character":76},"in_reply_to":"550c1cd3_bd59dede","updated":"2022-10-13 14:08:54.000000000","message":"Yes but we don\u0027t import from os_traits and I would prefer to make this more \"static\", having a defined n-lib method returning this special trait. Something similar to [1].\n\n[1]https://github.com/openstack/neutron-lib/blob/cb54b45e380b837335082ee2cfd8098ac939c0b7/neutron_lib/placement/utils.py#L24","commit_id":"2ae940c10cce7304a1a58bf7aeb24f86b2599b7d"}],"neutron/common/_constants.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"99bbb192264df71720e3f4fa818a666d765e4484","unresolved":true,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# TODO(ralonsoh): move this constant to neutron_lib.placement.constants"},{"line_number":83,"context_line":"# Tunnelled networks resource provider default name."},{"line_number":84,"context_line":"RP_TUNNELLED \u003d \u0027rp_tunnelled\u0027"},{"line_number":85,"context_line":"TRAIT_PREFIX_TUNNELLED \u003d \u0027TUNNELLED_\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5789723e_4cbfb69d","line":84,"updated":"2022-11-03 08:18:06.000000000","message":"nit: the same is in neutron/agent/common/utils.py :-)","commit_id":"59d4066213fdc6dee0f18953785b389fab225c78"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dd0858b7a938c98200b92bc2635009c66aba5cc6","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# TODO(ralonsoh): move this constant to neutron_lib.placement.constants"},{"line_number":83,"context_line":"# Tunnelled networks resource provider default name."},{"line_number":84,"context_line":"RP_TUNNELLED \u003d \u0027rp_tunnelled\u0027"},{"line_number":85,"context_line":"TRAIT_PREFIX_TUNNELLED \u003d \u0027TUNNELLED_\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"395fa6c6_1c9f65de","line":84,"in_reply_to":"5789723e_4cbfb69d","updated":"2022-11-03 09:34:18.000000000","message":"Removed from neutron/agent/common/utils.py in the next PS.","commit_id":"59d4066213fdc6dee0f18953785b389fab225c78"}],"neutron/common/utils.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":true,"context_lines":[{"line_number":61,"context_line":"from neutron._i18n import _"},{"line_number":62,"context_line":"from neutron.api import api_common"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"TIME_FORMAT \u003d \"%Y-%m-%dT%H:%M:%SZ\""},{"line_number":66,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"d90010fa_4412679d","line":64,"updated":"2022-12-07 11:53:47.000000000","message":"unrelated change?","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c706944526437ff651a04c42150e8e9e30d48a4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"from neutron._i18n import _"},{"line_number":62,"context_line":"from neutron.api import api_common"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"TIME_FORMAT \u003d \"%Y-%m-%dT%H:%M:%SZ\""},{"line_number":66,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"9d7c6201_5d5d9b4b","line":64,"in_reply_to":"d90010fa_4412679d","updated":"2022-12-12 08:42:27.000000000","message":"Sorry","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"}],"neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":"from neutron.conf.agent import ovs_conf"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"EXTRA_LOG_LEVEL_DEFAULTS \u003d ["}],"source_content_type":"text/x-python","patch_set":19,"id":"0c547a01_1f19b590","line":21,"updated":"2022-12-07 11:53:47.000000000","message":"ditto","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c706944526437ff651a04c42150e8e9e30d48a4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":"from neutron.conf.agent import ovs_conf"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"EXTRA_LOG_LEVEL_DEFAULTS \u003d ["}],"source_content_type":"text/x-python","patch_set":19,"id":"dab3ad0c_4635271a","line":21,"in_reply_to":"0c547a01_1f19b590","updated":"2022-12-12 08:42:27.000000000","message":"Done","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"}],"neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                      \u0027vif_port was not found. It seems that port is already \u0027"},{"line_number":433,"context_line":"                      \u0027deleted\u0027, port.get(\u0027port_id\u0027))"},{"line_number":434,"context_line":"            return"},{"line_number":435,"context_line":"        elif not port[\u0027physical_network\u0027]:"},{"line_number":436,"context_line":"            LOG.debug(\u0027update_minimum_bandwidth was received for port %s but \u0027"},{"line_number":437,"context_line":"                      \u0027has no physical network associated\u0027,"},{"line_number":438,"context_line":"                      port.get(\u0027port_id\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"487cc760_7efb840b","line":435,"updated":"2022-12-07 11:53:47.000000000","message":"is physical_network key always there? Or maybe it would be better to use get() ?","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c706944526437ff651a04c42150e8e9e30d48a4","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                      \u0027vif_port was not found. It seems that port is already \u0027"},{"line_number":433,"context_line":"                      \u0027deleted\u0027, port.get(\u0027port_id\u0027))"},{"line_number":434,"context_line":"            return"},{"line_number":435,"context_line":"        elif not port[\u0027physical_network\u0027]:"},{"line_number":436,"context_line":"            LOG.debug(\u0027update_minimum_bandwidth was received for port %s but \u0027"},{"line_number":437,"context_line":"                      \u0027has no physical network associated\u0027,"},{"line_number":438,"context_line":"                      port.get(\u0027port_id\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"a0b7fd57_b06dce05","line":435,"in_reply_to":"487cc760_7efb840b","updated":"2022-12-12 08:42:27.000000000","message":"Right, I\u0027ll use get instead.","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":true,"context_lines":[{"line_number":435,"context_line":"        elif not port[\u0027physical_network\u0027]:"},{"line_number":436,"context_line":"            LOG.debug(\u0027update_minimum_bandwidth was received for port %s but \u0027"},{"line_number":437,"context_line":"                      \u0027has no physical network associated\u0027,"},{"line_number":438,"context_line":"                      port.get(\u0027port_id\u0027))"},{"line_number":439,"context_line":"            return"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        self.ports[port[\u0027port_id\u0027]][(qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH,"}],"source_content_type":"text/x-python","patch_set":19,"id":"bb5d3af6_162006c5","line":438,"updated":"2022-12-07 11:53:47.000000000","message":"ok, I needed few minutes to understand why this new check is added but it\u0027s because for tunneled networks min bw is not enforced so we can\u0027t do anything for such ports here.","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c706944526437ff651a04c42150e8e9e30d48a4","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        elif not port[\u0027physical_network\u0027]:"},{"line_number":436,"context_line":"            LOG.debug(\u0027update_minimum_bandwidth was received for port %s but \u0027"},{"line_number":437,"context_line":"                      \u0027has no physical network associated\u0027,"},{"line_number":438,"context_line":"                      port.get(\u0027port_id\u0027))"},{"line_number":439,"context_line":"            return"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        self.ports[port[\u0027port_id\u0027]][(qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH,"}],"source_content_type":"text/x-python","patch_set":19,"id":"e3de31d6_d499900a","line":438,"in_reply_to":"bb5d3af6_162006c5","updated":"2022-12-12 08:42:27.000000000","message":"Right: I\u0027m removing the limitation of the QoS plugin in the OVN driver not to accept min-BW rules for any port [1]. That means we now accept min-BW rules for ports bound to ML2/OVS, that are consumed by Placement. But the agent QoS driver can\u0027t enforce these rules on tunnelled network ports. This is why I\u0027m doing this check here.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/860639/19/neutron/services/qos/drivers/openvswitch/driver.py","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"d09135e1a9e8207b074463de80110731ca75adc4","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                      \u0027vif_port was not found. It seems that port is already \u0027"},{"line_number":433,"context_line":"                      \u0027deleted\u0027, port.get(\u0027port_id\u0027))"},{"line_number":434,"context_line":"            return"},{"line_number":435,"context_line":"        elif not port.get(\u0027physical_network\u0027):"},{"line_number":436,"context_line":"            LOG.debug(\u0027update_minimum_bandwidth was received for port %s but \u0027"},{"line_number":437,"context_line":"                      \u0027has no physical network associated\u0027,"},{"line_number":438,"context_line":"                      port.get(\u0027port_id\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"6324974d_f05b56af","line":435,"range":{"start_line":435,"start_character":8,"end_line":435,"end_character":12},"updated":"2022-12-23 17:23:18.000000000","message":"nit: if will work just fine here, no?","commit_id":"9232617f763148f389206740928b3ec7750c4a01"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fee35274345dfaa15139e5dda4fdb4f980f3f1b8","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                      \u0027vif_port was not found. It seems that port is already \u0027"},{"line_number":433,"context_line":"                      \u0027deleted\u0027, port.get(\u0027port_id\u0027))"},{"line_number":434,"context_line":"            return"},{"line_number":435,"context_line":"        elif not port.get(\u0027physical_network\u0027):"},{"line_number":436,"context_line":"            LOG.debug(\u0027update_minimum_bandwidth was received for port %s but \u0027"},{"line_number":437,"context_line":"                      \u0027has no physical network associated\u0027,"},{"line_number":438,"context_line":"                      port.get(\u0027port_id\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"b1b5148f_1524562d","line":435,"range":{"start_line":435,"start_character":8,"end_line":435,"end_character":12},"in_reply_to":"6324974d_f05b56af","updated":"2023-01-02 11:34:18.000000000","message":"yes, it will work the same","commit_id":"9232617f763148f389206740928b3ec7750c4a01"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"346769e07a173c806b198c997624c381ec597977","unresolved":true,"context_lines":[{"line_number":261,"context_line":"            # If there is no physical network this is because this is an"},{"line_number":262,"context_line":"            # overlay network (tunnelled network)."},{"line_number":263,"context_line":"            rp_tun_name \u003d cfg.CONF.ml2.tunnelled_network_rp_name"},{"line_number":264,"context_line":"            physnet_trait \u003d common_utils.tunnelled_trait(rp_tun_name)"},{"line_number":265,"context_line":"        else:"},{"line_number":266,"context_line":"            physnet_trait \u003d pl_utils.physnet_trait("},{"line_number":267,"context_line":"                first_segment.physical_network)"}],"source_content_type":"text/x-python","patch_set":12,"id":"d55710e6_06e26c0a","line":264,"range":{"start_line":264,"start_character":12,"end_line":264,"end_character":25},"updated":"2022-11-14 16:31:22.000000000","message":"This should not be called \"physnet_trait\"","commit_id":"13571abfa396bfbc8188dd92367d35fec402a831"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ffb0726981f813da660e379586755239aad1b18a","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            # If there is no physical network this is because this is an"},{"line_number":262,"context_line":"            # overlay network (tunnelled network)."},{"line_number":263,"context_line":"            rp_tun_name \u003d cfg.CONF.ml2.tunnelled_network_rp_name"},{"line_number":264,"context_line":"            physnet_trait \u003d common_utils.tunnelled_trait(rp_tun_name)"},{"line_number":265,"context_line":"        else:"},{"line_number":266,"context_line":"            physnet_trait \u003d pl_utils.physnet_trait("},{"line_number":267,"context_line":"                first_segment.physical_network)"}],"source_content_type":"text/x-python","patch_set":12,"id":"94856be4_3e64cc61","line":264,"range":{"start_line":264,"start_character":12,"end_line":264,"end_character":25},"in_reply_to":"d55710e6_06e26c0a","updated":"2022-11-25 11:51:35.000000000","message":"Done","commit_id":"13571abfa396bfbc8188dd92367d35fec402a831"}],"neutron/tests/fullstack/test_qos.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":true,"context_lines":[{"line_number":825,"context_line":"            qoses, queues \u003d self._qos_info(vm.bridge)"},{"line_number":826,"context_line":"            self.fail(queuenum + qoses + queues)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    def test_min_bw_qos_create_network_vxlan_supported(self):"},{"line_number":829,"context_line":"        qos_policy \u003d self._create_qos_policy()"},{"line_number":830,"context_line":"        qos_policy_id \u003d qos_policy[\u0027id\u0027]"},{"line_number":831,"context_line":"        self.safe_client.create_minimum_bandwidth_rule("},{"line_number":832,"context_line":"            self.tenant_id, qos_policy_id, MIN_BANDWIDTH, self.direction)"},{"line_number":833,"context_line":"        network_args \u003d {\u0027network_type\u0027: \u0027vxlan\u0027,"},{"line_number":834,"context_line":"                        \u0027qos_policy_id\u0027: qos_policy_id}"},{"line_number":835,"context_line":"        net \u003d self.safe_client.create_network("},{"line_number":836,"context_line":"            self.tenant_id, name\u003d\u0027network-test\u0027, **network_args)"},{"line_number":837,"context_line":"        self.assertEqual(qos_policy_id, net[\u0027qos_policy_id\u0027])"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def test_min_bw_qos_update_network_vxlan_supported(self):"},{"line_number":840,"context_line":"        network_args \u003d {\u0027network_type\u0027: \u0027vxlan\u0027}"}],"source_content_type":"text/x-python","patch_set":19,"id":"6820b0f3_4ce5f7ac","line":837,"range":{"start_line":828,"start_character":4,"end_line":837,"end_character":61},"updated":"2022-12-07 11:53:47.000000000","message":"I don\u0027t think we still need that test really","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c706944526437ff651a04c42150e8e9e30d48a4","unresolved":false,"context_lines":[{"line_number":825,"context_line":"            qoses, queues \u003d self._qos_info(vm.bridge)"},{"line_number":826,"context_line":"            self.fail(queuenum + qoses + queues)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    def test_min_bw_qos_create_network_vxlan_supported(self):"},{"line_number":829,"context_line":"        qos_policy \u003d self._create_qos_policy()"},{"line_number":830,"context_line":"        qos_policy_id \u003d qos_policy[\u0027id\u0027]"},{"line_number":831,"context_line":"        self.safe_client.create_minimum_bandwidth_rule("},{"line_number":832,"context_line":"            self.tenant_id, qos_policy_id, MIN_BANDWIDTH, self.direction)"},{"line_number":833,"context_line":"        network_args \u003d {\u0027network_type\u0027: \u0027vxlan\u0027,"},{"line_number":834,"context_line":"                        \u0027qos_policy_id\u0027: qos_policy_id}"},{"line_number":835,"context_line":"        net \u003d self.safe_client.create_network("},{"line_number":836,"context_line":"            self.tenant_id, name\u003d\u0027network-test\u0027, **network_args)"},{"line_number":837,"context_line":"        self.assertEqual(qos_policy_id, net[\u0027qos_policy_id\u0027])"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def test_min_bw_qos_update_network_vxlan_supported(self):"},{"line_number":840,"context_line":"        network_args \u003d {\u0027network_type\u0027: \u0027vxlan\u0027}"}],"source_content_type":"text/x-python","patch_set":19,"id":"7210d47c_99172d24","line":837,"range":{"start_line":828,"start_character":4,"end_line":837,"end_character":61},"in_reply_to":"6820b0f3_4ce5f7ac","updated":"2022-12-12 08:42:27.000000000","message":"It is related to [1], now we are removing the limitation to create and update min-BW rules for ports bound to OVS.\n\nBut this is more an API test but needs explicitly the OVS driver of the QoS plugin. I\u0027ll merge both test in one to save testing time but I think those tests are relevant.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/860639/19/neutron/services/qos/drivers/openvswitch/driver.py","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":true,"context_lines":[{"line_number":836,"context_line":"            self.tenant_id, name\u003d\u0027network-test\u0027, **network_args)"},{"line_number":837,"context_line":"        self.assertEqual(qos_policy_id, net[\u0027qos_policy_id\u0027])"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def test_min_bw_qos_update_network_vxlan_supported(self):"},{"line_number":840,"context_line":"        network_args \u003d {\u0027network_type\u0027: \u0027vxlan\u0027}"},{"line_number":841,"context_line":"        network \u003d self.safe_client.create_network("},{"line_number":842,"context_line":"            self.tenant_id, name\u003d\u0027network-test\u0027, **network_args)"}],"source_content_type":"text/x-python","patch_set":19,"id":"d2e9e914_ac1c1d9a","line":839,"updated":"2022-12-07 11:53:47.000000000","message":"same for this one","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c706944526437ff651a04c42150e8e9e30d48a4","unresolved":false,"context_lines":[{"line_number":836,"context_line":"            self.tenant_id, name\u003d\u0027network-test\u0027, **network_args)"},{"line_number":837,"context_line":"        self.assertEqual(qos_policy_id, net[\u0027qos_policy_id\u0027])"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def test_min_bw_qos_update_network_vxlan_supported(self):"},{"line_number":840,"context_line":"        network_args \u003d {\u0027network_type\u0027: \u0027vxlan\u0027}"},{"line_number":841,"context_line":"        network \u003d self.safe_client.create_network("},{"line_number":842,"context_line":"            self.tenant_id, name\u003d\u0027network-test\u0027, **network_args)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9b995856_3ccbaf0f","line":839,"in_reply_to":"d2e9e914_ac1c1d9a","updated":"2022-12-12 08:42:27.000000000","message":"ditto","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"}],"releasenotes/notes/qos-minimum-bw-tunnelled-networks-8064d6f21f7d9267.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58fc0cc2dd96fae25c380cdcbf00887369d5f0d8","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    (add something coherent...)"},{"line_number":5,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":19,"id":"373b5f9d_b5937a8b","line":5,"updated":"2022-12-07 11:53:47.000000000","message":"I think You will need to update this release note 😄","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c706944526437ff651a04c42150e8e9e30d48a4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    (add something coherent...)"},{"line_number":5,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":19,"id":"79623a6d_22c228aa","line":5,"in_reply_to":"373b5f9d_b5937a8b","updated":"2022-12-12 08:42:27.000000000","message":"Right!","commit_id":"9f958da6340b3a1125696d5c573706db1d453a65"}]}