)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"68b3de1eaf6f361de9b4a229cc649c7e0a3dbb05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f644acb_8575232b","updated":"2022-10-11 03:48:19.000000000","message":"Code looks good to me, but it\u0027s better to add some unit test cases, or fullstack case to simulate events on a real running ovs-agent test process.","commit_id":"ccc13d6d143ad1072b35f381f25b3a15d3862e42"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"4f32b7d6b846d1a45da8985358fd1f2561b1c3e7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7fbb67f0_5a235a3a","in_reply_to":"3f644acb_8575232b","updated":"2022-10-18 14:59:54.000000000","message":"ack, will try to work on that","commit_id":"ccc13d6d143ad1072b35f381f25b3a15d3862e42"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"27c518f2336e3f74114129af9b27d536b1e5ecca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4eb06208_5f9495cc","in_reply_to":"7fbb67f0_5a235a3a","updated":"2022-12-05 09:35:56.000000000","message":"I added a unit test.\nAbout the fullstack tests, I have no idea on how to achieve that unfortunately.","commit_id":"ccc13d6d143ad1072b35f381f25b3a15d3862e42"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"ae9728f6fac9c6fa394e1446dfbbd52a69ffc9e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37677120_a447e236","updated":"2022-11-07 16:44:36.000000000","message":"Ack, I will do, I dont have enough time atm","commit_id":"0dae74097d385cd755ea9e7f1966ecb8ddd8e84c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ccb5a112419804149eae52c100aa25c0ef0fab25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3e31c53_39507a83","updated":"2022-11-02 11:39:17.000000000","message":"Hi Arnaud, as commented by Lajos and Liu, more test coverage is needed in this patch.","commit_id":"0dae74097d385cd755ea9e7f1966ecb8ddd8e84c"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"488259e918cabc9cb4d10f77bc565240c320f556","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7cc902bf_481e31a9","updated":"2023-01-03 15:05:22.000000000","message":"Hey team, \nI\u0027d like you to reconsider this patch with the unit test.\n\nI cant find an easy solution to reproduce this in fullstack, and I dont think it\u0027s needed anyway.\n\nAs stated in the commit message, a port with ofport\u003d-1 should not be considered as updated, and should be discarded until removal.","commit_id":"f22aa5dfddae9bd31fbb4fca8aed176e9913d34a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a31e2c8dcb095b5f115e4d2d7b22f3ac347c9b16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ace57b3_a2b6b533","updated":"2023-01-09 04:57:57.000000000","message":"OK, let\u0027s merge this first, fullstack case can be added as a separated patch if it is possible someday.","commit_id":"f22aa5dfddae9bd31fbb4fca8aed176e9913d34a"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c484c96fbdb8e9cdd0d37feeb71a31d90b929e44","unresolved":true,"context_lines":[{"line_number":1686,"context_line":"                continue"},{"line_number":1687,"context_line":"            current_ofport \u003d current[name]"},{"line_number":1688,"context_line":"            # Discarding port that disappeared from ovs"},{"line_number":1689,"context_line":"            if current_ofport \u003d\u003d -1:"},{"line_number":1690,"context_line":"                continue"},{"line_number":1691,"context_line":"            if ofport !\u003d current_ofport:"},{"line_number":1692,"context_line":"                port_moves.append(name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1caf46a5_8848b07d","line":1689,"range":{"start_line":1689,"start_character":33,"end_line":1689,"end_character":35},"updated":"2022-10-07 13:41:56.000000000","message":"there is INVALID_OFPORT constant for that","commit_id":"ccc13d6d143ad1072b35f381f25b3a15d3862e42"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d9219c2db9d03cc298c6fdb2357c9d45dfa3961a","unresolved":true,"context_lines":[{"line_number":1686,"context_line":"                continue"},{"line_number":1687,"context_line":"            current_ofport \u003d current[name]"},{"line_number":1688,"context_line":"            # Discarding port that disappeared from ovs"},{"line_number":1689,"context_line":"            if current_ofport \u003d\u003d -1:"},{"line_number":1690,"context_line":"                continue"},{"line_number":1691,"context_line":"            if ofport !\u003d current_ofport:"},{"line_number":1692,"context_line":"                port_moves.append(name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"48653982_bcd4f9ed","line":1689,"range":{"start_line":1689,"start_character":33,"end_line":1689,"end_character":35},"in_reply_to":"1caf46a5_8848b07d","updated":"2022-10-14 08:09:13.000000000","message":"+1\nhttps://opendev.org/openstack/neutron/src/branch/master/neutron/agent/common/ovs_lib.py#L52","commit_id":"ccc13d6d143ad1072b35f381f25b3a15d3862e42"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"4f32b7d6b846d1a45da8985358fd1f2561b1c3e7","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"                continue"},{"line_number":1687,"context_line":"            current_ofport \u003d current[name]"},{"line_number":1688,"context_line":"            # Discarding port that disappeared from ovs"},{"line_number":1689,"context_line":"            if current_ofport \u003d\u003d -1:"},{"line_number":1690,"context_line":"                continue"},{"line_number":1691,"context_line":"            if ofport !\u003d current_ofport:"},{"line_number":1692,"context_line":"                port_moves.append(name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffed4a85_880a3bf2","line":1689,"range":{"start_line":1689,"start_character":33,"end_line":1689,"end_character":35},"in_reply_to":"48653982_bcd4f9ed","updated":"2022-10-18 14:59:54.000000000","message":"Done","commit_id":"ccc13d6d143ad1072b35f381f25b3a15d3862e42"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"14b8f13c7b8c5fafa6a6bf265b278dd0eca2081d","unresolved":true,"context_lines":[{"line_number":2511,"context_line":"        expected \u003d [\u0027port1\u0027]"},{"line_number":2512,"context_line":"        self.assertEqual(expected,"},{"line_number":2513,"context_line":"                         self.agent._get_ofport_moves(current, previous))"},{"line_number":2514,"context_line":""},{"line_number":2515,"context_line":"    def test_update_stale_ofport_rules_clears_old(self):"},{"line_number":2516,"context_line":"        self.agent.prevent_arp_spoofing \u003d True"},{"line_number":2517,"context_line":"        self.agent.vifname_to_ofport_map \u003d {\u0027port1\u0027: 1, \u0027port2\u0027: 2}"}],"source_content_type":"text/x-python","patch_set":2,"id":"2430bae5_b8ba39a3","line":2514,"updated":"2022-10-25 09:00:22.000000000","message":"Could you please add some basic test to cover this case?\nThe following ~3 tests also a good candidate to check.","commit_id":"0dae74097d385cd755ea9e7f1966ecb8ddd8e84c"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"27c518f2336e3f74114129af9b27d536b1e5ecca","unresolved":false,"context_lines":[{"line_number":2511,"context_line":"        expected \u003d [\u0027port1\u0027]"},{"line_number":2512,"context_line":"        self.assertEqual(expected,"},{"line_number":2513,"context_line":"                         self.agent._get_ofport_moves(current, previous))"},{"line_number":2514,"context_line":""},{"line_number":2515,"context_line":"    def test_update_stale_ofport_rules_clears_old(self):"},{"line_number":2516,"context_line":"        self.agent.prevent_arp_spoofing \u003d True"},{"line_number":2517,"context_line":"        self.agent.vifname_to_ofport_map \u003d {\u0027port1\u0027: 1, \u0027port2\u0027: 2}"}],"source_content_type":"text/x-python","patch_set":2,"id":"4086b3e4_44182fd0","line":2514,"in_reply_to":"2430bae5_b8ba39a3","updated":"2022-12-05 09:35:56.000000000","message":"Done","commit_id":"0dae74097d385cd755ea9e7f1966ecb8ddd8e84c"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"27c518f2336e3f74114129af9b27d536b1e5ecca","unresolved":false,"context_lines":[{"line_number":2511,"context_line":"        expected \u003d [\u0027port1\u0027]"},{"line_number":2512,"context_line":"        self.assertEqual(expected,"},{"line_number":2513,"context_line":"                         self.agent._get_ofport_moves(current, previous))"},{"line_number":2514,"context_line":""},{"line_number":2515,"context_line":"    def test_update_stale_ofport_rules_clears_old(self):"},{"line_number":2516,"context_line":"        self.agent.prevent_arp_spoofing \u003d True"},{"line_number":2517,"context_line":"        self.agent.vifname_to_ofport_map \u003d {\u0027port1\u0027: 1, \u0027port2\u0027: 2}"}],"source_content_type":"text/x-python","patch_set":2,"id":"330395b1_84311d39","line":2514,"in_reply_to":"2430bae5_b8ba39a3","updated":"2022-12-05 09:35:56.000000000","message":"I added a small unit test.\nLet me know if you think it is enough","commit_id":"0dae74097d385cd755ea9e7f1966ecb8ddd8e84c"}]}