)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b340f6dba2e4aa23fc947af9f91a22148240d602","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49bbfbb5_9a372e7c","updated":"2022-10-14 10:53:33.000000000","message":"It makes sense. However it could be useful (but I don\u0027t know if possible) to have a neutron-tempest-plugin test checking that.","commit_id":"c33b47edc77520abcdd7176af1f0ae921bd489b3"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c4389b809eacff047d35cbfed66791b6f23b0c97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2bf9a75d_4eb6d31c","updated":"2022-10-14 14:29:22.000000000","message":"_get_dvr_hosts_for_router - kind of assumes that it returns all hosts including dvr_snat ones where router GW is placed, at least naming should be fixed. Sorry if I misunderstood something","commit_id":"c33b47edc77520abcdd7176af1f0ae921bd489b3"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"bf889f5248f7a4b30363c368821c8bc5101c319f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69426e9c_a0a6093d","updated":"2022-10-14 14:27:22.000000000","message":"sorry, I don\u0027t quite get it - isn\u0027t there a case when we need to update exactly gateway node on router update?","commit_id":"c33b47edc77520abcdd7176af1f0ae921bd489b3"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"96bcd1eeb089584e7bb9d810ec605c8fdbec76fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e2e6388d_86b9fc30","in_reply_to":"2bf9a75d_4eb6d31c","updated":"2022-10-18 14:55:39.000000000","message":"Hello,\n\nit will include the snat hosts because the in subnet_ids you will have the \"HA network tenant\" that is used by keepalived to do VRRP.","commit_id":"c33b47edc77520abcdd7176af1f0ae921bd489b3"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"96bcd1eeb089584e7bb9d810ec605c8fdbec76fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c177f3d_fc8fe0ac","in_reply_to":"69426e9c_a0a6093d","updated":"2022-10-18 14:55:39.000000000","message":"I dont think so","commit_id":"c33b47edc77520abcdd7176af1f0ae921bd489b3"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"bece39926a01db31561fa2a3522b3c92099a7189","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eae0457c_dbdd4c91","in_reply_to":"e2e6388d_86b9fc30","updated":"2022-10-18 15:02:35.000000000","message":"What about pure DVR routers (non-HA)?","commit_id":"c33b47edc77520abcdd7176af1f0ae921bd489b3"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"475081caef141b42a1f06de71849151b52118b86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"30fcb0fb_56c0cf39","in_reply_to":"eae0457c_dbdd4c91","updated":"2022-10-18 21:50:51.000000000","message":"That\u0027s a good point.\nThe agents hosting the router are retrieved from get_hosts_to_notify (see [1])\nno matter if they are HA or not, so they are notified in both cases.\n\n\n[1] https://github.com/openstack/neutron/blob/430abde13ec58e611a8752ca579fee5110a0a61d/neutron/db/l3_agentschedulers_db.py#L503","commit_id":"c33b47edc77520abcdd7176af1f0ae921bd489b3"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"435655daa86de6043218c7ae7046c7c3aaf6745b","unresolved":true,"context_lines":[{"line_number":342,"context_line":"                context, router_id))"},{"line_number":343,"context_line":"        for dvr_router in connected_dvr_routers:"},{"line_number":344,"context_line":"            dvr_hosts |\u003d set("},{"line_number":345,"context_line":"                self._get_dvr_hosts_for_router(context, dvr_router))"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        LOG.debug(\u0027Hosts for other DVR routers connected to router \u0027"},{"line_number":348,"context_line":"                  \u0027%(router_id)s: %(dvr_hosts)s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"05250b4f_5e184832","line":345,"range":{"start_line":345,"start_character":16,"end_line":345,"end_character":68},"updated":"2022-10-19 05:59:15.000000000","message":"Ok, seems this is where it makes difference in the case described in the bug.","commit_id":"c33b47edc77520abcdd7176af1f0ae921bd489b3"}]}