)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"215cd1ff1048b9661a4dd362e435c84ae8ef1f5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"935cc1c8_4ea6c4c9","updated":"2022-10-17 19:01:37.000000000","message":"Good job!","commit_id":"f43891bf866b65ceef0e51633afbbf57ee2a6be8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7c8369b79a23b2cedb870c8fe1627c6df05d0d7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5792830e_3ab6ea27","updated":"2022-10-18 08:37:17.000000000","message":"Would be good to also document this behavior, otherwise this will be a \"hidden\" feature that nobody will know about.\n\nIt can be another patch on top of this.","commit_id":"f43891bf866b65ceef0e51633afbbf57ee2a6be8"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"855aa9a74b185505114aa19f231b1faeb45c2ead","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"679d39bb_5526ecec","in_reply_to":"5792830e_3ab6ea27","updated":"2022-10-18 08:50:26.000000000","message":"+1 and it would allow to detail the use case, is this only recommended for larger scale deployments - and keeping 2 as default value?","commit_id":"f43891bf866b65ceef0e51633afbbf57ee2a6be8"}],"neutron/agent/ovn/metadata/server.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"215cd1ff1048b9661a4dd362e435c84ae8ef1f5d","unresolved":true,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class UnixDomainMetadataProxy(object):"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def __init__(self, conf, chassis, sb_idl\u003dNone):"},{"line_number":197,"context_line":"        self.conf \u003d conf"},{"line_number":198,"context_line":"        self.chassis \u003d chassis"},{"line_number":199,"context_line":"        self.sb_idl \u003d sb_idl"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af600a3_32f2a8ce","line":196,"range":{"start_line":196,"start_character":44,"end_line":196,"end_character":49},"updated":"2022-10-17 19:01:37.000000000","message":"It seems we always pass a parameter, don\u0027t we?","commit_id":"f43891bf866b65ceef0e51633afbbf57ee2a6be8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bd9f28aafa05e9d5c408c25fe74cab0665e10ac9","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class UnixDomainMetadataProxy(object):"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def __init__(self, conf, chassis, sb_idl\u003dNone):"},{"line_number":197,"context_line":"        self.conf \u003d conf"},{"line_number":198,"context_line":"        self.chassis \u003d chassis"},{"line_number":199,"context_line":"        self.sb_idl \u003d sb_idl"}],"source_content_type":"text/x-python","patch_set":2,"id":"688a00ec_dc8ffb04","line":196,"range":{"start_line":196,"start_character":44,"end_line":196,"end_character":49},"in_reply_to":"7af600a3_32f2a8ce","updated":"2022-10-18 07:13:59.000000000","message":"That was basically for the tests. That avoids rewriting several UTs","commit_id":"f43891bf866b65ceef0e51633afbbf57ee2a6be8"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"215cd1ff1048b9661a4dd362e435c84ae8ef1f5d","unresolved":true,"context_lines":[{"line_number":225,"context_line":"        md_workers \u003d self.conf.metadata_workers"},{"line_number":226,"context_line":"        if md_workers is None:"},{"line_number":227,"context_line":"            md_workers \u003d 2"},{"line_number":228,"context_line":"        sb_idl \u003d self.sb_idl if md_workers \u003d\u003d 0 else None"},{"line_number":229,"context_line":"        self.server.start(MetadataProxyHandler(self.conf, self.chassis,"},{"line_number":230,"context_line":"                                               sb_idl),"},{"line_number":231,"context_line":"                          self.conf.metadata_proxy_socket,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0737f0b8_f1d94989","line":228,"range":{"start_line":228,"start_character":32,"end_line":228,"end_character":42},"updated":"2022-10-17 19:01:37.000000000","message":"Maybe not strictly needed in this patch but shall we re-consider the default to be 0?","commit_id":"f43891bf866b65ceef0e51633afbbf57ee2a6be8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bd9f28aafa05e9d5c408c25fe74cab0665e10ac9","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        md_workers \u003d self.conf.metadata_workers"},{"line_number":226,"context_line":"        if md_workers is None:"},{"line_number":227,"context_line":"            md_workers \u003d 2"},{"line_number":228,"context_line":"        sb_idl \u003d self.sb_idl if md_workers \u003d\u003d 0 else None"},{"line_number":229,"context_line":"        self.server.start(MetadataProxyHandler(self.conf, self.chassis,"},{"line_number":230,"context_line":"                                               sb_idl),"},{"line_number":231,"context_line":"                          self.conf.metadata_proxy_socket,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fcb9ee12_d92b4acb","line":228,"range":{"start_line":228,"start_character":32,"end_line":228,"end_character":42},"in_reply_to":"0737f0b8_f1d94989","updated":"2022-10-18 07:13:59.000000000","message":"I\u0027ll push a follow-up patch changing the default OVN metadata workers value and a release note.","commit_id":"f43891bf866b65ceef0e51633afbbf57ee2a6be8"}]}