)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0a07aa3e522ed55b75d21e447b114dbc47a6f817","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luca Czesla \u003cluca.czesla@mail.schwarz\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-10-18 13:34:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the address scope to the OVN DBs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For the ovn-bgp-agent we need the address scope from the"},{"line_number":10,"context_line":"subnetpool in the OVN DBs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2fec0428_84aa973b","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":36},"updated":"2022-11-17 09:30:57.000000000","message":"\"to the LSP port register\" to be more specific","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"a83a7c452bfceef202264da7d8c93aba3cd6a13b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Luca Czesla \u003cluca.czesla@mail.schwarz\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-10-18 13:34:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the address scope to the OVN DBs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For the ovn-bgp-agent we need the address scope from the"},{"line_number":10,"context_line":"subnetpool in the OVN DBs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b9c591db_76073d47","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":36},"in_reply_to":"2fec0428_84aa973b","updated":"2022-11-22 10:53:26.000000000","message":"Changed it. Thanks.","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0a07aa3e522ed55b75d21e447b114dbc47a6f817","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add the address scope to the OVN DBs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For the ovn-bgp-agent we need the address scope from the"},{"line_number":10,"context_line":"subnetpool in the OVN DBs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieb4cab11068747bd79868c6eb1778aab91447c30"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f806fe3e_1a12f476","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":26},"updated":"2022-11-17 09:30:57.000000000","message":"Is it possible to describe why is this needed in 3-4 lines?","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"2d173ff390f5197479ac0d35e3516aa77b101b76","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add the address scope to the OVN DBs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For the ovn-bgp-agent we need the address scope from the"},{"line_number":10,"context_line":"subnetpool in the OVN DBs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieb4cab11068747bd79868c6eb1778aab91447c30"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"41f24fb5_878ce469","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":26},"in_reply_to":"47445b55_d7f84a56","updated":"2022-11-24 10:07:53.000000000","message":"Done","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"a83a7c452bfceef202264da7d8c93aba3cd6a13b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add the address scope to the OVN DBs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For the ovn-bgp-agent we need the address scope from the"},{"line_number":10,"context_line":"subnetpool in the OVN DBs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieb4cab11068747bd79868c6eb1778aab91447c30"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"47445b55_d7f84a56","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":26},"in_reply_to":"f806fe3e_1a12f476","updated":"2022-11-22 10:53:26.000000000","message":"Sure. I have extended the commit message with some information. Does it fit like this?","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"eb3fe8df8e728d8afa46b656216ce37f42cd5d00","unresolved":true,"context_lines":[{"line_number":12,"context_line":"southbound so the ovn-bgp-agent has access to it. The"},{"line_number":13,"context_line":"ovn-bgp-agent talks directly to the southbound to announce"},{"line_number":14,"context_line":"the networks via BGP that match the configured address scope."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ieb4cab11068747bd79868c6eb1778aab91447c30"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"87019f27_ba3a2a66","line":15,"updated":"2022-11-22 22:34:55.000000000","message":"Please refer to the RFE here:\n\nCloses-Bug: #1996741","commit_id":"740d21a849197710843c268420575dc326a3e33a"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"2d173ff390f5197479ac0d35e3516aa77b101b76","unresolved":false,"context_lines":[{"line_number":12,"context_line":"southbound so the ovn-bgp-agent has access to it. The"},{"line_number":13,"context_line":"ovn-bgp-agent talks directly to the southbound to announce"},{"line_number":14,"context_line":"the networks via BGP that match the configured address scope."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ieb4cab11068747bd79868c6eb1778aab91447c30"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"18b79a78_7f9a8375","line":15,"in_reply_to":"87019f27_ba3a2a66","updated":"2022-11-24 10:07:53.000000000","message":"Done. Thank you","commit_id":"740d21a849197710843c268420575dc326a3e33a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"b19e44e6fad8bb3ad875a49ef88bde1efca298f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90a1118e_edd19dbf","updated":"2022-10-18 13:15:36.000000000","message":"Thanks for this Luca. I guess that one potential thing missing here is to add external ids to existing resources from a maintenance task.\n\nExample:\nhttps://opendev.org/openstack/neutron/src/branch/master/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py#L510\n\nAlso, there\u0027s pep8 errors that Zuul pointed out:)\n\nThanks again!!","commit_id":"864a7b80ba3f98e2f2baf8094566820a32cd3254"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"e4e9288e90b31fed87fc5b4d405283b2d36b333e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a073bc7d_69a528cd","in_reply_to":"90a1118e_edd19dbf","updated":"2022-10-18 14:05:19.000000000","message":"I\u0027ve been thinking about that, too. Thanks for the nudge in the right direction. I will take a look at it.\n\nThanks for the feedback.","commit_id":"864a7b80ba3f98e2f2baf8094566820a32cd3254"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"92bb25c0fff156711f54823553227a546f9e60c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a3736c2_1460a5a9","updated":"2022-10-20 07:30:14.000000000","message":"Do you have a bug or more an RFE for this issue?","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0a07aa3e522ed55b75d21e447b114dbc47a6f817","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0adc2b7_2af4f10e","in_reply_to":"1a3736c2_1460a5a9","updated":"2022-11-17 09:30:57.000000000","message":"+1","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"99674222b55953129d886e172ec0ba69113e772a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3df49e83_45497341","in_reply_to":"e0adc2b7_2af4f10e","updated":"2022-11-17 09:31:24.000000000","message":"https://bugs.launchpad.net/neutron/+bug/1996741","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"eb3fe8df8e728d8afa46b656216ce37f42cd5d00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3db79eea_97256a0d","updated":"2022-11-22 22:34:55.000000000","message":"Can you add some sort of documentation and release note?","commit_id":"740d21a849197710843c268420575dc326a3e33a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cc729a1e0399cf100803f136329edd004c9e82d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b0bc12a0_1d7c979a","updated":"2022-11-23 09:38:20.000000000","message":"Please add the reference bug:\n\nCloses-Bug: #1996741","commit_id":"740d21a849197710843c268420575dc326a3e33a"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"2d173ff390f5197479ac0d35e3516aa77b101b76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"65b82979_2c16ae14","in_reply_to":"3db79eea_97256a0d","updated":"2022-11-24 10:07:53.000000000","message":"I have added the release notes. Not sure what is needed as documentation. Thank you.","commit_id":"740d21a849197710843c268420575dc326a3e33a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"54a4d2fd80b1be767dc68dfad40449fc4fa1f15c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"67da1f40_23e4257a","updated":"2022-11-25 07:32:23.000000000","message":"LGTM (left one supernit)","commit_id":"e199eb7a0bff6e15b34bdfbfc6ab82fd386294d4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2946be6ff6217b50e804c1fe1a25d1bcda7345d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c70f8220_74a52301","updated":"2022-11-24 10:18:58.000000000","message":"Looks OK, +2 and waiting for the CI","commit_id":"e199eb7a0bff6e15b34bdfbfc6ab82fd386294d4"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"7b25fc8e29a8b6f60abe06f6c0395d24b64dbad8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b58d342_d5795f23","in_reply_to":"c70f8220_74a52301","updated":"2022-11-24 14:08:25.000000000","message":"Cool, thanks for your help.","commit_id":"e199eb7a0bff6e15b34bdfbfc6ab82fd386294d4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3c252f739211d19558ac28be6b56bfeae3c933bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a4e78c5d_6a74b66a","updated":"2022-12-02 13:16:17.000000000","message":"recheck\n\nBoth failures looks unrelated to the changes","commit_id":"2272b9be9515553c41a791b7c7b518696c4a2ebb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2a0fb2f5e8570bbf2107e2592b51f12118e3ae70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6161861f_42f784ca","updated":"2022-12-02 17:18:06.000000000","message":"recheck fullstack issue fix merged","commit_id":"2272b9be9515553c41a791b7c7b518696c4a2ebb"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4748bd43da2936bd19d3e958bf3af79ec78f5e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2225ed21_9563da5f","updated":"2022-12-07 09:19:08.000000000","message":"recheck unrelated errors","commit_id":"2272b9be9515553c41a791b7c7b518696c4a2ebb"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cc729a1e0399cf100803f136329edd004c9e82d0","unresolved":true,"context_lines":[{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        raise periodics.NeverAgain()"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":530,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":531,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":532,"context_line":"    def check_port_has_address_scope(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"84af0d7f_5187d63c","line":529,"range":{"start_line":529,"start_character":4,"end_line":529,"end_character":72},"updated":"2022-11-23 09:38:20.000000000","message":"Because you are adding this new fields in the ovn_client, this task could could removed in some releases. Please add a comment here, something like:\n\n# TODO(your_nick): Remove this in the A+4 cycle","commit_id":"740d21a849197710843c268420575dc326a3e33a"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"2d173ff390f5197479ac0d35e3516aa77b101b76","unresolved":false,"context_lines":[{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        raise periodics.NeverAgain()"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":530,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":531,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":532,"context_line":"    def check_port_has_address_scope(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"21ebf878_13ecbd1d","line":529,"range":{"start_line":529,"start_character":4,"end_line":529,"end_character":72},"in_reply_to":"84af0d7f_5187d63c","updated":"2022-11-24 10:07:53.000000000","message":"I added it. Thanks","commit_id":"740d21a849197710843c268420575dc326a3e33a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"54a4d2fd80b1be767dc68dfad40449fc4fa1f15c","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                            context, port.name"},{"line_number":555,"context_line":"                        )"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"                        port_info, external_ids \u003d \\"},{"line_number":558,"context_line":"                            self._ovn_client.get_external_ids_from_port("},{"line_number":559,"context_line":"                                port_neutron"},{"line_number":560,"context_line":"                            )"}],"source_content_type":"text/x-python","patch_set":5,"id":"52912933_6b57afde","line":557,"range":{"start_line":557,"start_character":49,"end_line":557,"end_character":51},"updated":"2022-11-25 07:32:23.000000000","message":"I think using () is preferred over \"\\\"","commit_id":"e199eb7a0bff6e15b34bdfbfc6ab82fd386294d4"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"c3fe097870dd912c12f6bbaa2d27a49ccd07856b","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                            context, port.name"},{"line_number":555,"context_line":"                        )"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"                        port_info, external_ids \u003d \\"},{"line_number":558,"context_line":"                            self._ovn_client.get_external_ids_from_port("},{"line_number":559,"context_line":"                                port_neutron"},{"line_number":560,"context_line":"                            )"}],"source_content_type":"text/x-python","patch_set":5,"id":"f882da97_3d3918af","line":557,"range":{"start_line":557,"start_character":49,"end_line":557,"end_character":51},"in_reply_to":"52912933_6b57afde","updated":"2022-11-25 07:50:57.000000000","message":"Changed. Thanks","commit_id":"e199eb7a0bff6e15b34bdfbfc6ab82fd386294d4"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"b19e44e6fad8bb3ad875a49ef88bde1efca298f4","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        \"device_owner\","},{"line_number":73,"context_line":"        \"security_group_ids\","},{"line_number":74,"context_line":"        \"address4_scope_id\","},{"line_number":75,"context_line":"        \"address6_scope_id\","},{"line_number":76,"context_line":"    ],"},{"line_number":77,"context_line":")"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c272d969_59162c84","line":75,"range":{"start_line":75,"start_character":27,"end_line":75,"end_character":28},"updated":"2022-10-18 13:15:36.000000000","message":"I think this comma is not needed?","commit_id":"864a7b80ba3f98e2f2baf8094566820a32cd3254"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"e4e9288e90b31fed87fc5b4d405283b2d36b333e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"device_owner\","},{"line_number":73,"context_line":"        \"security_group_ids\","},{"line_number":74,"context_line":"        \"address4_scope_id\","},{"line_number":75,"context_line":"        \"address6_scope_id\","},{"line_number":76,"context_line":"    ],"},{"line_number":77,"context_line":")"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1e3e0820_a71e7bbc","line":75,"range":{"start_line":75,"start_character":27,"end_line":75,"end_character":28},"in_reply_to":"c272d969_59162c84","updated":"2022-10-18 14:05:19.000000000","message":"Done","commit_id":"864a7b80ba3f98e2f2baf8094566820a32cd3254"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0a07aa3e522ed55b75d21e447b114dbc47a6f817","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        \"device_owner\","},{"line_number":73,"context_line":"        \"security_group_ids\","},{"line_number":74,"context_line":"        \"address4_scope_id\","},{"line_number":75,"context_line":"        \"address6_scope_id\""},{"line_number":76,"context_line":"    ],"},{"line_number":77,"context_line":")"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7032528b_54bf6aa0","line":75,"range":{"start_line":75,"start_character":25,"end_line":75,"end_character":27},"updated":"2022-11-17 09:30:57.000000000","message":"Please add a comma here, now you have split all parameters. That will preserve the git history in future commits.","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"a83a7c452bfceef202264da7d8c93aba3cd6a13b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"device_owner\","},{"line_number":73,"context_line":"        \"security_group_ids\","},{"line_number":74,"context_line":"        \"address4_scope_id\","},{"line_number":75,"context_line":"        \"address6_scope_id\""},{"line_number":76,"context_line":"    ],"},{"line_number":77,"context_line":")"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4f07b6f0_11777bb8","line":75,"range":{"start_line":75,"start_character":25,"end_line":75,"end_character":27},"in_reply_to":"7032528b_54bf6aa0","updated":"2022-11-22 10:53:26.000000000","message":"Thanks. Done.","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e75833373d05701834204cdc300e3a8e71d73e0c","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                        continue"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"                    if subnet[\"subnetpool_id\"]:"},{"line_number":326,"context_line":"                        subnet_pool \u003d self._plugin.get_subnetpool("},{"line_number":327,"context_line":"                            context, id\u003dsubnet[\"subnetpool_id\"]"},{"line_number":328,"context_line":"                        )"},{"line_number":329,"context_line":"                        if subnet_pool[\"address_scope_id\"]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3516aac5_2ac852d3","line":326,"updated":"2022-11-16 15:47:51.000000000","message":"This call could raise SubnetPoolNotFound() potentially looking at _get_subnetpool() code, so might want to catch it. Not sure if you should continue or just not populate the info though.","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"e0d01857daae72e6aef2d26c9bbdf97b3399a085","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                        continue"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"                    if subnet[\"subnetpool_id\"]:"},{"line_number":326,"context_line":"                        subnet_pool \u003d self._plugin.get_subnetpool("},{"line_number":327,"context_line":"                            context, id\u003dsubnet[\"subnetpool_id\"]"},{"line_number":328,"context_line":"                        )"},{"line_number":329,"context_line":"                        if subnet_pool[\"address_scope_id\"]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"711dc417_45748886","line":326,"in_reply_to":"0fa9e62e_2d2031fc","updated":"2022-11-22 11:00:29.000000000","message":"Done","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"},{"author":{"_account_id":35408,"name":"Luca Czesla","email":"luca.czesla@mail.schwarz","username":"czesla"},"change_message_id":"a83a7c452bfceef202264da7d8c93aba3cd6a13b","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                        continue"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"                    if subnet[\"subnetpool_id\"]:"},{"line_number":326,"context_line":"                        subnet_pool \u003d self._plugin.get_subnetpool("},{"line_number":327,"context_line":"                            context, id\u003dsubnet[\"subnetpool_id\"]"},{"line_number":328,"context_line":"                        )"},{"line_number":329,"context_line":"                        if subnet_pool[\"address_scope_id\"]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"0fa9e62e_2d2031fc","line":326,"in_reply_to":"3516aac5_2ac852d3","updated":"2022-11-22 10:53:26.000000000","message":"Thank you. I caught the exception.","commit_id":"56966ff395ac7b648f0ef4661d7748b99eac3f38"}]}
