)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dd7560644b440e65855f05002c5298ac43eff652","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"02bd3840_417ae927","updated":"2022-11-17 11:32:37.000000000","message":"Hi folks. Thanks for the positive reviews. However the feedback from Roberto is something to consider. In this patch we should also add a check for the existing routers. \n\nI\u0027ll remove the +2 votes to continue working on it.","commit_id":"76b2cf2afd9f6ebd4b7558a19096a58af152acec"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"56a664e5a883e3ff57615bf74de99b16144e991d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b18bfa61_3d45d0ff","updated":"2022-11-16 18:33:42.000000000","message":"Thanks, this patch works for the OVN case. But what about SQL DB migration for routers already created? Will alembic migration file be provided for DBs already in use with OpenStack yoga?","commit_id":"76b2cf2afd9f6ebd4b7558a19096a58af152acec"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"64cd716cc5ea293dd61258244bbe0590a5b46668","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"807c702a_2288309d","updated":"2022-11-16 18:36:36.000000000","message":"Thanks, this patch works for the OVN case. But what about SQL DB migration for routers already created? Will migration support be provided for DBs already in use with OpenStack?","commit_id":"76b2cf2afd9f6ebd4b7558a19096a58af152acec"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"60177ab43f4805a5c096324ea174e691a80d9658","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7f5355d4_384b3f2c","updated":"2022-11-15 08:55:28.000000000","message":"recheck designate","commit_id":"76b2cf2afd9f6ebd4b7558a19096a58af152acec"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6042b4faab5a572d0b341db5c8079d3107543621","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d25b9d50_36c5bbf9","in_reply_to":"51a29d70_78a9707a","updated":"2022-11-17 17:00:46.000000000","message":"Done","commit_id":"76b2cf2afd9f6ebd4b7558a19096a58af152acec"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b7e5ad569190d056038f2e46fefbb9e2f1115023","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"51a29d70_78a9707a","in_reply_to":"807c702a_2288309d","updated":"2022-11-17 11:31:04.000000000","message":"Hello Roberto. Alembic is used to modify the structure of the DB, not to modify the data. What you are requesting here is an update for any existing router without the corresponding \"router_extra_attributes\" register and this is a legit request. I\u0027ll check where in the code should this be added; it could be an upgrade script or a check in the code anytime a router is read (temporarily)","commit_id":"76b2cf2afd9f6ebd4b7558a19096a58af152acec"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6042b4faab5a572d0b341db5c8079d3107543621","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1c404e46_8ff02889","in_reply_to":"b18bfa61_3d45d0ff","updated":"2022-11-17 17:00:46.000000000","message":"Done","commit_id":"76b2cf2afd9f6ebd4b7558a19096a58af152acec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"86f39a176d8fbb50008b72083654b748b54a8c30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6e707f6b_e990e2e7","updated":"2022-11-17 21:07:11.000000000","message":"recheck pep8 is real, others look unrelated","commit_id":"e2bac40a296e8f9c432ac8d70cb0377926d183f2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c282b04d37fc31492773297900444b9dde1499b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8215bc3f_44ce3054","updated":"2022-11-22 18:25:10.000000000","message":"recheck failing test should be skipped now, failure was unrelated","commit_id":"2081910d6d942d49d96297884a932ff93acb8759"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"23f31816aa55dbb8ccd6d1c1d7fb37cbf4cedb9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7d4d5360_79e0271c","updated":"2022-11-18 12:35:57.000000000","message":"recheck neutron-ovs-tempest-multinode-full unrelated live migration error","commit_id":"2081910d6d942d49d96297884a932ff93acb8759"}],"neutron/tests/unit/objects/test_router.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5872fbb9febf8ce7e817226765c570489e5d4d1b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                get_router_ids_without_router_std_attrs(self.context)"},{"line_number":185,"context_line":"            self.assertEqual(expected_router_ids, router_ids)"},{"line_number":186,"context_line":"            create_r_attr_reg(idx)"},{"line_number":187,"context_line":"            expected_router_ids \u003d expected_router_ids[1:]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"class RouterPortIfaceObjectTestCase(obj_test_base.BaseObjectIfaceTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"f1788b78_4681070f","line":187,"range":{"start_line":187,"start_character":12,"end_line":187,"end_character":57},"updated":"2022-11-17 16:52:00.000000000","message":"In each iteration, we remove the first object of the list because a RouterExtraAttributes register has been created for this router. That means in the next iteration \"get_router_ids_without_router_std_attrs\" won\u0027t return this router ID.","commit_id":"e2bac40a296e8f9c432ac8d70cb0377926d183f2"}]}