)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e1778d7cad1e9015bb984808404f87712c8c1a13","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sam Morrison \u003csorrison@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-21 09:25:50 +1100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVN: Don\u0027t disable dhcp agent extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using a mech_driver that needs dhcp_agent extension"},{"line_number":10,"context_line":"eg. linuxbridge alongside the ovn mech_driver the dhcp"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cc8bb81a_4143e4e7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":13},"updated":"2022-11-21 11:17:40.000000000","message":"If we accept this change, the title should be something like:\n\n[OVN] Add new ML2 extension \"dhcp_agent_scheduler\"\n\n\nBetter than a negative phrase.","commit_id":"e1aa0b0b89600dfe07ac0800e7061cfd4dfc3be6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"2ebbf80a2ee0ce1030de83b3112f00aff8cd45dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78ab9bd2_a21e2373","updated":"2022-11-20 22:30:00.000000000","message":"This doesn\u0027t seem the right way to fix this but I\u0027m not sure how else to fix it","commit_id":"e1aa0b0b89600dfe07ac0800e7061cfd4dfc3be6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"497b96b440e8e9a3e1f17bbcca40379e43fa0abd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a776c8b_ef5b3fdc","updated":"2022-11-23 09:55:46.000000000","message":"+2 but waiting for other opinions","commit_id":"3591ba416037f954ed0cc1827732501d40f5ce44"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"488dfd71e7ce4be4ac5e9e3ee333c25c3d46593f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a12a96f9_fcdd6621","updated":"2022-11-25 00:52:34.000000000","message":"Not sure what to do about those 2 failed tests","commit_id":"3591ba416037f954ed0cc1827732501d40f5ce44"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"098aebe5d11c8717e6ef27dc2dd4c913facac50a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc7ec1eb_a48ff07f","updated":"2022-12-21 17:12:12.000000000","message":"Ping fellow reviewers, please leave your opinion on this patch. Thanks!","commit_id":"3591ba416037f954ed0cc1827732501d40f5ce44"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d9caa3ce63c1dc602c450756380be917e414b781","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc34de7e_dcb4a5b1","updated":"2022-12-05 10:27:56.000000000","message":"hmm, after rereading old comments, better to wait for the alternative solutions check","commit_id":"3591ba416037f954ed0cc1827732501d40f5ce44"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1beedb6db50312b3c7de27c9af51842141c2f98d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"af226889_0846650b","updated":"2022-12-21 17:11:27.000000000","message":"recheck unrelated errors","commit_id":"3591ba416037f954ed0cc1827732501d40f5ce44"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c7ffadb74fa16bb3c8ecf9e02f63b3d7a055bc87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba90db90_a5234a26","in_reply_to":"8c988277_dcecc5af","updated":"2022-12-23 12:34:30.000000000","message":"You are right","commit_id":"3591ba416037f954ed0cc1827732501d40f5ce44"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"96b0f73c911e8856588a85959fa6cf235c398b29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9e3b7643_21930997","in_reply_to":"a12a96f9_fcdd6621","updated":"2022-11-25 10:56:47.000000000","message":"Until now, these tests were skipped as the failing jobs used the default driver (OVN) and dhcp_agent_scheduler was not listed/enabled:\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/api/network/admin/test_dhcp_agent_scheduler.py#L24\n\nBut they only make sense with \"real\" DHCP agents, so fail with OVN. We could probably be fixed on tempest side, though I do not like adding logic like \"if extension is enabled and this is not driver XXX\". Maybe the \"forced api extensions\" idea mentioned by slaweq could work here?","commit_id":"3591ba416037f954ed0cc1827732501d40f5ce44"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"61c4d2d1ce1924328e62386e7324db767b4eaa85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c988277_dcecc5af","in_reply_to":"af226889_0846650b","updated":"2022-12-22 14:08:21.000000000","message":"https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_4c2/865081/2/check/tempest-integrated-networking/4c22a37/testr_results.html\n\nThese errors are related, as with this patchset, these failing tests are not skipped anymore:\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/api/network/admin/test_dhcp_agent_scheduler.py#L24\nAnd fail as we do not have agent running","commit_id":"3591ba416037f954ed0cc1827732501d40f5ce44"}],"neutron/common/ovn/extensions.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"108a2d50a75fa4fab096ea63eacc63537d7f10ad","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    portbindings.ALIAS,"},{"line_number":115,"context_line":"    pbe_ext.ALIAS,"},{"line_number":116,"context_line":"    default_subnetpools.ALIAS,"},{"line_number":117,"context_line":"    dhcpagentscheduler.ALIAS,"},{"line_number":118,"context_line":"    dns.ALIAS,"},{"line_number":119,"context_line":"    external_net.ALIAS,"},{"line_number":120,"context_line":"    extra_dhcp_opt.ALIAS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5af3858_3adc58ca","line":117,"updated":"2022-11-21 09:51:32.000000000","message":"this isn\u0027t good way to do that because OVN don\u0027t really supports dhcp agent scheduler and You cannot e.g. schedule network to be hosted on the DHCP agent.\nMaybe instead we should introduce something like \"forced api extensions\" which can be scheduled by mech drivers and if extension would be in that forced list it would be enabled even if other drivers wouldn\u0027t support it. Wdyt?","commit_id":"e1aa0b0b89600dfe07ac0800e7061cfd4dfc3be6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"134f8b06a7fcb172cfc10331efc4fb4235a1dcdf","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    portbindings.ALIAS,"},{"line_number":115,"context_line":"    pbe_ext.ALIAS,"},{"line_number":116,"context_line":"    default_subnetpools.ALIAS,"},{"line_number":117,"context_line":"    dhcpagentscheduler.ALIAS,"},{"line_number":118,"context_line":"    dns.ALIAS,"},{"line_number":119,"context_line":"    external_net.ALIAS,"},{"line_number":120,"context_line":"    extra_dhcp_opt.ALIAS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"8fb15a3f_e6fbdd84","line":117,"in_reply_to":"8472d5fe_96b61f2d","updated":"2022-11-21 11:40:42.000000000","message":"Thanks for adding Rodolfo. That\u0027s correct, we can use ML2/OVN with Neutron DHCP for certain cases. The one we usually have is baremetal, since OVN built-server was lacking iPXE chainloading support (still lacks it for IPv6) we need to also deploy Neutron DHCP agent for those cases.\n\nThis patch adds support for it for example: https://review.opendev.org/c/openstack/neutron/+/840287","commit_id":"e1aa0b0b89600dfe07ac0800e7061cfd4dfc3be6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9e22552bbf26f5e6724b683f7c3cbea802a8d277","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    portbindings.ALIAS,"},{"line_number":115,"context_line":"    pbe_ext.ALIAS,"},{"line_number":116,"context_line":"    default_subnetpools.ALIAS,"},{"line_number":117,"context_line":"    dhcpagentscheduler.ALIAS,"},{"line_number":118,"context_line":"    dns.ALIAS,"},{"line_number":119,"context_line":"    external_net.ALIAS,"},{"line_number":120,"context_line":"    extra_dhcp_opt.ALIAS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ac4285e4_db8d3c67","line":117,"in_reply_to":"8fb15a3f_e6fbdd84","updated":"2022-11-22 10:22:09.000000000","message":"Right, not SRIOV but baremetal...","commit_id":"e1aa0b0b89600dfe07ac0800e7061cfd4dfc3be6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"09d92f949ea2c80ec011b3993f1fefef705688fe","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    portbindings.ALIAS,"},{"line_number":115,"context_line":"    pbe_ext.ALIAS,"},{"line_number":116,"context_line":"    default_subnetpools.ALIAS,"},{"line_number":117,"context_line":"    dhcpagentscheduler.ALIAS,"},{"line_number":118,"context_line":"    dns.ALIAS,"},{"line_number":119,"context_line":"    external_net.ALIAS,"},{"line_number":120,"context_line":"    extra_dhcp_opt.ALIAS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"8472d5fe_96b61f2d","line":117,"in_reply_to":"d5af3858_3adc58ca","updated":"2022-11-21 11:15:59.000000000","message":"Actually we do support using DHCP agents along with OVN mech driver for, for example, external SRIOV ports. I think we can add this extension here. Let me add Lucas to this review.","commit_id":"e1aa0b0b89600dfe07ac0800e7061cfd4dfc3be6"}]}