)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"62d8e34fc84bb885afc354211b093ff71286aa79","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous `getattr(old, \u0027nb_cfg\u0027, False)` would evaluate to `False`"},{"line_number":10,"context_line":"if the `old` row either did not contain a `nb_cfg` value or if the value"},{"line_number":11,"context_line":"was `0`."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As `0` is the value set on startup of the ovn-controller this causes the"},{"line_number":14,"context_line":"neutron-api to ignore any event a ovn-controller directly sends after"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9811d1b1_dc4caaf4","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":7},"updated":"2022-11-25 15:54:26.000000000","message":"nit: in this case, it could be better to specify the value type is integer","commit_id":"2cae2a8dd5084d4b362407019fdaeca27d9ab59a"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"8f203878a77cf7a25e0f0c13f635eca874ec4be1","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous `getattr(old, \u0027nb_cfg\u0027, False)` would evaluate to `False`"},{"line_number":10,"context_line":"if the `old` row either did not contain a `nb_cfg` value or if the value"},{"line_number":11,"context_line":"was `0`."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As `0` is the value set on startup of the ovn-controller this causes the"},{"line_number":14,"context_line":"neutron-api to ignore any event a ovn-controller directly sends after"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fd93628c_2572c8e9","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":7},"in_reply_to":"9811d1b1_dc4caaf4","updated":"2022-11-28 07:31:48.000000000","message":"i removed the quotes, which should make it clear that this is not a string","commit_id":"2cae2a8dd5084d4b362407019fdaeca27d9ab59a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"418f468f17c221bd2ccd67a68356860807600a12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5d6a058c_6a56c2b8","updated":"2022-12-02 14:07:05.000000000","message":"recheck fullstack issue fixed","commit_id":"24d806651cd12f04290c5b5d78d6978afedb78ac"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"f0b77f55e9ca3b7405b8184179a6fc5cf9fe9503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d1b6763d_734e762b","updated":"2022-12-19 07:18:12.000000000","message":"Thanks i earlier proposed this as part of https://review.opendev.org/c/openstack/neutron/+/847349 for fixing another FT test but that was stuck, should have pushed this in seperate PR.\nAlso i see you updating nb_cfg along with nb_cfg_timestamp and that should the issue as seen in other test https://bugs.launchpad.net/neutron/+bug/1974149/comments/4.","commit_id":"4cc611d319d0afe1ee04df6e4419014f1133df09"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"c7fc2867e3cf2f4ded25f7465dca6095b80f57f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"50c10073_277f1085","updated":"2022-12-14 12:16:03.000000000","message":"recheck","commit_id":"4cc611d319d0afe1ee04df6e4419014f1133df09"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"dd1a6315571a343c2646b0a97d30069ca79af939","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b2e98a39_10c722cb","updated":"2022-12-20 07:41:41.000000000","message":"recheck","commit_id":"4cc611d319d0afe1ee04df6e4419014f1133df09"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"62d8e34fc84bb885afc354211b093ff71286aa79","unresolved":true,"context_lines":[{"line_number":336,"context_line":"        # don\u0027t update the AgentCache. We use chassis_private.chassis to return"},{"line_number":337,"context_line":"        # data about the agent."},{"line_number":338,"context_line":"        return event \u003d\u003d self.ROW_CREATE or ("},{"line_number":339,"context_line":"            getattr(old, \u0027nb_cfg\u0027, False) and not"},{"line_number":340,"context_line":"            (self.table \u003d\u003d \u0027Chassis_Private\u0027 and not row.chassis))"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def run(self, event, row, old):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f6df29c_b0f36b44","side":"PARENT","line":339,"range":{"start_line":339,"start_character":12,"end_line":339,"end_character":41},"updated":"2022-11-25 15:54:26.000000000","message":"Just to be sure, the value in \"nb_cfg\" is an integer (according to the OVN schema):\n  \"nb_cfg\": {\"type\": {\"key\": \"integer\"}},\n  \nI\u0027m saying this because in the commit message your are writing \u00270\u0027 (string) and bool(\u00270\u0027)\u003dTrue","commit_id":"23d79219da7124f63d52b8f5408bf39d94a44848"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"8f203878a77cf7a25e0f0c13f635eca874ec4be1","unresolved":true,"context_lines":[{"line_number":336,"context_line":"        # don\u0027t update the AgentCache. We use chassis_private.chassis to return"},{"line_number":337,"context_line":"        # data about the agent."},{"line_number":338,"context_line":"        return event \u003d\u003d self.ROW_CREATE or ("},{"line_number":339,"context_line":"            getattr(old, \u0027nb_cfg\u0027, False) and not"},{"line_number":340,"context_line":"            (self.table \u003d\u003d \u0027Chassis_Private\u0027 and not row.chassis))"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def run(self, event, row, old):"}],"source_content_type":"text/x-python","patch_set":1,"id":"6468bb2b_68079de5","side":"PARENT","line":339,"range":{"start_line":339,"start_character":12,"end_line":339,"end_character":41},"in_reply_to":"1f6df29c_b0f36b44","updated":"2022-11-28 07:31:48.000000000","message":"yes you are right. I fixed the commit message","commit_id":"23d79219da7124f63d52b8f5408bf39d94a44848"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f386e5c4663ad77f0890451618688547855f1459","unresolved":true,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        # Lets start by shutting down the ovn-controller"},{"line_number":504,"context_line":"        # (where it will remove the Chassis_Private table entry)"},{"line_number":505,"context_line":"        self.sb_api.db_del(\u0027Chassis_Private\u0027, self.chassis_name)"},{"line_number":506,"context_line":"        try:"},{"line_number":507,"context_line":"            n_utils.wait_until_true(check_agent_down, timeout\u003d5)"},{"line_number":508,"context_line":"        except n_utils.WaitTimeout:"}],"source_content_type":"text/x-python","patch_set":4,"id":"694d366b_a2353bbc","line":505,"range":{"start_line":505,"start_character":7,"end_line":505,"end_character":64},"updated":"2022-12-02 15:49:10.000000000","message":"AttributeError: \u0027OvsdbSbOvnIdl\u0027 object has no attribute \u0027db_del\u0027\n\nhttps://2f4a32f753edcd6fd518-38c49964a79149719549049b602122d6.ssl.cf5.rackcdn.com/865697/4/check/neutron-functional-with-uwsgi/1b37201/testr_results.html","commit_id":"24d806651cd12f04290c5b5d78d6978afedb78ac"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"51f10441bae9c4a1cc80a558a50bf36e4d9ede49","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        # Lets start by shutting down the ovn-controller"},{"line_number":504,"context_line":"        # (where it will remove the Chassis_Private table entry)"},{"line_number":505,"context_line":"        self.sb_api.db_del(\u0027Chassis_Private\u0027, self.chassis_name)"},{"line_number":506,"context_line":"        try:"},{"line_number":507,"context_line":"            n_utils.wait_until_true(check_agent_down, timeout\u003d5)"},{"line_number":508,"context_line":"        except n_utils.WaitTimeout:"}],"source_content_type":"text/x-python","patch_set":4,"id":"a67c3b97_1d62c011","line":505,"range":{"start_line":505,"start_character":7,"end_line":505,"end_character":64},"in_reply_to":"694d366b_a2353bbc","updated":"2022-12-14 09:04:02.000000000","message":"thanks. Took me a while to get the functional test working, but now everything should be fine","commit_id":"24d806651cd12f04290c5b5d78d6978afedb78ac"}]}