)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58bd451c957c993a2bec237a4c4447386c774012","unresolved":true,"context_lines":[{"line_number":7,"context_line":"agent: fix issue when network is already removed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We may be in a situation where the network get removed prior the"},{"line_number":10,"context_line":"port. In that can there is no reason to call the driver to clean"},{"line_number":11,"context_line":"devices related to the network."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1997964"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f8a77b33_b1886f06","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":17},"updated":"2022-11-28 16:00:13.000000000","message":"nit: case","commit_id":"596dc4cb52516f3a6267b6d4f2bd8d29aa0b3b61"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1b1b481897c5a5feca61b4ede2364da343a23273","unresolved":false,"context_lines":[{"line_number":7,"context_line":"agent: fix issue when network is already removed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We may be in a situation where the network get removed prior the"},{"line_number":10,"context_line":"port. In that can there is no reason to call the driver to clean"},{"line_number":11,"context_line":"devices related to the network."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1997964"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a9121df8_181fbef6","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":17},"in_reply_to":"f8a77b33_b1886f06","updated":"2022-11-28 17:32:33.000000000","message":"Done","commit_id":"596dc4cb52516f3a6267b6d4f2bd8d29aa0b3b61"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"40cbfa32035de5d2a1fccbd47f18ef1cdf64a6d1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-28 18:31:22 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"agent: fix issue when network is already removed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We may be in a situation where the network get removed prior the"},{"line_number":10,"context_line":"port. In that case there are no reasons to call the driver to clean"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6581f249_d56f1dca","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2022-11-29 13:51:15.000000000","message":"nit: \"agent\" doesn\u0027t mean anything, we have many agent types. That could be, for example:\n\n[DHCP] Fix issue when network is already removed","commit_id":"861bc813867645f757e9a2bb559096c18052b064"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"95d832d3093f912f08a6d980a96e92ff95a73576","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-28 18:31:22 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"agent: fix issue when network is already removed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We may be in a situation where the network get removed prior the"},{"line_number":10,"context_line":"port. In that case there are no reasons to call the driver to clean"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2e121f46_d0b15e0e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"in_reply_to":"6581f249_d56f1dca","updated":"2022-11-29 16:19:22.000000000","message":"Ack","commit_id":"861bc813867645f757e9a2bb559096c18052b064"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"77481d0958ce973633b614ca27553bcd7adb2a60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e548f5f5_dc408f59","updated":"2022-11-30 11:26:13.000000000","message":"recheck unrelated","commit_id":"d2367885786efac4d5908d29d10709e1eee08bf7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2e8b54325f98a9a5a5d3dc1b293b95310107deb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1e7038e6_008efd34","updated":"2022-11-30 16:35:16.000000000","message":"recheck unrelated timeout","commit_id":"d2367885786efac4d5908d29d10709e1eee08bf7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bd7a98eed6275fc98b645cb67be96d3a441be7b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4499b84a_ceb1a7fc","updated":"2022-12-01 15:32:07.000000000","message":"recheck unrelated","commit_id":"a1a7bef545cfb245e288c14e82693f73e94e0d4b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fbeca90db2ac1e7feb878aa85003a126dc6b5fd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"162bd85e_796a72ae","updated":"2022-12-03 19:07:40.000000000","message":"recheck timeout","commit_id":"ec7c266cd25e70f06044ad5747137c511782a9ce"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"dc720a784308ff56bd28f14bb8a6e70bf71ddc9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"27d62d37_87ecdc7d","updated":"2022-12-08 11:13:08.000000000","message":"recheck","commit_id":"0433e52cc471b57098cb21e9b2df2d13f30c59d3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e2d0c6956a77329e088fba728db550985a74b4d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f3112c06_4c70f6b0","updated":"2022-12-08 13:32:00.000000000","message":"recheck test_dvr_router_fips_stale_gw_port","commit_id":"0433e52cc471b57098cb21e9b2df2d13f30c59d3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"04b8111c4a4e29681dab3a062729761e975e7583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"71a7304b_4a6405d1","updated":"2022-12-06 16:39:36.000000000","message":"thanks","commit_id":"0433e52cc471b57098cb21e9b2df2d13f30c59d3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"46e30f927305b8459fb1261a403f07ab4d55e863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"37ebaefd_3a82d276","updated":"2022-12-12 15:34:21.000000000","message":"recheck","commit_id":"36d726e21417549fd8d697f89f56478bc31d8944"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f7d3dcad0c84d6d70582866d554f298fa0dcc308","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6ce2c410_d4cea441","updated":"2022-12-12 12:11:01.000000000","message":"recheck","commit_id":"36d726e21417549fd8d697f89f56478bc31d8944"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c945bd8d3cdcb666aba40ba541650f5d27d8c08d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"22516c21_93201a96","updated":"2022-12-14 14:32:57.000000000","message":"recheck","commit_id":"8f1180b1329b567edef7a540eca56bd9830c0aaa"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"daf71ade5bf9296067aacd7d871ad5ce167c0906","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1b68232a_fc677611","updated":"2022-12-13 10:40:25.000000000","message":"recheck timeout","commit_id":"8f1180b1329b567edef7a540eca56bd9830c0aaa"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"72284df5126f45671297cfea089c2fbe8e380730","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d86de1af_c14d9573","updated":"2022-12-15 07:27:01.000000000","message":"recheck timeout","commit_id":"8f1180b1329b567edef7a540eca56bd9830c0aaa"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8b50156964e371a28961ebe7c6c9b282199fc868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1b0cea58_ee6719c6","updated":"2022-12-14 12:22:09.000000000","message":"recheck unrelated","commit_id":"8f1180b1329b567edef7a540eca56bd9830c0aaa"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0e3437b8c72cb8502667a03ba4afebeb33fec89d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3f2ef40b_baa86a82","updated":"2022-12-16 09:18:53.000000000","message":"recheck unrelated timeout tempest.api.compute.servers.test_server_actions.ServerActionsTestJSON","commit_id":"faa4803302539aa13d384e4ca3d72bff37a79f79"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58bd451c957c993a2bec237a4c4447386c774012","unresolved":true,"context_lines":[{"line_number":734,"context_line":"            # and add the network to the resync list to create"},{"line_number":735,"context_line":"            # (or acquire a reserved) port."},{"line_number":736,"context_line":"            if not network:"},{"line_number":737,"context_line":"                LOG.info(\u0027Network %s may have been deleted by agent or \u0027"},{"line_number":738,"context_line":"                         \u0027removed from DB.\u0027, payload[\u0027network_id\u0027])"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                self.call_driver(\u0027disable\u0027, network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6cd7ef69_e55eb091","line":737,"range":{"start_line":737,"start_character":20,"end_line":737,"end_character":24},"updated":"2022-11-28 16:00:13.000000000","message":"do we need it on INFO level? Wouldn\u0027t debug be enough?","commit_id":"596dc4cb52516f3a6267b6d4f2bd8d29aa0b3b61"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1b1b481897c5a5feca61b4ede2364da343a23273","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            # and add the network to the resync list to create"},{"line_number":735,"context_line":"            # (or acquire a reserved) port."},{"line_number":736,"context_line":"            if not network:"},{"line_number":737,"context_line":"                LOG.info(\u0027Network %s may have been deleted by agent or \u0027"},{"line_number":738,"context_line":"                         \u0027removed from DB.\u0027, payload[\u0027network_id\u0027])"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                self.call_driver(\u0027disable\u0027, network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"296c23e7_04f6d53d","line":737,"range":{"start_line":737,"start_character":20,"end_line":737,"end_character":24},"in_reply_to":"6cd7ef69_e55eb091","updated":"2022-11-28 17:32:33.000000000","message":"Yes you are right, not sure that operator needs this detail. Thanks.","commit_id":"596dc4cb52516f3a6267b6d4f2bd8d29aa0b3b61"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"40cbfa32035de5d2a1fccbd47f18ef1cdf64a6d1","unresolved":true,"context_lines":[{"line_number":201,"context_line":"    def call_driver(self, action, network, **action_kwargs):"},{"line_number":202,"context_line":"        sid_segment \u003d {}"},{"line_number":203,"context_line":"        sid_subnets \u003d collections.defaultdict(list)"},{"line_number":204,"context_line":"        if \u0027segments\u0027 in network and network.segments:"},{"line_number":205,"context_line":"            # In case of multi-segments network, let\u0027s group network per"},{"line_number":206,"context_line":"            # segments.  We can then create DHPC process per segmentation"},{"line_number":207,"context_line":"            # id. All subnets on a same network that are sharing the same"}],"source_content_type":"text/x-python","patch_set":2,"id":"908a2144_a7eceede","line":204,"range":{"start_line":204,"start_character":8,"end_line":204,"end_character":10},"updated":"2022-11-29 13:51:15.000000000","message":"I would make this check here:\n\nif not network:\n    LOG.info(\u0027Network not present, action: %action\u0027, %action)\n    \n    \nIn order to have the network ID, you can pass the network_id in the \"action_kwargs\". If present, you can print it in the message.","commit_id":"861bc813867645f757e9a2bb559096c18052b064"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c596392af0aa910acb9e49914677011099cdcb4c","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def call_driver(self, action, network, **action_kwargs):"},{"line_number":202,"context_line":"        sid_segment \u003d {}"},{"line_number":203,"context_line":"        sid_subnets \u003d collections.defaultdict(list)"},{"line_number":204,"context_line":"        if \u0027segments\u0027 in network and network.segments:"},{"line_number":205,"context_line":"            # In case of multi-segments network, let\u0027s group network per"},{"line_number":206,"context_line":"            # segments.  We can then create DHPC process per segmentation"},{"line_number":207,"context_line":"            # id. All subnets on a same network that are sharing the same"}],"source_content_type":"text/x-python","patch_set":2,"id":"414df43e_ee2d7e5c","line":204,"range":{"start_line":204,"start_character":8,"end_line":204,"end_character":10},"in_reply_to":"908a2144_a7eceede","updated":"2022-11-30 09:28:28.000000000","message":"Ack","commit_id":"861bc813867645f757e9a2bb559096c18052b064"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"40cbfa32035de5d2a1fccbd47f18ef1cdf64a6d1","unresolved":true,"context_lines":[{"line_number":733,"context_line":"            # the agent\u0027s port has been deleted. disable the service"},{"line_number":734,"context_line":"            # and add the network to the resync list to create"},{"line_number":735,"context_line":"            # (or acquire a reserved) port."},{"line_number":736,"context_line":"            if not network:"},{"line_number":737,"context_line":"                LOG.debug(\u0027Network %s may have been deleted by agent or \u0027"},{"line_number":738,"context_line":"                          \u0027removed from DB.\u0027, payload[\u0027network_id\u0027])"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                self.call_driver(\u0027disable\u0027, network)"},{"line_number":741,"context_line":"            self.schedule_resync(\"Agent port was deleted\", port.network_id)"},{"line_number":742,"context_line":"        else:"},{"line_number":743,"context_line":"            self.call_driver(\u0027reload_allocations\u0027, network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"587c56ac_6d2a4db8","line":740,"range":{"start_line":736,"start_character":12,"end_line":740,"end_character":52},"updated":"2022-11-29 13:51:15.000000000","message":"Instead of solving one case, why don\u0027t you check what is \"network\" in \"call_driver\" method?","commit_id":"861bc813867645f757e9a2bb559096c18052b064"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c596392af0aa910acb9e49914677011099cdcb4c","unresolved":false,"context_lines":[{"line_number":733,"context_line":"            # the agent\u0027s port has been deleted. disable the service"},{"line_number":734,"context_line":"            # and add the network to the resync list to create"},{"line_number":735,"context_line":"            # (or acquire a reserved) port."},{"line_number":736,"context_line":"            if not network:"},{"line_number":737,"context_line":"                LOG.debug(\u0027Network %s may have been deleted by agent or \u0027"},{"line_number":738,"context_line":"                          \u0027removed from DB.\u0027, payload[\u0027network_id\u0027])"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                self.call_driver(\u0027disable\u0027, network)"},{"line_number":741,"context_line":"            self.schedule_resync(\"Agent port was deleted\", port.network_id)"},{"line_number":742,"context_line":"        else:"},{"line_number":743,"context_line":"            self.call_driver(\u0027reload_allocations\u0027, network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f67f5389_13d9b57e","line":740,"range":{"start_line":736,"start_character":12,"end_line":740,"end_character":52},"in_reply_to":"2bc75153_3a525d7a","updated":"2022-11-30 09:28:28.000000000","message":"Ack","commit_id":"861bc813867645f757e9a2bb559096c18052b064"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ad9b93926436a775182d6b0860caabd4f4c862b6","unresolved":true,"context_lines":[{"line_number":733,"context_line":"            # the agent\u0027s port has been deleted. disable the service"},{"line_number":734,"context_line":"            # and add the network to the resync list to create"},{"line_number":735,"context_line":"            # (or acquire a reserved) port."},{"line_number":736,"context_line":"            if not network:"},{"line_number":737,"context_line":"                LOG.debug(\u0027Network %s may have been deleted by agent or \u0027"},{"line_number":738,"context_line":"                          \u0027removed from DB.\u0027, payload[\u0027network_id\u0027])"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                self.call_driver(\u0027disable\u0027, network)"},{"line_number":741,"context_line":"            self.schedule_resync(\"Agent port was deleted\", port.network_id)"},{"line_number":742,"context_line":"        else:"},{"line_number":743,"context_line":"            self.call_driver(\u0027reload_allocations\u0027, network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2bc75153_3a525d7a","line":740,"range":{"start_line":736,"start_character":12,"end_line":740,"end_character":52},"in_reply_to":"587c56ac_6d2a4db8","updated":"2022-11-29 14:30:07.000000000","message":"In the case of a port delete I can vaguely understand that the network to have been already deleted, But for other cases I think that would make sense to try handling them at the time when I arrive to ensure nothing is wrong in the process. What do you think?","commit_id":"861bc813867645f757e9a2bb559096c18052b064"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"94fcad423854785509dd6af4b397b0d5078272b7","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        sid_segment \u003d {}"},{"line_number":203,"context_line":"        sid_subnets \u003d collections.defaultdict(list)"},{"line_number":204,"context_line":"        if not network:"},{"line_number":205,"context_line":"            LOG.info(\u0027Network not present, action: %s, action_kwargs: %s\u0027,"},{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"29e800b7_80ffd8b5","line":205,"range":{"start_line":205,"start_character":55,"end_line":205,"end_character":68},"updated":"2022-12-12 09:13:34.000000000","message":"nit: not the best name but works.","commit_id":"36d726e21417549fd8d697f89f56478bc31d8944"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b6f352e89b5c666f71cc84656672394e210f1b7b","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        sid_segment \u003d {}"},{"line_number":203,"context_line":"        sid_subnets \u003d collections.defaultdict(list)"},{"line_number":204,"context_line":"        if not network:"},{"line_number":205,"context_line":"            LOG.info(\u0027Network not present, action: %s, action_kwargs: %s\u0027,"},{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"e33fae5d_bc8acb0e","line":205,"range":{"start_line":205,"start_character":55,"end_line":205,"end_character":68},"in_reply_to":"29e800b7_80ffd8b5","updated":"2022-12-14 13:48:23.000000000","message":"I actually don\u0027t think we need to log anything, but if we do isn\u0027t debug enough? There is nothing for the user to do in this case.","commit_id":"36d726e21417549fd8d697f89f56478bc31d8944"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d7e35250332c21d118200254dd78eaa38dbb0d5c","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        sid_segment \u003d {}"},{"line_number":203,"context_line":"        sid_subnets \u003d collections.defaultdict(list)"},{"line_number":204,"context_line":"        if not network:"},{"line_number":205,"context_line":"            LOG.info(\u0027Network not present, action: %s, action_kwargs: %s\u0027,"},{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"fd559faa_c9704312","line":205,"range":{"start_line":205,"start_character":55,"end_line":205,"end_character":68},"in_reply_to":"897f8ea4_78c1612a","updated":"2022-12-14 14:50:37.000000000","message":"Well this core doesn\u0027t agree, which is fine, we don\u0027t have to agree it happens all the time. But what can an operator do if they see this message?","commit_id":"36d726e21417549fd8d697f89f56478bc31d8944"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"92743341be220e92ea94b4e6b376694a4a668bba","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        sid_segment \u003d {}"},{"line_number":203,"context_line":"        sid_subnets \u003d collections.defaultdict(list)"},{"line_number":204,"context_line":"        if not network:"},{"line_number":205,"context_line":"            LOG.info(\u0027Network not present, action: %s, action_kwargs: %s\u0027,"},{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"e41934f2_cf6ca09b","line":205,"range":{"start_line":205,"start_character":55,"end_line":205,"end_character":68},"in_reply_to":"c0c9c9c3_feaba59d","updated":"2022-12-14 14:21:20.000000000","message":"Well, this patch hasn\u0027t merged yet. I say this because even logging the driver call on L242 only uses debug, not info.","commit_id":"36d726e21417549fd8d697f89f56478bc31d8944"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d91b9305557eb765905f656886b15765cc390773","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        sid_segment \u003d {}"},{"line_number":203,"context_line":"        sid_subnets \u003d collections.defaultdict(list)"},{"line_number":204,"context_line":"        if not network:"},{"line_number":205,"context_line":"            LOG.info(\u0027Network not present, action: %s, action_kwargs: %s\u0027,"},{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"c0c9c9c3_feaba59d","line":205,"range":{"start_line":205,"start_character":55,"end_line":205,"end_character":68},"in_reply_to":"e33fae5d_bc8acb0e","updated":"2022-12-14 13:55:53.000000000","message":"Feel free to share a patch with your idea of why we should use debug.","commit_id":"36d726e21417549fd8d697f89f56478bc31d8944"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c945bd8d3cdcb666aba40ba541650f5d27d8c08d","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        sid_segment \u003d {}"},{"line_number":203,"context_line":"        sid_subnets \u003d collections.defaultdict(list)"},{"line_number":204,"context_line":"        if not network:"},{"line_number":205,"context_line":"            LOG.info(\u0027Network not present, action: %s, action_kwargs: %s\u0027,"},{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"897f8ea4_78c1612a","line":205,"range":{"start_line":205,"start_character":55,"end_line":205,"end_character":68},"in_reply_to":"e41934f2_cf6ca09b","updated":"2022-12-14 14:32:57.000000000","message":"3 cores already voted in favor and I. Personally I would have increased the log level to warning. You are asking to decrease it :-)\n\nI understand that deciding which log level should be used is always tricky. Most of the time I would avoid to make any vote with such suggestion.\n\nI don\u0027t see anything wrong with info since this is a case that we should not expect to happen often and if it\u0027s that operator may want to be notified and understand the reason.\n\nI\u0027m always happy to address comments but for this case I would avoid arguing too much and let you share a patch with your reasons, then I would gladly share on it that we should use warning and not debug ;-)","commit_id":"36d726e21417549fd8d697f89f56478bc31d8944"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb83a1c6966da0485a2f73291e39f75cdc67a7e7","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        sid_segment \u003d {}"},{"line_number":203,"context_line":"        sid_subnets \u003d collections.defaultdict(list)"},{"line_number":204,"context_line":"        if not network:"},{"line_number":205,"context_line":"            LOG.info(\u0027Network not present, action: %s, action_kwargs: %s\u0027,"},{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"f2558367_009f21e7","line":205,"range":{"start_line":205,"start_character":55,"end_line":205,"end_character":68},"in_reply_to":"fd559faa_c9704312","updated":"2022-12-16 15:06:33.000000000","message":"To be honest, this is an exceptional situation. This could happen in a race condition only. The message with \"action_kwargs\" is not the best, but still useful for debugging. I think we can change it later if needed.","commit_id":"36d726e21417549fd8d697f89f56478bc31d8944"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d7e35250332c21d118200254dd78eaa38dbb0d5c","unresolved":true,"context_lines":[{"line_number":284,"context_line":"                    e.exc_type \u003d\u003d \u0027NetworkNotFound\u0027 or"},{"line_number":285,"context_line":"                    isinstance(e, exceptions.NetworkNotFound)):"},{"line_number":286,"context_line":"                LOG.debug(\"Network %s has been removed from the agent \""},{"line_number":287,"context_line":"                          \"or deleted from DB.\", network.id)"},{"line_number":288,"context_line":"            else:"},{"line_number":289,"context_line":"                LOG.exception(\u0027Unable to %(action)s dhcp for %(net_id)s.\u0027,"},{"line_number":290,"context_line":"                              {\u0027net_id\u0027: network.id, \u0027action\u0027: action})"}],"source_content_type":"text/x-python","patch_set":9,"id":"f581f28e_6fcd2085","line":287,"updated":"2022-12-14 14:50:37.000000000","message":"In this case we also don\u0027t have a network, but log at debug. This is my point. There is nowhere in the *call_driver() code that we log above debug, except the one line below.","commit_id":"8f1180b1329b567edef7a540eca56bd9830c0aaa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b6f352e89b5c666f71cc84656672394e210f1b7b","unresolved":true,"context_lines":[{"line_number":728,"context_line":"    def _port_delete(self, payload):"},{"line_number":729,"context_line":"        port_id \u003d payload[\u0027port_id\u0027]"},{"line_number":730,"context_line":"        port \u003d self.cache.get_port_by_id(port_id)"},{"line_number":731,"context_line":"        network \u003d self.cache.get_network_by_id(payload[\u0027network_id\u0027])"},{"line_number":732,"context_line":"        self.cache.add_to_deleted_ports(port_id)"},{"line_number":733,"context_line":"        if not port:"},{"line_number":734,"context_line":"            # Let\u0027s ensure that we clean namespace from stale devices"}],"source_content_type":"text/x-python","patch_set":9,"id":"19c462b4_9f8b9e5d","line":731,"updated":"2022-12-14 13:48:23.000000000","message":"I prefer just returning earlier here as I did in\n\nhttps://review.opendev.org/c/openstack/neutron/+/867315","commit_id":"8f1180b1329b567edef7a540eca56bd9830c0aaa"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d91b9305557eb765905f656886b15765cc390773","unresolved":true,"context_lines":[{"line_number":728,"context_line":"    def _port_delete(self, payload):"},{"line_number":729,"context_line":"        port_id \u003d payload[\u0027port_id\u0027]"},{"line_number":730,"context_line":"        port \u003d self.cache.get_port_by_id(port_id)"},{"line_number":731,"context_line":"        network \u003d self.cache.get_network_by_id(payload[\u0027network_id\u0027])"},{"line_number":732,"context_line":"        self.cache.add_to_deleted_ports(port_id)"},{"line_number":733,"context_line":"        if not port:"},{"line_number":734,"context_line":"            # Let\u0027s ensure that we clean namespace from stale devices"}],"source_content_type":"text/x-python","patch_set":9,"id":"5d34ea0d_94578362","line":731,"in_reply_to":"19c462b4_9f8b9e5d","updated":"2022-12-14 13:55:53.000000000","message":"Hey Brian, this has already behind discussed. Please see previous patchset.","commit_id":"8f1180b1329b567edef7a540eca56bd9830c0aaa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"92743341be220e92ea94b4e6b376694a4a668bba","unresolved":true,"context_lines":[{"line_number":728,"context_line":"    def _port_delete(self, payload):"},{"line_number":729,"context_line":"        port_id \u003d payload[\u0027port_id\u0027]"},{"line_number":730,"context_line":"        port \u003d self.cache.get_port_by_id(port_id)"},{"line_number":731,"context_line":"        network \u003d self.cache.get_network_by_id(payload[\u0027network_id\u0027])"},{"line_number":732,"context_line":"        self.cache.add_to_deleted_ports(port_id)"},{"line_number":733,"context_line":"        if not port:"},{"line_number":734,"context_line":"            # Let\u0027s ensure that we clean namespace from stale devices"}],"source_content_type":"text/x-python","patch_set":9,"id":"b9ed4226_0acffe93","line":731,"in_reply_to":"5d34ea0d_94578362","updated":"2022-12-14 14:21:20.000000000","message":"Ok, I guess Rodolfo asked for this mostly to log it happened, I\u0027m fine with that.","commit_id":"8f1180b1329b567edef7a540eca56bd9830c0aaa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb83a1c6966da0485a2f73291e39f75cdc67a7e7","unresolved":true,"context_lines":[{"line_number":728,"context_line":"    def _port_delete(self, payload):"},{"line_number":729,"context_line":"        port_id \u003d payload[\u0027port_id\u0027]"},{"line_number":730,"context_line":"        port \u003d self.cache.get_port_by_id(port_id)"},{"line_number":731,"context_line":"        network \u003d self.cache.get_network_by_id(payload[\u0027network_id\u0027])"},{"line_number":732,"context_line":"        self.cache.add_to_deleted_ports(port_id)"},{"line_number":733,"context_line":"        if not port:"},{"line_number":734,"context_line":"            # Let\u0027s ensure that we clean namespace from stale devices"}],"source_content_type":"text/x-python","patch_set":9,"id":"5946b2fa_78b14203","line":731,"in_reply_to":"b9ed4226_0acffe93","updated":"2022-12-16 15:06:33.000000000","message":"The point is that","commit_id":"8f1180b1329b567edef7a540eca56bd9830c0aaa"}]}