)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"7c3a6b9955317ebfd63e96c9c7ef7c8af7559905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36a70ccc_a00f6999","updated":"2022-12-01 14:50:32.000000000","message":"recheck unrelated neutron-fullstack-with-uwsgi failure","commit_id":"bc9765d741ed608cce28edce5f582dcf590655c2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"09042cb9e621f7da7f35c7a0b8bd92eabcdb0596","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f8e9d6f_5417d4a5","updated":"2022-12-02 07:31:11.000000000","message":"Probably need to wait to https://review.opendev.org/c/openstack/neutron/+/866307","commit_id":"671e6661795f03e7461312530f0309d6b12d16ce"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e4f389eb1ecbe491c5d9787bcd87aad90dc22752","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ebd37b22_40012b3e","updated":"2022-12-02 07:34:40.000000000","message":"just a nit/question","commit_id":"671e6661795f03e7461312530f0309d6b12d16ce"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"11217e7e885d537fd1abbabbcb334369796c2d77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dbb167ef_8b99dfb5","updated":"2022-12-02 16:42:24.000000000","message":"LGTM!","commit_id":"1979319fda28d984248ac9480a9dc0614a52b0d5"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"081254f52650c910ef33294b326d0c80a0378816","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"097f66a9_453711de","updated":"2022-12-02 08:23:14.000000000","message":"thanks","commit_id":"1979319fda28d984248ac9480a9dc0614a52b0d5"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"7839f450d6cb3eebf847b088aa0411b17a49495c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b6f15157_0135bc32","updated":"2022-12-05 15:43:41.000000000","message":"recheck neutron-functional-with-uwsgi unrelated","commit_id":"92efd8e45bef761fc464c932f1fd60d1c4d7e828"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"91a90d992635f351e0e1fc49127b2952c8967d48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ce3d0473_b450b9ea","updated":"2022-12-05 21:16:17.000000000","message":"recheck tempest unrelated","commit_id":"92efd8e45bef761fc464c932f1fd60d1c4d7e828"}],"neutron/db/l3_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a2efb39d2d9313951d6d150cc596de082b61ccc6","unresolved":true,"context_lines":[{"line_number":1037,"context_line":"                    # deleted, so instead returning a RouterInterfaceNotFound"},{"line_number":1038,"context_line":"                    # we continue the analysis avoiding that port"},{"line_number":1039,"context_line":"                    LOG.debug(\"Port %s has been deleted, not taking into \""},{"line_number":1040,"context_line":"                              \"account to router interfaces overlapping\","},{"line_number":1041,"context_line":"                              rp.port_id)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"            if subnets_id and len(subnets_id) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":1,"id":"00b8422c_08a5c06f","line":1040,"updated":"2022-12-01 15:03:34.000000000","message":"nit: if you update this patch again, it might be good to change this to match other similar debug statements, something like:\n\n\"Port %s could not be found, it might have been deleted concurrently. Will not be checked for an overlapping router interface.\"","commit_id":"bc9765d741ed608cce28edce5f582dcf590655c2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"e1da7ae1b4248dce7b9b249ea757176cd52d7547","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"                    # deleted, so instead returning a RouterInterfaceNotFound"},{"line_number":1038,"context_line":"                    # we continue the analysis avoiding that port"},{"line_number":1039,"context_line":"                    LOG.debug(\"Port %s has been deleted, not taking into \""},{"line_number":1040,"context_line":"                              \"account to router interfaces overlapping\","},{"line_number":1041,"context_line":"                              rp.port_id)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"            if subnets_id and len(subnets_id) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":1,"id":"21907549_8e5161f5","line":1040,"in_reply_to":"00b8422c_08a5c06f","updated":"2022-12-01 16:58:01.000000000","message":"Done","commit_id":"bc9765d741ed608cce28edce5f582dcf590655c2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a2efb39d2d9313951d6d150cc596de082b61ccc6","unresolved":true,"context_lines":[{"line_number":1040,"context_line":"                              \"account to router interfaces overlapping\","},{"line_number":1041,"context_line":"                              rp.port_id)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"            if subnets_id and len(subnets_id) \u003e 1:"},{"line_number":1044,"context_line":"                id_filter \u003d {\u0027id\u0027: subnets_id}"},{"line_number":1045,"context_line":"                subnets \u003d self._core_plugin.get_subnets(context.elevated(),"},{"line_number":1046,"context_line":"                                                        filters\u003did_filter)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f5e7373_f9f43de5","line":1043,"updated":"2022-12-01 15:03:34.000000000","message":"I would have thought len(subnets_id) \u003e 1 would be enough? As len([]) is 0","commit_id":"bc9765d741ed608cce28edce5f582dcf590655c2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"e1da7ae1b4248dce7b9b249ea757176cd52d7547","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"                              \"account to router interfaces overlapping\","},{"line_number":1041,"context_line":"                              rp.port_id)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"            if subnets_id and len(subnets_id) \u003e 1:"},{"line_number":1044,"context_line":"                id_filter \u003d {\u0027id\u0027: subnets_id}"},{"line_number":1045,"context_line":"                subnets \u003d self._core_plugin.get_subnets(context.elevated(),"},{"line_number":1046,"context_line":"                                                        filters\u003did_filter)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9897f07b_e1c40c8a","line":1043,"in_reply_to":"3f5e7373_f9f43de5","updated":"2022-12-01 16:58:01.000000000","message":"Totally agree! Tt was left there by carelessness","commit_id":"bc9765d741ed608cce28edce5f582dcf590655c2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e4f389eb1ecbe491c5d9787bcd87aad90dc22752","unresolved":true,"context_lines":[{"line_number":1041,"context_line":"                              \"an overlapping router interface.\","},{"line_number":1042,"context_line":"                              rp.port_id)"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"            if len(subnets_id) \u003e 1:"},{"line_number":1045,"context_line":"                id_filter \u003d {\u0027id\u0027: subnets_id}"},{"line_number":1046,"context_line":"                subnets \u003d self._core_plugin.get_subnets(context.elevated(),"},{"line_number":1047,"context_line":"                                                        filters\u003did_filter)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d36e9a05_05692798","line":1044,"range":{"start_line":1044,"start_character":12,"end_line":1044,"end_character":35},"updated":"2022-12-02 07:34:40.000000000","message":"before it was enough with being of len 1, why now is needed more than one. This is not commented on the commit message","commit_id":"671e6661795f03e7461312530f0309d6b12d16ce"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"2dbf80870cc618116a958872bf8a1f6d6130aee6","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"                              \"an overlapping router interface.\","},{"line_number":1042,"context_line":"                              rp.port_id)"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"            if len(subnets_id) \u003e 1:"},{"line_number":1045,"context_line":"                id_filter \u003d {\u0027id\u0027: subnets_id}"},{"line_number":1046,"context_line":"                subnets \u003d self._core_plugin.get_subnets(context.elevated(),"},{"line_number":1047,"context_line":"                                                        filters\u003did_filter)"}],"source_content_type":"text/x-python","patch_set":2,"id":"231a3f8a_1a47bfa3","line":1044,"range":{"start_line":1044,"start_character":12,"end_line":1044,"end_character":35},"in_reply_to":"d36e9a05_05692798","updated":"2022-12-02 07:46:59.000000000","message":"It was an ineffective validation, it was \"valid\" for us because at least we checked the existence but it would not make sense the subsequent code, to check overlapping we need at least two subnets, hence the change. So let me add a sentence explaining the motivation of this change in the commit msg.","commit_id":"671e6661795f03e7461312530f0309d6b12d16ce"}]}