)]}'
{"neutron/tests/fullstack/test_restore_flow.py":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"62b58355c7d2af39556593bba29c2594a44c7898","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        # Mock the host l2_agents"},{"line_number":51,"context_line":"        # TODO(amorin) Need help here"},{"line_number":52,"context_line":"        # for host in self.environment.hosts:"},{"line_number":53,"context_line":"        #     mock.patch.object(host.l2_agent, \u0027add_fdb_flow\u0027).start()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # Restart agent"},{"line_number":56,"context_line":"        host.l2_agent.restart()"}],"source_content_type":"text/x-python","patch_set":2,"id":"d997ae07_66555d22","line":53,"updated":"2022-12-06 14:49:38.000000000","message":"If someone can give me a hint on how to implement the mocking of this, that would be helpful.\nThanks","commit_id":"b739bc5b01f5a3a7839e15163a65c0112d821193"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f51fb94e44efe5d01b31dec675891ce6e61d26dd","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        # Mock the host l2_agents"},{"line_number":51,"context_line":"        # TODO(amorin) Need help here"},{"line_number":52,"context_line":"        # for host in self.environment.hosts:"},{"line_number":53,"context_line":"        #     mock.patch.object(host.l2_agent, \u0027add_fdb_flow\u0027).start()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # Restart agent"},{"line_number":56,"context_line":"        host.l2_agent.restart()"}],"source_content_type":"text/x-python","patch_set":2,"id":"e07708da_db7c1f1f","line":53,"in_reply_to":"d997ae07_66555d22","updated":"2022-12-07 15:32:03.000000000","message":"In fullstack tests we are using \"custom\" agent\u0027s code and we are monkey patching some methods. We are trying to avoid that as much as possible, but if that\u0027s necessary, please check it in https://github.com/openstack/neutron/blob/master/neutron/tests/fullstack/agents/ovs_agent.py","commit_id":"b739bc5b01f5a3a7839e15163a65c0112d821193"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"d137f5859c6deb91f96d02ac112b08ce41b799fa","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # Mock the host l2_agents"},{"line_number":51,"context_line":"        # TODO(amorin) Need help here"},{"line_number":52,"context_line":"        # for host in self.environment.hosts:"},{"line_number":53,"context_line":"        #     mock.patch.object(host.l2_agent, \u0027add_fdb_flow\u0027).start()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # Restart agent"},{"line_number":56,"context_line":"        host.l2_agent.restart()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dcf8b2ad_38d78e52","line":53,"in_reply_to":"e07708da_db7c1f1f","updated":"2022-12-08 13:39:06.000000000","message":"So, I did like you explained.\nBUT, I add to tweak the thing to change the mock behavior live (during the restart of the agent).\n\nThis solution looks like a trick, but it works like a charm.\nLet me know if you think I can do this differently.","commit_id":"b739bc5b01f5a3a7839e15163a65c0112d821193"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f51fb94e44efe5d01b31dec675891ce6e61d26dd","unresolved":true,"context_lines":[{"line_number":24,"context_line":"class TestRestoreFlow(base.BaseFullStackTestCase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    scenarios \u003d ["},{"line_number":27,"context_line":"        (\u0027Open vSwitch Agent\u0027, {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS})]"},{"line_number":28,"context_line":"    network_type \u003d \"vxlan\""},{"line_number":29,"context_line":"    num_hosts \u003d 3"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ed7b6b18_33f889e3","line":27,"updated":"2022-12-07 15:32:03.000000000","message":"do we really need scenarios if there is only one? And I don\u0027t think there is possibility to add any other scenario here.","commit_id":"537f2c48c0458f0aba6cdc7db120869cddeb2da5"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"d137f5859c6deb91f96d02ac112b08ce41b799fa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class TestRestoreFlow(base.BaseFullStackTestCase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    scenarios \u003d ["},{"line_number":27,"context_line":"        (\u0027Open vSwitch Agent\u0027, {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS})]"},{"line_number":28,"context_line":"    network_type \u003d \"vxlan\""},{"line_number":29,"context_line":"    num_hosts \u003d 3"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a193c4b3_4fe616de","line":27,"in_reply_to":"ed7b6b18_33f889e3","updated":"2022-12-08 13:39:06.000000000","message":"Done","commit_id":"537f2c48c0458f0aba6cdc7db120869cddeb2da5"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"df80346e1272508cf515cf1f79cf301e1005a712","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestRestoreFlow(base.BaseFullStackTestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    network_type \u003d \"vxlan\""},{"line_number":29,"context_line":"    num_hosts \u003d 3"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"22f3fcca_bb1f3225","line":28,"updated":"2022-12-08 13:48:36.000000000","message":"I removed the scenario here like slawek was asking, but I am not sure about the success result of the test anymore.","commit_id":"ab14d3f556d81243486d2df6d51b8e73aaece283"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"c60db8efd75619f22da7611a90be03ca563b4efa","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestRestoreFlow(base.BaseFullStackTestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    network_type \u003d \"vxlan\""},{"line_number":29,"context_line":"    num_hosts \u003d 3"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"2399e806_90b5dccc","line":28,"in_reply_to":"22f3fcca_bb1f3225","updated":"2022-12-08 14:46:29.000000000","message":"Found, I accidently removed the +x flag on ovs_agent.py","commit_id":"ab14d3f556d81243486d2df6d51b8e73aaece283"}]}