)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6e209a94a14202aa6e4c5223ff89b2f232eda4e0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"53393523_b2ea7444","updated":"2022-12-12 11:06:01.000000000","message":"Hey Rodolfo I would say that if you did not change tests that means no test assertions was added for this algorithm, how do you feel about to make one? That should be quite easy as you have extracted the whole function","commit_id":"9aa36126056b7a6853413cad8fcc065783281dca"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"df69478f636bac9d9c28bcb6081dfe27e7f6465d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cd61ec24_cfc7aef8","in_reply_to":"53393523_b2ea7444","updated":"2022-12-12 12:31:19.000000000","message":"It is irrelevant to test this method. What needs to be tested is what happens when the OVN L3 plugin is called when OVN is not a defined mech driver. But that requires something like a Tobiko test. I can\u0027t reproduce that with fullstack not tempest tests. And a UT here is trivial.","commit_id":"9aa36126056b7a6853413cad8fcc065783281dca"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3ccd20b89a6a829424d85a32e8daae4908f62856","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"76085ee3_8eb2974a","updated":"2022-12-12 14:46:55.000000000","message":"Thanks!","commit_id":"2fd17aa8762a2602527674896b86b3989899964e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5fb3b0cdd1880cf53440fbd5dcbce94b306be0b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"70f0dcea_019554a7","updated":"2022-12-13 11:03:20.000000000","message":"recheck timeout neutron-fullstack-with-uwsgi","commit_id":"2fd17aa8762a2602527674896b86b3989899964e"}],"neutron/services/ovn_l3/plugin.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6e209a94a14202aa6e4c5223ff89b2f232eda4e0","unresolved":true,"context_lines":[{"line_number":88,"context_line":"        super(OVNL3RouterPlugin, self).__init__()"},{"line_number":89,"context_line":"        self._plugin_property \u003d None"},{"line_number":90,"context_line":"        self._mech \u003d None"},{"line_number":91,"context_line":"        self._initialize_plugin_driver()"},{"line_number":92,"context_line":"        self._ovn_client_inst \u003d None"},{"line_number":93,"context_line":"        self.scheduler \u003d l3_ovn_scheduler.get_scheduler()"},{"line_number":94,"context_line":"        self.port_forwarding \u003d port_forwarding.OVNPortForwarding(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b7898e2_785633b6","line":91,"updated":"2022-12-12 11:06:01.000000000","message":"Sound reasonable to move this check at initialization.","commit_id":"9aa36126056b7a6853413cad8fcc065783281dca"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"df69478f636bac9d9c28bcb6081dfe27e7f6465d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        super(OVNL3RouterPlugin, self).__init__()"},{"line_number":89,"context_line":"        self._plugin_property \u003d None"},{"line_number":90,"context_line":"        self._mech \u003d None"},{"line_number":91,"context_line":"        self._initialize_plugin_driver()"},{"line_number":92,"context_line":"        self._ovn_client_inst \u003d None"},{"line_number":93,"context_line":"        self.scheduler \u003d l3_ovn_scheduler.get_scheduler()"},{"line_number":94,"context_line":"        self.port_forwarding \u003d port_forwarding.OVNPortForwarding(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9818612_c02e25be","line":91,"in_reply_to":"3b7898e2_785633b6","updated":"2022-12-12 12:31:19.000000000","message":"Done","commit_id":"9aa36126056b7a6853413cad8fcc065783281dca"}]}