)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"92341cc3c1b2387ad604d270c562a6b486aaa22d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0934704f_e26f6e63","updated":"2023-01-16 23:02:20.000000000","message":"LGTM. I\u0027m going to let Rodolfo read Lucas feedback, in case he want to implement it","commit_id":"fc10c16c66db03890b582bfeab9b8c7ed3befd6c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6447796f92d4f0168e36adadc9c71704617916dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7e856a5f_500f9b81","updated":"2023-01-17 13:30:16.000000000","message":"Thanks Rodolfo! It LGTM!","commit_id":"37b12a4566d6f6aa63c027598de0c7afc91679e4"}],"neutron/common/ovn/utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"54abdbbe87304cbd8b914db421a5a884d4905688","unresolved":true,"context_lines":[{"line_number":318,"context_line":"    if (constants.OVN_PORT_BINDING_PROFILE not in port or"},{"line_number":319,"context_line":"            not validators.is_attr_set("},{"line_number":320,"context_line":"                port[constants.OVN_PORT_BINDING_PROFILE])):"},{"line_number":321,"context_line":"        return {}, None, []"},{"line_number":322,"context_line":"    param_set \u003d {}"},{"line_number":323,"context_line":"    param_dict \u003d {}"},{"line_number":324,"context_line":"    vnic_type \u003d port.get(portbindings.VNIC_TYPE, portbindings.VNIC_NORMAL)"}],"source_content_type":"text/x-python","patch_set":6,"id":"441f01fb_224085e6","line":321,"updated":"2023-01-16 17:54:29.000000000","message":"Nit/Suggestion: I wonder if a namedtuple would be a better way to organize this return value.\n\n # Global definition\n BP_INFO \u003d collections.namedtuple(\u0027BindingProfileInfo\u0027, [\u0027port_profile\u0027,                                \u0027vnic_type\u0027,\u0027capabilities\u0027])\n \n # Use\n def validate_and_get_data_from_binding_profile(port):\n   ...\n   return BP_INFO({}, None, [])\n   \n # Consuming end\n bp_info \u003d validate_and_get_data_from_binding_profile(port)\n bp_info.port_profile\n bp_info.vnic_type\n bp_info.capabilities","commit_id":"fc10c16c66db03890b582bfeab9b8c7ed3befd6c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"acdc483a1b6de73befab7d056f565de1ecdc4d26","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    if (constants.OVN_PORT_BINDING_PROFILE not in port or"},{"line_number":319,"context_line":"            not validators.is_attr_set("},{"line_number":320,"context_line":"                port[constants.OVN_PORT_BINDING_PROFILE])):"},{"line_number":321,"context_line":"        return {}, None, []"},{"line_number":322,"context_line":"    param_set \u003d {}"},{"line_number":323,"context_line":"    param_dict \u003d {}"},{"line_number":324,"context_line":"    vnic_type \u003d port.get(portbindings.VNIC_TYPE, portbindings.VNIC_NORMAL)"}],"source_content_type":"text/x-python","patch_set":6,"id":"59fda515_9fb4a712","line":321,"in_reply_to":"441f01fb_224085e6","updated":"2023-01-17 13:15:38.000000000","message":"Agree, I always prefer a customized class to ensure the output of a method is this is going to be something complex.","commit_id":"fc10c16c66db03890b582bfeab9b8c7ed3befd6c"}]}