)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"860616086b1cf92f4355e12a3aa00ceef568952f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Set ip_nonlocal_bind to 0 for HA routers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set nonlocal_bind to 1 to allow starting applications in both"},{"line_number":10,"context_line":"routers (like ipsec from vpnaas) to do not rely on python process"},{"line_number":11,"context_line":"for performing router failover."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This revert https://review.opendev.org/393886/ completely, which was"},{"line_number":14,"context_line":"partially reverted by https://review.opendev.org/c/openstack/neutron/+/752360."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3dac3017_3bb33504","line":11,"range":{"start_line":10,"start_character":39,"end_line":11,"end_character":30},"updated":"2022-12-15 09:50:17.000000000","message":"Well, this is done (and was done before) by keepalived, at least the voting process. The L3 agent reads who is the active router and performs the needed actions. Can you explain this a bit more?","commit_id":"e57ceab522cd3b36b918ca33a33f20a8adca58de"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b2c0361989a27db8469395c3e76294ea0dbead4f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Set ip_nonlocal_bind to 0 for HA routers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set nonlocal_bind to 1 to allow starting applications in both"},{"line_number":10,"context_line":"routers (like ipsec from vpnaas) to do not rely on python process"},{"line_number":11,"context_line":"for performing router failover."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This revert https://review.opendev.org/393886/ completely, which was"},{"line_number":14,"context_line":"partially reverted by https://review.opendev.org/c/openstack/neutron/+/752360."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"47b7895f_768039b6","line":11,"range":{"start_line":10,"start_character":39,"end_line":11,"end_character":30},"in_reply_to":"3dac3017_3bb33504","updated":"2022-12-15 10:23:27.000000000","message":"When python process is down, or slow switch from backup to active might take some time. I\u0027m trying to avoid involving python process in this switch https://github.com/openstack/neutron-vpnaas/commit/76b606b8dbb2010538b223823bcf66e9864354c3","commit_id":"e57ceab522cd3b36b918ca33a33f20a8adca58de"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"415fd035c5b280febf6c7cbc1764f570d893c29b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set ip_nonlocal_bind to 0 for HA routers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set nonlocal_bind to 1 to allow starting applications in both"},{"line_number":10,"context_line":"routers (like ipsec from vpnaas) to do not rely on python process"},{"line_number":11,"context_line":"for performing router failover."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This revert https://review.opendev.org/393886/ completely, which was"},{"line_number":14,"context_line":"partially reverted by https://review.opendev.org/c/openstack/neutron/+/752360."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"957ee50d_a98ef190","line":11,"range":{"start_line":10,"start_character":39,"end_line":11,"end_character":30},"in_reply_to":"47b7895f_768039b6","updated":"2023-01-05 08:23:08.000000000","message":"Done","commit_id":"e57ceab522cd3b36b918ca33a33f20a8adca58de"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"860616086b1cf92f4355e12a3aa00ceef568952f","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This revert https://review.opendev.org/393886/ completely, which was"},{"line_number":14,"context_line":"partially reverted by https://review.opendev.org/c/openstack/neutron/+/752360."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I18a15aa3ca745b2b794610350f538d02575ccbe0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"72d9f555_cd060678","line":15,"updated":"2022-12-15 09:50:17.000000000","message":"Can you open a launchpad bug describing the rationale of the issue?","commit_id":"e57ceab522cd3b36b918ca33a33f20a8adca58de"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"415fd035c5b280febf6c7cbc1764f570d893c29b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This revert https://review.opendev.org/393886/ completely, which was"},{"line_number":14,"context_line":"partially reverted by https://review.opendev.org/c/openstack/neutron/+/752360."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I18a15aa3ca745b2b794610350f538d02575ccbe0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e8622cc8_4f712692","line":15,"in_reply_to":"281a85a6_691929c8","updated":"2023-01-05 08:23:08.000000000","message":"Done","commit_id":"e57ceab522cd3b36b918ca33a33f20a8adca58de"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b2c0361989a27db8469395c3e76294ea0dbead4f","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This revert https://review.opendev.org/393886/ completely, which was"},{"line_number":14,"context_line":"partially reverted by https://review.opendev.org/c/openstack/neutron/+/752360."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I18a15aa3ca745b2b794610350f538d02575ccbe0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"281a85a6_691929c8","line":15,"in_reply_to":"72d9f555_cd060678","updated":"2022-12-15 10:23:27.000000000","message":"will do","commit_id":"e57ceab522cd3b36b918ca33a33f20a8adca58de"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e443c677b33bae69b732700984e4b54aa6777be3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-15 13:40:55 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set ip_nonlocal_bind to 0 for HA routers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set nonlocal_bind to 1 to allow starting applications in both"},{"line_number":10,"context_line":"routers (like ipsec from vpnaas). nonlocal_bin 0 prevens us from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"86cbfb11_15b30a3e","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":25},"updated":"2022-12-15 12:23:14.000000000","message":"1","commit_id":"897d94cb54d4875c007c73c533177555d2175944"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e443c677b33bae69b732700984e4b54aa6777be3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-15 13:40:55 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set ip_nonlocal_bind to 0 for HA routers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set nonlocal_bind to 1 to allow starting applications in both"},{"line_number":10,"context_line":"routers (like ipsec from vpnaas). nonlocal_bin 0 prevens us from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"52007dd3_8fa32ee5","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":32},"updated":"2022-12-15 12:23:14.000000000","message":"And for DVR snat, right?","commit_id":"897d94cb54d4875c007c73c533177555d2175944"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"98daebdb1798daa9d90a118fab8068e694d0dff0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-15 13:40:55 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set ip_nonlocal_bind to 0 for HA routers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set nonlocal_bind to 1 to allow starting applications in both"},{"line_number":10,"context_line":"routers (like ipsec from vpnaas). nonlocal_bin 0 prevens us from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c9d64466_a124f82b","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":32},"in_reply_to":"52007dd3_8fa32ee5","updated":"2022-12-15 13:06:59.000000000","message":"Done","commit_id":"897d94cb54d4875c007c73c533177555d2175944"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"98daebdb1798daa9d90a118fab8068e694d0dff0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-15 13:40:55 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set ip_nonlocal_bind to 0 for HA routers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set nonlocal_bind to 1 to allow starting applications in both"},{"line_number":10,"context_line":"routers (like ipsec from vpnaas). nonlocal_bin 0 prevens us from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"80be78b0_ed109c58","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":25},"in_reply_to":"86cbfb11_15b30a3e","updated":"2022-12-15 13:06:59.000000000","message":"Done","commit_id":"897d94cb54d4875c007c73c533177555d2175944"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b2c0361989a27db8469395c3e76294ea0dbead4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79d4ceba_c4f84419","updated":"2022-12-15 10:23:27.000000000","message":"thanks for review Rodolfo.","commit_id":"e57ceab522cd3b36b918ca33a33f20a8adca58de"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"856ecbf1fcff74fa5275f6eeafe8edcd96aaf12d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7ff3d9e6_655fff91","updated":"2022-12-15 15:44:58.000000000","message":"thanks for review Brian","commit_id":"8c17d034c7448e37176374aa711ddcd2318d8f4d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"98daebdb1798daa9d90a118fab8068e694d0dff0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6ccb1697_3dcc9425","updated":"2022-12-15 13:06:59.000000000","message":"thanks for review Oleg","commit_id":"8c17d034c7448e37176374aa711ddcd2318d8f4d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d6dd0e90b46fee6f80b07c16eaf80a4978b18cd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8a741bed_80821f75","updated":"2022-12-25 08:41:15.000000000","message":"recheck","commit_id":"8d9e4ebb6d84637b8afec1aed459c29717ff4922"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5c92e17e42cbd0df8381c83b87d369b5b8e94d15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e24033f4_d843a95e","updated":"2022-12-26 07:39:47.000000000","message":"recheck bug https://bugs.launchpad.net/neutron/+bug/1940425","commit_id":"8d9e4ebb6d84637b8afec1aed459c29717ff4922"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ed5943aaf7a4c68e10b43c08bd20b668bc6622c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b81bb8df_d0ce08ef","updated":"2023-01-10 17:39:12.000000000","message":"There are some typos in the commit message, so if you have to respin you can fix them.","commit_id":"25ec6e7e4fc4df1de69e7f9850d2cb5e442857b9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fd67960278976326e0224690e82e8f4ddd0f3fc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"12817472_37f0c9a5","updated":"2023-01-11 12:04:20.000000000","message":"recheck","commit_id":"25ec6e7e4fc4df1de69e7f9850d2cb5e442857b9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8b2ddc79e998f13da4661da878d4413657aa07e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"35d02844_5c50d0ee","updated":"2023-01-11 16:20:08.000000000","message":"recheck","commit_id":"25ec6e7e4fc4df1de69e7f9850d2cb5e442857b9"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0d61f8542e112ae18d13be6559b4ad9422d9f8ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1f2f7abf_0de4bf1e","updated":"2023-01-09 09:07:41.000000000","message":"recheck CI issue (\"tox.tox_env.python.api.NoInterpreter: could not find python interpreter matching any of the specs py38\")","commit_id":"25ec6e7e4fc4df1de69e7f9850d2cb5e442857b9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"42435c9577593b03c86dbb72e53af4667863ea5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4b22b9bb_690b5d4f","updated":"2023-01-06 13:25:05.000000000","message":"recheck bug https://bugs.launchpad.net/neutron/+bug/1940425","commit_id":"25ec6e7e4fc4df1de69e7f9850d2cb5e442857b9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4ae94815ad2a1380debabf4fb3fdfab18660e8db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d25e920f_8be5d8b6","updated":"2023-01-11 20:05:57.000000000","message":"recheck bug https://bugs.launchpad.net/neutron/+bug/1940425","commit_id":"25ec6e7e4fc4df1de69e7f9850d2cb5e442857b9"}],"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2bd0dbf812a1984de41c5cba4de8dc0e6ceb68e5","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    This namespace sets the ip_nonlocal_bind to 0 for HA router namespaces."},{"line_number":55,"context_line":"    It does so to prevent sending gratuitous ARPs for interfaces that got VIP"},{"line_number":56,"context_line":"    removed in the middle of processing."},{"line_number":57,"context_line":"    It also disables ipv6 forwarding by default. Forwarding will be"},{"line_number":58,"context_line":"    enabled during router configuration processing only for the primary node."},{"line_number":59,"context_line":"    It has to be disabled on all other nodes to avoid sending MLD packets"}],"source_content_type":"text/x-python","patch_set":3,"id":"01f91f1a_07bb94b2","side":"PARENT","line":56,"updated":"2022-12-15 15:36:42.000000000","message":"This comment is important, and looking at commit history points at this bug:\n\nhttps://bugs.launchpad.net/neutron/+bug/1639315\n\nSo we will re-introduce this bug ?","commit_id":"b5fdad3cfb8ec60e8e7934bf55308ecf5d7661b1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"856ecbf1fcff74fa5275f6eeafe8edcd96aaf12d","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    This namespace sets the ip_nonlocal_bind to 0 for HA router namespaces."},{"line_number":55,"context_line":"    It does so to prevent sending gratuitous ARPs for interfaces that got VIP"},{"line_number":56,"context_line":"    removed in the middle of processing."},{"line_number":57,"context_line":"    It also disables ipv6 forwarding by default. Forwarding will be"},{"line_number":58,"context_line":"    enabled during router configuration processing only for the primary node."},{"line_number":59,"context_line":"    It has to be disabled on all other nodes to avoid sending MLD packets"}],"source_content_type":"text/x-python","patch_set":3,"id":"a0c19fe0_80784370","side":"PARENT","line":56,"in_reply_to":"01f91f1a_07bb94b2","updated":"2022-12-15 15:44:58.000000000","message":"According to commit linked to the bug #1639315 it was fixed by https://review.opendev.org/c/openstack/neutron/+/393886/, the issue was caused by keepalived bug https://bugzilla.redhat.com/show_bug.cgi?id\u003d1391553 which was  fixed in keepalived 1.2.20.\nCode that sends gratious arps from https://review.opendev.org/c/openstack/neutron/+/393886/ were reverted by https://review.opendev.org/c/openstack/neutron/+/752360 but ip_nonlocal_bind was left as 0. Since the code that sends garp from HA router is not present, there is no need to set ip_nonlocal_bind to 0 anymore (unless there are other reasons which I\u0027m not aware of).","commit_id":"b5fdad3cfb8ec60e8e7934bf55308ecf5d7661b1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"62bee4551ea2d732bd1c4c573f9168a6bb23f02d","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    This namespace sets the ip_nonlocal_bind to 0 for HA router namespaces."},{"line_number":55,"context_line":"    It does so to prevent sending gratuitous ARPs for interfaces that got VIP"},{"line_number":56,"context_line":"    removed in the middle of processing."},{"line_number":57,"context_line":"    It also disables ipv6 forwarding by default. Forwarding will be"},{"line_number":58,"context_line":"    enabled during router configuration processing only for the primary node."},{"line_number":59,"context_line":"    It has to be disabled on all other nodes to avoid sending MLD packets"}],"source_content_type":"text/x-python","patch_set":3,"id":"d9c3f83a_a02d133a","side":"PARENT","line":56,"in_reply_to":"1ae28c35_bbdd8b87","updated":"2023-01-05 08:23:19.000000000","message":"Done","commit_id":"b5fdad3cfb8ec60e8e7934bf55308ecf5d7661b1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"71be249b174a205d6226906c7d3483d9a3c484b3","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    This namespace sets the ip_nonlocal_bind to 0 for HA router namespaces."},{"line_number":55,"context_line":"    It does so to prevent sending gratuitous ARPs for interfaces that got VIP"},{"line_number":56,"context_line":"    removed in the middle of processing."},{"line_number":57,"context_line":"    It also disables ipv6 forwarding by default. Forwarding will be"},{"line_number":58,"context_line":"    enabled during router configuration processing only for the primary node."},{"line_number":59,"context_line":"    It has to be disabled on all other nodes to avoid sending MLD packets"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed5356f7_c75febf6","side":"PARENT","line":56,"in_reply_to":"a0c19fe0_80784370","updated":"2022-12-21 11:17:28.000000000","message":"This comment should include this information:\n* That we are using keepalived\u003e\u003d1.2.20 (actually this patch should introduce a sanity check for this)\n* An explanation of why LP#1639315 is now solved with this keepalived version.","commit_id":"b5fdad3cfb8ec60e8e7934bf55308ecf5d7661b1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5e941800559fd791a53a9c38a9f02027c8fc9530","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    This namespace sets the ip_nonlocal_bind to 0 for HA router namespaces."},{"line_number":55,"context_line":"    It does so to prevent sending gratuitous ARPs for interfaces that got VIP"},{"line_number":56,"context_line":"    removed in the middle of processing."},{"line_number":57,"context_line":"    It also disables ipv6 forwarding by default. Forwarding will be"},{"line_number":58,"context_line":"    enabled during router configuration processing only for the primary node."},{"line_number":59,"context_line":"    It has to be disabled on all other nodes to avoid sending MLD packets"}],"source_content_type":"text/x-python","patch_set":3,"id":"f9bb6142_77592a7b","side":"PARENT","line":56,"in_reply_to":"ed5356f7_c75febf6","updated":"2022-12-24 19:51:24.000000000","message":"I\u0027ve added this check in separate patch https://review.opendev.org/c/openstack/neutron/+/868524","commit_id":"b5fdad3cfb8ec60e8e7934bf55308ecf5d7661b1"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"17217f149f18dbdcf08460293333c7ad9bff9b4e","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    This namespace sets the ip_nonlocal_bind to 0 for HA router namespaces."},{"line_number":55,"context_line":"    It does so to prevent sending gratuitous ARPs for interfaces that got VIP"},{"line_number":56,"context_line":"    removed in the middle of processing."},{"line_number":57,"context_line":"    It also disables ipv6 forwarding by default. Forwarding will be"},{"line_number":58,"context_line":"    enabled during router configuration processing only for the primary node."},{"line_number":59,"context_line":"    It has to be disabled on all other nodes to avoid sending MLD packets"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae28c35_bbdd8b87","side":"PARENT","line":56,"in_reply_to":"f9bb6142_77592a7b","updated":"2022-12-26 07:59:56.000000000","message":"Please also update the doc-string as per Rodolfo\u0027s comment","commit_id":"b5fdad3cfb8ec60e8e7934bf55308ecf5d7661b1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"71be249b174a205d6226906c7d3483d9a3c484b3","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    This namespace sets the ip_nonlocal_bind to 1 for HA router namespaces."},{"line_number":55,"context_line":"    It allows to setup applications on both routers simulteniously like"},{"line_number":56,"context_line":"    ipsec from VPNaaS which speed up theirs failover and let HA work even when"},{"line_number":57,"context_line":"    python is down."},{"line_number":58,"context_line":"    It also disables ipv6 forwarding by default. Forwarding will be"},{"line_number":59,"context_line":"    enabled during router configuration processing only for the primary node."},{"line_number":60,"context_line":"    It has to be disabled on all other nodes to avoid sending MLD packets"}],"source_content_type":"text/x-python","patch_set":3,"id":"af099a0b_98bf4119","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":18},"updated":"2022-12-21 11:17:28.000000000","message":"That will be VPNaaS only, not the Neutron routers.","commit_id":"8c17d034c7448e37176374aa711ddcd2318d8f4d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5e941800559fd791a53a9c38a9f02027c8fc9530","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    This namespace sets the ip_nonlocal_bind to 1 for HA router namespaces."},{"line_number":55,"context_line":"    It allows to setup applications on both routers simulteniously like"},{"line_number":56,"context_line":"    ipsec from VPNaaS which speed up theirs failover and let HA work even when"},{"line_number":57,"context_line":"    python is down."},{"line_number":58,"context_line":"    It also disables ipv6 forwarding by default. Forwarding will be"},{"line_number":59,"context_line":"    enabled during router configuration processing only for the primary node."},{"line_number":60,"context_line":"    It has to be disabled on all other nodes to avoid sending MLD packets"}],"source_content_type":"text/x-python","patch_set":3,"id":"766058ab_5b993edd","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":18},"in_reply_to":"af099a0b_98bf4119","updated":"2022-12-24 19:51:24.000000000","message":"Done","commit_id":"8c17d034c7448e37176374aa711ddcd2318d8f4d"}]}