)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3e83eba40bb529b7b47ff7b5871cb2557872f0ae","unresolved":true,"context_lines":[{"line_number":786,"context_line":"                # We need to remove the old entries"},{"line_number":787,"context_line":"                self.add_txns_to_remove_port_dns_records(txn, port_object)"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"            # Query dnat_and_snat entries related this logical_port"},{"line_number":790,"context_line":"            nats \u003d self._nb_idl.db_find_rows("},{"line_number":791,"context_line":"                \u0027NAT\u0027,"},{"line_number":792,"context_line":"                (\u0027logical_port\u0027, \u0027\u003d\u0027, port[\u0027id\u0027]),"}],"source_content_type":"text/x-python","patch_set":1,"id":"97c0946d_242a0247","line":789,"range":{"start_line":789,"start_character":12,"end_line":789,"end_character":67},"updated":"2022-12-16 11:17:13.000000000","message":"I have some considerations.\n1) This method is not considering when you are adding a new fixed IP, without removing the other one.\n2) When changing the port IP, the Neutron API still shows the removed fixed IP. This change does not only affects OVN but the API itself.\n\nIMO, we should prevent deleting/changing the fixed IP if it is linked to a FIP.","commit_id":"e4c29187c90cdeefb3c046e19127456a6d785a43"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"1f34682ad19a0a8f4805776b5030960570011407","unresolved":true,"context_lines":[{"line_number":786,"context_line":"                # We need to remove the old entries"},{"line_number":787,"context_line":"                self.add_txns_to_remove_port_dns_records(txn, port_object)"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"            # Query dnat_and_snat entries related this logical_port"},{"line_number":790,"context_line":"            nats \u003d self._nb_idl.db_find_rows("},{"line_number":791,"context_line":"                \u0027NAT\u0027,"},{"line_number":792,"context_line":"                (\u0027logical_port\u0027, \u0027\u003d\u0027, port[\u0027id\u0027]),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3741ced8_b554fcab","line":789,"range":{"start_line":789,"start_character":12,"end_line":789,"end_character":67},"in_reply_to":"97c0946d_242a0247","updated":"2022-12-16 12:56:39.000000000","message":"1)Yeah, I also considered it, but actually the case that multiple ipv4 addresses not support now, right?\n2)You are right.\nMaybe we could raise an error when deleting/changing the fixed IP if it is linked to a FIP in ml2/plugin. It is also expensive because it should query neutron db for FIP.\nemm, I gotta think...","commit_id":"e4c29187c90cdeefb3c046e19127456a6d785a43"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3e83eba40bb529b7b47ff7b5871cb2557872f0ae","unresolved":true,"context_lines":[{"line_number":798,"context_line":"                    fixed_ip_v4 \u003d None"},{"line_number":799,"context_line":"                    for fixed_ip in port[\u0027fixed_ips\u0027]:"},{"line_number":800,"context_line":"                        subnet_id \u003d fixed_ip[\u0027subnet_id\u0027]"},{"line_number":801,"context_line":"                        subnet \u003d self._plugin.get_subnet(context, subnet_id)"},{"line_number":802,"context_line":"                        # Only consider ipv4 address"},{"line_number":803,"context_line":"                        if subnet[\u0027ip_version\u0027] \u003d\u003d const.IP_VERSION_4:"},{"line_number":804,"context_line":"                            fixed_ip_v4 \u003d fixed_ip[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"b39efee5_98039415","line":801,"range":{"start_line":801,"start_character":24,"end_line":801,"end_character":76},"updated":"2022-12-16 11:17:13.000000000","message":"This operation is expensive. Please consider not calling the DB.","commit_id":"e4c29187c90cdeefb3c046e19127456a6d785a43"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"1f34682ad19a0a8f4805776b5030960570011407","unresolved":true,"context_lines":[{"line_number":798,"context_line":"                    fixed_ip_v4 \u003d None"},{"line_number":799,"context_line":"                    for fixed_ip in port[\u0027fixed_ips\u0027]:"},{"line_number":800,"context_line":"                        subnet_id \u003d fixed_ip[\u0027subnet_id\u0027]"},{"line_number":801,"context_line":"                        subnet \u003d self._plugin.get_subnet(context, subnet_id)"},{"line_number":802,"context_line":"                        # Only consider ipv4 address"},{"line_number":803,"context_line":"                        if subnet[\u0027ip_version\u0027] \u003d\u003d const.IP_VERSION_4:"},{"line_number":804,"context_line":"                            fixed_ip_v4 \u003d fixed_ip[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"904d22e5_21ce7df3","line":801,"range":{"start_line":801,"start_character":24,"end_line":801,"end_character":76},"in_reply_to":"b39efee5_98039415","updated":"2022-12-16 12:56:39.000000000","message":"OK","commit_id":"e4c29187c90cdeefb3c046e19127456a6d785a43"}]}