)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"228087b12b611639336de4fbd5f0771b39e36a97","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     LIU Yulong \u003ci@liuyulong.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-05 16:25:33 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds a RPC for ovs-agent to get server side config options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a starts for ovs-agent to get config options from"},{"line_number":10,"context_line":"neutron-server side. The L3_HA_NET_CIDR \u003d \u0027169.254.192.0/18\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f9e5714a_1ecacda3","line":7,"updated":"2024-02-06 18:16:26.000000000","message":"the title of the commit doesn\u0027t explain the actual effect of the change. A reader could think that this commit merely adds a new rpc entrypoint but no functional change to the behavior of the agent were introduced. (Which is not the case.)","commit_id":"c0b26db8fa87e40880c61a058e9be204f68c6121"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a9cabdf68dee780e9e73644ef94c297424c55d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"02e1a0d6_01f303f7","updated":"2023-12-01 18:50:33.000000000","message":"I think this change is useful might just need a rebase.","commit_id":"aeb5a445661cd36d32ef87a3c1637816cd5d9492"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"072630f255b501f94ac13d6a4f44256ccb388104","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d2872afc_79e71383","in_reply_to":"02e1a0d6_01f303f7","updated":"2023-12-05 08:19:10.000000000","message":"Done","commit_id":"aeb5a445661cd36d32ef87a3c1637816cd5d9492"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"deee15c79ec3e89bc45945f11078ed098be436d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1c18e045_2a93f3f8","updated":"2024-01-22 01:24:05.000000000","message":"Adding Rodolfo to get a second opinion","commit_id":"c0b26db8fa87e40880c61a058e9be204f68c6121"}],"neutron/agent/rpc.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"228087b12b611639336de4fbd5f0771b39e36a97","unresolved":true,"context_lines":[{"line_number":127,"context_line":"              - update_device_up"},{"line_number":128,"context_line":"              - update_device_list (indirectly, called from update_device_down"},{"line_number":129,"context_line":"                and update_device_up)"},{"line_number":130,"context_line":"        1.10 - Support get_neutron_server_confs"},{"line_number":131,"context_line":"    \u0027\u0027\u0027"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, topic):"}],"source_content_type":"text/x-python","patch_set":5,"id":"4dd99f6c_be4379ce","line":130,"range":{"start_line":130,"start_character":42,"end_line":130,"end_character":47},"updated":"2024-02-06 18:16:26.000000000","message":"nit: confs \u003d configurations. I think configuration is singular. (options are not). A better name would be either `get_server_config` or `get_server_config_options`.\n\n(Note also that neutron is not in the name, since it\u0027s self-evident.)","commit_id":"c0b26db8fa87e40880c61a058e9be204f68c6121"}],"neutron/plugins/ml2/rpc.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a9cabdf68dee780e9e73644ef94c297424c55d43","unresolved":true,"context_lines":[{"line_number":442,"context_line":"            rpc_context, vnic_type\u003dvnic_type, host\u003dhost)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def get_neutron_server_confs(self, rpc_context):"},{"line_number":445,"context_line":"        return {\u0027l3_ha_net_cidr\u0027: cfg.CONF.l3_ha_net_cidr}"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"class AgentNotifierApi(dvr_rpc.DVRAgentRpcApiMixin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ae659b50_d407946d","line":445,"updated":"2023-12-01 18:50:33.000000000","message":"Have a couple of comments.\n\n1) The name of the method and RPC call doesn\u0027t exactly match what it\u0027s doing, it\u0027s only getting a single config value, not all server configs, I think it should be renamed if that\u0027s all it does, like get_l3_ha_net_cidr_config?\n\n2) Is there a need for other values here where it could be more generic, like get_l3_ha_opts? Doesn\u0027t look like it.","commit_id":"aeb5a445661cd36d32ef87a3c1637816cd5d9492"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"072630f255b501f94ac13d6a4f44256ccb388104","unresolved":true,"context_lines":[{"line_number":442,"context_line":"            rpc_context, vnic_type\u003dvnic_type, host\u003dhost)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def get_neutron_server_confs(self, rpc_context):"},{"line_number":445,"context_line":"        return {\u0027l3_ha_net_cidr\u0027: cfg.CONF.l3_ha_net_cidr}"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"class AgentNotifierApi(dvr_rpc.DVRAgentRpcApiMixin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"d63d5bab_c8cc874d","line":445,"in_reply_to":"ae659b50_d407946d","updated":"2023-12-05 08:19:10.000000000","message":"This methods can be extended to have more neutron-server config options. This is why name it as get_neutron_server_confs. For this patch, ovs-agent only needs the option of l3_ha_net_cidr.","commit_id":"aeb5a445661cd36d32ef87a3c1637816cd5d9492"}]}