)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"53169fa5f87841da0d2d4dc21bcc5c2e22d8f981","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"149cdf13_70ce2903","updated":"2022-12-28 12:09:37.000000000","message":"1.2.20 looks quite old version and also the workaround https://review.opendev.org/c/openstack/neutron/+/752360 reverted long back, not sure how much it worth adding the sanity check now but also adding it shouldn\u0027t hurt and would be safe to avoid older keepalived\u003c1.2.20 is being used somehow.","commit_id":"be0776d647453be52d269403ba33d42e42240727"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fb096da0360457de55d2ab2cebe39a3f31e88db6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"16ed3f08_224f7fb7","updated":"2022-12-27 18:25:36.000000000","message":"recheck","commit_id":"be0776d647453be52d269403ba33d42e42240727"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"facf44670d3ced00608ecf2ac9f0418f7b9b4fc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4eb4b297_2af54f39","updated":"2022-12-27 21:24:57.000000000","message":"recheck bug https://bugs.launchpad.net/neutron/+bug/1940425","commit_id":"be0776d647453be52d269403ba33d42e42240727"}],"neutron/cmd/runtime_checks.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"397a02775a637cd935038995a88ebb6c1bc1d802","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    keepalived_with_track \u003d version.parse(\u00272.0.3\u0027)"},{"line_number":59,"context_line":"    keepalived_version \u003d get_keepalived_version()"},{"line_number":60,"context_line":"    if keepalived_version:"},{"line_number":61,"context_line":"        return keepalived_version \u003e\u003d keepalived_with_track"}],"source_content_type":"text/x-python","patch_set":5,"id":"1486377e_a49f1bff","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":25},"updated":"2022-12-26 07:37:21.000000000","message":"else: return False?","commit_id":"8a4c89d6dcc2cf7576127f4a12c5a0eeea4d34bf"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5bfdbcf7f91be411ff8f20746bdcf16ab5f6abb8","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    keepalived_with_track \u003d version.parse(\u00272.0.3\u0027)"},{"line_number":59,"context_line":"    keepalived_version \u003d get_keepalived_version()"},{"line_number":60,"context_line":"    if keepalived_version:"},{"line_number":61,"context_line":"        return keepalived_version \u003e\u003d keepalived_with_track"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a748f64_f4fb1ff4","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":25},"in_reply_to":"1486377e_a49f1bff","updated":"2022-12-27 13:25:28.000000000","message":"Done","commit_id":"8a4c89d6dcc2cf7576127f4a12c5a0eeea4d34bf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86f6a036738d34566d6fc5d6fcb4830136f636a6","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        return keepalived_version"},{"line_number":51,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":52,"context_line":"        LOG.exception(\"Failed to get keepalived version\")"},{"line_number":53,"context_line":"        return False"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def keepalived_use_no_track_support():"}],"source_content_type":"text/x-python","patch_set":6,"id":"cadf4ef3_2c4a7e59","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":20},"updated":"2023-01-02 11:03:10.000000000","message":"nit: If we are expecting a string/number, we should not return a boolean in case of error but None","commit_id":"be0776d647453be52d269403ba33d42e42240727"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"397a02775a637cd935038995a88ebb6c1bc1d802","unresolved":true,"context_lines":[{"line_number":429,"context_line":"def keepalived_garp_on_sighup_supported():"},{"line_number":430,"context_line":"    keepalived_garp_on_sighup \u003d (\u00271.2.20\u0027)"},{"line_number":431,"context_line":"    keepalived_version \u003d runtime_checks.get_keepalived_version()"},{"line_number":432,"context_line":"    if keepalived_version:"},{"line_number":433,"context_line":"        return keepalived_version \u003e\u003d keepalived_garp_on_sighup"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a3caefc4_c63f6c88","line":432,"range":{"start_line":432,"start_character":4,"end_line":432,"end_character":26},"updated":"2022-12-26 07:37:21.000000000","message":"else: return False","commit_id":"8a4c89d6dcc2cf7576127f4a12c5a0eeea4d34bf"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3384c53a6c65f5aade83d530d95d77b2aa19b9c4","unresolved":false,"context_lines":[{"line_number":429,"context_line":"def keepalived_garp_on_sighup_supported():"},{"line_number":430,"context_line":"    keepalived_garp_on_sighup \u003d (\u00271.2.20\u0027)"},{"line_number":431,"context_line":"    keepalived_version \u003d runtime_checks.get_keepalived_version()"},{"line_number":432,"context_line":"    if keepalived_version:"},{"line_number":433,"context_line":"        return keepalived_version \u003e\u003d keepalived_garp_on_sighup"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a946f325_d93fbab9","line":432,"range":{"start_line":432,"start_character":4,"end_line":432,"end_character":26},"in_reply_to":"a3caefc4_c63f6c88","updated":"2022-12-27 13:25:39.000000000","message":"Done","commit_id":"8a4c89d6dcc2cf7576127f4a12c5a0eeea4d34bf"}],"neutron/cmd/sanity_check.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"397a02775a637cd935038995a88ebb6c1bc1d802","unresolved":true,"context_lines":[{"line_number":161,"context_line":"                  \u0027dataplane downtime during HA router failover. \u0027"},{"line_number":162,"context_line":"                  \u0027Please use at least version 1.2.20 which support \u0027"},{"line_number":163,"context_line":"                  \u0027sending garp on SIGHUP.\u0027)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"def check_dibbler_version():"},{"line_number":167,"context_line":"    result \u003d checks.dibbler_version_supported()"}],"source_content_type":"text/x-python","patch_set":5,"id":"687df43d_1374fcaa","line":164,"updated":"2022-12-26 07:37:21.000000000","message":"return result?","commit_id":"8a4c89d6dcc2cf7576127f4a12c5a0eeea4d34bf"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5bfdbcf7f91be411ff8f20746bdcf16ab5f6abb8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                  \u0027dataplane downtime during HA router failover. \u0027"},{"line_number":162,"context_line":"                  \u0027Please use at least version 1.2.20 which support \u0027"},{"line_number":163,"context_line":"                  \u0027sending garp on SIGHUP.\u0027)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"def check_dibbler_version():"},{"line_number":167,"context_line":"    result \u003d checks.dibbler_version_supported()"}],"source_content_type":"text/x-python","patch_set":5,"id":"f909cc60_8defbd7d","line":164,"in_reply_to":"687df43d_1374fcaa","updated":"2022-12-27 13:25:28.000000000","message":"Done","commit_id":"8a4c89d6dcc2cf7576127f4a12c5a0eeea4d34bf"}]}