)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6936185c61e499c6ac9ead3e3b276e0945e0e77f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"904a79fb_f398d36b","updated":"2023-01-04 10:14:47.000000000","message":"Looks reasonable and helpful. Just one thing. Thanks you.","commit_id":"56c6314ec6667db2ad91d040783f46a68ce9900a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1024bbaac5e8fe8663ca6e890507ba78dd5ef8b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5baa6a20_f319822e","updated":"2023-01-06 08:14:18.000000000","message":"Feel like it\u0027s a bit too much logs, but as we are in debug no need to argue. Thank you.","commit_id":"0b78a10ed83827962f66fe4140deb9ca5295e03a"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"5d5b1d22d0641412c34b585987236dc2dbe3d92f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d6fe96e6_4439c850","updated":"2023-03-10 15:41:59.000000000","message":"recheck","commit_id":"0b78a10ed83827962f66fe4140deb9ca5295e03a"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"1b6b82225425377b27c9869a27c85fa0cbc3549d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"662868b9_77da4b76","updated":"2023-05-22 10:33:37.000000000","message":"recheck","commit_id":"78dbe55f19b61dc977bb255d135049712ceb0e8c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"322cabe911500f9d1ab73c2beb5f005a4278bb47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"766a5978_496562a4","updated":"2023-05-05 08:02:31.000000000","message":"recheck\nneutron.tests.fullstack.test_agent_bandwidth_report.TestPlacementBandwidthReport failure is not related (I have to check if it is frequent recently)","commit_id":"78dbe55f19b61dc977bb255d135049712ceb0e8c"}],"neutron/agent/common/ovsdb_monitor.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6936185c61e499c6ac9ead3e3b276e0945e0e77f","unresolved":true,"context_lines":[{"line_number":140,"context_line":"                        devices_modified.append(device)"},{"line_number":141,"context_line":"                    dev_to_ofport[name] \u003d ofport"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        if devices_added:"},{"line_number":144,"context_line":"            LOG.debug("},{"line_number":145,"context_line":"                \u0027Adding %(len)s \"added\" events to new_events: %(events)s\u0027,"},{"line_number":146,"context_line":"                {\"len\": len(devices_added), \"events\": devices_added})"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb3f4f63_a4efc8e3","line":143,"updated":"2023-01-04 10:14:47.000000000","message":"This should be just one log with device_added, modified, removed. Also you don\u0027t want to add a condition that show or not a log, specifically in debug, You want to always show it, that helps to compare expected behaviors. \n\nOnly the severity should be used.","commit_id":"56c6314ec6667db2ad91d040783f46a68ce9900a"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"52140b2ced71d1ec6fcfba01954fee6ddb78386a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                        devices_modified.append(device)"},{"line_number":141,"context_line":"                    dev_to_ofport[name] \u003d ofport"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        if devices_added:"},{"line_number":144,"context_line":"            LOG.debug("},{"line_number":145,"context_line":"                \u0027Adding %(len)s \"added\" events to new_events: %(events)s\u0027,"},{"line_number":146,"context_line":"                {\"len\": len(devices_added), \"events\": devices_added})"}],"source_content_type":"text/x-python","patch_set":1,"id":"26d81d8e_31924df9","line":143,"in_reply_to":"eb3f4f63_a4efc8e3","updated":"2023-01-04 16:58:35.000000000","message":"Done","commit_id":"56c6314ec6667db2ad91d040783f46a68ce9900a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6936185c61e499c6ac9ead3e3b276e0945e0e77f","unresolved":true,"context_lines":[{"line_number":157,"context_line":"        self.new_events[\u0027removed\u0027].extend(devices_removed)"},{"line_number":158,"context_line":"        self.new_events[\u0027modified\u0027].extend(devices_modified)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if any([len(self.new_events[\u0027added\u0027]) \u003e 0,"},{"line_number":161,"context_line":"                len(self.new_events[\u0027modified\u0027]) \u003e 0,"},{"line_number":162,"context_line":"                len(self.new_events[\u0027removed\u0027]) \u003e 0]):"},{"line_number":163,"context_line":"            LOG.debug("}],"source_content_type":"text/x-python","patch_set":1,"id":"d02d1e32_0338127c","line":160,"updated":"2023-01-04 10:14:47.000000000","message":"Same here, I would have removed the condition.","commit_id":"56c6314ec6667db2ad91d040783f46a68ce9900a"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"52140b2ced71d1ec6fcfba01954fee6ddb78386a","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.new_events[\u0027removed\u0027].extend(devices_removed)"},{"line_number":158,"context_line":"        self.new_events[\u0027modified\u0027].extend(devices_modified)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if any([len(self.new_events[\u0027added\u0027]) \u003e 0,"},{"line_number":161,"context_line":"                len(self.new_events[\u0027modified\u0027]) \u003e 0,"},{"line_number":162,"context_line":"                len(self.new_events[\u0027removed\u0027]) \u003e 0]):"},{"line_number":163,"context_line":"            LOG.debug("}],"source_content_type":"text/x-python","patch_set":1,"id":"e4c16d6f_9627c7db","line":160,"in_reply_to":"d02d1e32_0338127c","updated":"2023-01-04 16:58:35.000000000","message":"Done","commit_id":"56c6314ec6667db2ad91d040783f46a68ce9900a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1024bbaac5e8fe8663ca6e890507ba78dd5ef8b6","unresolved":true,"context_lines":[{"line_number":140,"context_line":"                        devices_modified.append(device)"},{"line_number":141,"context_line":"                    dev_to_ofport[name] \u003d ofport"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        LOG.debug("},{"line_number":144,"context_line":"            \u0027Extending new_events with: \u0027"},{"line_number":145,"context_line":"            \u0027%(len_added)s added, \u0027"},{"line_number":146,"context_line":"            \u0027%(len_modified)s modified, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"c68f8d9b_c5e9e44b","line":143,"updated":"2023-01-06 08:14:18.000000000","message":"I would say we have tests that assert behavior. So from log that you have added line 120 we should be able to say that, event added,modified,removed are correct.","commit_id":"0b78a10ed83827962f66fe4140deb9ca5295e03a"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"519a58b3e7d40472cd78122b5bc98c3d9ad41b91","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                        devices_modified.append(device)"},{"line_number":141,"context_line":"                    dev_to_ofport[name] \u003d ofport"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        LOG.debug("},{"line_number":144,"context_line":"            \u0027Extending new_events with: \u0027"},{"line_number":145,"context_line":"            \u0027%(len_added)s added, \u0027"},{"line_number":146,"context_line":"            \u0027%(len_modified)s modified, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"70757047_dd277fc9","line":143,"in_reply_to":"c68f8d9b_c5e9e44b","updated":"2023-05-04 09:23:38.000000000","message":"Ack","commit_id":"0b78a10ed83827962f66fe4140deb9ca5295e03a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1024bbaac5e8fe8663ca6e890507ba78dd5ef8b6","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        self.new_events[\u0027modified\u0027].extend(devices_modified)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        LOG.debug("},{"line_number":163,"context_line":"            \u0027Current size of new_events: added\u003d%(added)s \u0027"},{"line_number":164,"context_line":"            \u0027modified\u003d%(modified)s removed\u003d%(removed)s\u0027,"},{"line_number":165,"context_line":"            {\"added\": len(self.new_events[\u0027added\u0027]),"},{"line_number":166,"context_line":"             \"modified\": len(self.new_events[\u0027modified\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"bdd0219d_a8384eee","line":163,"updated":"2023-01-06 08:14:18.000000000","message":"dito","commit_id":"0b78a10ed83827962f66fe4140deb9ca5295e03a"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"519a58b3e7d40472cd78122b5bc98c3d9ad41b91","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        self.new_events[\u0027modified\u0027].extend(devices_modified)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        LOG.debug("},{"line_number":163,"context_line":"            \u0027Current size of new_events: added\u003d%(added)s \u0027"},{"line_number":164,"context_line":"            \u0027modified\u003d%(modified)s removed\u003d%(removed)s\u0027,"},{"line_number":165,"context_line":"            {\"added\": len(self.new_events[\u0027added\u0027]),"},{"line_number":166,"context_line":"             \"modified\": len(self.new_events[\u0027modified\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"93918caa_9eb5e9cc","line":163,"in_reply_to":"bdd0219d_a8384eee","updated":"2023-05-04 09:23:38.000000000","message":"I refactored into one line, with the size of each elements and the whole events printed.\nThat should be enough for debug purpose","commit_id":"0b78a10ed83827962f66fe4140deb9ca5295e03a"}]}