)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e724272fe496d1581ed87e3f26aa9e2e277b6341","unresolved":true,"context_lines":[{"line_number":13,"context_line":"set on the device before moving on to configure MTU and other attributes"},{"line_number":14,"context_line":"of the device."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Brian Haley \u003chaleyb.dev@gmail.com\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-bug: #2000164"},{"line_number":19,"context_line":"Change-Id: I23facc53795a9592ccb137c60fb1f356406a4e00"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"35faa525_5032e56a","line":16,"updated":"2023-01-10 15:34:39.000000000","message":"Now if only stackalytics counted this (or actually worked :)","commit_id":"c3620166204d2d12729ca1eba92feaadbe802d42"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"20c5699891ccefa2526b0e2ebad82469055c9d4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b95e0e53_d8544b4d","updated":"2023-01-04 21:39:03.000000000","message":"You\u0027ll have to tweak the unit test code to account for the \"get\" of the link address, this worked for me, I couldn\u0027t get PropertyMock() to work.\n\ndiff --git a/neutron/tests/unit/agent/linux/test_interface.py b/neutron/tests/unit/agent/linux/test_interface.py\nindex 9b3b5ca13e..726e4c2743 100644\n--- a/neutron/tests/unit/agent/linux/test_interface.py\n+++ b/neutron/tests/unit/agent/linux/test_interface.py\n@@ -72,6 +72,8 @@ class TestBase(base.BaseTestCase):\n         self.ip_dev \u003d self.ip_dev_p.start()\n         self.ip_p \u003d mock.patch.object(ip_lib, \u0027IPWrapper\u0027)\n         self.ip \u003d self.ip_p.start()\n+        link \u003d self.ip.return_value.device.return_value.link\n+        link.address \u003d \u0027aa:bb:cc:dd:ee:ff\u0027\n         self.device_exists_p \u003d mock.patch.object(ip_lib, \u0027device_exists\u0027)\n         self.device_exists \u003d self.device_exists_p.start()\n         self.get_devices_with_ip_p \u003d mock.patch.object(ip_lib,\n@@ -492,12 +494,11 @@ class TestOVSInterfaceDriver(TestBase):\n                     reraise \u003d mock.patch.object(\n                         excutils, \u0027save_and_reraise_exception\u0027)\n                     reraise.start()\n-                    ip_wrapper \u003d mock.Mock()\n                     for exception in (OSError(),\n                                       pyroute2_exc.NetlinkError(22),\n                                       RuntimeError()):\n-                        ip_wrapper.ensure_namespace.side_effect \u003d exception\n-                        self.ip.return_value \u003d ip_wrapper\n+                        ip \u003d self.ip.return_value\n+                        ip.ensure_namespace.side_effect \u003d exception\n                         delete_port.reset_mock()\n                         ovs.plug_new(\n                             \u002701234567-1234-1234-99\u0027,\n@@ -573,6 +574,7 @@ class TestOVSInterfaceDriverWithVeth(TestOVSInterfaceDriver):\n                 interface, \u0027_get_veth\u0027,\n                 return_value\u003d(root_dev, ns_dev)).start()\n             ns_dev.name \u003d devname\n+            ns_dev.link.address \u003d \u0027aa:bb:cc:dd:ee:ff\u0027\n \n             expected \u003d [mock.call(),\n                         mock.call().add_veth(\u0027tap0\u0027, devname,","commit_id":"51a49ffc048d8a2887be0638fda5c5033cb169ce"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"16c16ca4345a5c7c46de7e21aa15c267584d0e87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81e426dc_1e287be6","in_reply_to":"b95e0e53_d8544b4d","updated":"2023-01-09 11:40:21.000000000","message":"Thx Brian. That indeed works fine.","commit_id":"51a49ffc048d8a2887be0638fda5c5033cb169ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e724272fe496d1581ed87e3f26aa9e2e277b6341","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7bcff44e_24cc5780","updated":"2023-01-10 15:34:39.000000000","message":"LGTM","commit_id":"c3620166204d2d12729ca1eba92feaadbe802d42"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"48fbfa9fa494042f567b36787039059e53a2fbc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e302bdb_f9cc8858","updated":"2023-01-16 12:46:12.000000000","message":"recheck\nFullstack timeout is interesting as https://review.opendev.org/c/openstack/neutron/+/870096 was merged","commit_id":"c3620166204d2d12729ca1eba92feaadbe802d42"}]}