)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6189995b4a7e382151b929332bcdfacee4d9067c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"the target network segment."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"depends on new constant \u0027DEVICE_OWNER_MANILA_PREFIX\u0027 in neutron-lib"},{"line_number":16,"context_line":"Depends-On: I9be781d99a08a6a015c3747eb15f20bc356cf08e"},{"line_number":17,"context_line":"Partial-Bug: #1580880"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I647d00a30564ade246e704ff199b6aceafdc4c50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1203b764_9f73e945","line":16,"updated":"2023-01-06 15:51:08.000000000","message":"Unfortunately a change in neutron-lib can\u0027t be tested this way, you have to wait for a new release and update requirements.txt accordingly. If you look in the logs for the failed job you\u0027ll see an AttributeError in q-svc.log for the constant.\n\nIf you need to use the value sooner you could put it in ./neutron/plugins/ml2/common/constants.py then update the code once neutron-lib is released.","commit_id":"3afae8dece927734b513f83bb17d871780294699"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"cd1e83761deed75e2ad821b90bed461cfcb08dad","unresolved":false,"context_lines":[{"line_number":13,"context_line":"the target network segment."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"depends on new constant \u0027DEVICE_OWNER_MANILA_PREFIX\u0027 in neutron-lib"},{"line_number":16,"context_line":"Depends-On: I9be781d99a08a6a015c3747eb15f20bc356cf08e"},{"line_number":17,"context_line":"Partial-Bug: #1580880"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I647d00a30564ade246e704ff199b6aceafdc4c50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"80b7a9a0_ef837420","line":16,"in_reply_to":"1203b764_9f73e945","updated":"2023-01-06 16:12:08.000000000","message":"Ack","commit_id":"3afae8dece927734b513f83bb17d871780294699"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"64424b7f730af7a3c1b2466ebc2bccc3a2513c7f","unresolved":true,"context_lines":[{"line_number":12,"context_line":"similar way: issue port binding upfront to determine the segmentation id in"},{"line_number":13,"context_line":"the target network segment."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Bug: #1580880"},{"line_number":16,"context_line":"Change-Id: I647d00a30564ade246e704ff199b6aceafdc4c50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cad3b31a_d25bdd6a","line":15,"updated":"2023-01-06 19:15:44.000000000","message":"One more thing. This bug is quite old and the fixes for it released over 3 years ago. I think for this change you will want to open a new bug as it seems a little different. Is there a corresponding change in Manila to support this as well?\n\nYou would want to add a release note as well, since it might be an easy way for people to find out it is now supported.","commit_id":"603e8af9468ef9c296aa359ee0fd7d8d843e652c"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"ce5bd5ff50378ab3ce018a7af3f5b3159748c0d3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"similar way: issue port binding upfront to determine the segmentation id in"},{"line_number":13,"context_line":"the target network segment."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Bug: #1580880"},{"line_number":16,"context_line":"Change-Id: I647d00a30564ade246e704ff199b6aceafdc4c50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6603084c_18b1fccf","line":15,"in_reply_to":"cad3b31a_d25bdd6a","updated":"2023-01-18 07:02:30.000000000","message":"Makes sense, I opened a new bug + added a reno.\n\nThe change in manila making use of this enhancement is proposed with https://review.opendev.org/c/openstack/manila/+/869720\n(I added the same comment to the bug)","commit_id":"603e8af9468ef9c296aa359ee0fd7d8d843e652c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6189995b4a7e382151b929332bcdfacee4d9067c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4e2f328c_7cf1aeee","updated":"2023-01-06 15:51:08.000000000","message":"Hi Maurice, thanks for the change!","commit_id":"3afae8dece927734b513f83bb17d871780294699"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c587fc3ac08111a9f66b7ac7c9a6d8a8d288a95d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"211ef943_75da878a","updated":"2023-01-17 09:40:01.000000000","message":"Could you please add some unit tests also?\nAs I see the tempest failures not related","commit_id":"603e8af9468ef9c296aa359ee0fd7d8d843e652c"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"ce5bd5ff50378ab3ce018a7af3f5b3159748c0d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"339076a2_6bf64a16","in_reply_to":"211ef943_75da878a","updated":"2023-01-18 07:02:30.000000000","message":"Done","commit_id":"603e8af9468ef9c296aa359ee0fd7d8d843e652c"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"b34bafca9861eecd4da1ccbac8fe83c6473543a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"39187afc_a3c676bd","updated":"2023-02-06 08:22:12.000000000","message":"Thanks for the review, Slawek.","commit_id":"08b0d3ec36bd563970419da893da239a768e39ba"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"63a17891a9c6b27946ec975839a18a1b2f4e3a6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e6ef4f23_d59e1662","updated":"2023-02-07 09:55:18.000000000","message":"Don\u0027t think test failure is related, can +W once it\u0027s passing.","commit_id":"5c697b8d60571ef4a052586a73edd3d513d0d635"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"a55f4bebdff7d9bc6da2b9745acb02804de5fdd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fae8fe61_5643496f","updated":"2023-02-08 15:45:00.000000000","message":"recheck\n\nneutron-ovn-rally-task TIMED_OUT","commit_id":"5c697b8d60571ef4a052586a73edd3d513d0d635"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"d658b9f46894d4659665f6b6256bba28452d8c61","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"869c4eb8_4306e80d","updated":"2023-02-08 08:39:09.000000000","message":"recheck\n\nunrelated \"Timed out after 5 seconds\" in neutron.tests.functional.agent.ovn.extensions.test_qos_hwol.OVSInterfaceEventTestCase.test_port_creation_and_deletion","commit_id":"5c697b8d60571ef4a052586a73edd3d513d0d635"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"ee7215ec48cb34b53f065953f1c5a28d79b3ff92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dda884e3_9fa7b551","updated":"2023-02-07 07:39:02.000000000","message":"recheck\n\nunrelated error \"Connecting to cloud-images.ubuntu.com (cloud-images.ubuntu.com)|2620:2d:4000:1::17|:443... connected.\nUnable to establish SSL connection.\"","commit_id":"5c697b8d60571ef4a052586a73edd3d513d0d635"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"2e672042eff1736cd52dcb8a95aca920e3f6fd68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2518f733_afad3967","updated":"2023-02-06 11:32:36.000000000","message":"recheck\n\nunrelated error \"die 123 \u0027Failed to run /opt/stack/new/grenade/projects/60_nova/resources.sh create \u0027\"","commit_id":"5c697b8d60571ef4a052586a73edd3d513d0d635"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"b60a47caba0f009aef214204571a1642cc614185","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da3be18f_941e0d08","updated":"2023-02-09 11:55:05.000000000","message":"recheck\n\nunrelated test failures","commit_id":"5c697b8d60571ef4a052586a73edd3d513d0d635"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d3480ae9b4783337c4dcf5c5a19d7ed46a01c5b4","unresolved":true,"context_lines":[{"line_number":2616,"context_line":"                const.DEVICE_OWNER_COMPUTE_PREFIX,"},{"line_number":2617,"context_line":"                ml2_consts.DEVICE_OWNER_MANILA_PREFIX)):"},{"line_number":2618,"context_line":"            msg \u003d _(\u0027Invalid port %s. Operation only valid on compute \u0027"},{"line_number":2619,"context_line":"                    \u0027and manila ports\u0027) % port[\u0027id\u0027]"},{"line_number":2620,"context_line":"            raise exc.BadRequest(resource\u003d\u0027port\u0027, msg\u003dmsg)"},{"line_number":2621,"context_line":""},{"line_number":2622,"context_line":"    def _make_port_binding_dict(self, binding, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1416361e_e66d3386","line":2619,"range":{"start_line":2619,"start_character":25,"end_line":2619,"end_character":31},"updated":"2023-01-24 12:27:33.000000000","message":"suggestion: \"shared filesystem ports\" as it seems more meaningful and kind of in line with \"compute\" (as opposed to \"nova\")","commit_id":"ab362bd2a4df9fe585b7d700429899ea8dd70ecf"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"c957ab88d6e8252c7f4fc6bdb11d858a00e60a9f","unresolved":false,"context_lines":[{"line_number":2616,"context_line":"                const.DEVICE_OWNER_COMPUTE_PREFIX,"},{"line_number":2617,"context_line":"                ml2_consts.DEVICE_OWNER_MANILA_PREFIX)):"},{"line_number":2618,"context_line":"            msg \u003d _(\u0027Invalid port %s. Operation only valid on compute \u0027"},{"line_number":2619,"context_line":"                    \u0027and manila ports\u0027) % port[\u0027id\u0027]"},{"line_number":2620,"context_line":"            raise exc.BadRequest(resource\u003d\u0027port\u0027, msg\u003dmsg)"},{"line_number":2621,"context_line":""},{"line_number":2622,"context_line":"    def _make_port_binding_dict(self, binding, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"e6299c45_5ff89dbd","line":2619,"range":{"start_line":2619,"start_character":25,"end_line":2619,"end_character":31},"in_reply_to":"1416361e_e66d3386","updated":"2023-01-24 12:42:43.000000000","message":"Done","commit_id":"ab362bd2a4df9fe585b7d700429899ea8dd70ecf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7ad6d3a13cc88230f8aeff4a0fb1167e11ae895a","unresolved":true,"context_lines":[{"line_number":2611,"context_line":"            self.mechanism_manager.update_network_postcommit(mech_context)"},{"line_number":2612,"context_line":""},{"line_number":2613,"context_line":"    @staticmethod"},{"line_number":2614,"context_line":"    def _validate_compute_or_fileshare_port(port):"},{"line_number":2615,"context_line":"        if not port[\u0027device_owner\u0027].startswith(("},{"line_number":2616,"context_line":"                const.DEVICE_OWNER_COMPUTE_PREFIX,"},{"line_number":2617,"context_line":"                ml2_consts.DEVICE_OWNER_MANILA_PREFIX)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"2be9067c_69431c0a","line":2614,"updated":"2023-02-04 12:31:53.000000000","message":"maybe this should be simply renamed to something like \"validate_port_supports_multiple_bindings\" or something similar, more generic than it\u0027s now.","commit_id":"08b0d3ec36bd563970419da893da239a768e39ba"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"b34bafca9861eecd4da1ccbac8fe83c6473543a5","unresolved":false,"context_lines":[{"line_number":2611,"context_line":"            self.mechanism_manager.update_network_postcommit(mech_context)"},{"line_number":2612,"context_line":""},{"line_number":2613,"context_line":"    @staticmethod"},{"line_number":2614,"context_line":"    def _validate_compute_or_fileshare_port(port):"},{"line_number":2615,"context_line":"        if not port[\u0027device_owner\u0027].startswith(("},{"line_number":2616,"context_line":"                const.DEVICE_OWNER_COMPUTE_PREFIX,"},{"line_number":2617,"context_line":"                ml2_consts.DEVICE_OWNER_MANILA_PREFIX)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"69ba8ee1_0d4fa05c","line":2614,"in_reply_to":"2be9067c_69431c0a","updated":"2023-02-06 08:22:12.000000000","message":"Thanks for the suggestion, that makes sense.","commit_id":"08b0d3ec36bd563970419da893da239a768e39ba"}],"releasenotes/notes/multiple-portbinding-for-manila-5f5232d506fe414e.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7ad6d3a13cc88230f8aeff4a0fb1167e11ae895a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Manila ports can now have multiple port bindings associated in order to"},{"line_number":5,"context_line":"    better support manila share server migration."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8a744186_060593d0","line":4,"updated":"2023-02-04 12:31:53.000000000","message":"I\u0027m not english speaker but wouldn\u0027t be better something like \"Ports owned by Manila service...\" or something like that?","commit_id":"08b0d3ec36bd563970419da893da239a768e39ba"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"b34bafca9861eecd4da1ccbac8fe83c6473543a5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Manila ports can now have multiple port bindings associated in order to"},{"line_number":5,"context_line":"    better support manila share server migration."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"62f868e4_cf1be79c","line":4,"in_reply_to":"8a744186_060593d0","updated":"2023-02-06 08:22:12.000000000","message":"I\u0027m not a native speaker, either. I wanted to have the keyword \u0027Manila\u0027 at the front of the sentence so that people not using that service can easily skip that note.","commit_id":"08b0d3ec36bd563970419da893da239a768e39ba"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7ad6d3a13cc88230f8aeff4a0fb1167e11ae895a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Manila ports can now have multiple port bindings associated in order to"},{"line_number":5,"context_line":"    better support manila share server migration."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"03eafdfb_d14b4c1a","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":10},"updated":"2023-02-04 12:31:53.000000000","message":"nit: what exactly \"better\" means here? Can You explain it a bit more?","commit_id":"08b0d3ec36bd563970419da893da239a768e39ba"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"b34bafca9861eecd4da1ccbac8fe83c6473543a5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Manila ports can now have multiple port bindings associated in order to"},{"line_number":5,"context_line":"    better support manila share server migration."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0a498de7_6e0ee646","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":10},"in_reply_to":"03eafdfb_d14b4c1a","updated":"2023-02-06 08:22:12.000000000","message":"Done","commit_id":"08b0d3ec36bd563970419da893da239a768e39ba"}]}