)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b3797531c4ef84ed2c52ad6e4f874b4c651ffbfd","unresolved":true,"context_lines":[{"line_number":13,"context_line":"the possible root cause of this issue."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2c6acf3c29f3d1e7574240376f7bcb46c98579c6"},{"line_number":16,"context_line":"Related-Bug: #995031"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c9b5ff2e_9eb120ae","line":16,"updated":"2023-01-11 08:54:59.000000000","message":"Just noticed that there is something wrong with the bug report :-)","commit_id":"0a33fbea142c36c38f746fdbf9c3609e8c222744"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"48410d5528af5461955c0085280f0c9cd1a53972","unresolved":true,"context_lines":[{"line_number":13,"context_line":"the possible root cause of this issue."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2c6acf3c29f3d1e7574240376f7bcb46c98579c6"},{"line_number":16,"context_line":"Related-Bug: #995031"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2480a4d6_9658c79a","line":16,"in_reply_to":"c9b5ff2e_9eb120ae","updated":"2023-01-12 13:20:59.000000000","message":"Uuuh, thanks","commit_id":"0a33fbea142c36c38f746fdbf9c3609e8c222744"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b3797531c4ef84ed2c52ad6e4f874b4c651ffbfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8d9e3cc0_11497783","updated":"2023-01-11 08:54:59.000000000","message":"Sorry for that Lajos I did not noticed that the bug report was not right.","commit_id":"0a33fbea142c36c38f746fdbf9c3609e8c222744"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"20e59f52abe839c89cc937b7816ebeac990297a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19e870ad_8198030f","updated":"2023-02-02 22:02:17.000000000","message":"recheck VlanIdInUse unrelated error","commit_id":"de0918cea3fa3c107d4cc08137c04573274716f8"}],"neutron/agent/linux/interface.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"04e1ae019352ed45b9ef4caf728c6deb810dde72","unresolved":true,"context_lines":[{"line_number":402,"context_line":"        else:"},{"line_number":403,"context_line":"            ns_dev \u003d ip.device(device_name)"},{"line_number":404,"context_line":"        if not ns_dev:"},{"line_number":405,"context_line":"            LOG.warning(\"Ns Device %s is not yet ready in %s!\","},{"line_number":406,"context_line":"                        device_name, namespace)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        internal \u003d not self.conf.ovs_use_veth"}],"source_content_type":"text/x-python","patch_set":2,"id":"56bd3fce_ed98509c","line":405,"updated":"2023-01-10 14:29:27.000000000","message":"Maybe \"Device %s is not ready in namespace %s!\" ?","commit_id":"bfa6ac4e5a4f8f90f4120504da4d23d7febc16a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6c37c6c554c4fee434d32b14c5506d863a16492e","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        else:"},{"line_number":403,"context_line":"            ns_dev \u003d ip.device(device_name)"},{"line_number":404,"context_line":"        if not ns_dev:"},{"line_number":405,"context_line":"            LOG.warning(\"Ns Device %s is not yet ready in %s!\","},{"line_number":406,"context_line":"                        device_name, namespace)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        internal \u003d not self.conf.ovs_use_veth"}],"source_content_type":"text/x-python","patch_set":2,"id":"421cc691_6bfabd0f","line":405,"in_reply_to":"56bd3fce_ed98509c","updated":"2023-01-11 08:12:53.000000000","message":"Done","commit_id":"bfa6ac4e5a4f8f90f4120504da4d23d7febc16a8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"04e1ae019352ed45b9ef4caf728c6deb810dde72","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":433,"context_line":"                    ovs \u003d ovs_lib.OVSBridge(bridge)"},{"line_number":434,"context_line":"                    ovs.delete_port(tap_name)"},{"line_number":435,"context_line":"            except Exception:"},{"line_number":436,"context_line":"                LOG.warning(\"Failed to plug interface %s to bridge %s in \""},{"line_number":437,"context_line":"                            \"namespace %s due to unknown reason.\","},{"line_number":438,"context_line":"                            device_name, bridge, namespace)"}],"source_content_type":"text/x-python","patch_set":2,"id":"14b996ad_5c2e13be","line":435,"range":{"start_line":435,"start_character":19,"end_line":435,"end_character":28},"updated":"2023-01-10 14:29:27.000000000","message":"Should use \u0027Exception as e\u0027, then you can print \u0027e\u0027 using str(e) in the log message.","commit_id":"bfa6ac4e5a4f8f90f4120504da4d23d7febc16a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6c37c6c554c4fee434d32b14c5506d863a16492e","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":433,"context_line":"                    ovs \u003d ovs_lib.OVSBridge(bridge)"},{"line_number":434,"context_line":"                    ovs.delete_port(tap_name)"},{"line_number":435,"context_line":"            except Exception:"},{"line_number":436,"context_line":"                LOG.warning(\"Failed to plug interface %s to bridge %s in \""},{"line_number":437,"context_line":"                            \"namespace %s due to unknown reason.\","},{"line_number":438,"context_line":"                            device_name, bridge, namespace)"}],"source_content_type":"text/x-python","patch_set":2,"id":"938b0505_2660f457","line":435,"range":{"start_line":435,"start_character":19,"end_line":435,"end_character":28},"in_reply_to":"14b996ad_5c2e13be","updated":"2023-01-11 08:12:53.000000000","message":"Thanks, I added the exception string","commit_id":"bfa6ac4e5a4f8f90f4120504da4d23d7febc16a8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4487514ae538d72b75ff5c8758e26d584bce2a06","unresolved":true,"context_lines":[{"line_number":435,"context_line":"            except Exception:"},{"line_number":436,"context_line":"                LOG.warning(\"Failed to plug interface %s to bridge %s in \""},{"line_number":437,"context_line":"                            \"namespace %s due to unknown reason.\","},{"line_number":438,"context_line":"                            device_name, bridge, namespace)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        # NOTE(ihrachys): the order here is significant: we must set MTU after"},{"line_number":441,"context_line":"        # the device is moved into a namespace, otherwise OVS bridge does not"}],"source_content_type":"text/x-python","patch_set":2,"id":"42e3ce28_383b0ba8","line":438,"updated":"2023-01-10 15:04:46.000000000","message":"You should reraise it after logging","commit_id":"bfa6ac4e5a4f8f90f4120504da4d23d7febc16a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6c37c6c554c4fee434d32b14c5506d863a16492e","unresolved":true,"context_lines":[{"line_number":435,"context_line":"            except Exception:"},{"line_number":436,"context_line":"                LOG.warning(\"Failed to plug interface %s to bridge %s in \""},{"line_number":437,"context_line":"                            \"namespace %s due to unknown reason.\","},{"line_number":438,"context_line":"                            device_name, bridge, namespace)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        # NOTE(ihrachys): the order here is significant: we must set MTU after"},{"line_number":441,"context_line":"        # the device is moved into a namespace, otherwise OVS bridge does not"}],"source_content_type":"text/x-python","patch_set":2,"id":"a7240c7f_82e6c109","line":438,"in_reply_to":"42e3ce28_383b0ba8","updated":"2023-01-11 08:12:53.000000000","message":"Thanks it seems that the raise has no effect on the unit test failures, but anyway it is necessary there.","commit_id":"bfa6ac4e5a4f8f90f4120504da4d23d7febc16a8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b3797531c4ef84ed2c52ad6e4f874b4c651ffbfd","unresolved":true,"context_lines":[{"line_number":436,"context_line":"                LOG.warning(\"Failed to plug interface %s to bridge %s in \""},{"line_number":437,"context_line":"                            \"namespace %s due to unknown reason: %s\","},{"line_number":438,"context_line":"                            device_name, bridge, namespace, str(exc))"},{"line_number":439,"context_line":"                raise exc"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        # NOTE(ihrachys): the order here is significant: we must set MTU after"},{"line_number":442,"context_line":"        # the device is moved into a namespace, otherwise OVS bridge does not"}],"source_content_type":"text/x-python","patch_set":3,"id":"cf06e015_90c802dd","line":439,"updated":"2023-01-11 08:54:59.000000000","message":"You could have used\n\n  with save_and_reraise_exception():, right?","commit_id":"0a33fbea142c36c38f746fdbf9c3609e8c222744"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"48410d5528af5461955c0085280f0c9cd1a53972","unresolved":true,"context_lines":[{"line_number":436,"context_line":"                LOG.warning(\"Failed to plug interface %s to bridge %s in \""},{"line_number":437,"context_line":"                            \"namespace %s due to unknown reason: %s\","},{"line_number":438,"context_line":"                            device_name, bridge, namespace, str(exc))"},{"line_number":439,"context_line":"                raise exc"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        # NOTE(ihrachys): the order here is significant: we must set MTU after"},{"line_number":442,"context_line":"        # the device is moved into a namespace, otherwise OVS bridge does not"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f69dd44_4cd2cdd3","line":439,"in_reply_to":"cf06e015_90c802dd","updated":"2023-01-12 13:20:59.000000000","message":"true, I played with unit tests, and forgot to ad back reraise","commit_id":"0a33fbea142c36c38f746fdbf9c3609e8c222744"}],"neutron/tests/unit/agent/linux/test_interface.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6c37c6c554c4fee434d32b14c5506d863a16492e","unresolved":true,"context_lines":[{"line_number":461,"context_line":"            expected \u003d ["},{"line_number":462,"context_line":"                mock.call(),"},{"line_number":463,"context_line":"                mock.call().device(\u0027tap0\u0027),"},{"line_number":464,"context_line":"                mock.ANY,"},{"line_number":465,"context_line":"                mock.call().device().link.set_address(\u0027aa:bb:cc:dd:ee:ff\u0027),"},{"line_number":466,"context_line":"                mock.call().device().link.set_address(\u0027aa:bb:cc:dd:ee:ff\u0027)]"},{"line_number":467,"context_line":"            if namespace:"}],"source_content_type":"text/x-python","patch_set":3,"id":"a53b7fdd_cf789fc4","line":464,"updated":"2023-01-11 08:12:53.000000000","message":"The \"if not ns_dev:.....\" means an extra call for device.","commit_id":"0a33fbea142c36c38f746fdbf9c3609e8c222744"}]}