)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"4b942057cbb3bd2dd61bbbd5b40e5bc6ace407f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b63feedd_10e420a1","updated":"2023-02-13 11:02:23.000000000","message":"Hello team, this patch is failing in dvr ha on multinode devstack because it\u0027s using computes nodes as network nodes.\n\nThis is not supposed to be possible as per:\nhttps://bugs.launchpad.net/neutron/+bug/1934666\n\nIs devstack tests possible on such case?","commit_id":"ee8e85a3be4b125f28be71321408647c4570e1aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7e0d9fd60b0306e3776e0a782aa05f525ea3199c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e622548b_e5cb9158","in_reply_to":"b63feedd_10e420a1","updated":"2023-02-14 16:07:30.000000000","message":"As commented in the CI meeting today [1], this job used to have 3 nodes. If we disable the dvr_snat mode in the compute, then we won\u0027t check HA because we won\u0027t have two networker nodes (only the controller will be).\n\nWe need to disable the dvr_snat mode from the compute but at the same time we need to add a second networker node.\n\n[1]https://meetings.opendev.org/meetings/neutron_ci/2023/neutron_ci.2023-02-14-15.00.log.html#l-265","commit_id":"ee8e85a3be4b125f28be71321408647c4570e1aa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7ec5fac00a330a71d0cbd522a7b5cf10b749b25a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7420b07c_32672da8","in_reply_to":"e18860ac_5f6283f1","updated":"2023-02-21 08:22:27.000000000","message":"I proposed https://review.opendev.org/c/openstack/neutron/+/874536 - lets see how it will behave in the CI and what do You think about it.","commit_id":"ee8e85a3be4b125f28be71321408647c4570e1aa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"83ba087f8a02dc4731e2ff1735bfddac646467f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e18860ac_5f6283f1","in_reply_to":"e622548b_e5cb9158","updated":"2023-02-21 07:59:00.000000000","message":"I think that we can have only one \"networker\" node in that job but keep \"ha\u003dTrue\" in neutron\u0027s config. That way we will test ha code path but not eventuall failover of the snat (which should be fine IMO).","commit_id":"ee8e85a3be4b125f28be71321408647c4570e1aa"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"7c3d98cb80634b025971011c54e1a0812ed3dbc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"23ee78ce_690eeb5f","updated":"2023-06-09 14:18:46.000000000","message":"I\u0027ll have to find time to work on the failed tests here","commit_id":"0aee99ac10311074a07f748011430865b69b270d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1ac4ef0e97a4982b286a52ed5cffe917873da2de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6c91467e_c2cb759b","updated":"2023-06-07 01:01:22.000000000","message":"IIRC, every compute node qr-devs in qrouter-namespace can answer the ARP request from baremetal (ironic instance) node of vlan network. Have you tested this?","commit_id":"0aee99ac10311074a07f748011430865b69b270d"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"331e8e23270206418a5bd8cb6dc92a67e5df38e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4aec156e_22d75f8a","in_reply_to":"6c91467e_c2cb759b","updated":"2023-06-09 14:08:45.000000000","message":"This is very true, we mitigate this on our side by adding some openflow rules in ovs bridge.\n\nWe are using a custom driver, so that wont apply \"as is\" on upstream code.\nI will try to work on it in, but I suggest to do that on another patchset (this one is about the snat dvr, not the compute dvr).","commit_id":"0aee99ac10311074a07f748011430865b69b270d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c6d298709794c95c596cf31a737380d7c81d9e4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e9e74117_bb4f93cc","updated":"2023-10-09 07:33:30.000000000","message":"recheck\nhttps://review.opendev.org/c/openstack/neutron/+/897332 fixed the n-t-p failures with no router active on any of the l3 agents","commit_id":"bcf2f652cb9de84f050964fa615e3c47639b5bd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4e98b519189ac82662db6a9038fd26f4a9f1ddc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1d6afb0c_3f630b84","updated":"2024-10-28 13:04:04.000000000","message":"The unit test failures are related and the functional failures are also suspicious , please check them","commit_id":"42018ba570626b5d4ca93b69d2f464679206f7ac"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"759e03c080b322bed2b5d7101c5fb6812311ee81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ee389308_c2904fc8","updated":"2024-10-29 19:10:08.000000000","message":"thank you for the review!\nI will take a look at it","commit_id":"42018ba570626b5d4ca93b69d2f464679206f7ac"}],"neutron/agent/l3/ha.py":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"66d8bb372c6a68261edbfeadcd708fc90aaf497d","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        if state \u003d\u003d \u0027master\u0027:"},{"line_number":239,"context_line":"            ri.enable_internal_network()"},{"line_number":240,"context_line":"            ri.routes_updated([], ri.routes)"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            ri.disable_internal_network()"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9108b1e6_6ae83545","line":240,"updated":"2023-02-28 17:48:07.000000000","message":"I noticed on my sidewe are missing default gateway in snat namespace.\nI have a fix internally that I need to backport here.\nso w-1 until I do this","commit_id":"4ef6043085b68d352fa83df09b0fc3756b2ef85f"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"3c1d72e717fa8e8c95c023db934cd73938eefebd","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        if state \u003d\u003d \u0027master\u0027:"},{"line_number":239,"context_line":"            ri.enable_internal_network()"},{"line_number":240,"context_line":"            ri.routes_updated([], ri.routes)"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            ri.disable_internal_network()"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c1793fc7_58c6802a","line":240,"in_reply_to":"9108b1e6_6ae83545","updated":"2023-05-04 09:53:13.000000000","message":"Done","commit_id":"4ef6043085b68d352fa83df09b0fc3756b2ef85f"}]}
