)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"67bddfffe843921d93aab9c6a3404d12c25fd2fc","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  [ml2]"},{"line_number":21,"context_line":"  extension_drivers +\u003d port_hints"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This patch also bumps neutron-lib requirement to 3.5.0."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I80816618285d742775bc0534510c0f874f84ed2e"},{"line_number":26,"context_line":"Partially-Implements: #1990842"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"cfe8de1a_55bfabfe","line":23,"range":{"start_line":23,"start_character":49,"end_line":23,"end_character":54},"updated":"2023-04-17 07:42:06.000000000","message":"+1","commit_id":"b96c9000538032c269ebbe689ba7d0762d1f0a90"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fa1ba68aff79f84def50a1b396d90287a5e6a7ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"646e5705_6347e496","updated":"2023-02-14 18:23:13.000000000","message":"more is coming.....","commit_id":"ecca75e1314b26b3e27c4beb9fed5931d5960124"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"2d64999356b93b748a05a5be22d80a1d5d8c11ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d657f631_ac66713d","in_reply_to":"646e5705_6347e496","updated":"2023-02-15 14:44:29.000000000","message":"Keep it coming.","commit_id":"ecca75e1314b26b3e27c4beb9fed5931d5960124"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e0b5de8361b30124632d480c0053fc3933707cb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7f255538_a4539b2f","updated":"2023-02-28 12:01:43.000000000","message":"I\u0027m ok with that change but I think that we need to wait for 2023.1 release as now we are in the Feature Freeze phase of the cycle.","commit_id":"1230f29d63662dbffdd22f9ee7efd9525626f198"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"4bdd87c4ab87e8154e4cba79683f72a27dd6ce35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1a175796_ae4c7d1c","in_reply_to":"1ff7485c_e8783088","updated":"2023-03-22 09:03:17.000000000","message":"Done.","commit_id":"1230f29d63662dbffdd22f9ee7efd9525626f198"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"535ca92557fd713886cc3931f23989af6ec8dabb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c1f3bad6_e2568955","in_reply_to":"7f255538_a4539b2f","updated":"2023-03-01 14:45:45.000000000","message":"Makes perfect sense. Thanks for the review.","commit_id":"1230f29d63662dbffdd22f9ee7efd9525626f198"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0f88aa7d279787193643bf4099c7a1b13bf87f8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1ff7485c_e8783088","in_reply_to":"c1f3bad6_e2568955","updated":"2023-03-09 10:15:48.000000000","message":"--\u003e https://review.opendev.org/c/openstack/neutron/+/876051 (you can push your patch on top of this one)","commit_id":"1230f29d63662dbffdd22f9ee7efd9525626f198"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c5df4cf381a938f55b71b81a92253d62642e1300","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f4a38bd4_33540609","updated":"2023-03-28 08:40:18.000000000","message":"I have not yet reviewed all, one point that I do not understand regarding the database:\n\nhttps://review.opendev.org/c/openstack/neutron-specs/+/862133/3/specs/2023.1/ovs-tx-steering.rst\n","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"4016d265ba1829d54d513b45c505a576b0edbfe4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5a85bde5_dde432fc","updated":"2023-03-23 10:00:25.000000000","message":"recheck bug/2000150","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"6963561ad7c384cd269f420d63571dc463507156","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ca33b076_5f31551b","updated":"2023-04-12 14:43:43.000000000","message":"recheck ubuntu repo unavailable","commit_id":"3ec7b121e30201c934ba2e2909b8aa96fd75efd8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"18a5b7ff5cbd2abb0525a113e985df4ea0ae86c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"224f16f1_fb7bcb39","updated":"2023-04-17 15:24:36.000000000","message":"Code looks ok. But please check the file mode. I also have a couple of questions.","commit_id":"b96c9000538032c269ebbe689ba7d0762d1f0a90"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"67bddfffe843921d93aab9c6a3404d12c25fd2fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d7821917_48bf05c3","updated":"2023-04-17 07:42:06.000000000","message":"recheck\ngrenade job hit https://bugs.launchpad.net/neutron/+bug/2015065","commit_id":"b96c9000538032c269ebbe689ba7d0762d1f0a90"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"47430ee944e4f2e30b78f484440a493e82f76834","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a8ef4424_f198b46f","updated":"2023-04-19 09:06:09.000000000","message":"recheck https://bugs.launchpad.net/neutron/+bug/2015065","commit_id":"2d50d7a711d80a70be0a795a8e7323cf1519c104"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"2806c273c0fef00acad0c455b7c6f2095f3b90fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"aa5594ee_189da9a6","updated":"2023-04-19 13:35:11.000000000","message":"recheck image download error","commit_id":"2d50d7a711d80a70be0a795a8e7323cf1519c104"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"18215d1ba79add7b00e1c86554913437f8094148","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"fea83f6d_91d1c4ef","updated":"2023-04-20 08:53:48.000000000","message":"recheck image download problem","commit_id":"2d50d7a711d80a70be0a795a8e7323cf1519c104"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f57dfb3a414a8d9f982f1b17aff6be1dadf709d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"66104a31_09bf2908","updated":"2023-04-20 14:39:24.000000000","message":"recheck package repo problem","commit_id":"2d50d7a711d80a70be0a795a8e7323cf1519c104"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"473dc6c0671f115230e34399b56c64d945592cd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0d235d5e_275e4803","updated":"2023-04-27 08:55:04.000000000","message":"recheck cloud image download problems","commit_id":"49dd588c3e48827fe32d83007bece24d2fff4cd7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"9412f339b3924a84473269456118e7c6358742cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"740f3430_97ead7e5","updated":"2023-04-26 09:20:46.000000000","message":"recheck gate issues fixed","commit_id":"49dd588c3e48827fe32d83007bece24d2fff4cd7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"55dacc258035297b3cc7fddc8c1f39afea12f4af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"1464b839_1a0079a7","updated":"2023-04-28 15:39:36.000000000","message":"recheck vexxhost nodes disabled","commit_id":"49dd588c3e48827fe32d83007bece24d2fff4cd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"494a49e713555c3d9533969277430846408fc029","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"107566c3_30793dbe","updated":"2023-05-08 11:50:57.000000000","message":"only migration script revision number change as I see","commit_id":"9f523c56333e0cb1768f4ff1ab78640d6590288d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"75320adf9f8f82cea083a35715c2243196d1afc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ffb19d78_ba849bdd","updated":"2023-05-08 13:09:20.000000000","message":"something is wrong","commit_id":"9f523c56333e0cb1768f4ff1ab78640d6590288d"}],"neutron/api/definitions/__init__.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"18a5b7ff5cbd2abb0525a113e985df4ea0ae86c2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"85d02e6f_217358e4","updated":"2023-04-17 15:24:36.000000000","message":"Please, reset the previous file mode","commit_id":"b96c9000538032c269ebbe689ba7d0762d1f0a90"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"48b9282ae3fbc0c5fbf162a2f019d3f45d3fd92c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"579abb00_eb125863","in_reply_to":"85d02e6f_217358e4","updated":"2023-04-18 13:16:28.000000000","message":"Done","commit_id":"b96c9000538032c269ebbe689ba7d0762d1f0a90"}],"neutron/api/definitions/port_hints.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"ed282ff9950424d43a56e0e52d7298d662183125","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"202efdf1_9565537e","updated":"2023-01-18 14:04:06.000000000","message":"This is duplicated code to get the gate properly test these changes. Will be removed as soon as the n-lib counterpart is merged and released. Please ignore this file and review the n-lib change instead:\n\nhttps://review.opendev.org/c/openstack/neutron-lib/+/870080","commit_id":"2000e5792a97f1d58c38eb6b8d0da4a09013d211"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fa1ba68aff79f84def50a1b396d90287a5e6a7ad","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64c0307a_0d89d8bf","in_reply_to":"202efdf1_9565537e","updated":"2023-02-14 18:23:13.000000000","message":"Why not just in neutron/extensions/_port_hint_extension.py?","commit_id":"2000e5792a97f1d58c38eb6b8d0da4a09013d211"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"2d64999356b93b748a05a5be22d80a1d5d8c11ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"227c59e5_bceeb11b","in_reply_to":"64c0307a_0d89d8bf","updated":"2023-02-15 14:44:29.000000000","message":"I guess I was putting it at a location, so the migration can be s/neutron/neutron_lib/ in the relevant import lines. :-)","commit_id":"2000e5792a97f1d58c38eb6b8d0da4a09013d211"}],"neutron/db/migration/alembic_migrations/versions/2023.2/expand/931868cd25f7_port_hints.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c5df4cf381a938f55b71b81a92253d62642e1300","unresolved":true,"context_lines":[{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    op.create_table("},{"line_number":36,"context_line":"        \u0027porthints\u0027,"},{"line_number":37,"context_line":"        sa.Column("},{"line_number":38,"context_line":"            \u0027port_id\u0027,"},{"line_number":39,"context_line":"            sa.String(length\u003ddb_const.UUID_FIELD_SIZE),"},{"line_number":40,"context_line":"            sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5953e442_d47244a3","line":37,"updated":"2023-03-28 08:40:18.000000000","message":"I think I\u0027m missing something. In the spec it seems that you were mentioning that the ports\u0027 table will be extended with a column hints, right?","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7b7bed89fcaca174566f1e2072214e9200a7c80f","unresolved":true,"context_lines":[{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    op.create_table("},{"line_number":36,"context_line":"        \u0027porthints\u0027,"},{"line_number":37,"context_line":"        sa.Column("},{"line_number":38,"context_line":"            \u0027port_id\u0027,"},{"line_number":39,"context_line":"            sa.String(length\u003ddb_const.UUID_FIELD_SIZE),"},{"line_number":40,"context_line":"            sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"cc696d46_a8ffb3fb","line":37,"in_reply_to":"5953e442_d47244a3","updated":"2023-03-28 08:56:21.000000000","message":"When I wrote the spec I did not check yet how similar plugins do this. Later I found examples (e.g. db/models/port_device_profile.py) that introduced a new table, which is auto-joined to the ports table. I\u0027m no db expert, but the effect seems to me practically the same.","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a7842ad340e48ac9eca6b8ceb75f9a4a0a396943","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    op.create_table("},{"line_number":36,"context_line":"        \u0027porthints\u0027,"},{"line_number":37,"context_line":"        sa.Column("},{"line_number":38,"context_line":"            \u0027port_id\u0027,"},{"line_number":39,"context_line":"            sa.String(length\u003ddb_const.UUID_FIELD_SIZE),"},{"line_number":40,"context_line":"            sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"81e573d9_2937c3f7","line":37,"in_reply_to":"71c0729c_4f576aac","updated":"2023-03-30 12:25:15.000000000","message":"Done\n\nhttps://review.opendev.org/c/openstack/neutron-specs/+/879043","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ba93a229f2b913a21c5f0b3fbeee1ed5de9c9dde","unresolved":true,"context_lines":[{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    op.create_table("},{"line_number":36,"context_line":"        \u0027porthints\u0027,"},{"line_number":37,"context_line":"        sa.Column("},{"line_number":38,"context_line":"            \u0027port_id\u0027,"},{"line_number":39,"context_line":"            sa.String(length\u003ddb_const.UUID_FIELD_SIZE),"},{"line_number":40,"context_line":"            sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"71c0729c_4f576aac","line":37,"in_reply_to":"cc696d46_a8ffb3fb","updated":"2023-03-28 09:26:03.000000000","message":"Yes I think that can make sense to have it. any chance that you update the spec?","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ba93a229f2b913a21c5f0b3fbeee1ed5de9c9dde","unresolved":true,"context_lines":[{"line_number":40,"context_line":"            sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":41,"context_line":"            primary_key\u003dTrue),"},{"line_number":42,"context_line":"        sa.Column(\u0027hints\u0027,"},{"line_number":43,"context_line":"            sa.String(4095),"},{"line_number":44,"context_line":"            nullable\u003dTrue),"},{"line_number":45,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":11,"id":"24d738c6_a919a6af","line":43,"updated":"2023-03-28 09:26:03.000000000","message":"This limit should be mentioned in you spec and API","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a7842ad340e48ac9eca6b8ceb75f9a4a0a396943","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":41,"context_line":"            primary_key\u003dTrue),"},{"line_number":42,"context_line":"        sa.Column(\u0027hints\u0027,"},{"line_number":43,"context_line":"            sa.String(4095),"},{"line_number":44,"context_line":"            nullable\u003dTrue),"},{"line_number":45,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":11,"id":"883027d9_c8216fb2","line":43,"in_reply_to":"24d738c6_a919a6af","updated":"2023-03-30 12:25:15.000000000","message":"Done\n\nhttps://review.opendev.org/c/openstack/neutron-lib/+/879042\nhttps://review.opendev.org/c/openstack/neutron-specs/+/879043","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ba93a229f2b913a21c5f0b3fbeee1ed5de9c9dde","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            primary_key\u003dTrue),"},{"line_number":42,"context_line":"        sa.Column(\u0027hints\u0027,"},{"line_number":43,"context_line":"            sa.String(4095),"},{"line_number":44,"context_line":"            nullable\u003dTrue),"},{"line_number":45,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":11,"id":"d44366b7_84377ecc","line":44,"updated":"2023-03-28 09:26:03.000000000","message":"I don\u0027t think it is acceptable to have this column NULL. In that case we want to completely remove the row, right?","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"8f44e1215e39cd5d521ed28bf72fadbd6d9a760e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            primary_key\u003dTrue),"},{"line_number":42,"context_line":"        sa.Column(\u0027hints\u0027,"},{"line_number":43,"context_line":"            sa.String(4095),"},{"line_number":44,"context_line":"            nullable\u003dTrue),"},{"line_number":45,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":11,"id":"17df864d_d86f47e9","line":44,"in_reply_to":"0ed55a5e_31a97d9f","updated":"2023-04-05 15:08:59.000000000","message":"When I updated this, I forgot to update the model too. Interestingly the model-migration comparison functional test did not run on the previous patch set in the gate to catch this. At the moment I don\u0027t know why.","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"cc87c0323e588cc08e04ceaec42336001f0aca6f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            primary_key\u003dTrue),"},{"line_number":42,"context_line":"        sa.Column(\u0027hints\u0027,"},{"line_number":43,"context_line":"            sa.String(4095),"},{"line_number":44,"context_line":"            nullable\u003dTrue),"},{"line_number":45,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":11,"id":"f3659aa8_ecb93388","line":44,"in_reply_to":"17df864d_d86f47e9","updated":"2023-04-06 12:27:06.000000000","message":"The reason for the test not running was that we have two stestr commands in the relevant tox env. The first stestr failed for other reasons so tox did not proceed to the second. But in the next patch set, the test was executed as expected.","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a7842ad340e48ac9eca6b8ceb75f9a4a0a396943","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            primary_key\u003dTrue),"},{"line_number":42,"context_line":"        sa.Column(\u0027hints\u0027,"},{"line_number":43,"context_line":"            sa.String(4095),"},{"line_number":44,"context_line":"            nullable\u003dTrue),"},{"line_number":45,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":11,"id":"0ed55a5e_31a97d9f","line":44,"in_reply_to":"d44366b7_84377ecc","updated":"2023-03-30 12:25:15.000000000","message":"Done","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4ef7d407cb57108c4410862b92f305ba131fdec1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            primary_key\u003dTrue),"},{"line_number":42,"context_line":"        sa.Column(\u0027hints\u0027,"},{"line_number":43,"context_line":"            sa.String(4095),"},{"line_number":44,"context_line":"            nullable\u003dTrue),"},{"line_number":45,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":11,"id":"683114e8_80db3ee5","line":44,"in_reply_to":"f3659aa8_ecb93388","updated":"2023-04-11 08:50:55.000000000","message":"thanks for checking","commit_id":"0da4390f35f6ba8093800a48b205bca27df56f69"}],"neutron/db/models/port_hints.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6e60a5a0ec64bd0aa2c542cc3fb7aa9e021f00e4","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        models_v2.Port,"},{"line_number":31,"context_line":"        load_on_pending\u003dTrue,"},{"line_number":32,"context_line":"        backref\u003dsa.orm.backref("},{"line_number":33,"context_line":"            \u0027hints\u0027, uselist\u003dFalse, cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    revises_on_change \u003d (\u0027port\u0027, )"}],"source_content_type":"text/x-python","patch_set":9,"id":"e740f68a_7b80ad33","line":33,"range":{"start_line":33,"start_character":60,"end_line":33,"end_character":66},"updated":"2023-02-23 10:15:34.000000000","message":"why not \"subquery\"? It is preferable from performance perspective","commit_id":"fab95652f90a2b599deec9cc1b201dc7dd5be4e2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"8d72919d48056dfb231b2e322273d49b315d76b4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        models_v2.Port,"},{"line_number":31,"context_line":"        load_on_pending\u003dTrue,"},{"line_number":32,"context_line":"        backref\u003dsa.orm.backref("},{"line_number":33,"context_line":"            \u0027hints\u0027, uselist\u003dFalse, cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    revises_on_change \u003d (\u0027port\u0027, )"}],"source_content_type":"text/x-python","patch_set":9,"id":"4c47a825_989df421","line":33,"range":{"start_line":33,"start_character":60,"end_line":33,"end_character":66},"in_reply_to":"e740f68a_7b80ad33","updated":"2023-02-24 12:43:30.000000000","message":"Done","commit_id":"fab95652f90a2b599deec9cc1b201dc7dd5be4e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"18a5b7ff5cbd2abb0525a113e985df4ea0ae86c2","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        models_v2.Port,"},{"line_number":31,"context_line":"        load_on_pending\u003dTrue,"},{"line_number":32,"context_line":"        backref\u003dsa.orm.backref("},{"line_number":33,"context_line":"            \u0027hints\u0027, uselist\u003dFalse, cascade\u003d\u0027delete\u0027, lazy\u003d\u0027subquery\u0027))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    revises_on_change \u003d (\u0027port\u0027, )"}],"source_content_type":"text/x-python","patch_set":15,"id":"2327dff1_f7bf6574","line":33,"range":{"start_line":33,"start_character":54,"end_line":33,"end_character":69},"updated":"2023-04-17 15:24:36.000000000","message":"nit: why not joined? should be faster. Same as in \"PortDeviceProfile\", for example.","commit_id":"b96c9000538032c269ebbe689ba7d0762d1f0a90"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34aa07c75a97fca06d55398848835e9ed5ccef96","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        models_v2.Port,"},{"line_number":31,"context_line":"        load_on_pending\u003dTrue,"},{"line_number":32,"context_line":"        backref\u003dsa.orm.backref("},{"line_number":33,"context_line":"            \u0027hints\u0027, uselist\u003dFalse, cascade\u003d\u0027delete\u0027, lazy\u003d\u0027subquery\u0027))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    revises_on_change \u003d (\u0027port\u0027, )"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa068d5a_fc438ae7","line":33,"range":{"start_line":33,"start_character":54,"end_line":33,"end_character":69},"in_reply_to":"2327dff1_f7bf6574","updated":"2023-04-18 10:19:22.000000000","message":"AFAIU \u0027joined\u0027 is faster on GET queries, but GETs are fast enough. The concern is mostly about LIST ports where \u0027subquery\u0027 is preferable, wdyt?","commit_id":"b96c9000538032c269ebbe689ba7d0762d1f0a90"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a0298f6b07c0bff326fdf4fac0b480b9c4273aba","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        models_v2.Port,"},{"line_number":31,"context_line":"        load_on_pending\u003dTrue,"},{"line_number":32,"context_line":"        backref\u003dsa.orm.backref("},{"line_number":33,"context_line":"            \u0027hints\u0027, uselist\u003dFalse, cascade\u003d\u0027delete\u0027, lazy\u003d\u0027subquery\u0027))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    revises_on_change \u003d (\u0027port\u0027, )"}],"source_content_type":"text/x-python","patch_set":15,"id":"47108213_eabfbc7d","line":33,"range":{"start_line":33,"start_character":54,"end_line":33,"end_character":69},"in_reply_to":"fa068d5a_fc438ae7","updated":"2023-04-18 10:34:00.000000000","message":"Right, actually that was discussed in https://bugs.launchpad.net/neutron/+bug/1649317. Thus keep it as is now.","commit_id":"b96c9000538032c269ebbe689ba7d0762d1f0a90"}],"neutron/db/port_hints_db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"18a5b7ff5cbd2abb0525a113e985df4ea0ae86c2","unresolved":true,"context_lines":[{"line_number":41,"context_line":"                obj.update()"},{"line_number":42,"context_line":"            else:"},{"line_number":43,"context_line":"                obj.delete()"},{"line_number":44,"context_line":"            result[phints_def.HINTS] \u003d data[phints_def.HINTS]"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            self._process_create_port(context, data, result)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"e7600e58_b9117de2","line":44,"range":{"start_line":44,"start_character":39,"end_line":44,"end_character":61},"updated":"2023-04-17 15:24:36.000000000","message":"We\u0027ll we have always \"phints_def.HINTS\" in the data dict?\n\nEDIT: actually checking [1], we\u0027ll always have it here. So why L39 is a \"get\"?\n\n[1]https://review.opendev.org/c/openstack/neutron/+/870081/15/neutron/plugins/ml2/extensions/port_hints.py#40","commit_id":"b96c9000538032c269ebbe689ba7d0762d1f0a90"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"48b9282ae3fbc0c5fbf162a2f019d3f45d3fd92c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                obj.update()"},{"line_number":42,"context_line":"            else:"},{"line_number":43,"context_line":"                obj.delete()"},{"line_number":44,"context_line":"            result[phints_def.HINTS] \u003d data[phints_def.HINTS]"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            self._process_create_port(context, data, result)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1518f4fb_e6d34ca0","line":44,"range":{"start_line":44,"start_character":39,"end_line":44,"end_character":61},"in_reply_to":"e7600e58_b9117de2","updated":"2023-04-18 13:16:28.000000000","message":"Done","commit_id":"b96c9000538032c269ebbe689ba7d0762d1f0a90"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a45d5bd0ad4303d1805ff426c7ff6f004ac7ad22","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _extend_port_dict(self, port_db, result):"},{"line_number":49,"context_line":"        if port_db.hints:"},{"line_number":50,"context_line":"            result[phints_def.HINTS] \u003d port_db.hints.hints"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            result[phints_def.HINTS] \u003d None"}],"source_content_type":"text/x-python","patch_set":16,"id":"d3eb4104_e7718a11","line":50,"range":{"start_line":50,"start_character":39,"end_line":50,"end_character":58},"updated":"2023-04-25 11:25:11.000000000","message":"This is a string, since the ovo to/from_db conversions do not apply here. We need to manually json.loads(), otherwise the api responses do not conform to the spec.","commit_id":"2d50d7a711d80a70be0a795a8e7323cf1519c104"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"89925b2a64deb58181b12eb118f9912d28bbf87a","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _extend_port_dict(self, port_db, result):"},{"line_number":49,"context_line":"        if port_db.hints:"},{"line_number":50,"context_line":"            result[phints_def.HINTS] \u003d port_db.hints.hints"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            result[phints_def.HINTS] \u003d None"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa29c31b_ed80efac","line":50,"range":{"start_line":50,"start_character":39,"end_line":50,"end_character":58},"in_reply_to":"ae216929_bcb9d7a7","updated":"2023-04-25 11:48:25.000000000","message":"thanks for updating","commit_id":"2d50d7a711d80a70be0a795a8e7323cf1519c104"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"287f71b47812edb364929c8b81c3679cad51b39f","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _extend_port_dict(self, port_db, result):"},{"line_number":49,"context_line":"        if port_db.hints:"},{"line_number":50,"context_line":"            result[phints_def.HINTS] \u003d port_db.hints.hints"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            result[phints_def.HINTS] \u003d None"}],"source_content_type":"text/x-python","patch_set":16,"id":"ae216929_bcb9d7a7","line":50,"range":{"start_line":50,"start_character":39,"end_line":50,"end_character":58},"in_reply_to":"d3eb4104_e7718a11","updated":"2023-04-25 11:28:21.000000000","message":"Done, see also: https://review.opendev.org/c/openstack/neutron-lib/+/881468","commit_id":"2d50d7a711d80a70be0a795a8e7323cf1519c104"}]}