)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"839154a139d12eed79b70f8e4f20e433eb67c301","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b6b936f4_cd0d75c9","updated":"2023-01-19 12:36:17.000000000","message":"This is not going to work in \"neutron-ovn-tempest-ovs-release-ubuntu-old\". Ubuntu focal is deploying OVN 20.03 (the package included in this version). This check is enforced since [1] and we should keep it until we drop the support for Ubuntu 20.04.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/862492","commit_id":"15ae90769067a16782fc8aa89679962e0f9df78b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"02cbb52acdbca21dfe52ecf1e0eb457477e61a04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8b2de3a0_9a2a95bb","updated":"2023-01-19 09:12:49.000000000","message":"recheck FT","commit_id":"15ae90769067a16782fc8aa89679962e0f9df78b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ddc5edfc1dd64e12e14a43ceb288535f37a6744f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"60606be9_dc4390b4","updated":"2023-01-18 16:29:34.000000000","message":"recheck fullstack timeout","commit_id":"15ae90769067a16782fc8aa89679962e0f9df78b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb9e49f979746b6bd8bd4f00cb8fbb95727f1eac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"64809065_5957ef73","updated":"2023-03-28 16:48:25.000000000","message":"recheck grenade","commit_id":"52e2a6498aa6c4903bcce8be7480a9f932e6c4be"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"71429c859316df03c733d844c79a760b41932e8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a0e55413_5b374f78","updated":"2023-03-27 08:51:19.000000000","message":"recheck grenade","commit_id":"52e2a6498aa6c4903bcce8be7480a9f932e6c4be"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4f9f42a24b74f548e523deb14f33a9b29fd9ae24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9d341c9d_3949ced0","updated":"2023-04-19 09:39:56.000000000","message":"recheck tempest","commit_id":"64d2acaf575a6cee8999c8a9f8fbd89a9193a59d"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"406c8daa3313eb154aeeb31495bc453edff853ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"97642e39_41711a8b","updated":"2023-04-26 19:17:41.000000000","message":"Looks good to me, just setting -1 for visibility to consider that version check(corner case)","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7cd4a05d6cdd5f9ad7b26a4b533b34797ae967f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2f58bc02_8d928a66","updated":"2023-04-26 06:25:02.000000000","message":"recheck tempest","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7b401f46fe5abe15d1e7b99dfec5b9ba6505dc90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"34a01df6_5cb22f7a","updated":"2023-04-26 14:28:14.000000000","message":"recheck tempest","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2af58d43807819c070174ec362149f813997aa69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c8f5db79_c9cc56d3","updated":"2023-04-25 17:10:28.000000000","message":"recheck tempest","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6a441043bdd13861a04ae3625cb0bae1ee5d208d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"499c65ad_b37571b5","updated":"2023-04-28 13:14:02.000000000","message":"recheck vexxhost nodes disabled","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"afe73e4385f0dac055a020adb12715904fcddef3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e3450b0a_10bde11e","updated":"2023-05-22 09:15:42.000000000","message":"Great to see this cause I think it simplifies the code a little! Thanks!","commit_id":"be4e150de98506b080c3b9a3f324324821e4666e"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"406c8daa3313eb154aeeb31495bc453edff853ca","unresolved":true,"context_lines":[{"line_number":665,"context_line":"        ver \u003d _get_ovn_version(OVNCheckType.sb_db_schema)"},{"line_number":666,"context_line":"        minver \u003d versionutils.convert_version_to_tuple("},{"line_number":667,"context_line":"            OVN_SB_DB_SCHEMA_CHASSIS_PRIVATE)"},{"line_number":668,"context_line":"        if ver \u003c minver:"},{"line_number":669,"context_line":"            return False"},{"line_number":670,"context_line":"    except (OSError, RuntimeError, ValueError) as e:"},{"line_number":671,"context_line":"        LOG.debug(\u0027Exception while checking OVN DB schema version. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"f446f147_83118ed8","line":668,"range":{"start_line":668,"start_character":11,"end_line":668,"end_character":23},"updated":"2023-04-26 19:17:41.000000000","message":"Just a thought: \nUsing tuple comparison for version check has some flaws. For example, (2,9) \u003d\u003d (2,9,0) comparison yields False but from version check it should be True in my opinion. Similarly, (2,9) \u003c (2,9,0) yields True although it should False in my opinion.  The second scenario is possible, since _get_ovn_version() returns tuple of 3 elements and the OVN_SB_DB_SCHEMA_CHASSIS_PRIVATE produces tuple of 2 elements. So ver \u003d (2,9,0) , minver \u003d (2,9) ver \u003c minver evaluates to False and exception is raised and logged.","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7c00b626594384b88d61e085ed77c23d9305e9e1","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        ver \u003d _get_ovn_version(OVNCheckType.sb_db_schema)"},{"line_number":666,"context_line":"        minver \u003d versionutils.convert_version_to_tuple("},{"line_number":667,"context_line":"            OVN_SB_DB_SCHEMA_CHASSIS_PRIVATE)"},{"line_number":668,"context_line":"        if ver \u003c minver:"},{"line_number":669,"context_line":"            return False"},{"line_number":670,"context_line":"    except (OSError, RuntimeError, ValueError) as e:"},{"line_number":671,"context_line":"        LOG.debug(\u0027Exception while checking OVN DB schema version. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"6b315f67_483ca914","line":668,"range":{"start_line":668,"start_character":11,"end_line":668,"end_character":23},"in_reply_to":"36203942_6c2bd4d3","updated":"2023-04-27 09:30:35.000000000","message":"Actually it is a bug but if \"ver \u003c minver\" if false, then the check passes. In your example (2,9,0) \u003c (2,9), that will pass the version check.\n\nWe need to be more accurate but the current checks won\u0027t stop any revision check.","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c966586f472bbdb93344be69784b5fb0845a700","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        ver \u003d _get_ovn_version(OVNCheckType.sb_db_schema)"},{"line_number":666,"context_line":"        minver \u003d versionutils.convert_version_to_tuple("},{"line_number":667,"context_line":"            OVN_SB_DB_SCHEMA_CHASSIS_PRIVATE)"},{"line_number":668,"context_line":"        if ver \u003c minver:"},{"line_number":669,"context_line":"            return False"},{"line_number":670,"context_line":"    except (OSError, RuntimeError, ValueError) as e:"},{"line_number":671,"context_line":"        LOG.debug(\u0027Exception while checking OVN DB schema version. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"8be5d8a9_673cd9e7","line":668,"range":{"start_line":668,"start_character":11,"end_line":668,"end_character":23},"in_reply_to":"6b315f67_483ca914","updated":"2023-04-27 09:45:32.000000000","message":"--\u003e https://review.opendev.org/c/openstack/neutron/+/881708","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"720b5b798c522ea8629f60e5741850fb2df1f116","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        ver \u003d _get_ovn_version(OVNCheckType.sb_db_schema)"},{"line_number":666,"context_line":"        minver \u003d versionutils.convert_version_to_tuple("},{"line_number":667,"context_line":"            OVN_SB_DB_SCHEMA_CHASSIS_PRIVATE)"},{"line_number":668,"context_line":"        if ver \u003c minver:"},{"line_number":669,"context_line":"            return False"},{"line_number":670,"context_line":"    except (OSError, RuntimeError, ValueError) as e:"},{"line_number":671,"context_line":"        LOG.debug(\u0027Exception while checking OVN DB schema version. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"2b301152_7e236af5","line":668,"range":{"start_line":668,"start_character":11,"end_line":668,"end_character":23},"in_reply_to":"8be5d8a9_673cd9e7","updated":"2023-04-27 14:06:25.000000000","message":"You are right about \" if \"ver \u003c minver\" if false \" I missread when the LOG.debug gets executed. Thanks for proposing that tuple length change. I\u0027ll review it","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"90fd7867d4de97fbb67ac0027727ddcf1c887e58","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        ver \u003d _get_ovn_version(OVNCheckType.sb_db_schema)"},{"line_number":666,"context_line":"        minver \u003d versionutils.convert_version_to_tuple("},{"line_number":667,"context_line":"            OVN_SB_DB_SCHEMA_CHASSIS_PRIVATE)"},{"line_number":668,"context_line":"        if ver \u003c minver:"},{"line_number":669,"context_line":"            return False"},{"line_number":670,"context_line":"    except (OSError, RuntimeError, ValueError) as e:"},{"line_number":671,"context_line":"        LOG.debug(\u0027Exception while checking OVN DB schema version. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"36203942_6c2bd4d3","line":668,"range":{"start_line":668,"start_character":11,"end_line":668,"end_character":23},"in_reply_to":"f446f147_83118ed8","updated":"2023-04-27 09:20:20.000000000","message":"That\u0027s a bug, indeed. I\u0027ll open a LP right now.","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"}],"neutron/cmd/sanity_check.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"406c8daa3313eb154aeeb31495bc453edff853ca","unresolved":true,"context_lines":[{"line_number":350,"context_line":"def check_ovn_sb_db_schema_chassis_private():"},{"line_number":351,"context_line":"    result \u003d checks.ovn_sb_db_schema_chassis_private_supported()"},{"line_number":352,"context_line":"    if not result:"},{"line_number":353,"context_line":"        LOG.warning(\u0027OVN SB DB schema does not support chassis private. This \u0027"},{"line_number":354,"context_line":"                    \u0027support was added in DB schema version 2.9.0.\u0027)"},{"line_number":355,"context_line":"    return result"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"48790d58_ca808f77","line":353,"range":{"start_line":353,"start_character":55,"end_line":353,"end_character":70},"updated":"2023-04-26 19:17:41.000000000","message":"nit: Other warnings are using literal tables names. For consistency this should be \"Chassis_Private\"","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"90fd7867d4de97fbb67ac0027727ddcf1c887e58","unresolved":false,"context_lines":[{"line_number":350,"context_line":"def check_ovn_sb_db_schema_chassis_private():"},{"line_number":351,"context_line":"    result \u003d checks.ovn_sb_db_schema_chassis_private_supported()"},{"line_number":352,"context_line":"    if not result:"},{"line_number":353,"context_line":"        LOG.warning(\u0027OVN SB DB schema does not support chassis private. This \u0027"},{"line_number":354,"context_line":"                    \u0027support was added in DB schema version 2.9.0.\u0027)"},{"line_number":355,"context_line":"    return result"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"56c762be_531e1dad","line":353,"range":{"start_line":353,"start_character":55,"end_line":353,"end_character":70},"in_reply_to":"48790d58_ca808f77","updated":"2023-04-27 09:20:20.000000000","message":"Done","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"406c8daa3313eb154aeeb31495bc453edff853ca","unresolved":true,"context_lines":[{"line_number":441,"context_line":"                    default\u003dFalse),"},{"line_number":442,"context_line":"    BoolOptCallback(\u0027ovn_sb_db_schema_chassis_private_support\u0027,"},{"line_number":443,"context_line":"                    check_ovn_sb_db_schema_virtual_port,"},{"line_number":444,"context_line":"                    help\u003d_(\u0027Check OVN SB DB schema support chassis private\u0027),"},{"line_number":445,"context_line":"                    default\u003dFalse),"},{"line_number":446,"context_line":"]"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5b680684_acd8cc7e","line":444,"range":{"start_line":444,"start_character":59,"end_line":444,"end_character":74},"updated":"2023-04-26 19:17:41.000000000","message":"ditto","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"90fd7867d4de97fbb67ac0027727ddcf1c887e58","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                    default\u003dFalse),"},{"line_number":442,"context_line":"    BoolOptCallback(\u0027ovn_sb_db_schema_chassis_private_support\u0027,"},{"line_number":443,"context_line":"                    check_ovn_sb_db_schema_virtual_port,"},{"line_number":444,"context_line":"                    help\u003d_(\u0027Check OVN SB DB schema support chassis private\u0027),"},{"line_number":445,"context_line":"                    default\u003dFalse),"},{"line_number":446,"context_line":"]"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"c08eb3a4_d1271efe","line":444,"range":{"start_line":444,"start_character":59,"end_line":444,"end_character":74},"in_reply_to":"5b680684_acd8cc7e","updated":"2023-04-27 09:20:20.000000000","message":"Done","commit_id":"7d3e9664b4edf57fb5a93fcfffd60199600421c8"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"5f29242272aa0af629afd69e44b2e5cbd76b1a21","unresolved":true,"context_lines":[{"line_number":448,"context_line":"                    default\u003dFalse),"},{"line_number":449,"context_line":"    BoolOptCallback(\u0027ovn_localnet_learn_fdb_support\u0027,"},{"line_number":450,"context_line":"                    check_ovn_localnet_learn_fdb_support,"},{"line_number":451,"context_line":"                    help\u003d_(\u0027Check OVN supports localnet_learn_fdb option\u0027),"},{"line_number":452,"context_line":"                    default\u003dFalse),"},{"line_number":453,"context_line":"    BoolOptCallback(\u0027ovn_sb_db_schema_chassis_private_support\u0027,"},{"line_number":454,"context_line":"                    check_ovn_sb_db_schema_virtual_port,"}],"source_content_type":"text/x-python","patch_set":9,"id":"d44d5f92_9545f6cb","line":451,"range":{"start_line":451,"start_character":38,"end_line":451,"end_character":46},"updated":"2023-05-09 17:00:33.000000000","message":"nit: \u0027Check OVN localnet_learn_fdp option support\" to be consistent with other messages","commit_id":"be4e150de98506b080c3b9a3f324324821e4666e"}]}