)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8713d929ddf977079d9578c3d90db148b7bd3eff","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     elajkat \u003clajos.katona@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-24 14:52:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fullstack: Wait placement process fixtrue to really stop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It seems that in test test_configurations_are_synced_towards_placement"},{"line_number":10,"context_line":"when the fake placement process is stopped it can take longer and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c491ed8a_2e286c4b","line":7,"updated":"2023-01-24 18:42:46.000000000","message":"s/fixtrue/fixture","commit_id":"d7355d6a3bda2b66317d0eb9ac6ca385c01fd745"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e37d16f8a6a9e15a59e874fc1323c0baa5107bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8e067a9b_686f3ff9","updated":"2023-01-25 15:19:22.000000000","message":"Thanks Lajos, now there is no \"layer violation\" 😊","commit_id":"0ae432e71712be671ec93dded3245513b6810cd0"}],"neutron/tests/fullstack/resources/process.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b28ed6e071075aedb431fea5d503b4d15c2273f","unresolved":true,"context_lines":[{"line_number":99,"context_line":"            return executor.submit(_restart)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def process_is_running(self):"},{"line_number":102,"context_line":"        return self.process._is_running"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def process_is_not_running(self):"},{"line_number":105,"context_line":"        return not self.process._is_running"}],"source_content_type":"text/x-python","patch_set":3,"id":"6ec46e9b_ed74b631","line":102,"updated":"2023-01-24 19:21:17.000000000","message":"This shouldn\u0027t look at _is_running either, it should, for example, call self.process.is_running() which would do that (it doesn\u0027t exist yet of course). This would make it similar to start() and stop() above that call their respective parent class functions.","commit_id":"d7355d6a3bda2b66317d0eb9ac6ca385c01fd745"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5f6352535cc2f6d16b87e6523ffebba6aa7bb930","unresolved":true,"context_lines":[{"line_number":99,"context_line":"            return executor.submit(_restart)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def process_is_running(self):"},{"line_number":102,"context_line":"        return self.process._is_running"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def process_is_not_running(self):"},{"line_number":105,"context_line":"        return not self.process._is_running"}],"source_content_type":"text/x-python","patch_set":3,"id":"051a51ea_d2a95faf","line":102,"in_reply_to":"6ec46e9b_ed74b631","updated":"2023-01-25 13:02:36.000000000","message":"by default I try to avoid touching non-test code to fix test code but you are right it is really better.","commit_id":"d7355d6a3bda2b66317d0eb9ac6ca385c01fd745"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8713d929ddf977079d9578c3d90db148b7bd3eff","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        return self.process._is_running"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def process_is_not_running(self):"},{"line_number":105,"context_line":"        return not self.process._is_running"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class RabbitmqEnvironmentFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":3,"id":"235293b1_a9bb5f14","line":105,"updated":"2023-01-24 18:42:46.000000000","message":"`return not self.process_is_running()`\n\nSo if we change behavior of this function it\u0027s reflected for free.","commit_id":"d7355d6a3bda2b66317d0eb9ac6ca385c01fd745"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5f6352535cc2f6d16b87e6523ffebba6aa7bb930","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        return self.process._is_running"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def process_is_not_running(self):"},{"line_number":105,"context_line":"        return not self.process._is_running"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class RabbitmqEnvironmentFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ef777703_ad2b3337","line":105,"in_reply_to":"235293b1_a9bb5f14","updated":"2023-01-25 13:02:36.000000000","message":"thanks.","commit_id":"d7355d6a3bda2b66317d0eb9ac6ca385c01fd745"}],"neutron/tests/fullstack/test_agent_bandwidth_report.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"40e567208f5fd25253640a7070672e6513e504df","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        # restarting the agent to be sure that the sync will fail."},{"line_number":243,"context_line":"        def _placement_is_not_running():"},{"line_number":244,"context_line":"            placement_fixt \u003d self.environment.placement.process_fixture"},{"line_number":245,"context_line":"            return not placement_fixt.process._is_running"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        utils.wait_until_true("},{"line_number":248,"context_line":"            predicate\u003dfunctools.partial(_placement_is_not_running),"}],"source_content_type":"text/x-python","patch_set":1,"id":"a6d2e054_8728ee36","line":245,"updated":"2023-01-20 18:55:42.000000000","message":"My only comment is this should really live in the ProcessFixture class where start/stop are, and it would call the AsyncProcess class class in return. Otherwise this test is relying on knowledge of a private value from that parent class.","commit_id":"c20716b38a456270b4ea1893828f857fa8959d76"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d75a815caac2a5b5346a00bd467fdd19b4ae4860","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        # restarting the agent to be sure that the sync will fail."},{"line_number":243,"context_line":"        def _placement_is_not_running():"},{"line_number":244,"context_line":"            placement_fixt \u003d self.environment.placement.process_fixture"},{"line_number":245,"context_line":"            return not placement_fixt.process._is_running"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        utils.wait_until_true("},{"line_number":248,"context_line":"            predicate\u003dfunctools.partial(_placement_is_not_running),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a641f4d_bb9f008d","line":245,"in_reply_to":"a6d2e054_8728ee36","updated":"2023-01-24 13:55:12.000000000","message":"thanks, I added the is_running/is_not_running methods to process fixture class, it is really a better place, and can be used later for other prcesses also","commit_id":"c20716b38a456270b4ea1893828f857fa8959d76"}]}