)]}'
{"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"6a7d889ec9922debeed7fcab19b0b08d8322d0d3","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    port_dev.route.add_gateway(gateway_ip)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def assert_ping(src_namespace, dst_ip, timeout\u003d1, count\u003d3, retry\u003dFalse):"},{"line_number":112,"context_line":"    ipversion \u003d netaddr.IPAddress(dst_ip).version"},{"line_number":113,"context_line":"    ping_command \u003d \u0027ping\u0027 if ipversion \u003d\u003d 4 else \u0027ping6\u0027"},{"line_number":114,"context_line":"    ns_ip_wrapper \u003d ip_lib.IPWrapper(src_namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"22024965_ec9273a4","line":111,"range":{"start_line":111,"start_character":59,"end_line":111,"end_character":64},"updated":"2023-01-19 17:13:19.000000000","message":"personal nit:\nto me `retry` means that it will try few times but the code only tries one more time. So I would either change this variable to `retry_once\u003dFalse` or change the variable to `retry_count\u003d0` and then update the function logic to retry set amount of time.\nAgain this is just my personal preference","commit_id":"ef4b1c7fa72723fdc940565327533ce4b16223e0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4fdf039da2fd8c99e01d963757b1211f20320dac","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    port_dev.route.add_gateway(gateway_ip)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def assert_ping(src_namespace, dst_ip, timeout\u003d1, count\u003d3, retry\u003dFalse):"},{"line_number":112,"context_line":"    ipversion \u003d netaddr.IPAddress(dst_ip).version"},{"line_number":113,"context_line":"    ping_command \u003d \u0027ping\u0027 if ipversion \u003d\u003d 4 else \u0027ping6\u0027"},{"line_number":114,"context_line":"    ns_ip_wrapper \u003d ip_lib.IPWrapper(src_namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"87e4694b_cce0f477","line":111,"range":{"start_line":111,"start_character":59,"end_line":111,"end_character":64},"in_reply_to":"22024965_ec9273a4","updated":"2023-01-20 09:32:58.000000000","message":"I\u0027ll use retry_count in the next PS","commit_id":"ef4b1c7fa72723fdc940565327533ce4b16223e0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"19fc1beef7bb96877ed8e055f9e79a7bbe32e6bc","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                privsep_exec\u003dTrue)"},{"line_number":121,"context_line":"            return"},{"line_number":122,"context_line":"        except n_exc.ProcessExecutionError as exc:"},{"line_number":123,"context_line":"            if not retry_count:"},{"line_number":124,"context_line":"                raise exc"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"200b1f8b_47f743a8","line":123,"updated":"2023-01-23 11:44:19.000000000","message":"would it be maybe worth to log here what exception occured always?","commit_id":"f235ce8791ab31bac598a3ebb40fb48cf2e4d1ab"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f22b1d672c3794411b35796b5cbd8209ea53b09e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                privsep_exec\u003dTrue)"},{"line_number":121,"context_line":"            return"},{"line_number":122,"context_line":"        except n_exc.ProcessExecutionError as exc:"},{"line_number":123,"context_line":"            if not retry_count:"},{"line_number":124,"context_line":"                raise exc"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"15284fdb_9595fd51","line":123,"in_reply_to":"200b1f8b_47f743a8","updated":"2023-01-24 16:31:45.000000000","message":"The exception will be logged, same as before. I don\u0027t think we need to add more logs here.","commit_id":"f235ce8791ab31bac598a3ebb40fb48cf2e4d1ab"}]}