)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d7624a5dace307ce012d996912ea3386db1690fd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 14:35:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure traffic for provider vlan networks is not centralized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an extra checking to ensure the"},{"line_number":10,"context_line":"\"reside-on-redirect-chassis\" is set to true for the logical"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ea793dc6_b962a751","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":60},"updated":"2023-01-20 15:04:07.000000000","message":"Sorry, I must be understanding this in the wrong way. What we need is to *always* define the provider VLAN networks as centralized, right? This is why we are always setting the \u0027reside-on-redirect-chassis\u0027 flag to True in this case.\n\nWhy then \"is not centralized\"? Shouldn\u0027t be \"is centralized\"?","commit_id":"624b2dbd2fd157464877d484793add729ec35764"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"df9e9752d34c8d7cc573e90073171e7947d7af5c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 14:35:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure traffic for provider vlan networks is not centralized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an extra checking to ensure the"},{"line_number":10,"context_line":"\"reside-on-redirect-chassis\" is set to true for the logical"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d1188224_9abf3cf0","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":60},"in_reply_to":"45f5d462_a00d24f7","updated":"2023-01-30 12:31:43.000000000","message":"It\u0027s a good option, I agree. We can document the version of core OVN is required for this feature once it\u0027s fixed in core OVN.","commit_id":"624b2dbd2fd157464877d484793add729ec35764"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"086ee89dd1bd976d03f947edbc8bcaffde418279","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 14:35:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure traffic for provider vlan networks is not centralized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an extra checking to ensure the"},{"line_number":10,"context_line":"\"reside-on-redirect-chassis\" is set to true for the logical"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f67757e6_b603f871","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":60},"in_reply_to":"5b62d471_34ef3050","updated":"2023-01-20 18:23:57.000000000","message":"Thanks for exploring this. This is very confusing indeed.\n\nIf I were to implement this perhaps I would just consider 2 out of the 3 behaviors here: The second (reside False WITHOUT mac-mappings) and the third (reside False WITH mac-mappings).\n\nI understand the third one is currently broken but this is something we can fix at core OVN level I assume.\n\nRegarding the first one (reside True WITHOUT mac-mappings), is there any use case for this ? It\u0027s still centralized, just like the second one. Do we really need to support this non-tunneled centralized use case ?!?!\n\nWhat you think, perhaps we should refactor how we do VLAN + DVR here and be sane about the options we offer to avoid creating all this confusion.","commit_id":"624b2dbd2fd157464877d484793add729ec35764"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b7740b62c0a4854babe6b6623254f36fb77e6b95","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 14:35:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure traffic for provider vlan networks is not centralized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an extra checking to ensure the"},{"line_number":10,"context_line":"\"reside-on-redirect-chassis\" is set to true for the logical"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfe7388b_2edfc954","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":60},"in_reply_to":"5ca4fea1_367b0494","updated":"2023-01-26 14:41:28.000000000","message":"Yes, I think the right way is not check the external flat (in the specific case where I hit this, the network was not router:external, but internal, yet a provider network. This means also that utils function is actually not really accurate. It is not checking if the network is provider, but if it is external or not (meaning if it requires a neutron router to sent the traffic out or not).\n\nSo, we need to decide, should we do:\n1) update the utils function so that it checks if the network is provider, and have another function to check if it is external,\n2) use the new check (physical information instead of external) for this patch, and\n3) mark this with a FIXME so that this is removed once the ovn bug related to it is resolved?","commit_id":"624b2dbd2fd157464877d484793add729ec35764"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"70b1f151851845df005fe20bd4edf97c75e2a103","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 14:35:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure traffic for provider vlan networks is not centralized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an extra checking to ensure the"},{"line_number":10,"context_line":"\"reside-on-redirect-chassis\" is set to true for the logical"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"45f5d462_a00d24f7","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":60},"in_reply_to":"bfe7388b_2edfc954","updated":"2023-01-30 12:16:58.000000000","message":"I would go for the 3rd option. This is a temporary fix until OVN core is fixed. So I would keep the current code and a comment (and a release note).","commit_id":"624b2dbd2fd157464877d484793add729ec35764"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"3882778d4a2d4589f2069a8e76c7c66e000e2a58","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 14:35:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure traffic for provider vlan networks is not centralized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an extra checking to ensure the"},{"line_number":10,"context_line":"\"reside-on-redirect-chassis\" is set to true for the logical"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f06265f9_7b4f233d","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":60},"in_reply_to":"d1188224_9abf3cf0","updated":"2023-02-03 09:47:54.000000000","message":"Done","commit_id":"624b2dbd2fd157464877d484793add729ec35764"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"2731e94aed32b3e70dea9b4c8a073ee0c8e4fc11","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 14:35:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure traffic for provider vlan networks is not centralized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an extra checking to ensure the"},{"line_number":10,"context_line":"\"reside-on-redirect-chassis\" is set to true for the logical"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5b62d471_34ef3050","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":60},"in_reply_to":"ea793dc6_b962a751","updated":"2023-01-20 16:08:35.000000000","message":"This is tricky and maybe at core-ovn level. Let me try to explain my findings:\n- reside-on-redirect-chassis flag to True --\u003e means traffic is not tunneled to the controller with the gateway port, but the traffic still needs to go through the controller with the gateway port (that is what I thought was distributed, but it is indeed centralized, just avoids the tunneling and therefore the MTU issue)\n- reside-on-redirect-chassis flag to False --\u003e the traffic goes tunneled to the controller with the gateway port (this is centralized too, plus requires extra MTU reduction)\n- reside-on-redirect-chassis flat to False, but ovn-chassis-mac-mappings configured --\u003e this is the true distributed, no tunnels being used, and traffic should not go to the controller with the gateway port. However this is not working as expected and the traffic is being sent (thorough genev tunnel) to the controller","commit_id":"624b2dbd2fd157464877d484793add729ec35764"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"4aee877d64f975aa52cdb5967c40c527f68ef4d9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 14:35:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure traffic for provider vlan networks is not centralized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an extra checking to ensure the"},{"line_number":10,"context_line":"\"reside-on-redirect-chassis\" is set to true for the logical"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fd72069c_eb303c01","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":60},"in_reply_to":"f67757e6_b603f871","updated":"2023-01-20 18:51:15.000000000","message":"Note there is a difference between your first and second cases. Reside True without mac-mappings means the traffic is centralized through the cr-lrp, but not tunneled (therefore avoiding MTU issues), while reside false without mac-mappings means tunneled to the cr-lrp (so also centralized), meaning extra reduction on the MTU needed","commit_id":"624b2dbd2fd157464877d484793add729ec35764"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"aa7dce906a67c794106eff13cbb2dc51c49b5cfc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 14:35:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure traffic for provider vlan networks is not centralized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an extra checking to ensure the"},{"line_number":10,"context_line":"\"reside-on-redirect-chassis\" is set to true for the logical"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ca4fea1_367b0494","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":60},"in_reply_to":"fd72069c_eb303c01","updated":"2023-01-26 14:22:08.000000000","message":"Ahhh, now I get that. Please, write an article about this!! And thanks for the explanation.\n\nDo you want to keep the -W flag?","commit_id":"624b2dbd2fd157464877d484793add729ec35764"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dd2d4c5ca510ed1cd33a29810686e615234f9c4c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"  extra MTU reduction to work."},{"line_number":23,"context_line":"- reside-on-redirect-chassis flag to True: means traffic is not"},{"line_number":24,"context_line":"  tunneled to the controller with the gateway port, but the traffic is"},{"line_number":25,"context_line":"  centralized through the controoler with the gateway port. Thus it"},{"line_number":26,"context_line":"  does not require extra MTU reduction."},{"line_number":27,"context_line":"- reside-on-redirect-chassis to False, but with ovn-chassis-mac-mappings"},{"line_number":28,"context_line":"  configured: means the traffic is fully distributed and it is not being"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ec471521_565d21ec","line":25,"range":{"start_line":25,"start_character":26,"end_line":25,"end_character":36},"updated":"2023-02-03 09:20:23.000000000","message":"(nit) controoler -\u003e controller","commit_id":"507dd252fb92cab0b707d735de6e50209e6d9977"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"3882778d4a2d4589f2069a8e76c7c66e000e2a58","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  extra MTU reduction to work."},{"line_number":23,"context_line":"- reside-on-redirect-chassis flag to True: means traffic is not"},{"line_number":24,"context_line":"  tunneled to the controller with the gateway port, but the traffic is"},{"line_number":25,"context_line":"  centralized through the controoler with the gateway port. Thus it"},{"line_number":26,"context_line":"  does not require extra MTU reduction."},{"line_number":27,"context_line":"- reside-on-redirect-chassis to False, but with ovn-chassis-mac-mappings"},{"line_number":28,"context_line":"  configured: means the traffic is fully distributed and it is not being"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"33fe2432_a9be8595","line":25,"range":{"start_line":25,"start_character":26,"end_line":25,"end_character":36},"in_reply_to":"ec471521_565d21ec","updated":"2023-02-03 09:47:54.000000000","message":"Done","commit_id":"507dd252fb92cab0b707d735de6e50209e6d9977"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"95c0a7c641b07a8759adac0df5aec35fe4217920","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"122e7f4a_dff5749c","updated":"2023-01-20 12:02:25.000000000","message":"Thanks for this Luis! The change LGTM but, for standardizing the code we should use the helper method that already exists to check if the network is a provider network","commit_id":"f9af37269dd84fe6982051a360fe70219341c6ce"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"947335a449cb28a37135376bf45055ebbe7c05e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e96f3ec_7ab95df3","updated":"2023-01-20 15:44:06.000000000","message":"most probably this is not the right approach and the problem is that the flag is not working as intended","commit_id":"624b2dbd2fd157464877d484793add729ec35764"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dd2d4c5ca510ed1cd33a29810686e615234f9c4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"025ac7f5_1884c3be","updated":"2023-02-03 09:20:23.000000000","message":"LGTM, just a meganit typo in the commit msg","commit_id":"507dd252fb92cab0b707d735de6e50209e6d9977"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9a3b0a8e9b759c5983357a8b808546dc891945db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"214e07c5_e1b8fc17","updated":"2023-01-31 06:34:09.000000000","message":"recheck neutron-functional-with-uwsgi unrelated","commit_id":"507dd252fb92cab0b707d735de6e50209e6d9977"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"95199ad1e0c35756e5d3b36707c0cac2f39b4ea1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4e0adfac_abc98aa9","updated":"2023-02-13 08:54:23.000000000","message":"Thanks for digging into the problem and proposing this patch working around the core OVN issue.","commit_id":"9c46e190d33b81c75d9f145c729edbaa718ea868"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"055728f3834f2e978530667c1bc3f9bc6557d676","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"489b863f_b71a9773","updated":"2023-02-13 14:20:20.000000000","message":"We need a test that makes sure that a packet of the size the MTU goes through to not regress. Can we add this as a followup?\n\nalso nit: [ovn] to the commit message title :)","commit_id":"9c46e190d33b81c75d9f145c729edbaa718ea868"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ce3e98e673c7f56ad77db50b7a565bb804f2b95e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"76eaaba3_371b295e","updated":"2023-02-03 13:15:41.000000000","message":"recheck neutron-ovn-grenade-multinode-skip-level unrelated","commit_id":"9c46e190d33b81c75d9f145c729edbaa718ea868"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"561c1e7b94b843d565980396cada471aa7a0ed86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5285255f_51984121","updated":"2023-02-14 06:37:57.000000000","message":"recheck neutron-ovn-tempest-ipv6-only-ovs-release Invokation error","commit_id":"3d5dfc4991511b0b0cfb1a9e1c69f9ce0b173547"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"2ae575c262652e88ab2ee958fa46b674bdda0b0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9aee5eb6_90dec96c","updated":"2023-02-14 08:41:50.000000000","message":"recheck neutron-tempest-plugin-designate-scenario unrelated timeout","commit_id":"3d5dfc4991511b0b0cfb1a9e1c69f9ce0b173547"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0e459112197595e5a9d2e328078f516cd0504435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0aa320b9_49870d96","updated":"2023-02-21 08:24:10.000000000","message":"If a better way if found, I\u0027ll propose the improvement in a follow up patch","commit_id":"d7e52b31e8e25d2781cab20703844ba1cc5153cc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a00798e0b5a472cea3bf7d1e154b5e02c85b4c1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5062c8e0_e282f354","updated":"2023-02-21 07:43:54.000000000","message":"Investigating setting of a different flag that may end up in a better solution (distributed instead of centralized)","commit_id":"d7e52b31e8e25d2781cab20703844ba1cc5153cc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e8e9bcf86469da1d6c941e253153750f8de8c29b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1e69e42b_2ac1ef4e","updated":"2023-02-20 14:02:06.000000000","message":"recheck neutron-ovn-tempest-ipv6-only-ovs-release unrelated","commit_id":"d7e52b31e8e25d2781cab20703844ba1cc5153cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f9ccb5d0577689b3016872332f55fd7d43ba26f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3677d2eb_909220a8","in_reply_to":"5062c8e0_e282f354","updated":"2023-02-21 08:10:25.000000000","message":"This new flag can be proposed in another patch.","commit_id":"d7e52b31e8e25d2781cab20703844ba1cc5153cc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a8f1f1bb72a2b39263067adc4c97cc24f9a3004e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4f9fb2e8_bcb7c87e","updated":"2023-02-28 11:34:25.000000000","message":"Thx. Now release note looks good for me 😎","commit_id":"acb809eea422f417d4bfb2d46918839d7d379e4c"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b45bec6578016432332352e562c5ec026e847d1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c5f19687_cc143c95","updated":"2023-02-28 11:09:22.000000000","message":"recheck neutron-ovn-tempest-ovs-release-ubuntu-old unrelated","commit_id":"acb809eea422f417d4bfb2d46918839d7d379e4c"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c0135b0cafea6e65454799a4d5c34a247b697b32","unresolved":true,"context_lines":[{"line_number":725,"context_line":"        vlan_nets \u003d self._ovn_client._plugin.get_networks("},{"line_number":726,"context_line":"            context, {pnet.NETWORK_TYPE: [n_const.TYPE_VLAN]})"},{"line_number":727,"context_line":"        vlan_net_ids \u003d [vn[\u0027id\u0027] for vn in vlan_nets"},{"line_number":728,"context_line":"                        if not vn.get(pnet.PHYSICAL_NETWORK)]"},{"line_number":729,"context_line":"        router_ports \u003d self._ovn_client._plugin.get_ports("},{"line_number":730,"context_line":"            context, {\u0027network_id\u0027: vlan_net_ids,"},{"line_number":731,"context_line":"                      \u0027device_owner\u0027: n_const.ROUTER_PORT_OWNERS})"}],"source_content_type":"text/x-python","patch_set":1,"id":"f62ca447_e46d6cdd","line":728,"range":{"start_line":728,"start_character":31,"end_line":728,"end_character":60},"updated":"2023-01-20 12:02:42.000000000","message":"ditto (same as the other comment)","commit_id":"f9af37269dd84fe6982051a360fe70219341c6ce"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2d8558b2b7c00bfdff31fc713a95865e9b2ea41a","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        vlan_nets \u003d self._ovn_client._plugin.get_networks("},{"line_number":726,"context_line":"            context, {pnet.NETWORK_TYPE: [n_const.TYPE_VLAN]})"},{"line_number":727,"context_line":"        vlan_net_ids \u003d [vn[\u0027id\u0027] for vn in vlan_nets"},{"line_number":728,"context_line":"                        if not vn.get(pnet.PHYSICAL_NETWORK)]"},{"line_number":729,"context_line":"        router_ports \u003d self._ovn_client._plugin.get_ports("},{"line_number":730,"context_line":"            context, {\u0027network_id\u0027: vlan_net_ids,"},{"line_number":731,"context_line":"                      \u0027device_owner\u0027: n_const.ROUTER_PORT_OWNERS})"}],"source_content_type":"text/x-python","patch_set":1,"id":"a81dd749_1417c6a1","line":728,"range":{"start_line":728,"start_character":31,"end_line":728,"end_character":60},"in_reply_to":"f62ca447_e46d6cdd","updated":"2023-01-20 18:24:17.000000000","message":"Done","commit_id":"f9af37269dd84fe6982051a360fe70219341c6ce"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"95c0a7c641b07a8759adac0df5aec35fe4217920","unresolved":true,"context_lines":[{"line_number":1576,"context_line":"        if network.get(pnet.NETWORK_TYPE) \u003d\u003d const.TYPE_VLAN:"},{"line_number":1577,"context_line":"            options[ovn_const.LRP_OPTIONS_RESIDE_REDIR_CH] \u003d ("},{"line_number":1578,"context_line":"                \u0027false\u0027 if (ovn_conf.is_ovn_distributed_floating_ip() and"},{"line_number":1579,"context_line":"                            not network.get(pnet.PHYSICAL_NETWORK))"},{"line_number":1580,"context_line":"                else \u0027true\u0027)"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"        is_gw_port \u003d const.DEVICE_OWNER_ROUTER_GW \u003d\u003d port.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"ccf18c75_86e628de","line":1579,"range":{"start_line":1579,"start_character":32,"end_line":1579,"end_character":66},"updated":"2023-01-20 12:02:25.000000000","message":"Nit: \n\nThere\u0027s a utils method for this, utils.is_provider_network(net)","commit_id":"f9af37269dd84fe6982051a360fe70219341c6ce"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2d8558b2b7c00bfdff31fc713a95865e9b2ea41a","unresolved":false,"context_lines":[{"line_number":1576,"context_line":"        if network.get(pnet.NETWORK_TYPE) \u003d\u003d const.TYPE_VLAN:"},{"line_number":1577,"context_line":"            options[ovn_const.LRP_OPTIONS_RESIDE_REDIR_CH] \u003d ("},{"line_number":1578,"context_line":"                \u0027false\u0027 if (ovn_conf.is_ovn_distributed_floating_ip() and"},{"line_number":1579,"context_line":"                            not network.get(pnet.PHYSICAL_NETWORK))"},{"line_number":1580,"context_line":"                else \u0027true\u0027)"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"        is_gw_port \u003d const.DEVICE_OWNER_ROUTER_GW \u003d\u003d port.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"88e0c0cf_857e276a","line":1579,"range":{"start_line":1579,"start_character":32,"end_line":1579,"end_character":66},"in_reply_to":"53b485b1_091093c3","updated":"2023-01-20 18:24:17.000000000","message":"Done","commit_id":"f9af37269dd84fe6982051a360fe70219341c6ce"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"14e9ec508c1839dd641c6e6c4f90b41d4bc322ea","unresolved":true,"context_lines":[{"line_number":1576,"context_line":"        if network.get(pnet.NETWORK_TYPE) \u003d\u003d const.TYPE_VLAN:"},{"line_number":1577,"context_line":"            options[ovn_const.LRP_OPTIONS_RESIDE_REDIR_CH] \u003d ("},{"line_number":1578,"context_line":"                \u0027false\u0027 if (ovn_conf.is_ovn_distributed_floating_ip() and"},{"line_number":1579,"context_line":"                            not network.get(pnet.PHYSICAL_NETWORK))"},{"line_number":1580,"context_line":"                else \u0027true\u0027)"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"        is_gw_port \u003d const.DEVICE_OWNER_ROUTER_GW \u003d\u003d port.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"53b485b1_091093c3","line":1579,"range":{"start_line":1579,"start_character":32,"end_line":1579,"end_character":66},"in_reply_to":"ccf18c75_86e628de","updated":"2023-01-20 13:11:56.000000000","message":"this checks the router:external instead of the provider:physical_network, not sure what is the right approach here","commit_id":"f9af37269dd84fe6982051a360fe70219341c6ce"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a212822d25534bc7103b0d4010075fc1ce48c9d8","unresolved":true,"context_lines":[{"line_number":1994,"context_line":"                    self.update_subnet(context, subnet, network, txn)"},{"line_number":1995,"context_line":""},{"line_number":1996,"context_line":"                if utils.is_external_network(network):"},{"line_number":1997,"context_line":"                    # make sure to use admin context as this is a providernet"},{"line_number":1998,"context_line":"                    self.set_gateway_mtu(n_context.get_admin_context(),"},{"line_number":1999,"context_line":"                                         network, txn)"},{"line_number":2000,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d2df2bc4_79f34228","line":1997,"range":{"start_line":1997,"start_character":66,"end_line":1997,"end_character":77},"updated":"2023-02-13 08:59:17.000000000","message":"nit: external network","commit_id":"9c46e190d33b81c75d9f145c729edbaa718ea868"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e0d606044590a2739272ae8e937f3e05b5fb445b","unresolved":false,"context_lines":[{"line_number":1994,"context_line":"                    self.update_subnet(context, subnet, network, txn)"},{"line_number":1995,"context_line":""},{"line_number":1996,"context_line":"                if utils.is_external_network(network):"},{"line_number":1997,"context_line":"                    # make sure to use admin context as this is a providernet"},{"line_number":1998,"context_line":"                    self.set_gateway_mtu(n_context.get_admin_context(),"},{"line_number":1999,"context_line":"                                         network, txn)"},{"line_number":2000,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"0193efd7_88c8cd62","line":1997,"range":{"start_line":1997,"start_character":66,"end_line":1997,"end_character":77},"in_reply_to":"d2df2bc4_79f34228","updated":"2023-02-13 14:37:43.000000000","message":"Done","commit_id":"9c46e190d33b81c75d9f145c729edbaa718ea868"}],"releasenotes/notes/bug-2003455-b502cc637427560e.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"69458c704980952e0be7daf7ddb48007b346031f","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    is an OVN bug (https://bugzilla.redhat.com/show_bug.cgi?id\u003d2162756) making"},{"line_number":10,"context_line":"    it not work as expected. Until that is fixed, we need these workaround"},{"line_number":11,"context_line":"    that makes the traffic centrallized, but not tunneled, through the node"},{"line_number":12,"context_line":"    with the gateway port, thus avoiding MTU issues."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2bc8cf3a_81162b25","line":12,"updated":"2023-02-20 09:08:28.000000000","message":"sorry for the nit picking but in the reno there is also \"issues\" section which should contains known issues in the release. I think that this fits into that section really, at least part about the fact that traffic is centralized in such case.","commit_id":"3d5dfc4991511b0b0cfb1a9e1c69f9ce0b173547"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"19c3d64043995ebc83df762366085eae5d41e7e4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    is an OVN bug (https://bugzilla.redhat.com/show_bug.cgi?id\u003d2162756) making"},{"line_number":10,"context_line":"    it not work as expected. Until that is fixed, we need these workaround"},{"line_number":11,"context_line":"    that makes the traffic centrallized, but not tunneled, through the node"},{"line_number":12,"context_line":"    with the gateway port, thus avoiding MTU issues."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df5bf38d_c6f2e4eb","line":12,"in_reply_to":"2bc8cf3a_81162b25","updated":"2023-02-20 11:50:22.000000000","message":"Done","commit_id":"3d5dfc4991511b0b0cfb1a9e1c69f9ce0b173547"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c2e5a3b7386e84ca75afded0983f438636f09dcb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    is an OVN bug (https://bugzilla.redhat.com/show_bug.cgi?id\u003d2162756) making"},{"line_number":10,"context_line":"    it not work as expected. Until that is fixed, we need these workaround"},{"line_number":11,"context_line":"    that makes the traffic centrallized, but not tunneled, through the node"},{"line_number":12,"context_line":"    with the gateway port, thus avoiding MTU issues."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"628731a6_d80d02e6","line":12,"in_reply_to":"7c75b644_192e74d9","updated":"2023-02-28 07:21:50.000000000","message":"Done","commit_id":"3d5dfc4991511b0b0cfb1a9e1c69f9ce0b173547"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"50c18670fe229c0d72cf683b2042e206b651a0f0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    is an OVN bug (https://bugzilla.redhat.com/show_bug.cgi?id\u003d2162756) making"},{"line_number":10,"context_line":"    it not work as expected. Until that is fixed, we need these workaround"},{"line_number":11,"context_line":"    that makes the traffic centrallized, but not tunneled, through the node"},{"line_number":12,"context_line":"    with the gateway port, thus avoiding MTU issues."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7c75b644_192e74d9","line":12,"in_reply_to":"df5bf38d_c6f2e4eb","updated":"2023-02-27 14:24:57.000000000","message":"Thx but I was more thinking about splitting that note into 2 sections. One part about \"fix\" would be in \"fixes\" section and other one, related to the centralized traffic in the \"issues\" section.","commit_id":"3d5dfc4991511b0b0cfb1a9e1c69f9ce0b173547"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"50c18670fe229c0d72cf683b2042e206b651a0f0","unresolved":true,"context_lines":[{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 2003455 \u003chttps://bugs.launchpad.net/neutron/+bug/2003455\u003e`_]"},{"line_number":5,"context_line":"    This patch adds an extra checking to ensure the"},{"line_number":6,"context_line":"    \"reside-on-redirect-chassis\" is set to true for the logical"},{"line_number":7,"context_line":"    router port associated to vlan provider network despite having"},{"line_number":8,"context_line":"    the \"ovn_distributed_floating_ip\" enabled or not. This is needed as there"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d516f1a2_a67da4de","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":19},"updated":"2023-02-27 14:24:57.000000000","message":"I\u0027m very sorry that I didn\u0027t comment on that previously (I don\u0027t know why) but You should avoid writing things like \"this patch\" in the release notes. It will be later rendered on the html page without any connection to the patch so something like that will be looking odd in the release notes page. You can see it in https://94e50eac0c80dc1e0c2c-71a7b628b97eb3d783423fb75aa693ba.ssl.cf5.rackcdn.com/871252/8/check/build-openstack-releasenotes/5c09e98/docs/unreleased.html#known-issues\n\nFor the same reason, if You are writing 2 different sections, like \"issues\" and \"fixes\" in the same release note, both should be independent of each other as they will be not rendered close to each other later on the html page.","commit_id":"d7e52b31e8e25d2781cab20703844ba1cc5153cc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c2e5a3b7386e84ca75afded0983f438636f09dcb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 2003455 \u003chttps://bugs.launchpad.net/neutron/+bug/2003455\u003e`_]"},{"line_number":5,"context_line":"    This patch adds an extra checking to ensure the"},{"line_number":6,"context_line":"    \"reside-on-redirect-chassis\" is set to true for the logical"},{"line_number":7,"context_line":"    router port associated to vlan provider network despite having"},{"line_number":8,"context_line":"    the \"ovn_distributed_floating_ip\" enabled or not. This is needed as there"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d75d42d9_ec6ff451","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":19},"in_reply_to":"d516f1a2_a67da4de","updated":"2023-02-28 07:21:50.000000000","message":"Done","commit_id":"d7e52b31e8e25d2781cab20703844ba1cc5153cc"}]}