)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"107a672cd956439cf5fa37dba25e70c66b5c193a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b9f6a98a_6d9eaae0","updated":"2023-04-28 13:14:48.000000000","message":"Ping folks","commit_id":"64cddc8b00361b2155797e2880ca198211f43b5e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3842081b8739583bc6c6ef7da95cd5e34a07aa4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"16a50d7b_40561b07","updated":"2023-05-09 10:42:03.000000000","message":"Thanks Rodolfo. Just some nits and should be good!","commit_id":"a3226351269dc47f527e8637c9a01e7f22bf76a0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"35b5d11ad03318f0fba608deb8efb935bd220df9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fd6a0a03_f701f014","updated":"2023-05-09 15:24:20.000000000","message":"recheck grenade","commit_id":"627b9493ca6ccf61900eedd6e12d0415be35bf87"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5c464f338988d84309ff446f915f7c89eca3033a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"61b1ce2d_a99cf263","updated":"2023-05-24 14:19:43.000000000","message":"Remvoing +2, failures on the tests are real. Fat fingered the re-check there :-(","commit_id":"dcffdbf927f03ca841baebb0b74a63fe19a546d7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fce08a1aa008ce58426d8bac94c781b102046e63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"50ec51f9_9846a19f","updated":"2023-05-24 14:18:17.000000000","message":"recheck","commit_id":"dcffdbf927f03ca841baebb0b74a63fe19a546d7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8a2e6523b4563142a65d021d3d5bf4f0075cd154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9c2f039c_ff7abf9b","updated":"2023-05-30 06:34:42.000000000","message":"recheck grenade","commit_id":"ac231c817473c018dde8fa31594b1c9a78a36c13"}],"neutron/common/ovn/utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3842081b8739583bc6c6ef7da95cd5e34a07aa4d","unresolved":true,"context_lines":[{"line_number":870,"context_line":"    :param nb_idl: OVN NB IDL"},{"line_number":871,"context_line":"    :param sb_idl: OVN SB IDL"},{"line_number":872,"context_line":"    :param txn: The ovsdbapp transaction object."},{"line_number":873,"context_line":"    :returns: An HA Chassis Group UUID."},{"line_number":874,"context_line":"    \"\"\""},{"line_number":875,"context_line":"    az_hints \u003d common_utils.get_az_hints("},{"line_number":876,"context_line":"        plugin.get_network(context, network_id))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3d05631c_1bc7776d","line":873,"range":{"start_line":873,"start_character":14,"end_line":873,"end_character":39},"updated":"2023-05-09 10:42:03.000000000","message":"... or the HA chassis create group command object","commit_id":"a3226351269dc47f527e8637c9a01e7f22bf76a0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"19119ee8774156c6bbe64165dc892952484ad0d3","unresolved":false,"context_lines":[{"line_number":870,"context_line":"    :param nb_idl: OVN NB IDL"},{"line_number":871,"context_line":"    :param sb_idl: OVN SB IDL"},{"line_number":872,"context_line":"    :param txn: The ovsdbapp transaction object."},{"line_number":873,"context_line":"    :returns: An HA Chassis Group UUID."},{"line_number":874,"context_line":"    \"\"\""},{"line_number":875,"context_line":"    az_hints \u003d common_utils.get_az_hints("},{"line_number":876,"context_line":"        plugin.get_network(context, network_id))"}],"source_content_type":"text/x-python","patch_set":16,"id":"16b9d369_c64a2c63","line":873,"range":{"start_line":873,"start_character":14,"end_line":873,"end_character":39},"in_reply_to":"3d05631c_1bc7776d","updated":"2023-05-09 10:54:27.000000000","message":"exactly!","commit_id":"a3226351269dc47f527e8637c9a01e7f22bf76a0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3842081b8739583bc6c6ef7da95cd5e34a07aa4d","unresolved":true,"context_lines":[{"line_number":876,"context_line":"        plugin.get_network(context, network_id))"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    ha_ch_grp_name \u003d ovn_name(network_id)"},{"line_number":879,"context_line":"    # FIXME(lucasagomes): Couldn\u0027t find a better way of doing this"},{"line_number":880,"context_line":"    # without a sub-transaction. This shouldn\u0027t be a problem since"},{"line_number":881,"context_line":"    # the HA Chassis Group associated with a network will be deleted"},{"line_number":882,"context_line":"    # as part of the network delete method (if present)"},{"line_number":883,"context_line":"    ext_ids \u003d {constants.OVN_AZ_HINTS_EXT_ID_KEY: \u0027,\u0027.join(az_hints)}"},{"line_number":884,"context_line":"    hcg_cmd \u003d txn.add(nb_idl.ha_chassis_group_add("},{"line_number":885,"context_line":"        ha_ch_grp_name, may_exist\u003dTrue, external_ids\u003dext_ids))"}],"source_content_type":"text/x-python","patch_set":16,"id":"520926cb_2ab78867","line":882,"range":{"start_line":879,"start_character":0,"end_line":882,"end_character":55},"updated":"2023-05-09 10:42:03.000000000","message":"This comment is no longer valid right ? Cause we no longer need a sub-transaction with the new ovsdbapp.","commit_id":"a3226351269dc47f527e8637c9a01e7f22bf76a0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"19119ee8774156c6bbe64165dc892952484ad0d3","unresolved":false,"context_lines":[{"line_number":876,"context_line":"        plugin.get_network(context, network_id))"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    ha_ch_grp_name \u003d ovn_name(network_id)"},{"line_number":879,"context_line":"    # FIXME(lucasagomes): Couldn\u0027t find a better way of doing this"},{"line_number":880,"context_line":"    # without a sub-transaction. This shouldn\u0027t be a problem since"},{"line_number":881,"context_line":"    # the HA Chassis Group associated with a network will be deleted"},{"line_number":882,"context_line":"    # as part of the network delete method (if present)"},{"line_number":883,"context_line":"    ext_ids \u003d {constants.OVN_AZ_HINTS_EXT_ID_KEY: \u0027,\u0027.join(az_hints)}"},{"line_number":884,"context_line":"    hcg_cmd \u003d txn.add(nb_idl.ha_chassis_group_add("},{"line_number":885,"context_line":"        ha_ch_grp_name, may_exist\u003dTrue, external_ids\u003dext_ids))"}],"source_content_type":"text/x-python","patch_set":16,"id":"ffcae28b_003960cc","line":882,"range":{"start_line":879,"start_character":0,"end_line":882,"end_character":55},"in_reply_to":"520926cb_2ab78867","updated":"2023-05-09 10:54:27.000000000","message":"Right! Actually I\u0027m improving this method to avoid this (and because I need to have this method as a stand-alone function for https://review.opendev.org/c/openstack/neutron/+/872033/)","commit_id":"a3226351269dc47f527e8637c9a01e7f22bf76a0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a8eca4870ce868252e8e0c9dd5973ea5abbdbf36","unresolved":true,"context_lines":[{"line_number":857,"context_line":"        return chassis.external_ids"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"def sync_ha_chassis_group(context, network_id, plugin, nb_idl, sb_idl, txn):"},{"line_number":861,"context_line":"    \"\"\"Return the UUID of the HA Chassis Group or the HA Chassis Group cmd."},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    Given the Neutron Network ID, this method will return (or create"}],"source_content_type":"text/x-python","patch_set":17,"id":"a86df88a_56112169","line":860,"range":{"start_line":860,"start_character":47,"end_line":860,"end_character":53},"updated":"2023-05-24 08:19:21.000000000","message":"nit: instead of passing plugin as argument You can probably just use neutron_lib.plugins.directory.get_plugin()","commit_id":"627b9493ca6ccf61900eedd6e12d0415be35bf87"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5c9dee3a61adc23b35aa230346d8c7fa1fb4bb88","unresolved":false,"context_lines":[{"line_number":857,"context_line":"        return chassis.external_ids"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"def sync_ha_chassis_group(context, network_id, plugin, nb_idl, sb_idl, txn):"},{"line_number":861,"context_line":"    \"\"\"Return the UUID of the HA Chassis Group or the HA Chassis Group cmd."},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    Given the Neutron Network ID, this method will return (or create"}],"source_content_type":"text/x-python","patch_set":17,"id":"cb730768_ed6a3ba6","line":860,"range":{"start_line":860,"start_character":47,"end_line":860,"end_character":53},"in_reply_to":"a86df88a_56112169","updated":"2023-05-24 08:25:50.000000000","message":"Done","commit_id":"627b9493ca6ccf61900eedd6e12d0415be35bf87"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f86806ded761385ac75c8c909f7463d5a64e8ce3","unresolved":true,"context_lines":[{"line_number":3956,"context_line":"                self.assertEqual(ovn_const.LSP_TYPE_EXTERNAL, kwargs[\u0027type\u0027])"},{"line_number":3957,"context_line":"                self.assertEqual(fake_grp, kwargs[\u0027ha_chassis_group\u0027])"},{"line_number":3958,"context_line":"                sync_mock.assert_called_once_with("},{"line_number":3959,"context_line":"                    mock.ANY, net_id, mock.ANY, self.mech_driver.nb_ovn,"},{"line_number":3960,"context_line":"                    self.mech_driver.sb_ovn, mock.ANY)"},{"line_number":3961,"context_line":""},{"line_number":3962,"context_line":"    def test_create_port_with_vnic_direct(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"01966b5c_4dacdac1","line":3959,"range":{"start_line":3959,"start_character":38,"end_line":3959,"end_character":47},"updated":"2023-05-24 14:23:27.000000000","message":"We need to remove this mock.ANY here for the unittests","commit_id":"dcffdbf927f03ca841baebb0b74a63fe19a546d7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d48859360cf34ca47619b25d947425595e378ed7","unresolved":false,"context_lines":[{"line_number":3956,"context_line":"                self.assertEqual(ovn_const.LSP_TYPE_EXTERNAL, kwargs[\u0027type\u0027])"},{"line_number":3957,"context_line":"                self.assertEqual(fake_grp, kwargs[\u0027ha_chassis_group\u0027])"},{"line_number":3958,"context_line":"                sync_mock.assert_called_once_with("},{"line_number":3959,"context_line":"                    mock.ANY, net_id, mock.ANY, self.mech_driver.nb_ovn,"},{"line_number":3960,"context_line":"                    self.mech_driver.sb_ovn, mock.ANY)"},{"line_number":3961,"context_line":""},{"line_number":3962,"context_line":"    def test_create_port_with_vnic_direct(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"2c1e199d_bb0fc69b","line":3959,"range":{"start_line":3959,"start_character":38,"end_line":3959,"end_character":47},"in_reply_to":"01966b5c_4dacdac1","updated":"2023-05-24 14:36:49.000000000","message":"ahhh that one is missing, thanks!","commit_id":"dcffdbf927f03ca841baebb0b74a63fe19a546d7"}]}